pandorga 1.13.0 → 1.14.1

data/scripts/test/test-timeline-pan.mjs

@@ -0,0 +1,147 @@
+#!/usr/bin/env node
+// PLT-AC-47. Pure helper unit tests sliced from _includes/page/timeline-section.html
+// Executes panTarget and centerPreservingScroll from source rather than a copy.
+
+import fs from 'fs';
+import path from 'path';
+import { fileURLToPath } from 'url';
+
+const root = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..', '..');
+const source = fs.readFileSync(
+  path.join(root, '_includes/page/timeline-section.html'),
+  'utf8'
+);
+
+const start = source.indexOf('function panTarget');
+const end = source.indexOf('function parseDate');
+if (start < 0 || end < start) {
+  console.error('FAIL: panTarget / centerPreservingScroll missing from timeline-section.html');
+  process.exit(1);
+}
+
+const slice = source.slice(start, end);
+if (!slice.includes('function centerPreservingScroll')) {
+  console.error('FAIL: centerPreservingScroll missing from slice');
+  process.exit(1);
+}
+
+const api = new Function(
+  `${slice}\nreturn { panTarget, centerPreservingScroll };`
+)();
+
+const { panTarget, centerPreservingScroll } = api;
+
+let failed = 0;
+
+function check(condition, message) {
+  if (!condition) {
+    console.error(`FAIL: ${message}`);
+    failed += 1;
+  }
+}
+
+// ── panTarget tests (PLT-AC-47) ─────────────────────────────────────────────
+// Check step sizes 10% (0.1) and 90% (0.9), and clamping at both bounds (0 and maxScroll).
+
+const visibleW = 1000;
+const maxScroll = 4000;
+
+// Step 10% right (forward in time)
+check(panTarget(500, visibleW, maxScroll, 0.1) === 600, 'panTarget 10% right from 500 should be 600');
+// Step 10% left (backward in time)
+check(panTarget(500, visibleW, maxScroll, -0.1) === 400, 'panTarget 10% left from 500 should be 400');
+
+// Step 90% right
+check(panTarget(500, visibleW, maxScroll, 0.9) === 1400, 'panTarget 90% right from 500 should be 1400');
+// Step 90% left
+check(panTarget(1500, visibleW, maxScroll, -0.9) === 600, 'panTarget 90% left from 1500 should be 600');
+
+// Lower bound clamping (scrollLeft <= 0)
+check(panTarget(50, visibleW, maxScroll, -0.1) === 0, 'panTarget clamps at lower bound (10% left)');
+check(panTarget(500, visibleW, maxScroll, -0.9) === 0, 'panTarget clamps at lower bound (90% left)');
+check(panTarget(0, visibleW, maxScroll, -0.1) === 0, 'panTarget at 0 stays at 0');
+
+// Upper bound clamping (scrollLeft >= maxScroll)
+check(panTarget(3950, visibleW, maxScroll, 0.1) === 4000, 'panTarget clamps at upper bound (10% right)');
+check(panTarget(3500, visibleW, maxScroll, 0.9) === 4000, 'panTarget clamps at upper bound (90% right)');
+check(panTarget(4000, visibleW, maxScroll, 0.1) === 4000, 'panTarget at maxScroll stays at maxScroll');
+
+// ── centerPreservingScroll tests (PLT-AC-47) ────────────────────────────────
+// Center time preserved (within 1 day) across zoom factors 0.75 and 1.33.
+
+const MS_DAY = 86400000;
+const MS_YEAR = 365.25 * MS_DAY;
+const LABEL_W = 96;
+
+// Simulated timeline: 10 years of range
+const minT = new Date(2015, 0, 1).getTime();
+const maxT = new Date(2025, 0, 1).getTime();
+const rangeMs = maxT - minT;
+
+const initialZoomYears = 2;
+const visibleChartW = visibleW - LABEL_W;
+const initialChartW = visibleChartW * (rangeMs / (initialZoomYears * MS_YEAR));
+
+function makeXPosMs(chartW) {
+  return function (t) {
+    return LABEL_W + ((t - minT) / rangeMs) * chartW;
+  };
+}
+
+function timeFromX(x, chartW) {
+  const chartX = x - LABEL_W;
+  return minT + (chartX / chartW) * rangeMs;
+}
+
+// Suppose wrapper was scrolled to 1200px at 2 yr zoom
+const initialScrollLeft = 1200;
+const initialCenterPx = initialScrollLeft + visibleW / 2;
+const centerMs = timeFromX(initialCenterPx, initialChartW);
+
+// Zoom in: factor 0.75
+const zoomInYears = initialZoomYears * 0.75;
+const chartWZoomIn = visibleChartW * (rangeMs / (zoomInYears * MS_YEAR));
+const maxScrollZoomIn = Math.max(0, LABEL_W + chartWZoomIn + 32 - visibleW);
+const xPosMsZoomIn = makeXPosMs(chartWZoomIn);
+
+const newScrollLeftZoomIn = centerPreservingScroll(centerMs, xPosMsZoomIn, visibleW, maxScrollZoomIn);
+const newCenterPxZoomIn = newScrollLeftZoomIn + visibleW / 2;
+const centerMsAfterZoomIn = timeFromX(newCenterPxZoomIn, chartWZoomIn);
+const diffDaysZoomIn = Math.abs(centerMsAfterZoomIn - centerMs) / MS_DAY;
+
+check(
+  diffDaysZoomIn <= 1.0,
+  `center time preserved within 1 day on zoom factor 0.75 (drift: ${diffDaysZoomIn.toFixed(3)} days)`
+);
+
+// Zoom out: factor 1.33
+const zoomOutYears = initialZoomYears * 1.33;
+const chartWZoomOut = visibleChartW * (rangeMs / (zoomOutYears * MS_YEAR));
+const maxScrollZoomOut = Math.max(0, LABEL_W + chartWZoomOut + 32 - visibleW);
+const xPosMsZoomOut = makeXPosMs(chartWZoomOut);
+
+const newScrollLeftZoomOut = centerPreservingScroll(centerMs, xPosMsZoomOut, visibleW, maxScrollZoomOut);
+const newCenterPxZoomOut = newScrollLeftZoomOut + visibleW / 2;
+const centerMsAfterZoomOut = timeFromX(newCenterPxZoomOut, chartWZoomOut);
+const diffDaysZoomOut = Math.abs(centerMsAfterZoomOut - centerMs) / MS_DAY;
+
+check(
+  diffDaysZoomOut <= 1.0,
+  `center time preserved within 1 day on zoom factor 1.33 (drift: ${diffDaysZoomOut.toFixed(3)} days)`
+);
+
+// Clamping at lower bound
+const startCenterMs = minT; // Start of timeline
+const clampedStartScroll = centerPreservingScroll(startCenterMs, xPosMsZoomIn, visibleW, maxScrollZoomIn);
+check(clampedStartScroll === 0, 'centerPreservingScroll clamps to 0 at timeline start');
+
+// Clamping at upper bound
+const endCenterMs = maxT; // End of timeline
+const clampedEndScroll = centerPreservingScroll(endCenterMs, xPosMsZoomIn, visibleW, maxScrollZoomIn);
+check(clampedEndScroll === Math.round(maxScrollZoomIn), 'centerPreservingScroll clamps to maxScroll at timeline end');
+
+if (failed) {
+  console.error(`timeline pan: ${failed} failure(s)`);
+  process.exit(1);
+}
+console.log('PASS test-timeline-pan.mjs (PLT-AC-47)');

data/scripts/test/test-timeline-pan.rb

@@ -0,0 +1,116 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+# CV timeline temporal pan static gate (PLT-AC-47, docs/features/timeline-pan.md).
+#
+# Asserts:
+# - wrapper has tabindex="0", role="region", and aria-label
+# - pan prev/next and Today buttons exist with aria-labels
+# - script registers pointerdown, pointermove, pointerup, and keydown handlers
+# - shiftKey is checked on the selection path
+# - changeZoom no longer calls scrollToToday()
+# - prefers-reduced-motion check is present
+# - hint text "Shift+drag to select a period" is present
+
+require "pathname"
+
+ROOT = Pathname.new(__dir__).join("..", "..").expand_path
+TIMELINE_HTML = ROOT.join("_includes/page/timeline-section.html")
+
+def fail!(msg)
+  warn "FAIL test-timeline-pan: #{msg}"
+  exit 1
+end
+
+source = TIMELINE_HTML.read
+
+# 1. Wrapper accessibility attributes
+wrapper_match = source[/<div[^>]*id=["']timeline-chart-wrapper["'][^>]*>/]
+fail!("missing #timeline-chart-wrapper") unless wrapper_match
+fail!("wrapper missing tabindex=\"0\"") unless wrapper_match.include?('tabindex="0"')
+fail!("wrapper missing role=\"region\"") unless wrapper_match.include?('role="region"')
+fail!("wrapper missing aria-label") unless wrapper_match.include?('aria-label=')
+
+# 2. Pan and Today buttons with aria-labels inside #timeline-zoom-controls
+zoom_controls = source[/<div[^>]*id=["']timeline-zoom-controls["'][^>]*>.*?<\/div>/m]
+fail!("missing #timeline-zoom-controls") unless zoom_controls
+
+fail!("missing pan prev button (‹)") unless zoom_controls.include?("‹")
+fail!("missing pan next button (›)") unless zoom_controls.include?("›")
+fail!("missing Today button") unless zoom_controls.include?("Today")
+
+prev_btn = zoom_controls[/<button[^>]*>[^<]*‹[^<]*<\/button>/m]
+fail!("pan prev button missing aria-label") unless prev_btn && prev_btn.include?("aria-label=")
+
+next_btn = zoom_controls[/<button[^>]*>[^<]*›[^<]*<\/button>/m]
+fail!("pan next button missing aria-label") unless next_btn && next_btn.include?("aria-label=")
+
+today_btn = zoom_controls[/<button[^>]*>[^<]*Today[^<]*<\/button>/m]
+fail!("Today button missing aria-label") unless today_btn && today_btn.include?("aria-label=")
+
+# 3. Pointer and keyboard event handlers registered in the script
+script_match = source[/<script>(.*?)<\/script>/m, 1]
+fail!("inline script missing") unless script_match
+
+fail!("script missing pointerdown handler") unless script_match.include?("pointerdown")
+fail!("script missing pointermove handler") unless script_match.include?("pointermove")
+fail!("script missing pointerup handler") unless script_match.include?("pointerup")
+fail!("script missing keydown handler") unless script_match.include?("keydown")
+
+# 4. shiftKey checked on the selection path
+fail!("script does not check shiftKey for selection") unless script_match.include?("shiftKey")
+
+# 5. changeZoom no longer calls scrollToToday()
+# Brace-matched body, so a nested block cannot hide a later call.
+def function_body(script, name)
+  head = script.index(/function\s+#{name}\s*\([^)]*\)\s*\{/)
+  return nil unless head
+
+  open_at = script.index("{", head)
+  depth = 0
+  script[open_at..].each_char.with_index do |char, offset|
+    depth += 1 if char == "{"
+    depth -= 1 if char == "}"
+    return script[open_at + 1, offset - 1] if depth.zero?
+  end
+  nil
+end
+
+change_zoom_body = function_body(script_match, "changeZoom")
+fail!("missing changeZoom function") unless change_zoom_body
+if change_zoom_body.include?("scrollToToday")
+  fail!("changeZoom must not call scrollToToday(); zoom must preserve center date")
+end
+
+# 6. prefers-reduced-motion check present
+fail!("missing prefers-reduced-motion check") unless script_match.include?("prefers-reduced-motion")
+
+# 7. Selection hint text present
+fail!("missing hint text 'Shift+drag to select a period'") unless source.include?("Shift+drag to select a period")
+
+# 8. Pan buttons expose their bound state to assistive tech
+fail!("pan buttons must set aria-disabled at bounds") unless script_match.include?("aria-disabled")
+
+# 9. A second boot (inline stub, then runtime JSON) must not stack listeners
+boot_body = function_body(script_match, "bootTimeline")
+fail!("missing bootTimeline function") unless boot_body
+fail!("bootTimeline must abort the previous boot's listeners") unless boot_body.include?("AbortController") && boot_body.include?(".abort()")
+%w[pointerdown pointermove keydown resize].each do |type|
+  head = boot_body.index(/addEventListener\('#{type}',\s*function\s*\([^)]*\)\s*\{/)
+  fail!("missing #{type} listener in bootTimeline") unless head
+  open_at = boot_body.index("{", head)
+  depth = 0
+  close_at = nil
+  boot_body[open_at..].each_char.with_index do |char, offset|
+    depth += 1 if char == "{"
+    depth -= 1 if char == "}"
+    if depth.zero?
+      close_at = open_at + offset
+      break
+    end
+  end
+  tail = close_at && boot_body[(close_at + 1)..]
+  fail!("#{type} listener must take the boot's abort signal") unless tail&.match?(/\A,\s*bootScope\s*\)/)
+end
+
+puts "PASS test-timeline-pan (PLT-AC-47)"

data/scripts/validate.sh

@@ -72,6 +72,8 @@ TESTS=(
   scripts/test/test-discovery.rb
   scripts/test/test-hero-portraits.rb
   scripts/test/test-thumbnail-variants.rb
+  scripts/test/test-highlighter-pills.rb
+  scripts/test/test-timeline-pan.rb
 )
 
 failed=0
@@ -107,6 +109,11 @@ if ! node scripts/test/test-studio-pipeline-focus.mjs; then
   failed=1
 fi
 
+echo "-- scripts/test/test-timeline-pan.mjs"
+if ! node scripts/test/test-timeline-pan.mjs; then
+  failed=1
+fi
+
 if [[ "$failed" -ne 0 ]]; then
   echo "VALIDATE FAILED"
   exit 1

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pandorga
 version: !ruby/object:Gem::Version
-  version: 1.13.0
+  version: 1.14.1
 platform: ruby
 authors:
 - The Pandorga contributors
@@ -437,6 +437,7 @@ files:
 - scripts/test/test-hero-portraits.mjs
 - scripts/test/test-hero-portraits.rb
 - scripts/test/test-hero-summary.rb
+- scripts/test/test-highlighter-pills.rb
 - scripts/test/test-home-articles.rb
 - scripts/test/test-home-band-art.rb
 - scripts/test/test-home-band-intro.rb
@@ -477,6 +478,8 @@ files:
 - scripts/test/test-text-excerpt.rb
 - scripts/test/test-theme-contrast.rb
 - scripts/test/test-thumbnail-variants.rb
+- scripts/test/test-timeline-pan.mjs
+- scripts/test/test-timeline-pan.rb
 - scripts/test/test-unwrap-media-src.mjs
 - scripts/test/test-unwrap-media-src.rb
 - scripts/test/test-validate-allowlist.rb