pair_see 0.1.5 → 0.1.6

data/bin/pry

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
+
 #
 # This file was generated by Bundler.
 #
@@ -7,11 +8,11 @@
 # this file is here to facilitate running it.
 #
 
-require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
+require 'pathname'
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile',
+                                           Pathname.new(__FILE__).realpath)
 
-require "rubygems"
-require "bundler/setup"
+require 'rubygems'
+require 'bundler/setup'
 
-load Gem.bin_path("pry", "pry")
+load Gem.bin_path('pry', 'pry')

data/bin/rake

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
+
 #
 # This file was generated by Bundler.
 #
@@ -7,11 +8,11 @@
 # this file is here to facilitate running it.
 #
 
-require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
+require 'pathname'
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile',
+                                           Pathname.new(__FILE__).realpath)
 
-require "rubygems"
-require "bundler/setup"
+require 'rubygems'
+require 'bundler/setup'
 
-load Gem.bin_path("rake", "rake")
+load Gem.bin_path('rake', 'rake')

data/bin/rake_commit

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
+
 #
 # This file was generated by Bundler.
 #
@@ -7,11 +8,11 @@
 # this file is here to facilitate running it.
 #
 
-require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
+require 'pathname'
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile',
+                                           Pathname.new(__FILE__).realpath)
 
-require "rubygems"
-require "bundler/setup"
+require 'rubygems'
+require 'bundler/setup'
 
-load Gem.bin_path("rake_commit", "rake_commit")
+load Gem.bin_path('rake_commit', 'rake_commit')

data/bin/rspec

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
+
 #
 # This file was generated by Bundler.
 #
@@ -7,11 +8,11 @@
 # this file is here to facilitate running it.
 #
 
-require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
+require 'pathname'
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile',
+                                           Pathname.new(__FILE__).realpath)
 
-require "rubygems"
-require "bundler/setup"
+require 'rubygems'
+require 'bundler/setup'
 
-load Gem.bin_path("rspec-core", "rspec")
+load Gem.bin_path('rspec-core', 'rspec')

data/bin/rubocop

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
+
 #
 # This file was generated by Bundler.
 #
@@ -7,11 +8,11 @@
 # this file is here to facilitate running it.
 #
 
-require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
+require 'pathname'
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile',
+                                           Pathname.new(__FILE__).realpath)
 
-require "rubygems"
-require "bundler/setup"
+require 'rubygems'
+require 'bundler/setup'
 
-load Gem.bin_path("rubocop", "rubocop")
+load Gem.bin_path('rubocop', 'rubocop')

data/bin/ruby-parse

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
+
 #
 # This file was generated by Bundler.
 #
@@ -7,11 +8,11 @@
 # this file is here to facilitate running it.
 #
 
-require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
+require 'pathname'
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile',
+                                           Pathname.new(__FILE__).realpath)
 
-require "rubygems"
-require "bundler/setup"
+require 'rubygems'
+require 'bundler/setup'
 
-load Gem.bin_path("parser", "ruby-parse")
+load Gem.bin_path('parser', 'ruby-parse')

data/bin/ruby-rewrite

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
+
 #
 # This file was generated by Bundler.
 #
@@ -7,11 +8,11 @@
 # this file is here to facilitate running it.
 #
 
-require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
+require 'pathname'
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile',
+                                           Pathname.new(__FILE__).realpath)
 
-require "rubygems"
-require "bundler/setup"
+require 'rubygems'
+require 'bundler/setup'
 
-load Gem.bin_path("parser", "ruby-rewrite")
+load Gem.bin_path('parser', 'ruby-rewrite')

data/config/config.yml.example

@@ -0,0 +1,11 @@
+names:
+  - Person1
+  - Person2
+  - ManyNamesPerson mnperson mprss
+card_prefix:
+  - FOO-
+  - BAR-
+roots:
+  - /Users/foo/repo1
+  - /Users/foo/repositories/repo2
+  - /Users/foo/repositories/baz/repo3

data/lib/pair_see.rb

@@ -1,5 +1,5 @@
 require_relative 'pair_see/version.rb'
-require_relative 'pair_see/seer.rb'
+require_relative 'pair_see/too_much_stuff.rb'
 
 module PairSee
 end

data/lib/pair_see/active_devs.rb

@@ -2,18 +2,9 @@ module PairSee
   class ActiveDevs
     attr_reader :devs
 
-    def initialize(log_lines, options)
+    def initialize(log_lines, people)
       @log_lines = log_lines
-      @options = options
-      @devs = _active(options[:names])
-    end
-
-    def active_devs(config_file)
-      config = YAML.load_file(config_file)
-      devs_in_config = config['names'].split(' ')
-      devs_in_config.select do |dev|
-        _is_active?(dev)
-      end
+      @devs = _active(people)
     end
 
     def _active(devs)
@@ -26,4 +17,4 @@ module PairSee
       @log_lines.active? dev
     end
   end
-end
+end

data/lib/pair_see/card.rb

@@ -2,14 +2,15 @@ module PairSee
   class Card
     attr_reader :card_name, :number_of_commits, :last_date
 
-    def initialize(card_name, number_of_commits, first_date, last_date)
+    def initialize(card_name, commits)
       @card_name = card_name
-      @number_of_commits = number_of_commits
-      @first_date, @last_date = first_date, last_date
+      @number_of_commits = commits.count
+      @first_date = commits.first.date
+      @last_date = commits.last.date
     end
 
     def duration
-      (@first_date - @last_date).to_i + 1
+      (@last_date - @first_date).to_i + 1
     end
 
     def ==(other)

data/lib/pair_see/card_knowledge_summary.rb

@@ -0,0 +1,25 @@
+module PairSee
+  class CardKnowledgeSummary
+    include Comparable
+    attr_reader :commits_on_card_count
+
+    def initialize(card_number, commits_on_card_count, authors)
+      @card_number = card_number
+      @commits_on_card_count = commits_on_card_count
+      @authors = authors
+    end
+
+    def has_debt
+      @authors.count < 2
+    end
+
+    def pretty
+      pretty_author_names = @authors.map(&:to_s).join
+      "#{@card_number} has #{@commits_on_card_count} commits with only #{@authors.count} committer(s) #{pretty_author_names} on the entire card"
+    end
+
+    def authors_list
+      @authors.sort.join(' ')
+    end
+  end
+end

data/lib/pair_see/cards_per_person.rb

@@ -1,40 +1,50 @@
 module PairSee
   class CardsPerPerson
-    attr_reader :devs
+    attr_reader :people, :cards_per_person, :dev_pairs
 
     def initialize(log_lines, card_prefix, people)
-      @log_lines = log_lines
-      @card_prefix = card_prefix
-      @devs = _active(people)
+      @people = _active(people, log_lines)
+      @cards_per_person = _cards_per_person(log_lines, card_prefix)
+      @dev_pairs = @people.combination(2)
     end
 
-    def cards_per_person
-      @devs.map do |dev|
-        {dev => _cards_dev_worked_on(@log_lines, dev)}
-      end.inject({}) do |result, element|
-        result.merge(element)
-      end.map do |dev_name, cards_worked|
-        {dev_name => cards_worked.uniq}
-      end.inject({}) do |result, element|
-        result.merge(element)
-      end.sort do |a, b|
-        a[1].size <=> b[1].size
-      end.map do |dev, cards|
-        "#{dev}: [#{cards.size} cards] #{cards.sort.join(', ')}"
+    private
+
+    def _cards_per_person(log_lines, card_prefix)
+      all = _people_hash
+      _populate_card_numbers(all, log_lines, card_prefix)
+      _unique_cards_per_person(all)
+      _sort_by_cards_count(all)
+    end
+
+    def _sort_by_cards_count(all)
+      all.sort_by { |_, card_names| card_names.count }.map do |person, card_names|
+        sorted = card_names.compact.sort_by(&:to_i)
+        "#{person}: [#{card_names.size} cards] #{sorted.join(', ')}"
+      end
+    end
+
+    def _unique_cards_per_person(all)
+      all.each { |_, card_names| card_names.uniq! }
+    end
+
+    def _populate_card_numbers(all, log_lines, card_prefix)
+      log_lines.each do |log_line| # loop through the biggest list only once
+        all.each do |person, _|
+          if log_line.authored_by? person
+            all[person] << log_line.card_number(card_prefix)
+          end
+        end
       end
     end
 
-    def _cards_dev_worked_on(log_lines, person)
-      log_lines.select do |log_line|
-        log_line.authored_by?(person)
-      end.map do |log_line|
-        log_line.card_number(@card_prefix)
-      end.compact
+    def _people_hash
+      Hash[people.map { |key, _| [key, []] }]
     end
 
-    def _active(people)
+    def _active(people, log_lines)
       people.select do |person|
-        @log_lines.active? person
+        log_lines.active? person
       end
     end
   end

data/lib/pair_see/date_combo.rb

@@ -3,7 +3,8 @@ module PairSee
     attr_reader :date, :devs
 
     def initialize(date, *devs)
-      @date, @devs = date, devs
+      @date = date
+      @devs = devs
     end
 
     def to_s

data/lib/pair_see/knowledge_debt.rb

@@ -0,0 +1,31 @@
+module PairSee
+  class KnowledgeDebt
+    def initialize(log_lines, card_prefixes, people)
+      @log_lines = log_lines
+      @card_prefixes = card_prefixes
+      @people = people
+    end
+
+    def knowledge_debt
+      # TODO: do something here with percentage knowledge per card
+      commits_per_card.map do |card_name, commits|
+        authors_per_commit = commits.map do |log_line|
+          log_line.all_authors(@people)
+        end
+        authors = authors_per_commit.flatten.uniq
+        CardKnowledgeSummary.new(card_name, commits.count, authors)
+      end.select(&:has_debt).sort_by(&:authors_list).map(&:pretty)
+    end
+
+    def commits_per_card
+      card_to_commits = {}
+
+      @log_lines.each do |ll|
+        cn = ll.card_number(@card_prefixes)
+        card_to_commits[cn] = [] unless card_to_commits[cn]
+        card_to_commits[cn] << ll
+      end
+      card_to_commits
+    end
+  end
+end

data/lib/pair_see/log_line.rb

@@ -1,29 +1,32 @@
 module PairSee
   class LogLine
     require 'time'
-    attr_reader :line
+    attr_reader :line, :date, :card_number
 
     def initialize(line)
       @line = line
+      @date = _get_date(line)
     end
 
-    def authored_by?(*people)
-      return false if people.empty?
-      people.map {|person|
-        contains_any_of?(person.names)
-      }.all?
-    end
-
-    def contains_any_of?(names)
-      names.any? {|name| line_contains_name(name)}
+    def all_authors(people)
+      people.select do |person|
+        _contains_any_of?(person.names)
+      end
     end
 
-    def line_contains_name(name)
-      /(^|\s+|\W)#{name}(\s+|$|\W)/i =~ line
+    def authored_by?(*people)
+      return false if people.empty?
+      people.map do |person|
+        _contains_any_of?(person.names)
+      end.all?
     end
 
-    def contains_card?(card_prefix)
-      line.match(card_prefix)
+    def card_number(card_prefixes)
+      card_prefixes.each do |cp|
+        card_num = card_name([cp])
+        return card_num.gsub(cp, '') if card_num
+      end
+      nil
     end
 
     def contains_card_name?(card_name)
@@ -33,46 +36,41 @@ module PairSee
     end
 
     def card_name(card_prefixes)
-      card_prefixes.each {|cp|
+      card_prefixes.each do |cp|
         regex = /(#{cp}\d+)/
         matcher = line.match(regex)
-        if (!matcher.nil?)
-          return (line.match regex)[1]
-        end
-      }
-      return nil
+        return (line.match regex)[1] unless matcher.nil?
+      end
+      nil
     end
 
-    def card_number(card_prefixes)
-      card_prefixes.each {|cp|
-        card_num = card_name([cp])
-        if (card_num)
-          return card_num.gsub(cp, '')
-        end
-      }
-      return nil
+    def by_any?(devs)
+      return false if devs.empty?
+      devs.any? { |dev| authored_by?(dev) }
     end
 
-    def merge_commit?
-      line.match('Merge remote-tracking branch') || line.match('Merge branch')
+    def contains_card?(card_prefix)
+      line.match(card_prefix)
+    end
+
+    def to_s
+      line
     end
 
-    def date
+    private
+
+    def _get_date(line)
       regex = /(\d{4}-\d{2}-\d{2})/
       matcher = line.match(regex)
-      part_to_parse = matcher.nil? ? '' : (line.match regex)[1]
-      Date.parse(part_to_parse)
+      Date.parse((line.match regex)[1]) unless matcher.nil?
     end
 
-    def by_any?(devs)
-      if devs.size == 0
-        return false
-      end
-      devs.any? {|dev| authored_by?(dev)}
+    def _contains_any_of?(names)
+      names.any? { |name| _line_contains_name(name) }
     end
 
-    def to_s
-      line
+    def _line_contains_name(name)
+      /(^|\s+|\W)#{name}(\s+|$|\W)/i =~ line
     end
   end
 end