paid_up 0.7.5 → 0.7.6

data/spec/factories/group.rb

@@ -1,5 +1,15 @@
 FactoryGirl.define do
   factory :group do
     title 'Test Title'
+    transient do
+      owner { User.order("RANDOM()").first }
+    end
+    # the after(:create) yields two values; the user instance itself and the
+    # evaluator, which stores all values from the factory, including transient
+    # attributes; `create_list`'s second argument is the number of records
+    # to create and we make sure the user is associated properly to the post
+    after(:create) do |group, evaluator|
+      evaluator.owner.add_role(:owner, group)
+    end
   end
 end

data/spec/factories/user.rb

@@ -1,7 +1,25 @@
 FactoryGirl.define do
-  factory :user, aliases: [:subscriber] do
+  factory :user do
     email { "#{name.gsub(' ', '.').downcase}@example.com" }
     password "password"
     password_confirmation "password"
+    transient do
+      plan { PaidUp::Plan.order("RANDOM()").first }
+    end
+    # the after(:create) yields two values; the user instance itself and the
+    # evaluator, which stores all values from the factory, including transient
+    # attributes; `create_list`'s second argument is the number of records
+    # to create and we make sure the user is associated properly to the post
+    after(:create) do |user, evaluator|
+      token = Stripe::Token.create(
+          card: {
+              number: '4242424242424242',
+              exp_month: 1,
+              exp_year: 45,
+              cvc: '111'
+          }
+      ).id
+      user.subscribe_to_plan(evaluator.plan, token)
+    end
   end
 end

data/spec/models/group_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 require "cancan/matchers"
 
 describe Group do
-  include_context 'groups'
+  include_context 'loaded site'
 
   describe '#owners' do
     subject { first_group.owners }
@@ -22,7 +22,7 @@ describe Group do
   describe '#owners_enabled_count' do
     describe 'when limited' do
       subject { first_group.owners_enabled_count }
-      it { should eq 1 }
+      it { should eq 5 }
     end
     describe 'when unlimited' do
       subject { second_group.owners_enabled_count }
@@ -41,13 +41,13 @@ describe Group do
     it { should eq 2 }
   end
 
-  describe '#enabled?' do
+  describe '#enabled' do
     describe 'when true' do
-      subject { first_group.enabled? }
+      subject { first_group.enabled }
       it { should eq true }
     end
     describe 'when false' do
-      subject { disabled_group.enabled? }
+      subject { disabled_group.enabled }
       it { should eq false }
     end
   end

data/spec/models/paid_up/feature_spec.rb

@@ -1,12 +1,13 @@
 require 'rails_helper'
 
 describe PaidUp::Feature do
+  include_context 'loaded site'
+
   it { should validate_presence_of(:slug) }
   it { should validate_presence_of(:title) }
   it { should validate_presence_of(:setting_type) }
   it { should validate_inclusion_of(:setting_type).in_array(%w(boolean table_rows rolify_rows))}
 
-  include_context 'plans and features'
   context '#feature_model' do
     subject { groups_feature.feature_model }
     it { should eq Group }

data/spec/models/paid_up/plan_spec.rb

@@ -1,6 +1,8 @@
 require 'rails_helper'
 
 describe PaidUp::Plan do
+  include_context 'loaded site'
+
   it { should have_many(:plan_feature_settings).class_name('PaidUp::PlanFeatureSetting') }
 
   it { should validate_presence_of(:title) }
@@ -8,7 +10,6 @@ describe PaidUp::Plan do
 
   it { should validate_uniqueness_of(:title) }
 
-  include_context 'plans and features'
 
   describe '.subscribable' do
     context 'returns all subscribable plans' do
@@ -28,7 +29,7 @@ describe PaidUp::Plan do
     describe 'when setting_type is integer' do
       context 'returns the setting value if available' do
         subject { group_leader_plan.feature_setting('groups') }
-        it { should eq(1) }
+        it { should eq(5) }
       end
       context 'returns 0 if not available' do
         subject { free_plan.feature_setting('groups') }

data/spec/models/user_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 require "cancan/matchers"
 
 describe User do
-  include_context 'subscribers'
+  include_context 'loaded site'
 
   context '#stripe_data' do
     subject { no_ads_subscriber.stripe_data }
@@ -20,6 +20,9 @@ describe User do
         token = working_stripe_token free_subscriber
         free_subscriber.subscribe_to_plan no_ads_plan, token
       end
+      after do
+        free_subscriber.subscribe_to_plan free_plan
+      end
       subject { free_subscriber.plan }
       it { should eq(no_ads_plan) }
     end
@@ -29,6 +32,9 @@ describe User do
         before do
           no_ads_subscriber.subscribe_to_plan group_leader_plan
         end
+        after do
+          no_ads_subscriber.subscribe_to_plan no_ads_plan
+        end
         subject { no_ads_subscriber.plan }
         it { should eq(group_leader_plan) }
       end
@@ -37,6 +43,9 @@ describe User do
           token = working_stripe_token no_ads_subscriber
           no_ads_subscriber.subscribe_to_plan group_leader_plan, token
         end
+        after do
+          no_ads_subscriber.subscribe_to_plan no_ads_plan
+        end
         subject { no_ads_subscriber.plan }
         it { should eq(group_leader_plan) }
       end
@@ -60,6 +69,10 @@ describe User do
         before do
           professional_subscriber.subscribe_to_free_plan
         end
+        after do
+          token = working_stripe_token no_ads_subscriber
+          professional_subscriber.subscribe_to_plan professional_plan, token
+        end
         subject { professional_subscriber.plan }
         it { should eq(free_plan) }
       end
@@ -84,7 +97,7 @@ describe User do
     end
     context 'when subscribed to a plan with the feature limited' do
       subject { group_leader_subscriber.table_rows_remaining 'doodads' }
-      it { should eq 5 }
+      it { should eq 10 }
     end
     context 'when subscribed to a plan with the feature unlimited' do
       subject { professional_subscriber.table_rows_remaining 'doodads' }
@@ -114,7 +127,7 @@ describe User do
     end
     context 'when subscribed to a plan with the feature limited' do
       subject { group_leader_subscriber.table_rows_allowed 'doodads' }
-      it { should eq 5 }
+      it { should eq 10 }
     end
     context 'when subscribed to a plan with the feature unlimited' do
       subject { professional_subscriber.table_rows_allowed 'doodads' }
@@ -145,11 +158,11 @@ describe User do
     end
     context 'when subscribed to a plan with the feature limited' do
       subject { group_leader_subscriber.rolify_rows_remaining 'groups' }
-      it { should eq 1 }
+      it { should eq 4 }
     end
     context 'when subscribed to a plan with the feature unlimited' do
       subject { professional_subscriber.rolify_rows_remaining 'groups' }
-      it { should eq PaidUp::Unlimited.to_i }
+      it { should be > 99999999 }
     end
   end
 
@@ -175,7 +188,7 @@ describe User do
     end
     context 'when subscribed to a plan with the feature limited' do
       subject { group_leader_subscriber.rolify_rows_allowed 'groups' }
-      it { should eq 1 }
+      it { should eq 5 }
     end
     context 'when subscribed to a plan with the feature unlimited' do
       subject { professional_subscriber.rolify_rows_allowed 'groups' }
@@ -185,17 +198,19 @@ describe User do
 
   context '#rolify_rows' do
     context 'when possessing no rows' do
-      subject { professional_subscriber.rolify_rows 'groups' }
+      subject { blank_subscriber.rolify_rows 'groups' }
       it { should eq 0 }
     end
     context 'when possessing 3 rows' do
       before do
         3.times do
-          group = Group.create! title: Forgery('name').company_name
-          professional_subscriber.add_role(:owner, group)
+          FactoryGirl.create(
+            :group,
+            owner: blank_subscriber
+          )
         end
       end
-      subject { professional_subscriber.rolify_rows 'groups' }
+      subject { blank_subscriber.rolify_rows 'groups' }
       it { should eq 3 }
     end
   end
@@ -298,10 +313,11 @@ describe User do
   describe "Abilities" do
 
     context "when anonymous" do
-      let(:group) { Group.create!(title: 'Test Group') }
+      let(:group){ FactoryGirl.create(:group, owner: professional_subscriber) }
       let(:user){ nil }
       subject(:ability){ Ability.new(user) }
-      it{ should be_able_to(:read, Group) }
+      it{ should be_able_to(:index, group) }
+      it{ should be_able_to(:show, group) }
       it{ should_not be_able_to(:manage, group) }
       it{ should_not be_able_to(:own, Group) }
       it{ should_not be_able_to(:create, Group) }
@@ -309,10 +325,11 @@ describe User do
       it{ should_not be_able_to(:create, Doodad) }
     end
     context "when on free plan" do
-      let(:group) { Group.create!(title: 'Test Group') }
+      let(:group){ FactoryGirl.create(:group, owner: professional_subscriber) }
       let(:user){ free_subscriber }
       subject(:ability){ Ability.new(user) }
-      it{ should be_able_to(:read, Group) }
+      it{ should be_able_to(:index, group) }
+      it{ should be_able_to(:show, group) }
       it{ should_not be_able_to(:manage, group) }
       it{ should_not be_able_to(:own, Group) }
       it{ should_not be_able_to(:create, Group) }
@@ -321,24 +338,23 @@ describe User do
     end
     context "when on group plan" do
       context "given no groups are owned" do
-        let(:group) { Group.create!(title: 'Test Group') }
+        let(:group){ FactoryGirl.create(:group, owner: group_leader_subscriber) }
         let(:user){ group_leader_subscriber }
         subject(:ability){ Ability.new(user) }
-        it{ should be_able_to(:read, Group) }
-        it{ should_not be_able_to(:manage, group) }
+        it{ should be_able_to(:index, group) }
+        it{ should be_able_to(:show, group) }
+        it{ should be_able_to(:manage, group) }
         it{ should be_able_to(:own, Group) }
         it{ should be_able_to(:create, Group) }
         it{ should be_able_to(:use, :ad_free) }
         it{ should be_able_to(:create, Doodad) }
       end
-      context "given one group is owned" do
-        let(:group) { Group.create!(title: 'Test Group') }
-        let(:user) {
-          group_leader_subscriber.add_role(:owner, group)
-          group_leader_subscriber
-        }
+      context "given all allowed groups are owned" do
+        let(:group){ FactoryGirl.create(:group, owner: disabling_subscriber) }
+        let(:user) { disabling_subscriber }
         subject(:ability){ Ability.new(user) }
-        it{ should be_able_to(:read, Group) }
+        it{ should be_able_to(:index, group) }
+        it{ should be_able_to(:show, group) }
         it{ should be_able_to(:manage, group) }
         it{ should be_able_to(:own, Group) }
         it{ should_not be_able_to(:create, Group) }
@@ -348,10 +364,11 @@ describe User do
     end
     context "when on professional plan" do
       context "given no groups are owned" do
-        let(:group) { Group.create!(title: 'Test Group') }
+        let(:group){ FactoryGirl.create(:group, owner: blank_subscriber) }
         let(:user){ professional_subscriber }
         subject(:ability){ Ability.new(user) }
-        it{ should be_able_to(:read, Group) }
+        it{ should be_able_to(:index, group) }
+        it{ should be_able_to(:show, group) }
         it{ should_not be_able_to(:manage, group) }
         it{ should be_able_to(:own, Group) }
         it{ should be_able_to(:create, Group) }
@@ -359,13 +376,11 @@ describe User do
         it{ should be_able_to(:create, Doodad) }
       end
       context "given one group is owned" do
-        let(:group){ Group.create!(title: 'Test Group') }
-        let(:user){
-          professional_subscriber.add_role(:owner, group)
-          professional_subscriber
-        }
+        let(:group){ FactoryGirl.create(:group, owner: professional_subscriber) }
+        let(:user){ professional_subscriber }
         subject(:ability){ Ability.new(user) }
-        it{ should be_able_to(:read, Group) }
+        it{ should be_able_to(:index, group) }
+        it{ should be_able_to(:show, group) }
         it{ should be_able_to(:manage, group) }
         it{ should be_able_to(:own, Group) }
         it{ should be_able_to(:create, Group) }

data/spec/rails_helper.rb

@@ -10,6 +10,8 @@ require 'rspec/rails'
 require 'shoulda/matchers'
 require 'factory_girl_rails'
 require 'capybara/rspec'
+require 'database_cleaner'
+require 'rake'
 
 # Requires supporting ruby files with custom matchers and macros, etc, in
 # spec/support/ and its subdirectories. Files matching `spec/**/*_spec.rb` are
@@ -26,11 +28,26 @@ require 'capybara/rspec'
 #
 Dir["./spec/support/**/*.rb"].sort.each { |f| require f}
 
+ActiveRecord::Migrator.migrations_paths = 'spec/dummy/db/migrate'
+
 # Checks for pending migrations before tests are run.
 # If you are not using ActiveRecord, you can remove this line.
 # ActiveRecord::Migration.maintain_test_schema!
 
 RSpec.configure do |config|
+
+  config.before(:suite) do
+    DatabaseCleaner.strategy = :transaction
+    DatabaseCleaner.clean_with(:truncation)
+    Dummy::Application.load_tasks
+    Rake::Task['db:seed'].invoke # loading seeds
+  end
+  config.around(:each) do |example|
+    DatabaseCleaner.cleaning do
+      example.run
+    end
+  end
+
   # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
   # config.fixture_path = "#{::Rails.root}/spec/fixtures
 
@@ -39,7 +56,7 @@ RSpec.configure do |config|
   # If you're not using ActiveRecord, or you'd prefer not to run each of your
   # examples within a transaction, remove the following line or assign false
   # instead of true.
-  config.use_transactional_fixtures = true
+  # config.use_transactional_fixtures = true
 
   # RSpec Rails can automatically mix in different behaviours to your tests
   # based on their file location, for example enabling you to call `get` and

data/spec/routing/paid_up/plans_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 describe 'PaidUp::Routing' do
-  include_context 'plans and features'
+  include_context 'loaded site'
   routes { PaidUp::Engine.routes }
 
   describe "routes to the list of all plans" do

data/spec/routing/paid_up/subscription_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 describe 'PaidUp::Routing' do
-  include_context 'plans and features'
+  include_context 'loaded site'
   routes { PaidUp::Engine.routes }
 
   describe 'nested resource' do

data/spec/support/features.rb

@@ -0,0 +1,5 @@
+shared_context "features" do
+  let!(:ad_free_feature) { PaidUp::Feature.find_by_slug('ad_free') }
+  let!(:groups_feature) { PaidUp::Feature.find_by_slug('groups') }
+  let!(:doodads_feature) { PaidUp::Feature.find_by_slug('doodads') }\
+end

data/spec/support/groups.rb

@@ -1,34 +1,6 @@
 shared_context 'groups' do
-  include_context 'subscribers'
-
-  let!(:first_group) {
-    FactoryGirl.create(
-        :group,
-        title: 'First Group'
-    )
-  }
-  let!(:second_group) {
-    FactoryGirl.create(
-        :group,
-        title: 'Second Group'
-    )
-  }
-  let!(:third_group) {
-    FactoryGirl.create(
-        :group,
-        title: 'Third Group'
-    )
-  }
-  let!(:disabled_group) {
-    FactoryGirl.create(
-        :group,
-        title: 'Disabled Group'
-    )
-  }
-  before do
-    group_leader_subscriber.add_role(:owner, first_group)
-    group_leader_subscriber.add_role(:owner, disabled_group)
-    professional_subscriber.add_role(:owner, second_group)
-    professional_subscriber.add_role(:owner, third_group)
-  end
+  let(:first_group) { Group.find_by_title('First Group') }
+  let(:second_group) { Group.find_by_title('Second Group') }
+  let(:third_group) { Group.find_by_title('Third Group') }
+  let(:disabled_group) { Group.find_by_title('Disabled Group') }
 end

data/spec/support/loaded_site.rb

@@ -0,0 +1,7 @@
+shared_context 'loaded site' do
+  include_context 'plans'
+  include_context 'features'
+  include_context 'stripe'
+  include_context 'users'
+  include_context 'groups'
+end

data/spec/support/plans.rb

@@ -0,0 +1,7 @@
+shared_context "plans" do
+  let!(:anonymous_plan) { PaidUp::Plan.find_by_stripe_id('anonymous-plan') }
+  let!(:free_plan) { PaidUp::Plan.find_by_stripe_id('free-plan') }
+  let!(:no_ads_plan) { PaidUp::Plan.find_by_stripe_id('no-ads-plan') }
+  let!(:group_leader_plan) { PaidUp::Plan.find_by_stripe_id('group-leader-plan') }
+  let!(:professional_plan) { PaidUp::Plan.find_by_stripe_id('professional-plan') }
+end

data/spec/support/users.rb

@@ -0,0 +1,8 @@
+shared_context 'users' do
+  let(:free_subscriber) { User.find_by_name('Free Subscriber') }
+  let(:no_ads_subscriber) { User.find_by_name('No Ads Subscriber') }
+  let(:group_leader_subscriber) { User.find_by_name('Group Leader Subscriber') }
+  let(:professional_subscriber) { User.find_by_name('Professional Subscriber') }
+  let(:blank_subscriber) { User.find_by_name('Blank Subscriber') }
+  let(:disabling_subscriber) { User.find_by_name('Disabling Subscriber') }
+end

data/spec/views/paid_up/plans_spec.rb

@@ -1,8 +1,7 @@
 require "rails_helper"
 
 RSpec.describe "paid_up/plans/index" do
-  include_context 'plans and features'
-  include_context 'subscribers'
+  include_context 'loaded site'
 
   context 'when user is anonymous' do
     before do

data/spec/views/paid_up/subscriptions_spec.rb

@@ -1,8 +1,8 @@
 require "rails_helper"
 
 RSpec.describe "paid_up/subscriptions/new" do
+  include_context 'loaded site'
   context 'when user is logged in as free customer' do
-    include_context 'subscribers'
     context "displays a payment form" do
       before do
         view.extend PaidUp::PlansHelper
@@ -19,7 +19,6 @@ RSpec.describe "paid_up/subscriptions/new" do
     end
   end
   context 'when user is logged in as a paid customer' do
-    include_context 'subscribers'
     context "displays a payment form" do
       before do
         view.extend PaidUp::PlansHelper
@@ -38,8 +37,8 @@ RSpec.describe "paid_up/subscriptions/new" do
 end
 
 RSpec.describe "paid_up/subscriptions/index" do
+  include_context 'loaded site'
   context 'when user is logged in' do
-    include_context 'subscribers'
     context "displays the details of a user's subscriptions" do
       before do
         view.extend PaidUp::PlansHelper

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: paid_up
 version: !ruby/object:Gem::Version
-  version: 0.7.5
+  version: 0.7.6
 platform: ruby
 authors:
 - Karen Lundgren
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-21 00:00:00.000000000 Z
+date: 2015-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -276,6 +276,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.2'
+- !ruby/object:Gem::Dependency
+  name: factory_girl_rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.5'
 description: Allows a model of your choosing (such as users) to subscribe to a plan,
   which enables features.
 email: karen.e.lundgren@gmail.com
@@ -387,6 +401,9 @@ files:
 - spec/dummy/config/locales/en.yml
 - spec/dummy/config/routes.rb
 - spec/dummy/config/secrets.yml
+- spec/dummy/coverage/.last_run.json
+- spec/dummy/coverage/.resultset.json
+- spec/dummy/coverage/.resultset.json.lock
 - spec/dummy/db/development.sqlite3
 - spec/dummy/db/migrate/20150406154440_create_users_table.rb
 - spec/dummy/db/migrate/20150517175135_create_groups_table.rb
@@ -430,10 +447,12 @@ files:
 - spec/spec_helper.rb
 - spec/support/controller_macros.rb
 - spec/support/factory_girl.rb
+- spec/support/features.rb
 - spec/support/groups.rb
-- spec/support/plans_and_features.rb
+- spec/support/loaded_site.rb
+- spec/support/plans.rb
 - spec/support/stripe.rb
-- spec/support/subscribers.rb
+- spec/support/users.rb
 - spec/views/paid_up/plans_spec.rb
 - spec/views/paid_up/subscriptions_spec.rb
 homepage: http://www.gemvein.com/museum/cases/paid_up