pageflow 15.2.0 → 15.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 0f634bdc5700407153c1e555eb991eac53f2572d
-  data.tar.gz: 47766062e1a5fedffcce3c969fae1fa52ba10ed3
+SHA256:
+  metadata.gz: 96902980a5bb3f8dbdb7fea7c6d2ac7864cec92f72b841a32f9544d56f25ddf7
+  data.tar.gz: fb05810978adc0db7eac1901beec575d0d552c2187f95e4e4df92ab8d58801be
 SHA512:
-  metadata.gz: 8a87e52617931eeff9d0bce5bf8b09ef2673e4543173d9cd00edd88d2e2fab165222a6216785560fb099635e2a8fc7e7df9f1c69d3c8c79d94cde602aedcf5a2
-  data.tar.gz: ebcb2edecf5aca9a2dbbd2037a4e07120cdf3fcc3c578de36ba5a19d08507298a493e3ef15b21714829061dd0a43d777e4d882a2303a3beed8f0942506e2adf5
+  metadata.gz: 157deea11713fb77f374469ffcb2ed25ebe0e7401f140eea761266602099a89311b58be6b4e353980dc6bae3bd896136e2a27b7748c9e6434142816230973400
+  data.tar.gz: 571fd3407f0e45cd0ba1bb902349da1e84ee1ffdd7cb5367ac59cc22de439ae1866b79214e96c08ecc92956b367ec1a5dd84f2a1f6fa4ff4236d6b9307643e89

data/CHANGELOG.md

@@ -1,110 +1,116 @@
 # CHANGELOG
 
-### Version 15.2.0
+### Version 15.5.0
 
-2020-04-01
+2021-05-07
 
-[Compare changes](https://github.com/codevise/pageflow/compare/15-1-stable...v15.2.0)
+[Compare changes](https://github.com/codevise/pageflow/compare/15-4-stable...v15.5.0)
 
 #### Core
 
-##### Editor
+##### Manual Update Step
 
-- Bug fix: Re-add entry.configuration in editor for backwards compatibility
-  ([#1331](https://github.com/codevise/pageflow/pull/1331))
-- Bug fix: Fix help link in editor page type drop down
-  ([#1372](https://github.com/codevise/pageflow/pull/1372))
+- Upgrade Webpack config
 
-##### Documentation
+  Disable Babel compilation of `node_modules` directory to prevent
+  error of the form "_typeof is not defined" in Video.js HTTP
+  streaming service worker that is registered when DASH sources are
+  used. Add the following lines to the host application's
+  `config/webpack/environment.js` file:
 
-- Remind developers to configure their editor with ESLint before starting to contribute
-  ([#1369](https://github.com/codevise/pageflow/pull/1369))
-- Move troubleshooting to docs
-  ([#1327](https://github.com/codevise/pageflow/pull/1327))
+  ```
+  environment.config.merge(require('pageflow-scrolled/config/webpack'))
 
-##### Internal
+  // Opt into future default behavior of Webpacker [1] to work around
+  // problems with Video.js DASH service worker.
+  //
+  // [1] https://github.com/rails/webpacker/pull/2624
+  environment.loaders.delete('nodeModules')
 
-- Extract entry template from theming
-  ([#1315](https://github.com/codevise/pageflow/pull/1315))
-- Use Ruby 2.6.5 in Travis
-  ([#1334](https://github.com/codevise/pageflow/pull/1334))
-- Remove pageflow-react from yarn workspace list
-  ([#1329](https://github.com/codevise/pageflow/pull/1329))
+  ```
 
-#### Paged Entry Type
+  No longer precompiling `node_modules` means that some ES6 syntax
+  included in some of the packages will end up in the
+  bundle. `therubyracer` gem then causes "Use of const in strict mode"
+  error during SSR. Upgrading the host application to use `mini_racer`
+  instead fixes the problem.
+  ([#1655](https://github.com/codevise/pageflow/pull/1655))
 
-##### Published Entry
+##### Rails Engine
+
+- Allow registering entry type specific file importers
+  ([#1684](https://github.com/codevise/pageflow/pull/1684))
+- Nested revision components
+  ([#1654](https://github.com/codevise/pageflow/pull/1654))
+- Nested revision components
+  ([#1654](https://github.com/codevise/pageflow/pull/1654))
+- Upgrade to Devise 4.7
+  ([#1657](https://github.com/codevise/pageflow/pull/1657))
+
+##### Admin
 
-- Allow hiding the logo on page level
-  ([#1356](https://github.com/codevise/pageflow/pull/1356))
-- Bug fix: Make multimedia alert and new pages box display again for
-  new entries
-  ([#1366](https://github.com/codevise/pageflow/pull/1366))
+- Validate user locale
+  ([#1658](https://github.com/codevise/pageflow/pull/1658))
+
+#### Paged Entry Type
+
+- Add theme option for content text phone typography
+  ([#1670](https://github.com/codevise/pageflow/pull/1670))
+- Bug fix: Wait until listener is ready before requesting cookie notice
+  ([#1650](https://github.com/codevise/pageflow/pull/1650))
 
 #### Scrolled Entry Type
 
-##### Content Elements
+##### Rails Engine
 
-- Add before/after content element
-  ([#1351](https://github.com/codevise/pageflow/pull/1351))
-- dataWrapperChart content element
-  ([#1349](https://github.com/codevise/pageflow/pull/1349),
-   [#1355](https://github.com/codevise/pageflow/pull/1355))
-- External link content element
-  ([#1346](https://github.com/codevise/pageflow/pull/1346))
-- Add videoEmbed content element
-  ([#1336](https://github.com/codevise/pageflow/pull/1336))
+- Color/font options for scrolled themes
+  ([#1673](https://github.com/codevise/pageflow/pull/1673))
+- Improve scrolled install generator
+  ([#1682](https://github.com/codevise/pageflow/pull/1682))
 
-##### Widgets
+##### Published Entry
 
-- Improve navigation
-  ([#1347](https://github.com/codevise/pageflow/pull/1347))
+- Add 360 image content element based on @egjs/view360
+  ([#1675](https://github.com/codevise/pageflow/pull/1675),
+   [#1676](https://github.com/codevise/pageflow/pull/1676))
+- Add position wide for heading content elements
+  ([#1678](https://github.com/codevise/pageflow/pull/1678))
+- Remove chapter number from chapter box
+  ([#1679](https://github.com/codevise/pageflow/pull/1679))
+- Fix embed video opt in text color in inverted section
+  ([#1671](https://github.com/codevise/pageflow/pull/1671))
+- Handle player unallocated by empty pool
+  ([#1668](https://github.com/codevise/pageflow/pull/1668))
+- Horizontal scroller for desktop navigation bar
+  ([#1669](https://github.com/codevise/pageflow/pull/1669))
+- Improve file rights
+  ([#1665](https://github.com/codevise/pageflow/pull/1665))
+- Allow non latin characters in video embed caption
+  ([#1664](https://github.com/codevise/pageflow/pull/1664))
+- Hyphenate long text block headers
+  ([#1662](https://github.com/codevise/pageflow/pull/1662))
+- Upgrade Scrolled to Video.js 7
+  ([#1655](https://github.com/codevise/pageflow/pull/1655))
+- Improve before/after wiggle animation
+  ([#1659](https://github.com/codevise/pageflow/pull/1659))
+- Display notices for unsupported browser or non-js
+  ([#1653](https://github.com/codevise/pageflow/pull/1653))
+- Basic styles for print layout of scrolled entries
+  ([#1652](https://github.com/codevise/pageflow/pull/1652))
+- Bug fix: Hide frame around inline video on iOS 12
+  ([#1680](https://github.com/codevise/pageflow/pull/1680))
 
 ##### Editor
 
-- Adding content elements
-  ([#1337](https://github.com/codevise/pageflow/pull/1337))
-- Edit content elements in the editor
-  ([#1335](https://github.com/codevise/pageflow/pull/1335))
-- Add inline help texts for scrolled editor
-  ([#1353](https://github.com/codevise/pageflow/pull/1353))
-- Add section editing options in editor sidebar
-  ([#1363](https://github.com/codevise/pageflow/pull/1363))
-
-##### JavaScript API
-
-- Export useFile hook from scrolled frontend
-  ([#1371](https://github.com/codevise/pageflow/pull/1371))
-- Fix useFileRights hook
-  ([#1357](https://github.com/codevise/pageflow/pull/1357))
-- I18n for scrolled frontend
-  ([#1342](https://github.com/codevise/pageflow/pull/1342))
-- Content element frontend api
-  ([#1324](https://github.com/codevise/pageflow/pull/1324))
-- Enable registering content elements with default config
-  ([#1354](https://github.com/codevise/pageflow/pull/1354),
-   [#1360](https://github.com/codevise/pageflow/pull/1360))
-- Introduce configuration editor groups in scrolled editor
-  ([#1352](https://github.com/codevise/pageflow/pull/1352),
-   [#1365](https://github.com/codevise/pageflow/pull/1365))
-- Improve guides
-  ([#1362](https://github.com/codevise/pageflow/pull/1362),
-   [#1348](https://github.com/codevise/pageflow/pull/1348),
-   [#1344](https://github.com/codevise/pageflow/pull/1344))
-
-##### Internal
-
-- Make package imports external by default in Rollup config
-  ([#1341](https://github.com/codevise/pageflow/pull/1341))
-- Make pageflow-scrolled Capybara specs less flaky
-  ([#1339](https://github.com/codevise/pageflow/pull/1339))
-- Prevent Percy from reporting different video loading progress
-  ([#1343](https://github.com/codevise/pageflow/pull/1343))
-- Enable React devtools in editor iframe
-  ([#1338](https://github.com/codevise/pageflow/pull/1338))
-- Setup Storybook for content element development
-  ([#1326](https://github.com/codevise/pageflow/pull/1326))
+- Prevent concurrent save requests for embed urls
+  ([#1672](https://github.com/codevise/pageflow/pull/1672))
+- Do not trigger multiple save requests for backdrop updates
+  ([#1666](https://github.com/codevise/pageflow/pull/1666))
+- Fix lazy loading in editor for Safari
+  ([#1660](https://github.com/codevise/pageflow/pull/1660))
+- Bug fix: Cascade model removal through ForeignKeySubsetCollection
+  ([#1651](https://github.com/codevise/pageflow/pull/1651))
 
 See
-[15-1-stable branch](https://github.com/codevise/pageflow/blob/15-1-stable/CHANGELOG.md)
+[15-4-stable branch](https://github.com/codevise/pageflow/blob/15-4-stable/CHANGELOG.md)
 for previous changes.

data/README.md

@@ -1,7 +1,7 @@
 # Pageflow
 
 [![Gem Version](https://badge.fury.io/rb/pageflow.svg)](http://badge.fury.io/rb/pageflow)
-[![Build Status](https://travis-ci.org/codevise/pageflow.svg?branch=master)](https://travis-ci.org/codevise/pageflow)
+[![Build Status](https://github.com/codevise/pageflow/workflows/tests/badge.svg)](https://github.com/codevise/pageflow/actions)
 [![Coverage Status](https://coveralls.io/repos/github/codevise/pageflow/badge.svg?branch=master)](https://coveralls.io/github/codevise/pageflow?branch=master)
 [![Code Climate](https://codeclimate.com/github/codevise/pageflow/badges/gpa.svg)](https://codeclimate.com/github/codevise/pageflow)
 [![Reviewed by Hound](https://img.shields.io/badge/Reviewed_by-Hound-8E64B0.svg)](https://houndci.com)
@@ -53,7 +53,7 @@ Pageflow assumes the following choice of libraries:
 Pageflow runs in environments with:
 
 * Ruby >= 2.1 (see `.travis.yml` for supported versions)
-* Node >= 10.0
+* Node >= 10.18
 * Rails 4.2
 * Redis server (for Resque)
 * A database server supported by Active Record (tested with MySQL)
@@ -212,4 +212,3 @@ We would like to express our special thanks to the following services
 for supporting Pageflow through free open source plans:
 
 [![BrowserStack](doc/supporter_logos/browser_stack.png)](https://browserstack.com)
-[![Travis CI](doc/supporter_logos/travis_ci.png)](https://travis-ci.com/)

data/admins/pageflow/accounts.rb

@@ -30,9 +30,6 @@ module Pageflow
           membership_role_with_tooltip(own_role, scope: 'own_account_role')
         end
       end
-      column :default_theming do |account|
-        account.first_paged_entry_template.theme_name if authorized?(:read, account)
-      end
     end
 
     csv do
@@ -63,7 +60,6 @@ module Pageflow
     show :title => :name do |account|
       render 'account_details', :account => account
       render 'theming_details', :account => account
-      render 'entry_template_details', account: account
 
       tabs_view(Pageflow.config.admin_resource_tabs.find_by_resource(account.default_theming),
                 i18n: 'pageflow.admin.resource_tabs',
@@ -76,76 +72,25 @@ module Pageflow
       helper Pageflow::Admin::FormHelper
       helper Pageflow::Admin::LocalesHelper
       helper Pageflow::Admin::MembershipsHelper
-      helper Pageflow::Admin::WidgetsHelper
       helper ThemesHelper
 
       def new
         @account = Account.new
         @account.build_default_theming
-        @entry_template = @account.entry_templates.build(
-          default_locale: current_user.locale,
-          share_providers: Pageflow.config.default_share_providers,
-          entry_type: 'paged'
-        )
       end
 
       def create
-        account_params = (permitted_params[:account] || {})
-                         .except(:paged_entry_template_attributes)
+        account_params = permitted_params[:account] || {}
         @account = Account.new(account_params)
         @account.build_default_theming(permitted_params.fetch(:account, {})[
                                          :default_theming_attributes])
-        @entry_template = @account.entry_templates.build({entry_type: 'paged'}
-                                                  .merge(entry_template_params))
-
-        super
-        update_widgets('paged')
-      end
-
-      def edit
-        @entry_template = resource.first_paged_entry_template
         super
       end
 
       def update
-        @entry_template = resource.entry_templates.find_or_initialize_by(
-          entry_type: 'paged'
-        )
-        @entry_template.assign_attributes(entry_template_params)
-        @entry_template.save
         update! do |success, failure|
           success.html { redirect_to(admin_account_path(resource, params.permit(:tab))) }
         end
-        update_widgets('paged')
-      end
-
-      def entry_template_params
-        current_params = permitted_params_with_entry_template_attributes.fetch(:account, {})[
-          :paged_entry_template_attributes]&.to_hash
-        if current_params
-          config = true_false_strings_to_booleans_or_numbers(
-            current_params['configuration']
-          )
-          share_providers = true_false_strings_to_booleans_or_numbers(
-            current_params['share_providers']
-          )
-          current_params.merge('configuration' => config, 'share_providers' => share_providers)
-        else
-          {}
-        end
-      end
-
-      def update_widgets(entry_type)
-        if @account.valid?
-          EntryTemplate.find_by(account_id: @account.id, entry_type: entry_type)
-            &.widgets&.batch_update!(widgets_params)
-        end
-      end
-
-      def widgets_params
-        (params[:widgets].try(:permit!).to_h || {}).map do |role, type_name|
-          {role: role, type_name: type_name}
-        end
       end
 
       def permitted_params
@@ -154,12 +99,6 @@ module Pageflow
         with_permitted_feature_states(result)
       end
 
-      def permitted_params_with_entry_template_attributes
-        result = params.permit(account: permitted_account_attributes_plus_entry_template)
-
-        with_permitted_feature_states(result)
-      end
-
       def scoped_collection
         super.includes(:default_theming)
       end
@@ -172,25 +111,6 @@ module Pageflow
         result
       end
 
-      def true_false_strings_to_booleans_or_numbers(hash)
-        hash&.map { |k, v| [k, to_boolean_or_number(v)] }&.to_h
-      end
-
-      def to_boolean_or_number(value)
-        case value
-        when 'false'
-          false
-        when 'true'
-          true
-        when '0'
-          0
-        when '1'
-          1
-        else
-          value
-        end
-      end
-
       def permitted_account_attributes
         [
           :name,
@@ -200,11 +120,6 @@ module Pageflow
           permitted_attributes_for(:account)
       end
 
-      def permitted_account_attributes_plus_entry_template
-        permitted_account_attributes +
-          [paged_entry_template_attributes: permitted_entry_template_attributes]
-      end
-
       def permitted_theming_attributes
         [
           :cname,
@@ -219,18 +134,6 @@ module Pageflow
           permitted_attributes_for(:theming)
       end
 
-      def permitted_entry_template_attributes
-        [
-          :theme_name,
-          :default_author,
-          :default_publisher,
-          :default_keywords,
-          :default_locale,
-          share_providers: {},
-          configuration: {}
-        ]
-      end
-
       def permitted_attributes_for(resource_name)
         if params[:id]
           Pageflow.config_for(resource).admin_form_inputs.permitted_attributes_for(resource_name)

data/admins/pageflow/entry.rb

@@ -130,6 +130,14 @@ module Pageflow
                   input_html: {style: 'width: 200px'})
         end
 
+        if f.object.new_record?
+          f.input :type_name,
+                  as: :select,
+                  include_blank: false,
+                  collection: entry_type_collection,
+                  wrapper_html: {style: 'display: none'}
+        end
+
         if authorized?(:configure_folder_for, resource)
           folder_collection = collection_for_folders(resource.account, resource.folder)
           f.input(:folder,
@@ -168,6 +176,18 @@ module Pageflow
       end
     end
 
+    collection_action :entry_types do
+      account = Pageflow::Account.find(params[:account_id])
+
+      if authorized?(:see_entry_types, account)
+        @entry_types = helpers.entry_type_collection_for_account(account)
+
+        render(layout: false)
+      else
+        render(partial: 'not_allowed_to_see_entry_types', status: 403)
+      end
+    end
+
     member_action :duplicate, method: :post do
       entry = Entry.find(params[:id])
       authorize!(:duplicate, entry)
@@ -251,7 +271,7 @@ module Pageflow
       end
 
       def permitted_attributes
-        result = [:title]
+        result = [:title, :type_name]
         target = if !params[:id] && current_user.admin?
                    Account.first
                  elsif params[:id]

data/admins/pageflow/entry_templates.rb

@@ -0,0 +1,140 @@
+module Pageflow
+  ActiveAdmin.register EntryTemplate, as: 'EntryTemplate' do
+    menu false
+    config.batch_actions = false
+    actions :index, :new, :create, :edit, :update
+    form partial: 'form'
+
+    belongs_to :account, parent_class: Pageflow::Account
+
+    breadcrumb do
+      breadcrumb_links.first 3
+    end
+
+    controller do
+      helper Pageflow::Admin::FormHelper
+      helper Pageflow::Admin::WidgetsHelper
+
+      def index
+        redirect_to redirect_path
+      end
+
+      def new
+        account = Account.find(params[:account_id])
+        @entry_template = EntryTemplate.new(
+          account: account,
+          entry_type_name: params[:entry_type_name]
+        )
+
+        @page_title = page_title('new', params[:entry_type_name])
+
+        super
+      end
+
+      def create
+        @entry_template = EntryTemplate.new(
+          entry_template_params.merge(account_id: permitted_params[:account_id])
+        )
+        @page_title = page_title('new', @entry_template.entry_type_name)
+        authorize!(:create, @entry_template)
+        create! { redirect_path }
+        update_widgets if @entry_template.errors.empty?
+      end
+
+      def edit
+        @page_title = page_title('edit', resource.entry_type_name)
+        super
+      end
+
+      def update
+        @entry_template = EntryTemplate.find(params[:id])
+        @entry_template.assign_attributes(entry_template_params)
+        @page_title = page_title('edit', @entry_template.entry_type_name)
+        params[:entry_template].delete('share_providers')
+        params[:entry_template].delete('configuration')
+        authorize!(:update, @entry_template)
+        update! { redirect_path }
+        update_widgets if @entry_template.errors.empty?
+      end
+
+      private
+
+      def page_title(rest_verb, entry_type_name)
+        "#{I18n.t('pageflow.admin.entry_templates.page_title.' + rest_verb)} "\
+        "#{I18n.t('activerecord.values.pageflow/entry.type_names.' + entry_type_name)}"
+      end
+
+      def permitted_params
+        params.permit(
+          :account_id,
+          entry_template: permitted_entry_template_attributes
+        )
+      end
+
+      def permitted_entry_template_attributes
+        [
+          :id,
+          :account_id,
+          :entry_type_name,
+          :theme_name,
+          :default_author,
+          :default_publisher,
+          :default_keywords,
+          :default_locale,
+          share_providers: {},
+          configuration: {}
+        ]
+      end
+
+      def redirect_path
+        admin_account_path(params[:account_id], tab: 'entry_templates')
+      end
+
+      def entry_template_params
+        current_params = permitted_params[:entry_template]&.to_hash
+
+        if current_params
+          config = true_false_strings_to_booleans_or_numbers(
+            current_params['configuration']
+          )
+          share_providers = true_false_strings_to_booleans_or_numbers(
+            current_params['share_providers']
+          )
+          current_params.merge('configuration' => config,
+                               'share_providers' => share_providers)
+        else
+          {}
+        end
+      end
+
+      def true_false_strings_to_booleans_or_numbers(hash)
+        hash&.map { |k, v| [k, to_boolean_or_number(v)] }&.to_h
+      end
+
+      def to_boolean_or_number(value)
+        case value
+        when 'false'
+          false
+        when 'true'
+          true
+        when '0'
+          0
+        when '1'
+          1
+        else
+          value
+        end
+      end
+
+      def update_widgets
+        resource.widgets&.batch_update!(widgets_params)
+      end
+
+      def widgets_params
+        (params[:widgets].try(:permit!).to_h || {}).map do |role, type_name|
+          {role: role, type_name: type_name}
+        end
+      end
+    end
+  end
+end