pageflow 15.1.2 → 15.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: e36aad3da1e0af8d6a54b98c01e7af7d09712f38
-  data.tar.gz: b1553c60fd5fc7b617f06f831020f16eb9522c97
+SHA256:
+  metadata.gz: 3f03a7b8a1dfb0f883c3b74dc65373ddcdda27b3dad7a469b5f0c90dd66a4e7f
+  data.tar.gz: 62c18d804e95fb066746cb1cb482ad1504ca6e89107d63286c2950917a371d48
 SHA512:
-  metadata.gz: a00637112da27485532da857f43aaa9664aa0f7c533492fbd10cf7da92912cfd091282f873dab6d577f6fc5d4b4d7cdd6f25a798775a908f837fdcc96f9044d7
-  data.tar.gz: b4cdb7118d5d89ebb3b2e1f228475a1ba17ce4249619059f2995f3aa3738558939f1071b53c2325ce7234212c62712cd1469bde28519408721cadcf0623f393b
+  metadata.gz: cd94ad6911c8e9c0b0000f4eb294b3d0a06ebc108fa81692c284d0d2f89a53753665827110589979bd7e2a953f659bfd7e6707d35f89f5140821096742895251
+  data.tar.gz: 2ed57089f493c3d3c4773c503852c26473e50c0fe53e61acbbe0d01f2a6d383dc8460fcdaf06bfa349bcc5b17e3fe6960ad6791a629f09665283654037a0fd19

data/CHANGELOG.md

@@ -1,218 +1,188 @@
 # CHANGELOG
 
-### Version 15.1.2
+### Version 15.4.0
 
-2020-04-01
+2021-01-08
 
-[Compare changes](https://github.com/codevise/pageflow/compare/v15.1.1...v15.1.2)
-
-- Bug fix: Make multimedia alert and new pages box display again for
-  new paged entries
-  ([#1368](https://github.com/codevise/pageflow/pull/1368))
-
-### Version 15.1.1
-
-2020-02-12
-
-[Compare changes](https://github.com/codevise/pageflow/compare/v15.1.0...v15.1.1)
-
-- Re-add entry.configuration in editor for backwards compatibility
-  ([#1332](https://github.com/codevise/pageflow/pull/1332))
-
-### Version 15.1.0
-
-2020-02-05
-
-[Compare changes](https://github.com/codevise/pageflow/compare/15-0-stable...v15.1.0)
-
-See
-[changes grouped by pre releases](https://github.com/codevise/pageflow/blob/v15.1.0.rc0/CHANGELOG.md).
+[Compare changes](https://github.com/codevise/pageflow/compare/15-3-stable...v15.4.0)
 
 #### Core
 
-##### Host Application
-
-- Updated Active Admin to 2.5.0
-  ([#1280](https://github.com/codevise/pageflow/pull/1280))
-
-  Starting with Active Admin 2.0, using `unshift` (or any other
-  mutating method) to add load paths no longer work reliably (see
-  [activeadmin/activeadmin#5995](https://github.com/activeadmin/activeadmin/issues/5995).
-  Apply the following change to your host application's
-  `active_admin.rb` initializer:
-
-  ```diff
-  - ActiveAdmin.application.unshift(Pageflow.active_admin_load_path)
-  + ActiveAdmin.application.load_paths += [Pageflow.active_admin_load_path]
-  ```
-
-- Improve support for Webpack setup in host appplication
-  ([#1276](https://github.com/codevise/pageflow/pull/1276),
-   [#1279](https://github.com/codevise/pageflow/pull/1279))
-
-##### Admin
-
-- Improve add member button
-  ([#1195](https://github.com/codevise/pageflow/pull/1195))
-
 ##### Editor
 
-- Bug fix: Prevent including pageflow/ui in pageflow/editor
-  ([#1309](https://github.com/codevise/pageflow/pull/1309))
-
-##### Engine Config
-
-- Add entry type concept
-  ([#1249](https://github.com/codevise/pageflow/pull/1249))
-- Render entry type specific editor seed data
-  ([#1265](https://github.com/codevise/pageflow/pull/1265))
-- Entry type specific editor views
-  ([#1262](https://github.com/codevise/pageflow/pull/1262))
-- Entry type specific editor assets
-  ([#1257](https://github.com/codevise/pageflow/pull/1257))
-- Let entry types provide frontend apps to render entries
-  ([#1254](https://github.com/codevise/pageflow/pull/1254),
-   [#1255](https://github.com/codevise/pageflow/pull/1255))
-- Extend config DSL for entry types
-  ([#1267](https://github.com/codevise/pageflow/pull/1267))
-- Allow scoping file types and widget types by entry types
-  ([#1283](https://github.com/codevise/pageflow/pull/1283))
-- Decouple revision components and file types from page types
-  ([#1256](https://github.com/codevise/pageflow/pull/1256),
-   [#1259](https://github.com/codevise/pageflow/pull/1259))
-- Consider feature flags for file types available in editor
-  ([#1275](https://github.com/codevise/pageflow/pull/1275))
-- Extract part of appearance options into paged entry type
-  ([#1304](https://github.com/codevise/pageflow/pull/1304),
-   [#1321](https://github.com/codevise/pageflow/pull/1321))
-- Scope existing built ins to paged entry type
-  ([#1296](https://github.com/codevise/pageflow/pull/1296))
-- Integrate entry type specific config with feature flags
-  ([#1295](https://github.com/codevise/pageflow/pull/1295))
-- Decouple editor layout
-  ([#1284](https://github.com/codevise/pageflow/pull/1284))
-- Let entry types define editor controllers
-  ([#1271](https://github.com/codevise/pageflow/pull/1271))
-- Add authentication provider
-  ([#1236](https://github.com/codevise/pageflow/pull/1236))
-- Bug fix: Change revision#locale to always return string
-  ([#1239](https://github.com/codevise/pageflow/pull/1239))
-
-##### File Importers
-
-- Introduce file importer API
-  ([#1250](https://github.com/codevise/pageflow/pull/1250),
-   [#1266](https://github.com/codevise/pageflow/pull/1266),
-   [#1258](https://github.com/codevise/pageflow/pull/1258),
-   [#1269](https://github.com/codevise/pageflow/pull/1269),
-   [#1323](https://github.com/codevise/pageflow/pull/1323))
+- Improve editor styles
+  ([#1629](https://github.com/codevise/pageflow/pull/1629))
+- Bug fix: Wait for feature detection before booting editor
+  ([#1573](https://github.com/codevise/pageflow/pull/1573))
+- Bug fix: Work around Minicolors problem with updating swatches
+  ([#1583](https://github.com/codevise/pageflow/pull/1583))
 
 ##### Internal
 
-- Add configuration to revisions
-  ([#1306](https://github.com/codevise/pageflow/pull/1306))
-- Add entry type engines
-  ([#1247](https://github.com/codevise/pageflow/pull/1247))
-- Migrate legacy JavaScript to Rollup/Jest
-  ([#1241](https://github.com/codevise/pageflow/pull/1241))
-- Update pageflow-react build stack
-  ([#1240](https://github.com/codevise/pageflow/pull/1240))
-- Modernize editor JavaScript build stack
-  ([#1238](https://github.com/codevise/pageflow/pull/1238))
-- Replace chromedriver-helper by webdrivers
-  ([#1251](https://github.com/codevise/pageflow/pull/1251))
+- String literals in SQL should only be enclosed by single quotes
+  ([#1576](https://github.com/codevise/pageflow/pull/1576))
+- Stub Paperclip by default in specs
+  ([#1609](https://github.com/codevise/pageflow/pull/1609))
+- Retry js specs of pageflow engine
+  ([#1608](https://github.com/codevise/pageflow/pull/1608))
+- Migrate Travis jobs to GitHub actions
+  ([#1607](https://github.com/codevise/pageflow/pull/1607))
+- Fix CI and abort when dummy app generation fails
+  ([#1604](https://github.com/codevise/pageflow/pull/1604))
 
 #### Paged Entry Type
 
 ##### Editor
 
-- Bug fix: Fix page selection view
-  ([#1281](https://github.com/codevise/pageflow/pull/1281))
-
-##### Published Entry
-
-- Add width/height to social share images to make Facebook display
-  them faster.
-  ([#1223](https://github.com/codevise/pageflow/pull/1223))
-- Add translations for some text track languages
-  ([#1237](https://github.com/codevise/pageflow/pull/1237))
-- Add meta charset tag in application layout of paged entries
-  ([#1322](https://github.com/codevise/pageflow/pull/1322))
-- Bug fix: Invalidate page partial cache on locale change
-  ([#1311](https://github.com/codevise/pageflow/pull/1311))
-- Bug fix: Do not prefix partial paths with pageflow_paged
-  ([#1320](https://github.com/codevise/pageflow/pull/1320))
-- Bug fix: Fix `link_to home_button` raises URLGenerationError
-  ([#1310](https://github.com/codevise/pageflow/pull/1310))
-
-##### Internal
-
-- Move PagedEntriesController to paged entry type engine
-  ([#1285](https://github.com/codevise/pageflow/pull/1285))
-- Move editor actions into editor controller
-  ([#1282](https://github.com/codevise/pageflow/pull/1282))
+- Fix classic loading spinner preview in editor
+  ([#1649](https://github.com/codevise/pageflow/pull/1649))
 
 #### Scrolled Entry Type
 
 ##### Published Entry
 
-- Import scrolled entry type React app
-  ([#1264](https://github.com/codevise/pageflow/pull/1264))
-- Use seed data in scrolled entries
-  ([#1248](https://github.com/codevise/pageflow/pull/1248),
-   [#1270](https://github.com/codevise/pageflow/pull/1270),
-   [#1278](https://github.com/codevise/pageflow/pull/1278),
-   [#1286](https://github.com/codevise/pageflow/pull/1286),
-   [#1314](https://github.com/codevise/pageflow/pull/1314),
-   [#1242](https://github.com/codevise/pageflow/pull/1242))
-- Fix section index and references to adjacent chapters
-  ([#1316](https://github.com/codevise/pageflow/pull/1316))
-- Render uploaded images in scrolled entries
-  ([#1299](https://github.com/codevise/pageflow/pull/1299),
-   [#1303](https://github.com/codevise/pageflow/pull/1303))
-- Use chapters from db in navigaition bar
-  ([#1298](https://github.com/codevise/pageflow/pull/1298),
-   [#1300](https://github.com/codevise/pageflow/pull/1300),
-   [#1308](https://github.com/codevise/pageflow/pull/1308))
-- Sharing, imprint, privacy in navigation
-  ([#1319](https://github.com/codevise/pageflow/pull/1319))
+- Chapter deep linking
+  ([#1637](https://github.com/codevise/pageflow/pull/1637))
+- Lazy load DASH code for Scrolled
+  ([#1635](https://github.com/codevise/pageflow/pull/1635))
+- Deduplicate core-js in yarn.lock
+  ([#1634](https://github.com/codevise/pageflow/pull/1634))
+- Do not move backdrop when navigation is scrolled out of view
+  ([#1632](https://github.com/codevise/pageflow/pull/1632))
+- Navigation bar improvements
+  ([#1631](https://github.com/codevise/pageflow/pull/1631))
+- Do not fall back to file default motif area
+  ([#1628](https://github.com/codevise/pageflow/pull/1628))
+- Improve poster rendering
+  ([#1621](https://github.com/codevise/pageflow/pull/1621))
+- Optimize frontend rendering
+  ([#1620](https://github.com/codevise/pageflow/pull/1620))
+- Do not show scroll position based backdrop shadow initially
+  ([#1619](https://github.com/codevise/pageflow/pull/1619))
+- Prevent state update on unmounted component
+  ([#1618](https://github.com/codevise/pageflow/pull/1618))
+- Do not keep navigation open when focus is within
+  ([#1617](https://github.com/codevise/pageflow/pull/1617))
+- Improve unmute sequence
+  ([#1615](https://github.com/codevise/pageflow/pull/1615))
+- Show logo focus outline
+  ([#1613](https://github.com/codevise/pageflow/pull/1613))
+- Open logo link in new tab
+  ([#1612](https://github.com/codevise/pageflow/pull/1612))
+- Improve handling of untitled chapters
+  ([#1610](https://github.com/codevise/pageflow/pull/1610))
+- Logo link through theme option
+  ([#1603](https://github.com/codevise/pageflow/pull/1603))
+- Improve player controls
+  ([#1602](https://github.com/codevise/pageflow/pull/1602),
+   [#1586](https://github.com/codevise/pageflow/pull/1586))
+- change Email to Mail
+  ([#1601](https://github.com/codevise/pageflow/pull/1601))
+- Prevent parallel playback of media elements
+  ([#1599](https://github.com/codevise/pageflow/pull/1599))
+- Improve navigation tooltips
+  ([#1597](https://github.com/codevise/pageflow/pull/1597))
+- Give backdrops default background color
+  ([#1594](https://github.com/codevise/pageflow/pull/1594))
+- Replace hard coded title and meta tags
+  ([#1593](https://github.com/codevise/pageflow/pull/1593))
+- Prevent resuming atmo of other section
+  ([#1591](https://github.com/codevise/pageflow/pull/1591))
+- Add toggle mute button to navigation
+  ([#1589](https://github.com/codevise/pageflow/pull/1589))
+- Implements skip link for navigation
+  ([#1585](https://github.com/codevise/pageflow/pull/1585))
+- Position backdrop image/video according to motif area
+  ([#1582](https://github.com/codevise/pageflow/pull/1582))
+- Add motif area support for background videos
+  ([#1580](https://github.com/codevise/pageflow/pull/1580))
+- Require user to opt in to see external embeds
+  ([#1577](https://github.com/codevise/pageflow/pull/1577))
+- Renders alt text for media
+  ([#1574](https://github.com/codevise/pageflow/pull/1574))
+- Use theme specific favicons
+  ([#1569](https://github.com/codevise/pageflow/pull/1569))
+- Bug fix: Don't remove media tag when unallocating player in IE 11
+  ([#1648](https://github.com/codevise/pageflow/pull/1648))
+- Allow disabling video or dash via browser feature flag
+  ([#1647](https://github.com/codevise/pageflow/pull/1647))
+- Bug fix: Ensure muted inline media pauses on deactivation
+  ([#1646](https://github.com/codevise/pageflow/pull/1646))
+- Bug fix: Fix for unstable navigation bar on Safari
+  ([#1642](https://github.com/codevise/pageflow/pull/1642))
+- Bug fix: Invisible share links should not be clickable
+  ([#1641](https://github.com/codevise/pageflow/pull/1641))
+- Bug fix: Play unmute sound on iOS
+  ([#1640](https://github.com/codevise/pageflow/pull/1640))
+- Bug fix: Fix scroll flickering on Android Chrome
+  ([#1639](https://github.com/codevise/pageflow/pull/1639))
+- Bug fix: Do not request new player when object position changes
+  ([#1638](https://github.com/codevise/pageflow/pull/1638))
+- Bug fix: Fix "SourceBuffer removed from parent media source" error
+  ([#1636](https://github.com/codevise/pageflow/pull/1636))
+- Bug fix: Prevent overlapping floated elements in centered layout
+  ([#1590](https://github.com/codevise/pageflow/pull/1590))
+- Bug fix: Fix progress indicator in scrolled navigation bar
+  ([#1571](https://github.com/codevise/pageflow/pull/1571))
+
+##### Content Elements
+
+- Fix external links layout narrow screen sizes
+  ([#1598](https://github.com/codevise/pageflow/pull/1598))
+- Improve Datawrapper chart display
+  ([#1611](https://github.com/codevise/pageflow/pull/1611))
+- Never hide audio controls
+  ([#1616](https://github.com/codevise/pageflow/pull/1616))
+- Fixed before after height issue
+  ([#1606](https://github.com/codevise/pageflow/pull/1606))
+- Heading word-wrap and hyphen css
+  ([#1605](https://github.com/codevise/pageflow/pull/1605))
+- Fade out audio element when deactivating
+  ([#1592](https://github.com/codevise/pageflow/pull/1592))
+- Add caption and position options to chart element
+  ([#1587](https://github.com/codevise/pageflow/pull/1587))
+- Bug fix: BeforeAfter safari animation fix
+  ([#1623](https://github.com/codevise/pageflow/pull/1623))
 
 ##### Editor
 
-- Render demo in editor
-  ([#1268](https://github.com/codevise/pageflow/pull/1268))
-- Use data from Backbone collections in scrolled editor preview
-  ([#1288](https://github.com/codevise/pageflow/pull/1288),
-   [#1293](https://github.com/codevise/pageflow/pull/1293),
-   [#1292](https://github.com/codevise/pageflow/pull/1292),
-   [#1294](https://github.com/codevise/pageflow/pull/1294),
-   [#1305](https://github.com/codevise/pageflow/pull/1305))
-- Outline editing for scrolled entries
-  ([#1318](https://github.com/codevise/pageflow/pull/1318))
-
-##### Internal
-
-- Pass scrolled entry to watchCollections in tests
-  ([#1317](https://github.com/codevise/pageflow/pull/1317))
-- Setup Capybara for scrolled engine
-  ([#1289](https://github.com/codevise/pageflow/pull/1289))
-- Set PAGEFLOW_EDITOR global in scrolled editor
-  ([#1287](https://github.com/codevise/pageflow/pull/1287))
-
-#### Development Setup
-
-- DB seed data for scrolled entries
-  ([#1274](https://github.com/codevise/pageflow/pull/1274),
-   [#1302](https://github.com/codevise/pageflow/pull/1302))
-- Split Travis run into multiple jobs
-  ([#1261](https://github.com/codevise/pageflow/pull/1261))
-- Generate JSDoc and SassDoc in GitHub workflow
-  ([#1307](https://github.com/codevise/pageflow/pull/1307))
-- Add needed command to node package development docs
-  ([#1290](https://github.com/codevise/pageflow/pull/1290))
-- Improve Capybara Chrome setup
-  ([#1291](https://github.com/codevise/pageflow/pull/1291))
+- Ordering content elements
+  ([#1596](https://github.com/codevise/pageflow/pull/1596))
+- Preserve scroll position when toggling phone preview
+  ([#1614](https://github.com/codevise/pageflow/pull/1614))
+- Show section settings directly when section is selected
+  ([#1626](https://github.com/codevise/pageflow/pull/1626))
+- Make motif area selection snap to grid
+  ([#1578](https://github.com/codevise/pageflow/pull/1578))
+- Extend german help texts
+  ([#1625](https://github.com/codevise/pageflow/pull/1625))
+- Add options for gradient opacity/motif area exposure
+  ([#1624](https://github.com/codevise/pageflow/pull/1624))
+- Add missing translation
+  ([#1600](https://github.com/codevise/pageflow/pull/1600))
+- Bug fix: Apply default configuration when adding to end of section
+  ([#1630](https://github.com/codevise/pageflow/pull/1630))
+- Bug fix: Fix error when merging empty text blocks
+  ([#1588](https://github.com/codevise/pageflow/pull/1588))
+
+###### JavaScript API
+
+- Split isPrepared state into shouldLoad and shouldPrepare
+  ([#1622](https://github.com/codevise/pageflow/pull/1622))
+
+###### Internal
+
+- Fix Jest warnings caused by Backbone XHR
+  ([#1579](https://github.com/codevise/pageflow/pull/1579))
+- Remove renderer memoization in development
+  ([#1584](https://github.com/codevise/pageflow/pull/1584))
+- Import scrolled translations into LocaleApp
+  ([#1627](https://github.com/codevise/pageflow/pull/1627))
+- Navigation bar Storybook story
+  ([#1557](https://github.com/codevise/pageflow/pull/1557))
+- Fix storybook documentation
+  ([#1540](https://github.com/codevise/pageflow/pull/1540))
 
 See
-[15-0-stable branch](https://github.com/codevise/pageflow/blob/15-0-stable/CHANGELOG.md)
+[15-3-stable branch](https://github.com/codevise/pageflow/blob/15-3-stable/CHANGELOG.md)
 for previous changes.

data/README.md

@@ -1,7 +1,7 @@
 # Pageflow
 
 [![Gem Version](https://badge.fury.io/rb/pageflow.svg)](http://badge.fury.io/rb/pageflow)
-[![Build Status](https://travis-ci.org/codevise/pageflow.svg?branch=master)](https://travis-ci.org/codevise/pageflow)
+[![Build Status](https://github.com/codevise/pageflow/workflows/tests/badge.svg)](https://github.com/codevise/pageflow/actions)
 [![Coverage Status](https://coveralls.io/repos/github/codevise/pageflow/badge.svg?branch=master)](https://coveralls.io/github/codevise/pageflow?branch=master)
 [![Code Climate](https://codeclimate.com/github/codevise/pageflow/badges/gpa.svg)](https://codeclimate.com/github/codevise/pageflow)
 [![Reviewed by Hound](https://img.shields.io/badge/Reviewed_by-Hound-8E64B0.svg)](https://houndci.com)
@@ -53,7 +53,7 @@ Pageflow assumes the following choice of libraries:
 Pageflow runs in environments with:
 
 * Ruby >= 2.1 (see `.travis.yml` for supported versions)
-* Node >= 10.0
+* Node >= 10.18
 * Rails 4.2
 * Redis server (for Resque)
 * A database server supported by Active Record (tested with MySQL)
@@ -168,8 +168,7 @@ is only available for admins.
 
 ## Troubleshooting
 
-If you run into problems during the installation of Pageflow, please refer to the [Troubleshooting](https://github.com/codevise/pageflow/wiki/Troubleshooting) wiki
-page. If that doesn't help, consider [filing an issue](https://github.com/codevise/pageflow/issues?state=open).
+If you run into problems during the installation of Pageflow, please refer to the [Troubleshooting](doc/troubleshooting.md) docs. If that doesn't help, consider [filing an issue](https://github.com/codevise/pageflow/issues?state=open).
 
 ## Security Policy
 
@@ -213,4 +212,3 @@ We would like to express our special thanks to the following services
 for supporting Pageflow through free open source plans:
 
 [![BrowserStack](doc/supporter_logos/browser_stack.png)](https://browserstack.com)
-[![Travis CI](doc/supporter_logos/travis_ci.png)](https://travis-ci.com/)

data/admins/pageflow/accounts.rb

@@ -30,9 +30,6 @@ module Pageflow
           membership_role_with_tooltip(own_role, scope: 'own_account_role')
         end
       end
-      column :default_theming do |account|
-        account.default_theming.theme_name if authorized?(:read, account)
-      end
     end
 
     csv do
@@ -75,49 +72,31 @@ module Pageflow
       helper Pageflow::Admin::FormHelper
       helper Pageflow::Admin::LocalesHelper
       helper Pageflow::Admin::MembershipsHelper
-      helper Pageflow::Admin::WidgetsHelper
       helper ThemesHelper
 
       def new
         @account = Account.new
-        @account.build_default_theming(
-          default_locale: current_user.locale,
-          share_providers: Pageflow.config.default_share_providers
-        )
+        @account.build_default_theming
       end
 
       def create
-        @account = Account.new(permitted_params[:account])
-        @account.build_default_theming(permitted_params.fetch(:account, {})[:default_theming_attributes])
+        account_params = permitted_params[:account] || {}
+        @account = Account.new(account_params)
+        @account.build_default_theming(permitted_params.fetch(:account, {})[
+                                         :default_theming_attributes])
         super
-        update_widgets
       end
 
       def update
         update! do |success, failure|
           success.html { redirect_to(admin_account_path(resource, params.permit(:tab))) }
         end
-        update_widgets
-      end
-
-      def update_widgets
-        @account.default_theming.widgets.batch_update!(widgets_params) if @account.valid?
-      end
-
-      def widgets_params
-        (params[:widgets].try(:permit!).to_h || {}).map do |role, type_name|
-          {role: role, type_name: type_name}
-        end
       end
 
       def permitted_params
         result = params.permit(account: permitted_account_attributes)
 
-        if result[:account]
-          permit_feature_states(result[:account])
-        end
-
-        result
+        with_permitted_feature_states(result)
       end
 
       def scoped_collection
@@ -126,6 +105,12 @@ module Pageflow
 
       private
 
+      def with_permitted_feature_states(result)
+        result[:account] && permit_feature_states(result[:account])
+
+        result
+      end
+
       def permitted_account_attributes
         [
           :name,
@@ -139,19 +124,12 @@ module Pageflow
         [
           :cname,
           :additional_cnames,
-          :theme_name,
           :imprint_link_url,
           :imprint_link_label,
           :copyright_link_url,
           :copyright_link_label,
           :privacy_link_url,
-          :home_url,
-          :home_button_enabled_by_default,
-          :default_author,
-          :default_publisher,
-          :default_keywords,
-          :default_locale,
-          share_providers: []
+          :home_url
         ] +
           permitted_attributes_for(:theming)
       end