pageflow-oembed 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2371778074195896b81827f2a795f3499c18b6d8
-  data.tar.gz: 4b9135c2b5bb7d7e59497ec26459fc6ebbe29076
+  metadata.gz: 768e67651b4278343646a683061082b75803f7af
+  data.tar.gz: 0c9df1cbfe40cb14740b3eb57170d7cb45304dd3
 SHA512:
-  metadata.gz: ce5e2fedf29871d021fc32c0b3c4d79ddb047b8b8dc9420d94b2c70365b33f44e4b48b658d79d13761aaa6c263dba276044dc0cb115ed760b603f863e2b64bad
-  data.tar.gz: 82eca1dd591e3db49682543d02eeeef157f23870525a8c8bb0676e195c3a3fcb102a2559cdd15411c22b026c7dc590fae48a23e10afbb61027acb5924fbfdc6c
+  metadata.gz: bbc5417af0cf5e20ffed703cd89c48173625366adbe87b1fa9c0c116011151654c62301def80b64947247b303edf3965bdf30e08e10bf221517e7e003a6e5115
+  data.tar.gz: 86ba5adcc366f271755bfd02bbf8cce48463f6787cdefb38444bded60cf8a0874baa5546ea4dcae273a3a4f43f21389d1b2043b1a38aef5b148ead6245ed1e34

data/CHANGELOG

@@ -0,0 +1,8 @@
+Version 1.0.1—16 July 2017
+
+Bugfix: tweet ID is now correctly parsed from the link.
+
+Version 1.0.0—16 July 2017
+
+Twitter support. Doesn't actually use oEmbed, because the Twitter SDK
+handles everything for us.

data/README.md

@@ -91,6 +91,16 @@ Add it to the asset pipeline:
 //= require pageflow/oembed
 ```
 
+Finally, mount it in `routes.rb`:
+
+```ruby
+Rails.application.routes.draw do
+  ...
+  mount Pageflow::Oembed::Engine, at: '/oembed'
+  ...
+end
+```
+
 ## Usage
 
 In the Pageflow editor, insert a plain old link into the content text. Voila!

data/app/assets/javascript/pageflow/oembed.js

@@ -39,7 +39,8 @@ pageflow.widgetTypes.register('pageflow_oembed', {
 
   embedTwitter: function(link) {
     var url = link.getAttribute('href');
-    var tweetId = url.slice(-18);
+    var match = /(\d+)$/.exec(url);
+    tweetId = match[0];
     var theme = this.page(link).classList.contains('invert') ? 'light' : 'dark';
 
     link.insertAdjacentHTML('beforebegin', '<span id="tweet-'+tweetId+'"></span>')

data/lib/pageflow/oembed/version.rb

@@ -1,5 +1,5 @@
 module Pageflow
   module Oembed
-    VERSION = "1.0.0"
+    VERSION = "1.0.1"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pageflow-oembed
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Joost Baaij
@@ -121,6 +121,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- CHANGELOG
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt