pageflow-external-links 2.3.0 → 2.4.1

Sign up to get free protection for your applications and to get access to all the features.
Files changed (14) hide show
  1. checksums.yaml +4 -4
  2. data/.github/workflows/tests.yml +6 -0
  3. data/CHANGELOG.md +18 -8
  4. data/README.md +1 -1
  5. data/app/assets/javascripts/pageflow/external_links/editor/templates/site_selection.jst.ejs +2 -2
  6. data/app/assets/javascripts/pageflow/external_links/editor/views/site_selection_view.js +2 -2
  7. data/app/assets/stylesheets/pageflow/external_links/editor/external_sites.scss +7 -6
  8. data/app/assets/stylesheets/pageflow/external_links/editor/site_selection.scss +1 -25
  9. data/app/assets/stylesheets/pageflow/external_links/editor.scss +10 -8
  10. data/lib/pageflow/external_links/page_type.rb +2 -2
  11. data/lib/pageflow/external_links/version.rb +1 -1
  12. data/pageflow-external-links.gemspec +2 -2
  13. metadata +24 -12
  14. data/.travis.yml +0 -20
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 0c12b927a2072019bb2e7a9d9c9ea717ee56af93fa7703ede0d3233be892d1cf
4
- data.tar.gz: b123367dc4d2075c96732cf654115f161da86e848b0415f28da9ac1988efa75e
3
+ metadata.gz: 959b4de4fd00552fbf952ae08112b22c5e24e685e5f26ed39283fabb439e436a
4
+ data.tar.gz: a088a0d48df598655f32118a2dee6dc58e05523eea4833b7711f371426719dc3
5
5
  SHA512:
6
- metadata.gz: 6cc118d9fdbfcadd3c0ab1b2f20d0a6b8a316d1e7bdfb23688d60f433f5c3687e57b538a88c9c91516cd8877939c3fe9ef4b7f113de10a5cd3753f09c488066f
7
- data.tar.gz: 9ecd9cbb770216ce76286b88529a69f0ce17359821cd50794abf6629580ab871db6497ba7bda8626b9934f5ab6963a9b0209404de81c4343e3df9decd41af715
6
+ metadata.gz: 25cb06b59a6a5f3f1e27159f11ede11bb4d75cd4dd2b7bcdec06f5ecb6f6f2b4c3faddc6aee6833b26cb4613a9a3dd84a2c7cfd61dc45d4fdcbd2ef305070fd0
7
+ data.tar.gz: 2c24e4e0d17401cf2169b945e407ce918de78d4b389e2b2639c478316744e09155267f123680f9aa172b747195fd12dcb0bcdb3a0f152f7f979defb5c3380e32
data/.github/workflows/tests.yml ADDED
@@ -0,0 +1,6 @@
1
+ name: tests
2
+ on: [push, pull_request]
3
+
4
+ jobs:
5
+ call-workflow:
6
+ uses: codevise/pageflow/.github/workflows/reusable-workflow-rspec.yml@master
data/CHANGELOG.md CHANGED
@@ -1,16 +1,26 @@
1
1
  # CHANGELOG
2
2
 
3
- ### Version 2.3.0
3
+ ### Version 2.4.1
4
4
 
5
- 2022-03-29
5
+ 2023-01-10
6
6
 
7
- [Compare changes](https://github.com/codevise/pageflow-external-links/compare/2-2-stable...v2.3.0)
7
+ [Compare changes](https://github.com/codevise/pageflow-external-links/compare/v2.4.0...v2.4.1)
8
8
 
9
- - Add border-radius theme option
10
- ([#46](https://github.com/codevise/pageflow-external-links/pull/46))
11
- - Prevent error with missing site urls in Pageflow 15.1
12
- ([#44](https://github.com/codevise/pageflow-external-links/pull/44))
9
+ - Prefix ExternalLink::Site to prevent referencing Pageflow::Site
10
+ ([#49](https://github.com/codevise/pageflow-external-links/pull/49),
11
+ [#50](https://github.com/codevise/pageflow-external-links/pull/50))
12
+
13
+ ### Version 2.4.0
14
+
15
+ 2022-12-28
16
+
17
+ [Compare changes](https://github.com/codevise/pageflow-external-links/compare/2-3-stable...v2.4.0)
18
+
19
+ - Add support for Pageflow 16
20
+ ([#48](https://github.com/codevise/pageflow-external-links/pull/48))
21
+ - Rebrush editor styles
22
+ ([#47](https://github.com/codevise/pageflow-external-links/pull/47))
13
23
 
14
24
  See
15
- [2-2-stable branch](https://github.com/codevise/pageflow-external-links/blob/2-2-stable/CHANGELOG.md)
25
+ [2-3-stable branch](https://github.com/codevise/pageflow-external-links/blob/2-3-stable/CHANGELOG.md)
16
26
  for previous changes.
data/README.md CHANGED
@@ -1,7 +1,7 @@
1
1
  # Pageflow External Links
2
2
 
3
3
  [![Gem Version](https://badge.fury.io/rb/pageflow-external-links.svg)](http://badge.fury.io/rb/pageflow-external-links)
4
- [![Build Status](https://travis-ci.org/codevise/pageflow-external-links.svg?branch=master)](https://travis-ci.org/codevise/pageflow-external-links)
4
+ [![Build Status](https://github.com/codevise/pageflow-external-links/workflows/tests/badge.svg)](https://github.com/codevise/pageflow-external-links/actions)
5
5
 
6
6
  Page type to display links to external pages.
7
7
 
data/app/assets/javascripts/pageflow/external_links/editor/templates/site_selection.jst.ejs CHANGED
@@ -1,7 +1,7 @@
1
1
  <div class="box">
2
- <h2><%= I18n.t('pageflow.external_links.editor.templates.site_selection.title') %></h2>
2
+ <h1 class="dialog-header"><%= I18n.t('pageflow.external_links.editor.templates.site_selection.title') %></h1>
3
3
 
4
- <div class="wrapper editor">
4
+ <div class="content">
5
5
  <ul class="external_sites">
6
6
  </ul>
7
7
  </div>
data/app/assets/javascripts/pageflow/external_links/editor/views/site_selection_view.js CHANGED
@@ -1,5 +1,5 @@
1
1
  pageflow.externalLinks.SiteSelectionView = Backbone.Marionette.ItemView.extend({
2
- className: 'external_site_selection dialog',
2
+ className: 'external_site_selection dialog editor',
3
3
  template: 'pageflow/external_links/editor/templates/site_selection',
4
4
 
5
5
  mixins: [pageflow.dialogView],
@@ -42,4 +42,4 @@ pageflow.externalLinks.SiteSelectionView.selectSite = function() {
42
42
 
43
43
  pageflow.app.dialogRegion.show(view.render());
44
44
  }).promise();
45
- };
45
+ };
data/app/assets/stylesheets/pageflow/external_links/editor/external_sites.scss CHANGED
@@ -3,7 +3,9 @@ ul.external_sites {
3
3
 
4
4
  > li {
5
5
  position: relative;
6
- background-color: #eee;
6
+ background-color: var(--ui-primary-color-lightest);
7
+ border-radius: rounded();
8
+ overflow: hidden;
7
9
  margin-bottom: 2px;
8
10
  padding: 37px 10px 0 70px;
9
11
  white-space: nowrap;
@@ -11,9 +13,8 @@ ul.external_sites {
11
13
  height: 23px;
12
14
 
13
15
  &.navigatable {
14
- background-color: #fff;
15
16
  @include right-open-icon;
16
- @include background-icon-right($color: #888, $top: 20px);
17
+ @include background-icon-right($color: var(--ui-primary-color-light), $top: 20px);
17
18
  }
18
19
  }
19
20
 
@@ -25,11 +26,11 @@ ul.external_sites {
25
26
  width: 60px;
26
27
  vertical-align: middle;
27
28
  background-size: cover;
28
- background-color: #444;
29
+ background-color: var(--ui-on-surface-color-light);
29
30
  }
30
31
 
31
32
  a.select {
32
- @include button(#590);
33
+ @include simple-button("primary");
33
34
 
34
35
  padding-left: 5px;
35
36
  padding-right: 5px;
@@ -44,4 +45,4 @@ ul.external_sites {
44
45
  left: 70px;
45
46
  right: auto;
46
47
  }
47
- }
48
+ }
data/app/assets/stylesheets/pageflow/external_links/editor/site_selection.scss CHANGED
@@ -1,34 +1,10 @@
1
1
  .external_site_selection {
2
2
  .box {
3
- top: 5%;
4
- width: 90%;
5
3
  max-width: 400px;
6
4
  max-height: 745px;
7
- padding-bottom: 20px;
8
- height: 80%;
9
- }
10
-
11
- .wrapper {
12
- background-color: #fff;
13
- padding-right: 10px;
14
-
15
- overflow: hidden;
16
- overflow-y: scroll;
17
-
18
- position: absolute;
19
- top: 70px;
20
- bottom: 70px;
21
- left: 10px;
22
- right: 10px;
23
5
  }
24
6
 
25
7
  ul.external_sites {
26
8
  margin-top: 0;
27
9
  }
28
-
29
- .footer {
30
- position: absolute;
31
- bottom: 20px;
32
- right: 10px;
33
- }
34
- }
10
+ }
data/app/assets/stylesheets/pageflow/external_links/editor.scss CHANGED
@@ -7,7 +7,7 @@
7
7
  .manage_external_sites {
8
8
  a.add {
9
9
  @include plus-circled-icon;
10
- @include icon-button;
10
+ @include icon-button("primary");
11
11
  position: absolute;
12
12
  top: 0;
13
13
  right: 0;
@@ -25,39 +25,41 @@
25
25
  }
26
26
 
27
27
  a.remove {
28
- @include icon-only-button(#aaa);
28
+ @include icon-only-button("destructive");
29
29
  @include trash-icon;
30
30
  position: absolute;
31
31
  right: 4px;
32
- top: 4px;
32
+ top: 3px;
33
33
  }
34
34
 
35
35
  a.edit {
36
- @include icon-only-button(#aaa);
36
+ @include icon-only-button;
37
37
  @include pencil-icon;
38
38
  position: absolute;
39
39
  right: 40px;
40
- top: 4px;
40
+ top: 3px;
41
41
  }
42
42
 
43
43
  .external_links_site_reference {
44
44
  margin-bottom: 2px;
45
45
 
46
46
  > a:first-child {
47
+ position: relative;
47
48
  padding-left: 45px;
48
49
  cursor: default;
50
+ text-decoration: none;
49
51
  }
50
52
 
51
53
  .thumbnail {
52
54
  position: absolute;
53
55
  top: 0;
54
56
  left: 0;
55
- height: 35px;
57
+ height: 100%;
56
58
  width: 35px;
57
59
  cursor: move;
58
60
  background-size: cover;
59
- background-color: #444;
61
+ background-color: var(--ui-on-surface-color-light);
60
62
  }
61
63
  }
62
64
  }
63
- }
65
+ }
data/lib/pageflow/external_links/page_type.rb CHANGED
@@ -4,11 +4,11 @@ module Pageflow
4
4
  name 'external_links'
5
5
 
6
6
  def revision_components
7
- [Site]
7
+ [ExternalLinks::Site]
8
8
  end
9
9
 
10
10
  def view_helpers
11
- [SitesHelper]
11
+ [ExternalLinks::SitesHelper]
12
12
  end
13
13
  end
14
14
  end
data/lib/pageflow/external_links/version.rb CHANGED
@@ -1,5 +1,5 @@
1
1
  module Pageflow
2
2
  module ExternalLinks
3
- VERSION = '2.3.0'.freeze
3
+ VERSION = '2.4.1'.freeze
4
4
  end
5
5
  end
data/pageflow-external-links.gemspec CHANGED
@@ -18,11 +18,11 @@ Gem::Specification.new do |spec|
18
18
 
19
19
  spec.required_ruby_version = '~> 2.1'
20
20
 
21
- spec.add_runtime_dependency 'pageflow', '~> 15.x'
21
+ spec.add_runtime_dependency 'pageflow', ['>= 15.7', '< 17']
22
22
  spec.add_runtime_dependency 'pageflow-public-i18n', '~> 1.0'
23
23
 
24
24
  spec.add_development_dependency 'bundler', ['>= 1.0', '< 3']
25
- spec.add_development_dependency 'pageflow-support', '~> 15.x'
25
+ spec.add_development_dependency 'pageflow-support', ['>= 15.0', '< 17']
26
26
  spec.add_development_dependency 'rake', '~> 12.0'
27
27
  spec.add_development_dependency 'rspec-rails', '~> 3.0'
28
28
 
metadata CHANGED
@@ -1,29 +1,35 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: pageflow-external-links
3
3
  version: !ruby/object:Gem::Version
4
- version: 2.3.0
4
+ version: 2.4.1
5
5
  platform: ruby
6
6
  authors:
7
7
  - Codevise Solutions Ltd
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2022-03-29 00:00:00.000000000 Z
11
+ date: 2023-01-10 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: pageflow
15
15
  requirement: !ruby/object:Gem::Requirement
16
16
  requirements:
17
- - - "~>"
17
+ - - ">="
18
+ - !ruby/object:Gem::Version
19
+ version: '15.7'
20
+ - - "<"
18
21
  - !ruby/object:Gem::Version
19
- version: 15.x
22
+ version: '17'
20
23
  type: :runtime
21
24
  prerelease: false
22
25
  version_requirements: !ruby/object:Gem::Requirement
23
26
  requirements:
24
- - - "~>"
27
+ - - ">="
28
+ - !ruby/object:Gem::Version
29
+ version: '15.7'
30
+ - - "<"
25
31
  - !ruby/object:Gem::Version
26
- version: 15.x
32
+ version: '17'
27
33
  - !ruby/object:Gem::Dependency
28
34
  name: pageflow-public-i18n
29
35
  requirement: !ruby/object:Gem::Requirement
@@ -62,16 +68,22 @@ dependencies:
62
68
  name: pageflow-support
63
69
  requirement: !ruby/object:Gem::Requirement
64
70
  requirements:
65
- - - "~>"
71
+ - - ">="
72
+ - !ruby/object:Gem::Version
73
+ version: '15.0'
74
+ - - "<"
66
75
  - !ruby/object:Gem::Version
67
- version: 15.x
76
+ version: '17'
68
77
  type: :development
69
78
  prerelease: false
70
79
  version_requirements: !ruby/object:Gem::Requirement
71
80
  requirements:
72
- - - "~>"
81
+ - - ">="
82
+ - !ruby/object:Gem::Version
83
+ version: '15.0'
84
+ - - "<"
73
85
  - !ruby/object:Gem::Version
74
- version: 15.x
86
+ version: '17'
75
87
  - !ruby/object:Gem::Dependency
76
88
  name: rake
77
89
  requirement: !ruby/object:Gem::Requirement
@@ -121,11 +133,11 @@ executables: []
121
133
  extensions: []
122
134
  extra_rdoc_files: []
123
135
  files:
136
+ - ".github/workflows/tests.yml"
124
137
  - ".gitignore"
125
138
  - ".jshintignore"
126
139
  - ".jshintrc"
127
140
  - ".sassdocrc"
128
- - ".travis.yml"
129
141
  - CHANGELOG.md
130
142
  - Gemfile
131
143
  - Gemfile.ci
@@ -214,7 +226,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
214
226
  - !ruby/object:Gem::Version
215
227
  version: '0'
216
228
  requirements: []
217
- rubygems_version: 3.0.8
229
+ rubygems_version: 3.0.3.1
218
230
  signing_key:
219
231
  specification_version: 4
220
232
  summary: Pageflow Page Type for links to external sites
data/.travis.yml DELETED
@@ -1,20 +0,0 @@
1
- language: ruby
2
- gemfile: Gemfile.ci
3
-
4
- # User container based travis infrastructure which allows caching
5
- # features for open source projects.
6
- sudo: false
7
- cache: bundler
8
-
9
- env:
10
- - PUBLISH_THEME_DOC=true
11
-
12
- before_install:
13
- - nvm install stable
14
-
15
- script:
16
- - bin/rspec
17
- - bundle exec publish-pageflow-theme-doc
18
-
19
- services:
20
- - mysql