page_title_helper 10.0.0 → 11.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4a2d2a86550563f06693c579a4d0fa876aa7a914292d6d335075a234d436f69d
-  data.tar.gz: d4ef09751337d5a57635a9577654944494d2d5f3987d4abc6418ae162ec8545c
+  metadata.gz: 814c87d118a884882a8b973f8400381a1f49ffea958b4d54dce1e2b3833b714d
+  data.tar.gz: 7cdd22ada5241cd9479bcbffa3eb22bbe5d7a393be28eaec792c0acc433d3c1e
 SHA512:
-  metadata.gz: 2d438f0e98ea5115f2ef0c661a95e4e2d8346428bff0d46f7db1470405f55895b2c108ffba587476a87aafa9800e92d3c35565b4ae22d0dcb7c5df8786027e63
-  data.tar.gz: eabfd4cda52224608d36d2ba9ea68b545303f34a3dffc6a3b869d92f0e1487705f0be56437b1f0ded2f6b1f3a807d59abfffe054d3d5f7414cad2a2a7945d5f2
+  metadata.gz: 7139b11ec04058df050796a9f5c67655e526f2a060b75ca810387eea73d94fcd91b777b702ab6cf3c26390958bd89162ba95003d20658f88444c385cdc953e68
+  data.tar.gz: 8af793d5d6ebb7a1b0dc49058af8c42c24238abed90804bd97172f21589b03e96868ceeeaa92e7298345cc18f3ac7b28185fec4c0eef8910392c4b7025f85a0f

data/CHANGELOG.md

@@ -20,6 +20,17 @@ about why a change log is important.
 
 ### Security
 
+## 11.0.0: Add support for Ruby 4.0, drop support for Rails 7.2 and Ruby 3.2
+
+### Added
+
+- Add support for Ruby 4.0 (#240)
+
+### Removed
+
+- Drop support for Rails 7.2 (#264)
+- Drop support for Ruby 3.2 (#246)
+
 ## 10.0.0: Add support for Rails 8.1, drop support for Ruby 3.1 and Rails < 7.2
 
 ### Added

data/Gemfile

@@ -3,3 +3,9 @@
 source 'https://rubygems.org'
 
 gemspec
+
+gem 'rake', '~> 13.4.2'
+gem 'rubocop', '~> 1.92.0'
+gem 'rubocop-rails', '~> 2.38.0'
+gem 'rubocop-rake', '~> 0.7.1'
+gem 'shoulda', '~> 4.0.0'

data/README.md

@@ -1,6 +1,6 @@
 # Page title helper
 
-[![GitHub CI Status](https://github.com/lwe/page_title_helper/workflows/CI/badge.svg?branch=main)](https://github.com/lwe/page_title_helper/actions)
+[![Build Status](https://github.com/lwe/page_title_helper/actions/workflows/ci.yml/badge.svg?branch=main)](https://github.com/lwe/page_title_helper/actions/)
 [![Gem Version](https://badge.fury.io/rb/page_title_helper.svg)](https://badge.fury.io/rb/page_title_helper)
 
 This project adheres to [Semantic Versioning](https://semver.org/).

data/Rakefile

@@ -16,3 +16,8 @@ Rake::TestTask.new(:test) do |t|
   t.pattern = 'test/**/*_test.rb'
   t.verbose = true
 end
+
+desc 'Runs RuboCop for checking the Ruby files.'
+task :rubocop do
+  sh 'rubocop gemfiles/ lib/ test/ page_title_helper.gemspec Gemfile Rakefile'
+end

data/page_title_helper.gemspec

@@ -1,31 +1,36 @@
-$LOAD_PATH.push File.expand_path('lib', __dir__)
-require 'page_title_helper/version'
+# frozen_string_literal: true
 
-Gem::Specification.new do |s|
-  s.name        = 'page_title_helper'
-  s.version     = PageTitleHelper::VERSION
-  s.platform    = Gem::Platform::RUBY
-  s.summary     = 'Simple, internationalized and DRY page titles and headings for Rails.'
-  s.description = 'Simple, internationalized and DRY page titles and headings for Rails.'
+Gem::Specification.new do |spec|
+  spec.name = 'page_title_helper'
+  spec.summary = 'Simple, internationalized and DRY page titles and headings for Railspec.'
+  spec.version = '11.0.0'
+  spec.license = 'MIT'
 
-  s.required_ruby_version = '>= 3.2.0'
+  spec.required_ruby_version = '>= 3.3.0'
 
-  s.authors  = ['Lukas Westermann']
-  s.email    = ['lukas.westermann@gmail.com']
-  s.homepage = 'https://github.com/lwe/page_title_helper'
+  spec.homepage = 'https://github.com/lwe/page_title_helper'
+  spec.authors = ['Lukas Westermann']
+  spec.email = ['lukaspec.westermann@gmail.com']
 
-  s.files            = %w[Gemfile LICENSE README.md CODE_OF_CONDUCT.md CHANGELOG.md Rakefile
-                          page_title_helper.gemspec] + Dir['**/*.{rb,yml}']
-  s.test_files       = s.files.grep(%r{^(test|spec)/})
-  s.require_path     = 'lib'
+  spec.metadata = {
+    'bug_tracker_uri' => 'https://github.com/lwe/page_title_helper/issues',
+    'changelog_uri' => 'https://github.com/lwe/page_title_helper/blob/master/CHANGELOG.md',
+    'documentation_uri' => 'https://www.rubydoc.info/gems/page_title_helper',
+    'homepage_uri' => spec.homepage,
+    'source_code_uri' => 'https://github.com/lwe/page_title_helper'
+  }
 
-  s.license          = 'MIT'
+  spec.files = %w[
+    CHANGELOG.md
+    Gemfile
+    LICENSE
+    README.md
+    Rakefile
+    lib/page_title_helper.rb
+    page_title_helper.gemspec
+  ]
+  spec.extra_rdoc_files = %w[CHANGELOG.md LICENSE README.md]
+  spec.require_paths = ['lib']
 
-  s.add_dependency 'rails', '>= 7.2.0', '< 8.2'
-
-  s.add_development_dependency 'rake', '~> 13.3.0'
-  s.add_development_dependency 'rubocop', '~> 1.81.1'
-  s.add_development_dependency 'rubocop-rails', '~> 2.33.3'
-  s.add_development_dependency 'rubocop-rake', '~> 0.7.1'
-  s.add_development_dependency 'shoulda', '~> 4.0.0'
+  spec.add_dependency 'rails', '>= 8.0.0', '< 8.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: page_title_helper
 version: !ruby/object:Gem::Version
-  version: 10.0.0
+  version: 11.0.0
 platform: ruby
 authors:
 - Lukas Westermann
@@ -15,7 +15,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 7.2.0
+        version: 8.0.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '8.2'
@@ -25,105 +25,35 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 7.2.0
+        version: 8.0.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '8.2'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 13.3.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 13.3.0
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.81.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.81.1
-- !ruby/object:Gem::Dependency
-  name: rubocop-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.33.3
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.33.3
-- !ruby/object:Gem::Dependency
-  name: rubocop-rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.7.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.7.1
-- !ruby/object:Gem::Dependency
-  name: shoulda
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 4.0.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 4.0.0
-description: Simple, internationalized and DRY page titles and headings for Rails.
 email:
-- lukas.westermann@gmail.com
+- lukaspec.westermann@gmail.com
 executables: []
 extensions: []
-extra_rdoc_files: []
+extra_rdoc_files:
+- CHANGELOG.md
+- LICENSE
+- README.md
 files:
 - CHANGELOG.md
-- CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
 - lib/page_title_helper.rb
-- lib/page_title_helper/version.rb
 - page_title_helper.gemspec
-- test/en.yml
-- test/en_wohaapp.yml
-- test/multiple_formats_test.rb
-- test/page_title_helper_test.rb
-- test/test_helper.rb
 homepage: https://github.com/lwe/page_title_helper
 licenses:
 - MIT
-metadata: {}
+metadata:
+  bug_tracker_uri: https://github.com/lwe/page_title_helper/issues
+  changelog_uri: https://github.com/lwe/page_title_helper/blob/master/CHANGELOG.md
+  documentation_uri: https://www.rubydoc.info/gems/page_title_helper
+  homepage_uri: https://github.com/lwe/page_title_helper
+  source_code_uri: https://github.com/lwe/page_title_helper
 rdoc_options: []
 require_paths:
 - lib
@@ -131,19 +61,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.2.0
+      version: 3.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.20
 specification_version: 4
-summary: Simple, internationalized and DRY page titles and headings for Rails.
-test_files:
-- test/en.yml
-- test/en_wohaapp.yml
-- test/multiple_formats_test.rb
-- test/page_title_helper_test.rb
-- test/test_helper.rb
+summary: Simple, internationalized and DRY page titles and headings for Railspec.
+test_files: []

data/CODE_OF_CONDUCT.md

@@ -1,77 +0,0 @@
-# Contributor Code of Conduct
-
-## Our Pledge
-
-In the interest of fostering an open and welcoming environment, we as
-contributors and maintainers pledge to making participation in our project and
-our community a harassment-free experience for everyone, regardless of age,
-body size, disability, ethnicity, gender identity and expression, level of
-experience, nationality, personal appearance, race, religion, or sexual
-identity and orientation.
-
-## Our Standards
-
-Examples of behavior that contributes to creating a positive environment
-include:
-
-* Using welcoming and inclusive language
-* Being respectful of differing viewpoints and experiences
-* Gracefully accepting constructive criticism
-* Focusing on what is best for the community
-* Showing empathy towards other community members
-
-Examples of unacceptable behavior by participants include:
-
-* The use of sexualized language or imagery and unwelcome sexual attention or
-  advances
-* Trolling, insulting/derogatory comments, and personal or political attacks
-* Public or private harassment
-* Publishing others' private information, such as a physical or electronic
-  address, without explicit permission
-* Other conduct which could reasonably be considered inappropriate in a
-  professional setting
-
-
-## Our Responsibilities
-
-Project maintainers are responsible for clarifying the standards of acceptable
-behavior and are expected to take appropriate and fair corrective action in
-response to any instances of unacceptable behavior.
-
-Project maintainers have the right and responsibility to remove, edit, or
-reject comments, commits, code, wiki edits, issues, and other contributions
-that are not aligned to this Code of Conduct, or to ban temporarily or
-permanently any contributor for other behaviors that they deem inappropriate,
-threatening, offensive, or harmful.
-
-## Scope
-
-This Code of Conduct applies both within project spaces and in public spaces
-when an individual is representing the project or its community. Examples of
-representing a project or community include using an official project e-mail
-address, posting via an official social media account, or acting as an
-appointed representative at an online or offline event. Representation of a
-project may be further defined and clarified by project maintainers.
-
-## Enforcement
-
-Instances of abusive, harassing, or otherwise unacceptable behavior may be
-reported by contacting the project team at (lukas dot westermann at gmail dot com).
-All complaints will be reviewed and investigated and will result in a response
-that is deemed necessary and appropriate to the circumstances. The project team
-is obligated to maintain confidentiality with regard to the reporter of an
-incident. Further details of specific enforcement policies may be posted
-separately.
-
-Project maintainers who do not follow or enforce the Code of Conduct in good
-faith may face temporary or permanent repercussions as determined by other
-members of the project's leadership.
-
-## Attribution
-
-This Code of Conduct is adapted from the [Contributor Covenant][homepage],
-version 1.4, available at
-[https://contributor-covenant.org/version/1/4/][version].
-
-[homepage]: https://contributor-covenant.org
-[version]: https://contributor-covenant.org/version/1/4/

data/lib/page_title_helper/version.rb

@@ -1,5 +0,0 @@
-# frozen_string_literal: true
-
-module PageTitleHelper
-  VERSION = '10.0.0'
-end

data/test/en.yml

@@ -1,21 +0,0 @@
-en:
-  contacts:
-    list:
-      title: contacts.list.title
-      page_title: custom contacts title
-    myhaml:
-      title: this is haml!
-  admin:
-    account:
-      title: Account administration
-      show:
-        title: Account
-      new:
-        title: New account
-      edit:
-        title: Edit account
-        
-  placeholder: "Displaying %{name}"
-  app:
-    tagline: Default
-    other_tagline: Other default

data/test/en_wohaapp.yml

@@ -1,12 +0,0 @@
-en:
-  app:
-    name: Wohaapp
-  pages:
-    features:
-      title:
-        - "Feature comparison"
-        - !ruby/sym promo
-    signup:
-      title:
-        - "Sign up"
-        - ":title for :app now!"

data/test/multiple_formats_test.rb

@@ -1,74 +0,0 @@
-# frozen_string_literal: true
-
-require 'minitest/autorun'
-require 'test_helper'
-
-class MultipleFormatsTest < ActiveSupport::TestCase
-  context '#page_title supporting multiple formats through arrays' do
-    setup do
-      @view = TestView.new('contacts', 'list')
-    end
-
-    should 'accept an array passed in the page_title block and use the second argument as format' do
-      @view.page_title { ['Oh my...!', ':title // :app'] }
-      assert_equal 'Oh my...! // Page title helper', @view.page_title
-    end
-
-    should 'still return title as string and not the array' do
-      assert_equal('Oh my...!', @view.page_title { ['Oh my...!', ':title // :app'] })
-    end
-  end
-
-  context '#page_title with format aliases' do
-    setup do
-      PageTitleHelper.formats[:myformat] = ':title <-> :app'
-      @view = TestView.new('contacts', 'list')
-    end
-
-    should 'have a default alias named :app' do
-      assert_equal 'Page title helper', @view.page_title(format: :app)
-    end
-
-    should 'allow custom aliases to be defined and used' do
-      @view.page_title { 'Test' }
-      assert_equal 'Test <-> Page title helper', @view.page_title(format: :myformat)
-    end
-
-    should 'fallback to default format, if array is not big enough (i.e. only contains single element...)' do
-      assert_equal('Test', @view.page_title { ['Test'] })
-      assert_equal 'Test - Page title helper', @view.page_title
-    end
-
-    context 'used with the array block' do
-      should 'also allow aliases returned in that array thingy' do
-        assert_equal('Test', @view.page_title { ['Test', :myformat] })
-        assert_equal 'Test <-> Page title helper', @view.page_title
-      end
-
-      should 'override locally supplied :format arguments' do
-        assert_equal('Something', @view.page_title { ['Something', '* * * :title * * *'] })
-        # yeah, using x-tra ugly titles :)
-        assert_equal '* * * Something * * *', @view.page_title(format: '-= :title =-')
-      end
-    end
-  end
-
-  context '#page_title, aliases and YAML' do
-    setup do
-      I18n.load_path = [File.join(File.dirname(__FILE__), 'en_wohaapp.yml')]
-      I18n.reload!
-      PageTitleHelper.formats[:promo] = ':app > :title'
-      @view = TestView.new
-    end
-
-    should 'allow to override format through YAML' do
-      @view.controller! 'pages', 'features'
-      assert_equal 'Wohaapp > Feature comparison', @view.page_title
-    end
-
-    should 'handle raw string formats from YAML as well' do
-      @view.controller! 'pages', 'signup'
-      assert_equal 'Sign up for Wohaapp now!', @view.page_title
-    end
-  end
-end

data/test/page_title_helper_test.rb

@@ -1,137 +0,0 @@
-# frozen_string_literal: true
-
-require 'minitest/autorun'
-require 'test_helper'
-
-class PageTitleHelperTest < ActiveSupport::TestCase
-  context 'PageTitleHelper' do
-    setup do
-      I18n.load_path = [File.join(File.dirname(__FILE__), 'en.yml')]
-      I18n.reload!
-
-      @view = TestView.new('contacts', 'list')
-    end
-
-    context '::Interpolations' do
-      should 'interpolate :app and :title' do
-        assert_equal 'Page title helper', PageTitleHelper::Interpolations.app({})
-        assert_equal 'Appname', PageTitleHelper::Interpolations.app(app: 'Appname')
-        assert_equal 'untitled', PageTitleHelper::Interpolations.title(title: 'untitled')
-      end
-
-      should 'allow adding custom interpolations' do
-        # extend Interpolations
-        PageTitleHelper.interpolates(:app_reverse) { |env| app(env).reverse.downcase }
-
-        assert_equal 'anna', PageTitleHelper::Interpolations.app_reverse(app: 'Anna')
-        assert_equal 'ppa', PageTitleHelper::Interpolations.interpolate(':app_reverse', app: 'app')
-      end
-
-      should 'interpolate in correct order, i.e. longest first' do
-        PageTitleHelper.interpolates(:foobar) { |_env| 'foobar' }
-        PageTitleHelper.interpolates(:foobar_test) { |_env| 'foobar_test' }
-        PageTitleHelper.interpolates(:title_foobar) { |_env| 'title_foobar' }
-
-        assert_equal 'title_foobar / foobar_test / foobar / foobar_x',
-                     PageTitleHelper::Interpolations.interpolate(':title_foobar / :foobar_test / :foobar / :foobar_x',
-                                                                 {})
-      end
-    end
-
-    context '#page_title (define w/ block)' do
-      should 'return title from block and render with app name' do
-        assert_equal('foo', @view.page_title { 'foo' })
-        assert_equal 'foo - Page title helper', @view.page_title
-      end
-
-      should 'set custom title using a translation with a placeholder' do
-        assert_equal('Displaying Bella', @view.page_title { I18n.t(:placeholder, name: 'Bella') })
-        assert_equal 'Displaying Bella - Page title helper', @view.page_title
-      end
-    end
-
-    context '#page_title! (define)' do
-      should 'set page title' do
-        assert_equal 'test', @view.page_title!('test')
-        assert_equal 'test - Page title helper', @view.page_title
-      end
-
-      should 'set page title and interpret second argument as custom format' do
-        PageTitleHelper.formats[:bang] = ':title !! :app'
-        assert_equal 'test', @view.page_title!('test', :bang)
-        assert_equal 'test !! Page title helper', @view.page_title
-      end
-    end
-
-    context '#page_title (rendering)' do
-      should 'read default title from I18n, based on controller/action' do
-        assert_equal 'contacts.list.title - Page title helper', @view.page_title
-      end
-
-      should 'only print app name if format: :app' do
-        assert_equal 'Page title helper', @view.page_title(format: :app)
-      end
-
-      should 'print custom app name if :app defined and format: :app' do
-        assert_equal 'Some app', @view.page_title(app: 'Some app', format: :app)
-      end
-
-      should 'use custom format, if :format option is defined' do
-        assert_equal('test', @view.page_title { 'test' })
-        assert_equal 'Some app :: test', @view.page_title(app: 'Some app', format: ':app :: :title')
-        assert_equal 'Some app / test', @view.page_title(format: 'Some app / :title')
-      end
-
-      should 'return just title if format: false is passed' do
-        assert_equal('untitled', @view.page_title { 'untitled' })
-        assert_equal 'untitled', @view.page_title(format: false)
-      end
-
-      should 'return title if format: false and when using the DRY-I18n titles' do
-        assert_equal 'contacts.list.title', @view.page_title(format: false)
-      end
-
-      should 'render translated :"app.tagline" if no title is available' do
-        @view.controller! 'view/does', 'not_exist'
-        assert_equal 'Default - Page title helper', @view.page_title
-      end
-
-      should 'render use controller.title as first fallback, if no title exists' do
-        @view.controller! 'admin/account', 'index'
-        assert_equal 'Account administration - Page title helper', @view.page_title(default: 'Other default')
-      end
-
-      should 'not fallback to controller.title if controller.action.title exists' do
-        @view.controller! 'admin/account', 'show'
-        assert_equal 'Account - Page title helper', @view.page_title(default: 'Other default')
-      end
-
-      should 'fallback to controller.new.title if create has no title' do
-        @view.controller! 'admin/account', 'create'
-        assert_equal 'New account - Page title helper', @view.page_title(default: 'Other default')
-      end
-
-      should 'fallback to controller.edit.title if update has no title' do
-        @view.controller! 'admin/account', 'update'
-        assert_equal 'Edit account - Page title helper', @view.page_title(default: 'Other default')
-      end
-
-      should 'render custom "default" string, if title is not available nor controller.title' do
-        @view.controller! 'view/does', 'not_exist'
-        assert_equal 'Some default - Page title helper', @view.page_title(default: 'Some default')
-      end
-
-      should 'render custom default translation, if title is not available nor controller.title' do
-        @view.controller! 'view/does', 'not_exist'
-        assert_equal 'Other default - Page title helper', @view.page_title(default: :'app.other_tagline')
-      end
-    end
-
-    context 'README.md' do
-      should 'interpolate :controller' do
-        PageTitleHelper.interpolates(:controller) { |env| env[:view].controller.controller_name.humanize }
-        assert_equal 'contacts.list.title - Test', @view.page_title(format: ':title - :controller')
-      end
-    end
-  end
-end

data/test/test_helper.rb

@@ -1,47 +0,0 @@
-# frozen_string_literal: true
-
-# This line can be dropped once we no longer support Rails 7.0.
-require 'logger'
-# This line can be dropped once we no longer support Rails 7.1 and 7.2.
-require 'uri'
-require 'active_support'
-require 'action_view'
-require 'page_title_helper'
-
-unless defined?(IRB)
-  require 'active_support/test_case'
-  require 'shoulda'
-end
-
-# Use sorted tests. We need to change that after the tests have been converted
-# to RSpec.
-ActiveSupport.test_order = :sorted
-
-# fake global Rails module
-module Rails
-  class << self
-    def root
-      @root ||= Pathname.new('/this/is/just/for/testing/page_title_helper')
-    end
-
-    def env
-      'test'
-    end
-  end
-end
-
-# Mock ActionView a bit to allow easy (fake) template assignment
-class TestView < ActionView::Base
-  attr_reader :controller
-
-  def initialize(controller_path = nil, action = nil)
-    @controller = ActionView::TestCase::TestController.new
-    @controller.controller_path = controller_path
-    params[:action] = action if action
-  end
-
-  def controller!(controller_path, action)
-    @controller.controller_path = controller_path
-    params[:action] = action
-  end
-end