page_title_helper 1.0.0 → 1.0.1

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :major: 1
 :minor: 0
-:patch: 0
+:patch: 1

data/lib/page_title_helper.rb

@@ -9,6 +9,8 @@
 
 # PageTitleHelper
 module PageTitleHelper
+
+  # http://github.com/thoughtbot/paperclip/blob/master/lib/paperclip/interpolations.rb
   module Interpolations
     # Represents the environment which is passed into each interpolation call.
     class TitleEnv < ::Struct.new(:options, :view, :controller, :title); end
@@ -86,10 +88,17 @@ module PageTitleHelper
   
   protected
   
-    # Find current title key based on currently rendering template, same
-    # code as in {ActionView::Helpers::TranslationHelpers} to get that <tt>'.relative_key'</tt>
-    # magic working.
-    def i18n_template_key(suffix = :title)
-      template.path_without_format_and_extension.gsub(%r{/_?}, '.') + ".#{suffix}"
+    # Find current title key based on currently rendering template.
+    #
+    # Access +ActionView+s internal <tt>@_first_render</tt> variable, to access
+    # template first rendered, this is to help create the DRY-I18n-titles magic,
+    # and also kind of a hack, because this really seems to be some sort if
+    # internal variable, that's why it's "abstracted" away as well.
+    #
+    # Also ensure that the extensions (like <tt>.html.erb</tt> or
+    # <tt>.html.haml</tt>) have been stripped of and translated in the sense
+    # of converting <tt>/</tt> to <tt>.</tt>.
+    def i18n_template_key(suffix = nil)
+      @_first_render.template_path.gsub(/\.[^\/]*\Z/, '').tr('/', '.') + (suffix.present? ? ".#{suffix}" : "")
     end
 end

data/test/multiple_formats_test.rb

@@ -61,12 +61,12 @@ class MultipleFormatsTest < ActiveSupport::TestCase
     end
     
     should "allow to overide format through YAML" do
-      mock(@view).template { ActionView::Template.new 'pages/features.html.haml' }
+      @view.template = 'pages/features.html.haml'
       assert_equal 'Wohaapp > Feature comparison', @view.page_title
     end
     
     should "handle raw string formats from YAML as well" do
-      mock(@view).template { ActionView::Template.new 'pages/signup.html.haml' }
+      @view.template = 'pages/signup.html.haml'
       assert_equal 'Sign up for Wohaapp now!', @view.page_title
     end
   end

data/test/page_title_helper_test.rb

@@ -9,7 +9,7 @@ class PageTitleHelperTest < ActiveSupport::TestCase
       I18n.reload!
     
       @view = ActionView::Base.new
-      @view.template = ActionView::Template.new "contacts/list.html.erb"
+      @view.template_path = "contacts/list.html.erb"
     end
   
     context "::Interpolations" do
@@ -90,17 +90,17 @@ class PageTitleHelperTest < ActiveSupport::TestCase
       end
         
       should "render translated :'app.tagline' if no title is available" do
-        mock(@view).template { ActionView::Template.new('view/does/not_exist.html.erb') }
+        @view.template_path = 'view/does/not_exist.html.erb'
         assert_equal "Default - Page title helper", @view.page_title
       end
 
       should "render custom 'default' string, if title is not available" do
-        mock(@view).template { ActionView::Template.new('view/does/not_exist.html.erb') }
+        @view.template_path = 'view/does/not_exist.html.erb'
         assert_equal 'Some default - Page title helper', @view.page_title(:default => 'Some default')
       end
 
       should "render custom default translation, if title is not available" do
-        mock(@view).template { ActionView::Template.new('view/does/not_exist.html.erb') }
+        @view.template_path = 'view/does/not_exist.html.erb'
         assert_equal 'Other default - Page title helper', @view.page_title(:default => :'app.other_tagline')
       end
 
@@ -109,7 +109,7 @@ class PageTitleHelperTest < ActiveSupport::TestCase
       end
       
       should "work with other template engines, like HAML" do
-        mock(@view).template { ActionView::Template.new('contacts/myhaml.html.haml') }
+        @view.template_path = 'contacts/myhaml.html.haml'
         assert_equal 'this is haml! - Page title helper', @view.page_title
       end      
     end

data/test/test_helper.rb

@@ -13,4 +13,11 @@ end
 
 ROOT = File.expand_path File.dirname(File.dirname(__FILE__))
 RAILS_ROOT = '/this/is/just/for/testing/page_title_helper'
-RAILS_ENV = 'test'
+RAILS_ENV = 'test'
+
+class ActionView::Base
+  def template=(template)
+    @_first_render = template.respond_to?(:template_path) ? template : ActionView::Template.new(template)
+  end
+  alias_method :template_path=, :template=
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: page_title_helper
 version: !ruby/object:Gem::Version 
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors: 
 - Lukas Westermann
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-11-20 00:00:00 +01:00
+date: 2009-11-26 00:00:00 +01:00
 default_executable: 
 dependencies: []