page_record 0.4.0 → 0.5.0

data/spec/spec_helper.rb

@@ -8,12 +8,11 @@ require 'coveralls'
 Coveralls.wear!
 
 if defined?(ActionView::Base)
-	require 'rails'
+  require 'rails'
   require 'rspec/rails/mocks'
   include RSpec::Rails::Mocks
 end
 
-
 require 'page_record'
 require 'capybara'
 require 'capybara/dsl'
@@ -27,7 +26,6 @@ require_relative './support/shared_examples'
 Capybara.app = TestApp
 Capybara.app_host = nil
 
-
 RSpec.configure do |config|
   config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true

data/spec/support/shared_contexts.rb

@@ -10,7 +10,6 @@ shared_context "page with two tables with 3 records" do
   end
 end
 
-
 shared_context "page without records" do
   before do
     visit "/page-without-records"
@@ -29,9 +28,32 @@ shared_context "page one record in a form" do
   end
 end
 
-
 shared_context "page one record" do
   before do
     visit "/page-one-record"
   end
 end
+
+shared_context "page without errors" do
+  before do
+    visit "/page-without-errors"
+  end
+end
+
+shared_context "page with 1 error" do
+  before do
+    visit "/page-with-1-error"
+  end
+end
+
+shared_context "page with 2 errors on same attribute" do
+  before do
+    visit "/page-with-2-errors-on-same-attribute"
+  end
+end
+
+shared_context "page with 2 errors on different attributes" do
+  before do
+    visit "/page-with-2-errors-on-different-attributes"
+  end
+end

data/spec/support/shared_examples.rb

@@ -1,71 +1,67 @@
 shared_examples "valid call of .all" do
 
-	it "returns an Array" do
-		expect(subject.class).to eq Array
-	end
+  it "returns an Array" do
+    expect(subject.class).to eq Array
+  end
 
-	it "returns the inheriting class in the Array" do
-		subject.each do |record|
-			expect( record.class).to eq TeamPage
-		end
-	end
+  it "returns the inheriting class in the Array" do
+    subject.each do |record|
+      expect(record.class).to eq TeamPage
+    end
+  end
 
-	it "returns an element for each record on the page" do
-		expect( subject.count).to eq 3
-	end
+  it "returns an element for each record on the page" do
+    expect(subject.count).to eq 3
+  end
 
 end
 
-
 shared_examples "it handles filters" do
-	context "specified record contains specified filter" do
-		let(:filter)	{".champions_league"}
+  context "specified record contains specified filter" do
+    let(:filter) { ".champions_league" }
 
-		it_behaves_like "a valid call of .find"
+    it_behaves_like "a valid call of .find"
 
-	end
+  end
 
-	context "specified record doesn't contain specified filter" do
-		let(:filter)	{".euro_league"}
+  context "specified record doesn't contain specified filter" do
+    let(:filter) { ".euro_league" }
 
-		it "raises error PageRecord::RecordNotFound" do
-			expect{subject}.to raise_error(PageRecord::RecordNotFound)
-		end
-	end
+    it "raises error PageRecord::RecordNotFound" do
+      expect { subject }.to raise_error(PageRecord::RecordNotFound)
+    end
+  end
 end
 
-
 shared_examples "handles invalid selectors" do
-	context "with an non existing selector" do
-
-		let(:selector)	{"#non-existing-table"}
-		let(:filter)		{""}
-
+  context "with an non existing selector" do
 
-		it "raises error PageRecord::RecordNotFound" do
-			expect{subject}.to raise_error(PageRecord::RecordNotFound)
-		end
-	end
+    let(:selector) { "#non-existing-table" }
+    let(:filter) { "" }
 
-	context "with an undetermined selector" do
+    it "raises error PageRecord::RecordNotFound" do
+      expect { subject }.to raise_error(PageRecord::RecordNotFound)
+    end
+  end
 
-		let(:selector)	{".team-table"}
-		let(:filter)	{""}
+  context "with an undetermined selector" do
 
+    let(:selector) { ".team-table" }
+    let(:filter) { "" }
 
-		it "raises error PageRecord::MultipleRecords" do
-			expect{subject}.to raise_error(PageRecord::MultipleRecords)
-		end
+    it "raises error PageRecord::MultipleRecords" do
+      expect { subject }.to raise_error(PageRecord::MultipleRecords)
+    end
 
-	end
+  end
 end
 
 shared_examples "a valid call of .find" do
-	it "returns the inheriting class" do
-		expect(subject.class).to eq TeamPage
-	end
+  it "returns the inheriting class" do
+    expect(subject.class).to eq TeamPage
+  end
 
-	it "returns the record identified by the id" do
-		expect(subject.id).to eq '1'
-	end
+  it "returns the record identified by the id" do
+    expect(subject.id).to eq '1'
+  end
 end

data/spec/support/team.rb

@@ -1,6 +1,6 @@
 # @private This is just a class for testing
 class Team
-	def self.attribute_names
-		[ 'id' , 'name', 'points', 'ranking', 'goals']
-	end
-end
+  def self.attribute_names
+    %w(id name points ranking goals)
+  end
+end

data/spec/support/test_app.rb

@@ -1,24 +1,21 @@
 require 'sinatra/base'
 
-
 # @private This is just a test class
 class TestApp < Sinatra::Base
 
   set :root, File.dirname(__FILE__)
   set :raise_errors, true
-  # set :show_exceptions, false
-
 
   get '/*' do
-	  viewname = params[:splat].first   # eg "some/path/here"
-	  if File.exist?("#{settings.root}/views/#{viewname}.erb")
-	    erb :"#{viewname}"
-	  else
-	  	"can't find view #{viewname}"
-	  end
-	end
+    viewname = params[:splat].first   # eg "some/path/here"
+    if File.exist?("#{settings.root}/views/#{viewname}.erb")
+      erb :"#{viewname}"
+    else
+      "can't find view #{viewname}"
+    end
+  end
 end
 
-if __FILE__ == $0
-  Rack::Handler::WEBrick.run TestApp, :Port => 8070
-end
+if __FILE__ == $PROGRAM_NAME
+  Rack::Handler::WEBrick.run TestApp, Port: 8070
+end

data/spec/support/views/page-with-1-error.erb

@@ -0,0 +1,5 @@
+<form data-team-id='1'>
+	<div data-error-for='name'>this is the validation message</div>
+	<input data-attribute-for='name'>
+	<button data-action-for='create'>
+</form>

data/spec/support/views/page-with-2-errors-on-different-attributes.erb

@@ -0,0 +1,9 @@
+<form data-team-id='1'>
+	<div data-error-for='name'>this is the validation message for name</div>
+	<input data-attribute-for='name'>
+
+	<div data-error-for='age'>this is the validation message for age</div>
+	<input data-attribute-for='age'>
+
+	<button data-action-for='create'>
+</form>

data/spec/support/views/page-with-2-errors-on-same-attribute.erb

@@ -0,0 +1,6 @@
+<form data-team-id='1'>
+	<div data-error-for='name'>this is the first validation message</div>
+	<div data-error-for='name'>this is the second validation message</div>
+	<input data-attribute-for='name'>
+	<button data-action-for='create'>
+</form>

data/spec/support/views/page-without-errors.erb

@@ -0,0 +1,4 @@
+<form data-team-id='1'>
+	<input data-attribute-for='name'>
+	<button data-action-for='create'>
+</form>

data/spec/validation_spec.rb

@@ -0,0 +1,142 @@
+require_relative  './spec_helper'
+
+describe "Page Record validations" do
+
+  before do
+    class TeamPage < PageRecord::Base; end
+    PageRecord::Base.page page
+  end
+
+  let(:record) { TeamPage.find}
+
+  describe '#errors' do
+
+  	subject {record.errors}
+
+
+  	context "No errors on the page" do
+
+      include_context "page without errors"
+
+  		it "is empty" do
+  			expect(subject).to be_empty
+	  	end
+	  end
+
+	  context "1 error on the page" do
+      include_context "page with 1 error"
+
+  		it "returns an Error object with the atrribute and error" do
+  			expect(subject[:name]).to eq ['this is the validation message']
+	  	end
+
+	  end
+
+	  context "more errors on the same attribute" do
+      include_context "page with 2 errors on same attribute"
+
+  		it "returns an Error object with the atrributes and errors" do
+  			expect(subject[:name]).to eq ['this is the first validation message', 'this is the second validation message']
+	  	end
+
+	  end
+
+	  context "more errors on the different attributes" do
+      include_context "page with 2 errors on different attributes"
+
+  		it "returns an Error object with the atrributes and errors" do
+  			expect(subject[:name]).to eq ['this is the validation message for name']
+  			expect(subject[:age]).to eq ['this is the validation message for age']
+	  	end
+
+	  end
+
+
+  end
+
+  describe '#valid?' do
+
+  	subject { record.valid?}
+
+  	context "No errors on the page" do
+      include_context "page without errors"
+
+      it 'is true' do
+      	expect(subject).to be_true
+      end
+ 
+	  end
+
+	  context "1 error on the page" do
+      include_context "page with 1 error"
+
+      it 'is false' do
+      	expect(subject).to be_false
+      end
+
+
+	  end
+
+	  context "more errors on the same attribute" do
+      include_context "page with 2 errors on same attribute"
+
+      it 'is false' do
+      	expect(subject).to be_false
+      end
+    end
+
+	  context "more errors on the different attributes" do
+      include_context "page with 2 errors on different attributes"
+
+      it 'is false' do
+      	expect(subject).to be_false
+      end
+
+    end
+
+  end
+
+  describe '#invalid?' do
+
+  	subject { record.invalid?}
+
+  	context "No errors on the page" do
+      include_context "page without errors"
+
+      it 'is false' do
+      	expect(subject).to be_false
+      end
+ 
+	  end
+
+	  context "1 error on the page" do
+      include_context "page with 1 error"
+
+      it 'is true' do
+      	expect(subject).to be_true
+      end
+
+
+	  end
+
+	  context "more errors on the same attribute" do
+      include_context "page with 2 errors on same attribute"
+
+      it 'is true' do
+      	expect(subject).to be_true
+      end
+    end
+
+	  context "more errors on the different attributes" do
+      include_context "page with 2 errors on different attributes"
+
+      it 'is true' do
+      	expect(subject).to be_true
+      end
+
+    end
+
+  end
+
+
+end

data/tmp/rspec_guard_result

@@ -0,0 +1 @@
+./spec/inspector_spec.rb:12

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: page_record
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-06 00:00:00.000000000 Z
+date: 2013-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -123,6 +123,38 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: ruby_gntp
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
@@ -155,11 +187,31 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: activemodel
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Page Object implementation with ActiveRecord like reading from specialy
   formatted HTML-page
 email:
 - hajee@moretIA.com
-executables: []
+executables:
+- autospec
+- guard
+- rake
+- rspec
 extensions: []
 extra_rdoc_files: []
 files:
@@ -167,14 +219,20 @@ files:
 - .gitignore
 - .gitmodules
 - .rspec
+- .rubocop.yml
 - .travis.yml
 - .yardopts
 - CHANGES.md
 - Gemfile
 - Gemfile.lock
+- Guardfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- bin/autospec
+- bin/guard
+- bin/rake
+- bin/rspec
 - lib/page_record.rb
 - lib/page_record/attribute_accessors.rb
 - lib/page_record/base.rb
@@ -186,11 +244,15 @@ files:
 - lib/page_record/form_builder.rb
 - lib/page_record/formtastic.rb
 - lib/page_record/helpers.rb
+- lib/page_record/inspector.rb
 - lib/page_record/instance_actions.rb
 - lib/page_record/rspec.rb
+- lib/page_record/validation.rb
 - lib/page_record/version.rb
 - page_record.gemspec
+- spec/.rubocop.yml
 - spec/helpers_spec.rb
+- spec/inspector_spec.rb
 - spec/page_record_spec.rb
 - spec/spec_helper.rb
 - spec/support/shared_contexts.rb
@@ -199,10 +261,16 @@ files:
 - spec/support/test_app.rb
 - spec/support/views/page-one-record-in-a-form.erb
 - spec/support/views/page-one-record.erb
+- spec/support/views/page-with-1-error.erb
+- spec/support/views/page-with-2-errors-on-different-attributes.erb
+- spec/support/views/page-with-2-errors-on-same-attribute.erb
 - spec/support/views/page-with-duplicate-records.erb
 - spec/support/views/page-with-single-table-with-3-records.erb
 - spec/support/views/page-with-two-tables-with-3-records.erb
+- spec/support/views/page-without-errors.erb
 - spec/support/views/page-without-records.erb
+- spec/validation_spec.rb
+- tmp/rspec_guard_result
 homepage: https://github.com/appdrones/page_record
 licenses:
 - MIT
@@ -218,7 +286,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3628440066479554934
+      hash: 3974073958199987845
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -227,7 +295,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3628440066479554934
+      hash: 3974073958199987845
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24
@@ -236,7 +304,9 @@ specification_version: 3
 summary: Page Object implementation. Using some specialy formatted 'data-...' tags
   you can read records from HTML pages like an ActiveRecord page
 test_files:
+- spec/.rubocop.yml
 - spec/helpers_spec.rb
+- spec/inspector_spec.rb
 - spec/page_record_spec.rb
 - spec/spec_helper.rb
 - spec/support/shared_contexts.rb
@@ -245,7 +315,12 @@ test_files:
 - spec/support/test_app.rb
 - spec/support/views/page-one-record-in-a-form.erb
 - spec/support/views/page-one-record.erb
+- spec/support/views/page-with-1-error.erb
+- spec/support/views/page-with-2-errors-on-different-attributes.erb
+- spec/support/views/page-with-2-errors-on-same-attribute.erb
 - spec/support/views/page-with-duplicate-records.erb
 - spec/support/views/page-with-single-table-with-3-records.erb
 - spec/support/views/page-with-two-tables-with-3-records.erb
+- spec/support/views/page-without-errors.erb
 - spec/support/views/page-without-records.erb
+- spec/validation_spec.rb