page_print 0.1.4 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 24c8d328fc3a7c707f963911d6305fea21cf568e5dc8160356d4a7c09aff9ca6
-  data.tar.gz: c7ea027a685ecddae01d267a4d891b1a012cd8275273bcc3363e5c54ca246f91
+  metadata.gz: 169eff31f74498423a1a2e143966ade6f58e912a548922f906fba8b64264e905
+  data.tar.gz: 61a523b3f98cd4b36cdcd4b9fce35fa011995ef37a431a0b6379fa15e05a24c4
 SHA512:
-  metadata.gz: bf7f60c19abdec64973d019361abcccc71d795d367f8d3ba96d66a273b28dd7d0f11e81bcc121e6cb099c5b8e7fa71beacaae0b4b20fd01a7e834cd8728ebe95
-  data.tar.gz: 0ffd18445dcd38b6b2705c874409e943b31f947d67c577129db3a8e3ed7822f896f8af044fe2e9494927222256eb2034bbe3722d9558287063b613129c0b8cc5
+  metadata.gz: 703a44815c6a315aabf6bafd7e8f2f355794f619689ed5b37b31b58ba83388176da9ddde484484c818fb9ebc13132e5b62cbe32613f72776c778cb500406be88
+  data.tar.gz: 80a783772bd1ff36397aa6c830dd80373697664cd4a9d0e36a7d4798a87c906bf28683cca854b07f6edfd080b91fd5956d49cae22e35e9d2e04860f62c244b9a

data/README.md

@@ -130,6 +130,8 @@ Supported keyword options:
 - `resource_fetcher:` callable that receives a URL and returns `nil` or `{ content:, mime_type:, text_encoding: nil }`
 - `metadata:` hash with `:title`, `:author`, `:subject`, `:keywords`, `:creation_date`, or `:modification_date`
 
+Unresolved URLs are not fetched over the network. Provide assets through `resource_fetcher`, or return `nil` to skip a URL.
+
 `metadata[:creation_date]` and `metadata[:modification_date]` should be ISO-8601 strings, for example `2026-05-10T12:00:00Z`.
 
 Custom dimensions and margins require `unit:`. Supported units are `:pt`, `:pc`, `:in`, `:cm`, `:mm`, and `:px`.
@@ -151,7 +153,7 @@ For options and CSV output, see `benchmark/README.md`.
 
 ## Requirements
 
-- Ruby 3.0+
+- Ruby 3.2+
 - Native gems are published for `x86_64-linux` and `arm64-darwin`.
 - Native gems vendor PlutoBook but compile the small Ruby extension during install so it links against your local Ruby.
 - Source builds on unsupported platforms require PlutoBook development headers and library files.
@@ -250,6 +252,18 @@ gem build page_print.gemspec
 gem install ./page_print-*.gem
 ```
 
+## Releasing
+
+Publish a new version with:
+
+```sh
+bin/bump 0.1.6
+```
+
+That updates `lib/page_print/version.rb` and `Gemfile.lock`, commits `Release 0.1.6`, creates annotated tag `v0.1.6`, and pushes `main` plus the tag. Requires a clean worktree on `main`.
+
+The Package workflow then builds the source and platform gems, pushes them to RubyGems (trusted publishing / OIDC, GitHub environment `release`), and creates a GitHub Release with the gem artifacts and commit notes since the previous `v*` tag.
+
 ## Building Native Gems
 
 Build an `x86_64-linux` platform gem with a vendored PlutoBook library:
@@ -264,7 +278,7 @@ Build an Apple Silicon macOS platform gem with a vendored PlutoBook library:
 bundle exec rake package:darwin_arm64
 ```
 
-These tasks check out PlutoBook `v0.17.0`, build it into `lib/page_print/vendor/<platform>`, and write a platform gem to `pkg/`. Platform gems compile the Ruby extension during gem install to avoid tying the gem to the build machine's Ruby version.
+These tasks check out PlutoBook `v0.18.0`, build it into `lib/page_print/vendor/<platform>`, and write a platform gem to `pkg/`. Platform gems compile the Ruby extension during gem install to avoid tying the gem to the build machine's Ruby version.
 
 Native gems bundle PlutoBook and its non-system shared library dependencies. Optional PlutoBook features for curl, TurboJPEG, and WebP are disabled to keep the bundled dependency set smaller.
 

data/ext/page_print/page_print.c

@@ -48,7 +48,7 @@ typedef struct {
     plutobook_page_size_t page_size;
     plutobook_page_margins_t margins;
     plutobook_media_type_t media;
-    const char *base_url;
+    VALUE base_url;
     VALUE resource_fetcher;
     VALUE metadata;
 } pageprint_options_t;
@@ -97,6 +97,11 @@ typedef struct {
     int ok;
 } pageprint_write_pdf_stream_args_t;
 
+typedef struct {
+    plutobook_t *book;
+    VALUE metadata;
+} pageprint_apply_metadata_args_t;
+
 static VALUE pageprint_append_pdf_string(VALUE value);
 static plutobook_stream_status_t pageprint_write_pdf_string(void *closure, const char *data, unsigned int length);
 static plutobook_resource_data_t *pageprint_fetch_resource(void *closure, const char *url);
@@ -368,6 +373,15 @@ static void pageprint_apply_metadata(plutobook_t *book, VALUE metadata)
     pageprint_set_metadata_value(book, metadata, id_modification_date, PLUTOBOOK_PDF_METADATA_MODIFICATION_DATE);
 }
 
+static VALUE pageprint_apply_metadata_with_gvl(VALUE ptr)
+{
+    pageprint_apply_metadata_args_t *args = (pageprint_apply_metadata_args_t *)ptr;
+
+    pageprint_apply_metadata(args->book, args->metadata);
+
+    return Qnil;
+}
+
 static void *pageprint_load_html_without_gvl(void *ptr)
 {
     pageprint_load_html_args_t *args = ptr;
@@ -487,23 +501,26 @@ static plutobook_resource_data_t *pageprint_fetch_resource(void *closure, const
     pageprint_resource_fetch_args_t args;
     int state;
 
-    args.fetcher = fetcher;
-    args.url = url;
-    args.resource = NULL;
+    if (!NIL_P(fetcher->object)) {
+        args.fetcher = fetcher;
+        args.url = url;
+        args.resource = NULL;
 
-    state = (int)(intptr_t)rb_thread_call_with_gvl(pageprint_call_resource_fetcher_with_gvl, &args);
+        state = (int)(intptr_t)rb_thread_call_with_gvl(pageprint_call_resource_fetcher_with_gvl, &args);
 
-    if (state) {
-        fetcher->state = state;
-        plutobook_set_error_message("failed to fetch URL '%s'", url);
-        return NULL;
-    }
+        if (state) {
+            fetcher->state = state;
+            plutobook_set_error_message("failed to fetch URL '%s'", url);
+            return NULL;
+        }
 
-    if (args.resource) {
-        return args.resource;
+        if (args.resource) {
+            return args.resource;
+        }
     }
 
-    return plutobook_fetch_url(url);
+    plutobook_set_error_message("network fetch disabled for URL '%s'", url);
+    return NULL;
 }
 
 static pageprint_options_t pageprint_options_from_value(VALUE options)
@@ -521,7 +538,7 @@ static pageprint_options_t pageprint_options_from_value(VALUE options)
     result.page_size = PLUTOBOOK_PAGE_SIZE_A4;
     result.margins = PLUTOBOOK_PAGE_MARGINS_NORMAL;
     result.media = PLUTOBOOK_MEDIA_TYPE_PRINT;
-    result.base_url = "";
+    result.base_url = Qnil;
     result.resource_fetcher = Qnil;
     result.metadata = Qnil;
 
@@ -556,7 +573,7 @@ static pageprint_options_t pageprint_options_from_value(VALUE options)
             rb_raise(rb_eTypeError, "base_url must be a String or nil");
         }
 
-        result.base_url = StringValueCStr(base_url_value);
+        result.base_url = base_url_value;
     }
 
     if (page_size_value != Qundef) {
@@ -596,6 +613,7 @@ static plutobook_t *pageprint_create_book_from_html(VALUE html, VALUE options, p
     pageprint_options_t pageprint_options;
 
     const char *html_str;
+    const char *base_url_str;
     long html_len;
 
     plutobook_t *book;
@@ -628,21 +646,30 @@ static plutobook_t *pageprint_create_book_from_html(VALUE html, VALUE options, p
     resource_fetcher->object = pageprint_options.resource_fetcher;
     resource_fetcher->state = 0;
 
-    if (!NIL_P(resource_fetcher->object)) {
-        plutobook_set_custom_resource_fetcher(book, pageprint_fetch_resource, resource_fetcher);
-    }
+    plutobook_set_custom_resource_fetcher(book, pageprint_fetch_resource, resource_fetcher);
 
     /* 2. Load HTML */
     plutobook_clear_error_message();
 
+    base_url_str = "";
+    if (!NIL_P(pageprint_options.base_url)) {
+        base_url_str = StringValueCStr(pageprint_options.base_url);
+    }
+
     load_args.book = book;
     load_args.html = html_str;
     load_args.length = (int)html_len;
     load_args.user_style = "";
     load_args.user_script = "";
-    load_args.base_url = pageprint_options.base_url;
+    load_args.base_url = base_url_str;
     load_args.ok = 0;
 
+    RB_GC_GUARD(html);
+    RB_GC_GUARD(options);
+    RB_GC_GUARD(pageprint_options.base_url);
+    RB_GC_GUARD(pageprint_options.resource_fetcher);
+    RB_GC_GUARD(pageprint_options.metadata);
+
     rb_thread_call_without_gvl(
         pageprint_load_html_without_gvl,
         &load_args,
@@ -665,7 +692,20 @@ static plutobook_t *pageprint_create_book_from_html(VALUE html, VALUE options, p
         rb_jump_tag(resource_fetcher->state);
     }
 
-    pageprint_apply_metadata(book, pageprint_options.metadata);
+    {
+        pageprint_apply_metadata_args_t metadata_args;
+        int metadata_state = 0;
+
+        metadata_args.book = book;
+        metadata_args.metadata = pageprint_options.metadata;
+
+        rb_protect(pageprint_apply_metadata_with_gvl, (VALUE)&metadata_args, &metadata_state);
+
+        if (metadata_state) {
+            plutobook_destroy(book);
+            rb_jump_tag(metadata_state);
+        }
+    }
 
     return book;
 }
@@ -734,6 +774,11 @@ static VALUE pageprint_html_to_pdf(int argc, VALUE *argv, VALUE self) {
     write_args.path = path_str;
     write_args.ok = 0;
 
+    RB_GC_GUARD(html);
+    RB_GC_GUARD(options);
+    RB_GC_GUARD(resource_fetcher.object);
+    RB_GC_GUARD(path);
+
     rb_thread_call_without_gvl(
         pageprint_write_pdf_without_gvl,
         &write_args,
@@ -751,10 +796,6 @@ static VALUE pageprint_html_to_pdf(int argc, VALUE *argv, VALUE self) {
         pageprint_raise_plutobook_error_with_path(rb_eRuntimeError, "failed to write PDF to", path_str);
     }
 
-    RB_GC_GUARD(resource_fetcher.object);
-    RB_GC_GUARD(options);
-    RB_GC_GUARD(path);
-
     return Qtrue;
 }
 
@@ -783,6 +824,11 @@ static VALUE pageprint_html_to_pdf_string(int argc, VALUE *argv, VALUE self) {
     write_args.output = &output;
     write_args.ok = 0;
 
+    RB_GC_GUARD(html);
+    RB_GC_GUARD(options);
+    RB_GC_GUARD(resource_fetcher.object);
+    RB_GC_GUARD(output.output);
+
     rb_thread_call_without_gvl(
         pageprint_write_pdf_stream_without_gvl,
         &write_args,
@@ -804,10 +850,6 @@ static VALUE pageprint_html_to_pdf_string(int argc, VALUE *argv, VALUE self) {
         pageprint_raise_plutobook_error(rb_eRuntimeError, "failed to write PDF to string");
     }
 
-    RB_GC_GUARD(resource_fetcher.object);
-    RB_GC_GUARD(options);
-    RB_GC_GUARD(output.output);
-
     return output.output;
 }
 

data/lib/page_print/version.rb

@@ -1,3 +1,3 @@
 module PagePrint
-  VERSION = '0.1.4'
+  VERSION = '0.1.6'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: page_print
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.6
 platform: ruby
 authors:
 - Dino Maric
@@ -40,7 +40,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '3.0'
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="