page_object_stubs 0.0.3 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a5539524aebc21c73f8646618784864432644092
-  data.tar.gz: f09fbc4ee8ef7bad40407e10908e10409cf2053b
+  metadata.gz: 955a66396ea7ac62b092d815d36bd9e9d15ffe7b
+  data.tar.gz: 01ab88000db1ac9eee71e9bf916bbfffe6a32d30
 SHA512:
-  metadata.gz: 9c1a140433db21e3259f1bc2a755f47d2751c6201514576bc6f2b89eb07fcb3c99b333af83e53d069f626f607007a33722577e266346af31bcd996fe83090625
-  data.tar.gz: 696669b89acd0fda6a6ddd44b27b5c898d9cad8bf3ea0e70b0eb71e92116cae512a6dbe67626df8eb865c0d5a924020b776d188e349e74b12a4ee4b7b659f267
+  metadata.gz: 8b59b9a8c6128d056c7e2cc85306a603019e7dbe11f5b7b17080791495f4c451b8d9debe6aa48df160fbcd640367362685b2cd2c0d2a71cda439616d900f0cb7
+  data.tar.gz: a2b0bc729f623920abc71cd3b4b64bc3c899528b4b49387a6703fd2c4783d601dfbb63d8e03e43978568b262c7f5997e58b0bd18a967c3059ebd0225fd512ea5

data/lib/page_object_stubs/page_object_stubs.rb

@@ -12,11 +12,9 @@ module PageObjectStubs
     # @param [Hash] opts
     # @option opts [Array<File>] :targets Array of target files to create stubs from (required)
     # @option opts [Dir] :output_folder Folder to create stubs in (required)
-    # @option opts [Boolean] :angularjs Enable angularjs support (optional, default false)
     def generate opts={}
-      angularjs = !!opts.fetch(:angularjs, false)
-      targets   = opts.fetch(:targets)
-      targets   = targets.select do |target|
+      targets = opts.fetch(:targets)
+      targets = targets.select do |target|
         File.file?(target) && File.readable?(target)
       end
 
@@ -45,10 +43,10 @@ R
 
         page_objects.name_type_pairs.each do |pair|
           element_type = pair.first
+          # if 'page_url' exists, then we need `def goto`
+          # for all others, we need the name of the element to generate the remaining methods.
           if element_type == 'page_url'
             output += wrap 'goto'
-            # visit loads goto then runs the Protractor waitForAngular JavaScript
-            output += wrap 'visit' if angularjs
             next
           end
 
@@ -62,29 +60,31 @@ R
         end
 
 
-        stub_file = File.join(output_folder, file_name + '_stub.rb')
+        stub_file      = File.join(output_folder, file_name + '_stub.rb')
+
+        # Note that the page method is defined as a singleton method on the
+        # top level 'main' object. This ensures we're not polluting the global
+        # object space by defining methods on every object which would happen
+        # if Kernel was used instead.
 
         output_postfix = <<R
     end
   end
 end
 
-module Kernel
-  def #{file_method_name}
-    Stub::#{file_module_name}
-  end
-end unless Kernel.respond_to? :#{file_method_name}
+public
+
+def #{file_method_name}
+  Stub::#{file_module_name}
+end
 R
 
         output = output_prefix + output + output_postfix
 
         File.open(stub_file, 'w') do |file|
-          file.write output.strip
+          file.write output
         end
       end
-
-# if 'page_url' exists, then we need `def goto`
-# for all others, we need the name of the element to generate the remaining methods.
     end
   end
 end

data/lib/page_object_stubs/raketask.rb

@@ -8,7 +8,6 @@ module PageObjectStubs
     # @option opts [String] :task_desc the description of the stubs task (optional)
     # @option opts [lambda] :targets lambda that will return an array of targets (optional)
     # @option opts [lambda] :output_folder lambda that will return the output folder (optional)
-    # @option opts [Boolean] :angularjs generate angularjs stubs. default true (optional)
     def add_stubs_task opts={}
       task_name     = opts.fetch(:task_name, 'stubs')
       task_desc     = opts.fetch(:task_desc, 'Generate stubs')
@@ -16,7 +15,6 @@ module PageObjectStubs
       # Get the dir that contains the Rakefile via Rake (__dir__ will not work)
       targets       = opts.fetch(:targets, lambda { Dir.glob(File.join(Rake.application.original_dir, 'page', '*_page.rb')) })
       output_folder = opts.fetch(:output_folder, lambda { File.join(Rake.application.original_dir, 'helper', 'stub') })
-      angularjs     = opts.fetch(:angularjs, true)
 
       raise 'targets must be a lambda' unless targets.lambda?
       raise 'output_folder must be a lambda' unless output_folder.lambda?
@@ -24,8 +22,7 @@ module PageObjectStubs
       Rake.application.last_description = task_desc
       Rake::Task.define_task task_name do
         PageObjectStubs.generate targets:       targets.call,
-                                 output_folder: output_folder.call,
-                                 angularjs:     angularjs
+                                 output_folder: output_folder.call
       end
     end
   end

data/lib/page_object_stubs/version.rb

@@ -1,4 +1,4 @@
 module PageObjectStubs
-  VERSION = '0.0.3' unless defined? ::PageObjectStubs::VERSION
-  DATE    = '2015-05-10' unless defined? ::PageObjectStubs::DATE
+  VERSION = '1.0.0' unless defined? ::PageObjectStubs::VERSION
+  DATE    = '2015-06-06' unless defined? ::PageObjectStubs::DATE
 end

data/release_notes.md

@@ -1,3 +1,9 @@
+#### v1.0.0 2015-06-06
+
+- [df4833e](https://github.com/bootstraponline/page_object_stubs/commit/df4833e0856873e581498d4a024b6d832a84bc66) Release 1.0.0
+- [bcd8c46](https://github.com/bootstraponline/page_object_stubs/commit/bcd8c46a5025956e9bddc7d5655e29177826a50b) Use top level singleton instead of Kernel method
+
+
 #### v0.0.3 2015-05-10
 
 - [fb08c84](https://github.com/bootstraponline/page_object_stubs/commit/fb08c84b55849da5fdd8d0e517d02addd9aebd6d) Release 0.0.3

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: page_object_stubs
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 1.0.0
 platform: ruby
 authors:
 - code@bootstraponline.com
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-10 00:00:00.000000000 Z
+date: 2015-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser