page_magic 1.2.8 → 1.2.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 54342b32a9fb2d649e4cada494b95c5be2fafd72
-  data.tar.gz: d2bd77b31ef141f7905859acc4713eb16957fe17
+  metadata.gz: cdfe7b7eb4aa09e8eab7a961a1b03156f4650af8
+  data.tar.gz: faaf84a4ff0c42dffa54b405bfbcb31812a3be6e
 SHA512:
-  metadata.gz: f0a0a3d5e51de8e34df2518ad3bebf2c1b87fdaca9f4e2ab1d35a1317f83ae7e8d096bc014481b276d326019201ff9537b3ef38a884b27d938cd5c63241237c3
-  data.tar.gz: 90a9469dde8f3f435a7bea31e9dbddb7a98cfd46b5cd62f43f62ed9b28c5334fb13542219abb5e4313fa12d7acf95add7ee050d1cbfc07230f164e2d12457081
+  metadata.gz: 352cdaa5d434b979ec5061193e9864f7fcb1b2d3418a4de064be94fef99ce71288da4421c4cfaceb1079fc0349e4b7c1ab4852c91c0f626bc9c7922f20f80b55
+  data.tar.gz: 1b22dfc283761f9ded938a899d115b7ffb3b07c96e58736879f33161621b6ccfb1510d0f1886bec75e30a95d1d5c4656613fc9671c9cc79a23e2d0d5f21cca69

data/.rubocop.yml

@@ -4,6 +4,8 @@ Metrics/LineLength:
 AllCops:
   TargetRubyVersion: 2.1
   Exclude:
+    - 'lib/active_support/**/*'
+    - 'spec/lib/active_support/**/*'
     - 'pkg/**/*'
     - 'vendor/**/*'
     - 'coverage/**/*'
@@ -17,4 +19,18 @@ Metrics/MethodLength:
   Max: 11
 
 Style/MethodMissing:
-  Enabled: false
+  Enabled: false
+
+Metrics/BlockLength:
+  Enabled: true
+  Exclude:
+   - 'spec/**/*'
+
+Style/PercentLiteralDelimiters:
+  PreferredDelimiters:
+    default: ()
+    '%i': '[]'
+    '%I': '[]'
+    '%r': '{}'
+    '%w': '[]'
+    '%W': '[]'

data/.simplecov

@@ -1,8 +1,8 @@
 require 'pullreview/coverage'
-require "codeclimate-test-reporter"
 
-SimpleCov.formatters  = [SimpleCov::Formatter::HTMLFormatter,PullReview::Coverage::Formatter,CodeClimate::TestReporter::Formatter]
+SimpleCov.formatters  = [SimpleCov::Formatter::HTMLFormatter,PullReview::Coverage::Formatter]
 
 SimpleCov.start do
   add_filter '/spec/'
+  add_filter '/lib/active_support/core_ext/object/to_query.rb'
 end

data/Gemfile

@@ -1,24 +1,24 @@
 source 'https://rubygems.org'
 
+gem 'activesupport-inflector'
 gem 'capybara', '>= 2.5'
-gem 'activesupport', '~> 4'
 
 group :test do
-  gem 'watir-webdriver'
-  gem 'sinatra'
-  gem 'rspec', require: 'rspec/core/rake_task'
-  gem 'simplecov', require: false
-  gem 'poltergeist'
+  gem 'arbre'
   gem 'codeclimate-test-reporter', group: :test, require: nil
+  gem 'poltergeist'
   gem 'pullreview-coverage', require: false
   gem 'reek'
-  gem 'arbre'
+  gem 'rspec', require: 'rspec/core/rake_task'
+  gem 'simplecov', require: false
+  gem 'sinatra'
+  gem 'watir-webdriver'
 end
 
 group :development do
+  gem 'github-markup', '~> 1.4'
   gem 'jeweler', '~> 2.0'
+  gem 'redcarpet', '~> 3.3'
   gem 'rubocop', '~> 0.34', require: 'rubocop/rake_task'
   gem 'yard', '~> 0.8'
-  gem 'redcarpet', '~> 3.3'
-  gem 'github-markup', '~> 1.4'
 end

data/Gemfile.lock

@@ -1,14 +1,13 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (4.2.7)
+    activesupport (4.2.10)
       i18n (~> 0.7)
-      json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
       thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
-    addressable (2.5.2)
-      public_suffix (>= 2.0.2, < 4.0)
+    activesupport-inflector (0.1.0)
+    addressable (2.4.0)
     arbre (1.1.1)
       activesupport (>= 3.0.0)
     ast (2.3.0)
@@ -17,159 +16,157 @@ GEM
       ice_nine (~> 0.11.0)
       thread_safe (~> 0.3, >= 0.3.1)
     builder (3.2.3)
-    capybara (2.7.1)
+    capybara (2.15.2)
       addressable
-      mime-types (>= 1.16)
+      mini_mime (>= 0.1.3)
       nokogiri (>= 1.3.3)
       rack (>= 1.0.0)
       rack-test (>= 0.5.4)
       xpath (~> 2.0)
-    certifi (2016.08.02)
-    childprocess (0.5.9)
+    certifi (2017.07.27)
+    childprocess (0.8.0)
       ffi (~> 1.0, >= 1.0.11)
     cliver (0.3.2)
-    codeclimate-engine-rb (0.3.1)
+    codeclimate-engine-rb (0.4.0)
       virtus (~> 1.0)
-    codeclimate-test-reporter (0.6.0)
-      simplecov (>= 0.7.1, < 1.0.0)
+    codeclimate-test-reporter (1.0.8)
+      simplecov (<= 0.13)
     coercible (1.0.0)
       descendants_tracker (~> 0.0.1)
     descendants_tracker (0.0.4)
       thread_safe (~> 0.3, >= 0.3.1)
-    diff-lcs (1.2.5)
+    diff-lcs (1.3)
     docile (1.1.5)
     equalizer (0.0.11)
     faraday (0.9.2)
       multipart-post (>= 1.2, < 3)
-    ffi (1.9.14)
+    ffi (1.9.18)
     git (1.3.0)
-    github-markup (1.4.0)
-    github_api (0.11.3)
-      addressable (~> 2.3)
-      descendants_tracker (~> 0.0.1)
+    github-markup (1.6.1)
+    github_api (0.16.0)
+      addressable (~> 2.4.0)
+      descendants_tracker (~> 0.0.4)
       faraday (~> 0.8, < 0.10)
-      hashie (>= 1.2)
-      multi_json (>= 1.7.5, < 2.0)
-      nokogiri (~> 1.6.0)
-      oauth2
+      hashie (>= 3.4)
+      mime-types (>= 1.16, < 3.0)
+      oauth2 (~> 1.0)
     hashie (3.5.6)
     highline (1.7.8)
-    i18n (0.7.0)
+    i18n (0.8.6)
     ice_nine (0.11.2)
-    jeweler (2.3.5)
+    jeweler (2.3.7)
       builder
-      bundler (>= 1.0)
+      bundler (>= 1)
       git (>= 1.2.5)
-      github_api (~> 0.11.0)
+      github_api (~> 0.16.0)
       highline (>= 1.6.15)
       nokogiri (>= 1.5.10)
       psych (~> 2.2)
       rake
       rdoc
       semver2
-    json (1.8.6)
+    json (2.1.0)
     jwt (1.5.6)
-    mime-types (3.1)
-      mime-types-data (~> 3.2015)
-    mime-types-data (3.2016.0521)
-    mini_portile2 (2.1.0)
-    minitest (5.9.0)
+    mime-types (2.99.3)
+    mini_mime (0.1.4)
+    mini_portile2 (2.3.0)
+    minitest (5.10.3)
     multi_json (1.12.2)
     multi_xml (0.6.0)
     multipart-post (2.0.0)
-    nokogiri (1.6.8.1)
-      mini_portile2 (~> 2.1.0)
+    nokogiri (1.8.1)
+      mini_portile2 (~> 2.3.0)
     oauth2 (1.4.0)
       faraday (>= 0.8, < 0.13)
       jwt (~> 1.0)
       multi_json (~> 1.3)
       multi_xml (~> 0.5)
       rack (>= 1.2, < 3)
-    parser (2.3.1.2)
+    parallel (1.12.0)
+    parser (2.4.0.0)
       ast (~> 2.2)
-    poltergeist (1.10.0)
+    poltergeist (1.16.0)
       capybara (~> 2.1)
       cliver (~> 0.3.1)
       websocket-driver (>= 0.2.0)
     powerpack (0.1.1)
     psych (2.2.4)
-    public_suffix (3.0.0)
     pullreview-coverage (0.0.5)
       certifi
       simplecov (>= 0.7.1, < 1.0.0)
     rack (1.6.8)
     rack-protection (1.5.3)
       rack
-    rack-test (0.6.3)
-      rack (>= 1.0)
-    rainbow (2.1.0)
+    rack-test (0.7.0)
+      rack (>= 1.0, < 3)
+    rainbow (2.2.2)
+      rake
     rake (12.1.0)
     rdoc (5.1.0)
-    redcarpet (3.3.4)
-    reek (4.2.3)
-      codeclimate-engine-rb (~> 0.3.1)
-      parser (~> 2.3.1, >= 2.3.1.2)
+    redcarpet (3.4.0)
+    reek (4.7.2)
+      codeclimate-engine-rb (~> 0.4.0)
+      parser (>= 2.4.0.0, < 2.5)
       rainbow (~> 2.0)
-    rspec (3.5.0)
-      rspec-core (~> 3.5.0)
-      rspec-expectations (~> 3.5.0)
-      rspec-mocks (~> 3.5.0)
-    rspec-core (3.5.2)
-      rspec-support (~> 3.5.0)
-    rspec-expectations (3.5.0)
+    rspec (3.6.0)
+      rspec-core (~> 3.6.0)
+      rspec-expectations (~> 3.6.0)
+      rspec-mocks (~> 3.6.0)
+    rspec-core (3.6.0)
+      rspec-support (~> 3.6.0)
+    rspec-expectations (3.6.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-mocks (3.5.0)
+      rspec-support (~> 3.6.0)
+    rspec-mocks (3.6.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-support (3.5.0)
-    rubocop (0.42.0)
-      parser (>= 2.3.1.1, < 3.0)
+      rspec-support (~> 3.6.0)
+    rspec-support (3.6.0)
+    rubocop (0.50.0)
+      parallel (~> 1.10)
+      parser (>= 2.3.3.1, < 3.0)
       powerpack (~> 0.1)
-      rainbow (>= 1.99.1, < 3.0)
+      rainbow (>= 2.2.2, < 3.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (~> 1.0, >= 1.0.1)
-    ruby-progressbar (1.8.1)
-    rubyzip (1.2.0)
-    selenium-webdriver (2.53.4)
+    ruby-progressbar (1.9.0)
+    rubyzip (1.2.1)
+    selenium-webdriver (3.6.0)
       childprocess (~> 0.5)
       rubyzip (~> 1.0)
-      websocket (~> 1.0)
     semver2 (3.4.2)
-    simplecov (0.12.0)
+    simplecov (0.13.0)
       docile (~> 1.1.0)
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.0)
-    sinatra (1.4.7)
+    simplecov-html (0.10.2)
+    sinatra (1.4.8)
       rack (~> 1.5)
       rack-protection (~> 1.4)
       tilt (>= 1.3, < 3)
     thread_safe (0.3.6)
-    tilt (2.0.5)
-    tzinfo (1.2.2)
+    tilt (2.0.8)
+    tzinfo (1.2.3)
       thread_safe (~> 0.1)
-    unicode-display_width (1.1.0)
+    unicode-display_width (1.3.0)
     virtus (1.0.5)
       axiom-types (~> 0.1)
       coercible (~> 1.0)
       descendants_tracker (~> 0.0, >= 0.0.3)
       equalizer (~> 0.0, >= 0.0.9)
-    watir-webdriver (0.9.3)
+    watir-webdriver (0.9.9)
       selenium-webdriver (>= 2.46.2)
-    websocket (1.2.3)
-    websocket-driver (0.6.4)
+    websocket-driver (0.7.0)
       websocket-extensions (>= 0.1.0)
     websocket-extensions (0.1.2)
-    xpath (2.0.0)
+    xpath (2.1.0)
       nokogiri (~> 1.3)
-    yard (0.9.5)
+    yard (0.9.9)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  activesupport (~> 4)
+  activesupport-inflector
   arbre
   capybara (>= 2.5)
   codeclimate-test-reporter

data/Rakefile

@@ -19,4 +19,12 @@ end
 
 Jeweler::RubygemsDotOrgTasks.new
 
-task default: [:spec, 'rubocop:auto_correct']
+require 'rake/testtask'
+Rake::TestTask.new do |t|
+  t.libs << 'spec'
+  t.pattern = 'spec/**/*_test.rb'
+  t.warning = true
+  t.verbose = true
+end
+
+task default: [:spec, :test, 'rubocop:auto_correct']

data/VERSION

@@ -1 +1 @@
-1.2.8
+1.2.9

data/circle.yml

@@ -3,4 +3,6 @@ machine:
     version: '2.2'
 test:
   override:
-    - bundle exec rake
+    - bundle exec rake
+  post:
+    - CODECLIMATE_REPO_TOKEN=$CODECLIMATE_REPO_TOKEN bundle exec codeclimate-test-reporter

data/lib/active_support/core_ext/object/to_query.rb

@@ -0,0 +1,84 @@
+require 'cgi'
+
+class Object
+  # Alias of <tt>to_s</tt>.
+  def to_param
+    to_s
+  end
+
+  # Converts an object into a string suitable for use as a URL query string,
+  # using the given <tt>key</tt> as the param name.
+  def to_query(key)
+    "#{CGI.escape(key.to_param)}=#{CGI.escape(to_param.to_s)}"
+  end
+end
+
+class NilClass
+  # Returns +self+.
+  def to_param
+    self
+  end
+end
+
+class TrueClass
+  # Returns +self+.
+  def to_param
+    self
+  end
+end
+
+class FalseClass
+  # Returns +self+.
+  def to_param
+    self
+  end
+end
+
+class Array
+  # Calls <tt>to_param</tt> on all its elements and joins the result with
+  # slashes. This is used by <tt>url_for</tt> in Action Pack.
+  def to_param
+    collect(&:to_param).join '/'
+  end
+
+  # Converts an array into a string suitable for use as a URL query string,
+  # using the given +key+ as the param name.
+  #
+  #   ['Rails', 'coding'].to_query('hobbies') # => "hobbies%5B%5D=Rails&hobbies%5B%5D=coding"
+  def to_query(key)
+    prefix = "#{key}[]"
+
+    if empty?
+      nil.to_query(prefix)
+    else
+      collect { |value| value.to_query(prefix) }.join '&'
+    end
+  end
+end
+
+class Hash
+  # Returns a string representation of the receiver suitable for use as a URL
+  # query string:
+  #
+  #   {name: 'David', nationality: 'Danish'}.to_query
+  #   # => "name=David&nationality=Danish"
+  #
+  # An optional namespace can be passed to enclose key names:
+  #
+  #   {name: 'David', nationality: 'Danish'}.to_query('user')
+  #   # => "user%5Bname%5D=David&user%5Bnationality%5D=Danish"
+  #
+  # The string pairs "key=value" that conform the query string
+  # are sorted lexicographically in ascending order.
+  #
+  # This method is also aliased as +to_param+.
+  def to_query(namespace = nil)
+    collect do |key, value|
+      unless (value.is_a?(Hash) || value.is_a?(Array)) && value.empty?
+        value.to_query(namespace ? "#{namespace}[#{key}]" : key)
+      end
+    end.compact.sort! * '&'
+  end
+
+  alias to_param to_query
+end

data/lib/page_magic.rb

@@ -31,7 +31,8 @@ module PageMagic
     def included(clazz)
       clazz.class_eval do
         include(InstanceMethods)
-        extend(Elements, ClassMethods)
+        extend ClassMethods
+        extend Elements
       end
     end
 

data/lib/page_magic/drivers.rb

@@ -1,4 +1,5 @@
 require 'page_magic/driver'
+require 'page_magic/utils/string'
 module PageMagic
   # class Drivers - creates an object that can be used to hold driver definitions
   # These PageMagic gets the user's chosen driver from this object.
@@ -16,12 +17,10 @@ module PageMagic
     # Loads drivers defined in files at the given path
     # @param [String] path where the drivers are located
     def load(path = "#{__dir__}/drivers")
-      require 'active_support/inflector'
-
       Dir["#{path}/*.rb"].each do |driver_file|
         require driver_file
         driver_name = File.basename(driver_file)[/(.*)\.rb$/, 1]
-        register self.class.const_get(driver_name.classify)
+        register self.class.const_get(Utils::String.classify(driver_name))
       end
     end
 

data/lib/page_magic/element.rb

@@ -6,12 +6,18 @@ require 'page_magic/element/query_builder'
 module PageMagic
   # class Element - represents an element in a html page.
   class Element
-    EVENT_TYPES = [:set, :select, :select_option, :unselect_option, :click].freeze
+    EVENT_TYPES = %i[set select select_option unselect_option click].freeze
     DEFAULT_HOOK = proc {}.freeze
     EVENT_NOT_SUPPORTED_MSG = '%s event not supported'.freeze
 
-    include SelectorMethods, Watchers, SessionMethods, WaitMethods, Locators
-    extend Elements, SelectorMethods, Forwardable
+    include Locators
+    include WaitMethods
+    include SessionMethods
+    include Watchers
+    include SelectorMethods
+    extend Forwardable
+    extend SelectorMethods
+    extend Elements
 
     attr_reader :type, :name, :parent_element, :browser_element, :before_events, :after_events
 
@@ -24,7 +30,7 @@ module PageMagic
       # @!method before_events
       # If a block is passed in, it adds it to be run before an event is triggered on an element.
       # @see .after_events
-      %i(after_events before_events).each do |method|
+      %i[after_events before_events].each do |method|
         define_method method do |&block|
           instance_variable_name = "@#{method}".to_sym
           instance_variable_value = instance_variable_get(instance_variable_name) || [DEFAULT_HOOK]

data/lib/page_magic/elements.rb

@@ -14,7 +14,7 @@ module PageMagic
 
     INVALID_METHOD_NAME_MSG = 'a method already exists with this method name'.freeze
 
-    TYPES = [:text_field, :button, :link, :checkbox, :select_list, :radio, :textarea].collect do |type|
+    TYPES = %i[text_field button link checkbox select_list radio textarea].collect do |type|
       [type, :"#{type}s"]
     end.flatten.freeze
 

data/lib/page_magic/instance_methods.rb

@@ -3,7 +3,10 @@ module PageMagic
   module InstanceMethods
     attr_reader :browser, :session, :browser_element
 
-    include Watchers, SessionMethods, WaitMethods, Element::Locators
+    include Element::Locators
+    include WaitMethods
+    include SessionMethods
+    include Watchers
 
     # Creates a new instance
     # @param [Session] session session that provides gateway to the browser throw the users chosen browser

data/lib/page_magic/matcher.rb

@@ -44,7 +44,7 @@ module PageMagic
     # @param [Matcher] other
     # @return [Fixnum] -1 = smaller, 0 = equal to, 1 = greater than
     def <=>(other)
-      results = [:path, :parameters, :fragment].collect do |component|
+      results = %i[path parameters fragment].collect do |component|
         compare(send(component), other.send(component))
       end
       results.find { |result| !result.zero? } || 0
@@ -113,7 +113,7 @@ module PageMagic
 
     def query_string_valid?(string)
       return true unless parameters
-      !parameters.any? do |key, value|
+      parameters.none? do |key, value|
         !compatible?(parameters_hash(string)[key.downcase.to_s], value)
       end
     end

data/lib/page_magic/utils/string.rb

@@ -0,0 +1,12 @@
+module PageMagic
+  module Utils
+    # module String - contains methods for manipulating strings
+    module String
+      class << self
+        def classify(string_or_symbol)
+          string_or_symbol.to_s.split('_').collect(&:capitalize).reduce(:+)
+        end
+      end
+    end
+  end
+end

data/page_magic.gemspec

@@ -2,11 +2,11 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: page_magic 1.2.8 ruby lib
+# stub: page_magic 1.2.9 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "page_magic"
-  s.version = "1.2.8"
+  s.version = "1.2.9"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
@@ -30,6 +30,7 @@ Gem::Specification.new do |s|
     "Rakefile",
     "VERSION",
     "circle.yml",
+    "lib/active_support/core_ext/object/to_query.rb",
     "lib/page_magic.rb",
     "lib/page_magic/class_methods.rb",
     "lib/page_magic/driver.rb",
@@ -51,11 +52,13 @@ Gem::Specification.new do |s|
     "lib/page_magic/matcher.rb",
     "lib/page_magic/session.rb",
     "lib/page_magic/session_methods.rb",
+    "lib/page_magic/utils/string.rb",
     "lib/page_magic/wait_methods.rb",
     "lib/page_magic/watcher.rb",
     "lib/page_magic/watchers.rb",
     "page_magic.gemspec",
     "spec/element_spec.rb",
+    "spec/lib/active_support/core_ext/object/to_query_test.rb",
     "spec/page_magic/class_methods_spec.rb",
     "spec/page_magic/driver_spec.rb",
     "spec/page_magic/drivers/poltergeist_spec.rb",
@@ -73,6 +76,7 @@ Gem::Specification.new do |s|
     "spec/page_magic/matcher_spec.rb",
     "spec/page_magic/session_methods_spec.rb",
     "spec/page_magic/session_spec.rb",
+    "spec/page_magic/utils/string_spec.rb",
     "spec/page_magic/wait_methods_spec.rb",
     "spec/page_magic/watchers_spec.rb",
     "spec/page_magic_spec.rb",
@@ -95,30 +99,30 @@ Gem::Specification.new do |s|
     s.specification_version = 4
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
+      s.add_runtime_dependency(%q<activesupport-inflector>, [">= 0"])
       s.add_runtime_dependency(%q<capybara>, [">= 2.5"])
-      s.add_runtime_dependency(%q<activesupport>, ["~> 4"])
+      s.add_development_dependency(%q<github-markup>, ["~> 1.4"])
       s.add_development_dependency(%q<jeweler>, ["~> 2.0"])
+      s.add_development_dependency(%q<redcarpet>, ["~> 3.3"])
       s.add_development_dependency(%q<rubocop>, ["~> 0.34"])
       s.add_development_dependency(%q<yard>, ["~> 0.8"])
-      s.add_development_dependency(%q<redcarpet>, ["~> 3.3"])
-      s.add_development_dependency(%q<github-markup>, ["~> 1.4"])
     else
+      s.add_dependency(%q<activesupport-inflector>, [">= 0"])
       s.add_dependency(%q<capybara>, [">= 2.5"])
-      s.add_dependency(%q<activesupport>, ["~> 4"])
+      s.add_dependency(%q<github-markup>, ["~> 1.4"])
       s.add_dependency(%q<jeweler>, ["~> 2.0"])
+      s.add_dependency(%q<redcarpet>, ["~> 3.3"])
       s.add_dependency(%q<rubocop>, ["~> 0.34"])
       s.add_dependency(%q<yard>, ["~> 0.8"])
-      s.add_dependency(%q<redcarpet>, ["~> 3.3"])
-      s.add_dependency(%q<github-markup>, ["~> 1.4"])
     end
   else
+    s.add_dependency(%q<activesupport-inflector>, [">= 0"])
     s.add_dependency(%q<capybara>, [">= 2.5"])
-    s.add_dependency(%q<activesupport>, ["~> 4"])
+    s.add_dependency(%q<github-markup>, ["~> 1.4"])
     s.add_dependency(%q<jeweler>, ["~> 2.0"])
+    s.add_dependency(%q<redcarpet>, ["~> 3.3"])
     s.add_dependency(%q<rubocop>, ["~> 0.34"])
     s.add_dependency(%q<yard>, ["~> 0.8"])
-    s.add_dependency(%q<redcarpet>, ["~> 3.3"])
-    s.add_dependency(%q<github-markup>, ["~> 1.4"])
   end
 end
 

data/spec/lib/active_support/core_ext/object/to_query_test.rb

@@ -0,0 +1,78 @@
+# frozen_string_literal: true
+
+require 'minitest'
+Minitest.autorun
+require 'active_support/core_ext/object/to_query'
+
+class ToQueryTest < ::Minitest::Test
+  def test_simple_conversion
+    assert_query_equal 'a=10', a: 10
+  end
+
+  def test_cgi_escaping
+    assert_query_equal 'a%3Ab=c+d', 'a:b' => 'c d'
+  end
+
+  def test_nil_parameter_value
+    empty = Object.new
+    def empty.to_param
+      nil
+    end
+    assert_query_equal 'a=', 'a' => empty
+  end
+
+  def test_nested_conversion
+    assert_query_equal 'person%5Blogin%5D=seckar&person%5Bname%5D=Nicholas',
+                       person: Hash[:login, 'seckar', :name, 'Nicholas']
+  end
+
+  def test_multiple_nested
+    assert_query_equal 'account%5Bperson%5D%5Bid%5D=20&person%5Bid%5D=10',
+                       Hash[:account, { person: { id: 20 } }, :person, { id: 10 }]
+  end
+
+  def test_array_values
+    assert_query_equal 'person%5Bid%5D%5B%5D=10&person%5Bid%5D%5B%5D=20',
+                       person: { id: [10, 20] }
+  end
+
+  def test_array_values_are_not_sorted
+    assert_query_equal 'person%5Bid%5D%5B%5D=20&person%5Bid%5D%5B%5D=10',
+                       person: { id: [20, 10] }
+  end
+
+  def test_empty_array
+    assert_equal 'person%5B%5D=', [].to_query('person')
+  end
+
+  def test_nested_empty_hash
+    assert_equal '',
+                 {}.to_query
+    assert_query_equal 'a=1&b%5Bc%5D=3',
+                       a: 1, b: { c: 3, d: {} }
+    assert_query_equal '',
+                       a: { b: { c: {} } }
+    assert_query_equal 'b%5Bc%5D=false&b%5Be%5D=&b%5Bf%5D=&p=12',
+                       p: 12, b: { c: false, e: nil, f: '' }
+    assert_query_equal 'b%5Bc%5D=3&b%5Bf%5D=',
+                       b: { c: 3, k: {}, f: '' }
+    assert_query_equal 'b=3',
+                       a: [], b: 3
+  end
+
+  def test_hash_with_namespace
+    hash = { name: 'Nakshay', nationality: 'Indian' }
+    assert_equal 'user%5Bname%5D=Nakshay&user%5Bnationality%5D=Indian', hash.to_query('user')
+  end
+
+  def test_hash_sorted_lexicographically
+    hash = { type: 'human', name: 'Nakshay' }
+    assert_equal 'name=Nakshay&type=human', hash.to_query
+  end
+
+  private
+
+  def assert_query_equal(expected, actual)
+    assert_equal expected.split('&'), actual.to_query.split('&')
+  end
+end

data/spec/page_magic/element/query_spec.rb

@@ -18,7 +18,7 @@ module PageMagic
           end
 
           it 'raises an error' do
-            expected_message = 'Unable to find css "wrong"'
+            expected_message = 'Unable to find visible css "wrong"'
             expect { subject.execute(page.browser) }.to raise_exception(ElementMissingException, expected_message)
           end
         end
@@ -29,7 +29,7 @@ module PageMagic
           end
 
           it 'raises an error' do
-            expected_message = 'Ambiguous match, found 2 elements matching css "a"'
+            expected_message = 'Ambiguous match, found 2 elements matching visible css "a"'
             expect { subject.execute(page.browser) }.to raise_error AmbiguousQueryException, expected_message
           end
         end

data/spec/page_magic/element/selector_spec.rb

@@ -33,7 +33,7 @@ module PageMagic
             described_class.new(supports_type: true)
           end
           it 'includes the element type in the result' do
-            expect(subject.build(:field, :locator)).to eq([:field, :locator])
+            expect(subject.build(:field, :locator)).to eq(%i[field locator])
           end
         end
 
@@ -54,7 +54,7 @@ module PageMagic
           end
 
           it 'is added to the result' do
-            expect(subject.build(:field, :locator)).to eq([:css, :locator])
+            expect(subject.build(:field, :locator)).to eq(%i[css locator])
           end
         end
       end

data/spec/page_magic/elements_spec.rb

@@ -113,8 +113,7 @@ module PageMagic
             subject.class_eval do
               link(:hello, text: 'world')
 
-              def hello
-              end
+              def hello; end
             end
           end.to raise_error(InvalidMethodNameException)
         end
@@ -122,8 +121,7 @@ module PageMagic
         it 'should not allow element names that match method names' do
           expect do
             subject.class_eval do
-              def hello
-              end
+              def hello; end
 
               link(:hello, text: 'world')
             end

data/spec/page_magic/session_spec.rb

@@ -124,7 +124,7 @@ module PageMagic
       context 'more than one match on path' do
         it 'orders the results by specificity ' do
           subject.define_page_mappings %r{/page} => :mapped_page_using_regex, '/page' => :mapped_page_using_string
-          expected_result = [:mapped_page_using_string, :mapped_page_using_regex]
+          expected_result = %i[mapped_page_using_string mapped_page_using_regex]
           expect(subject.instance_eval { matches('/page') }).to eq(expected_result)
         end
       end
@@ -155,8 +155,7 @@ module PageMagic
 
       it 'checks the current page' do
         page.class_eval do
-          def my_method
-          end
+          def my_method; end
         end
         expect(subject.respond_to?(:my_method)).to eq(true)
       end

data/spec/page_magic/utils/string_spec.rb

@@ -0,0 +1,34 @@
+require 'page_magic/utils/string'
+module PageMagic
+  module Utils
+    describe String do
+      describe '.classify' do
+        context 'parameter is symbol' do
+          it 'returns a string' do
+            expect(described_class.classify(:Symbol)).to eq('Symbol')
+          end
+        end
+
+        context 'parameter is string' do
+          it 'returns a string' do
+            expect(described_class.classify(:String)).to eq('String')
+          end
+        end
+
+        context 'single word' do
+          context 'first letter is lower case' do
+            it 'converts the first letter to uppercase' do
+              expect(described_class.classify(:symbol)).to eq('Symbol')
+            end
+          end
+        end
+
+        context 'snakecase' do
+          it 'removes underscores and capitalises each word' do
+            expect(described_class.classify(:snake_case)).to eq('SnakeCase')
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: page_magic
 version: !ruby/object:Gem::Version
-  version: 1.2.8
+  version: 1.2.9
 platform: ruby
 authors:
 - Leon Davis
@@ -11,103 +11,103 @@ cert_chain: []
 date: 2017-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: capybara
+  name: activesupport-inflector
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: capybara
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4'
+        version: '2.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4'
+        version: '2.5'
 - !ruby/object:Gem::Dependency
-  name: jeweler
+  name: github-markup
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.4'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: jeweler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.34'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.34'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: yard
+  name: redcarpet
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '3.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '3.3'
 - !ruby/object:Gem::Dependency
-  name: redcarpet
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '0.34'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '0.34'
 - !ruby/object:Gem::Dependency
-  name: github-markup
+  name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '0.8'
 description: Framework for modeling and interacting with webpages which wraps capybara
 email: info@lad-tech.com
 executables: []
@@ -127,6 +127,7 @@ files:
 - Rakefile
 - VERSION
 - circle.yml
+- lib/active_support/core_ext/object/to_query.rb
 - lib/page_magic.rb
 - lib/page_magic/class_methods.rb
 - lib/page_magic/driver.rb
@@ -148,11 +149,13 @@ files:
 - lib/page_magic/matcher.rb
 - lib/page_magic/session.rb
 - lib/page_magic/session_methods.rb
+- lib/page_magic/utils/string.rb
 - lib/page_magic/wait_methods.rb
 - lib/page_magic/watcher.rb
 - lib/page_magic/watchers.rb
 - page_magic.gemspec
 - spec/element_spec.rb
+- spec/lib/active_support/core_ext/object/to_query_test.rb
 - spec/page_magic/class_methods_spec.rb
 - spec/page_magic/driver_spec.rb
 - spec/page_magic/drivers/poltergeist_spec.rb
@@ -170,6 +173,7 @@ files:
 - spec/page_magic/matcher_spec.rb
 - spec/page_magic/session_methods_spec.rb
 - spec/page_magic/session_spec.rb
+- spec/page_magic/utils/string_spec.rb
 - spec/page_magic/wait_methods_spec.rb
 - spec/page_magic/watchers_spec.rb
 - spec/page_magic_spec.rb