page_magic 1.0.0.alpha4 → 1.0.0.alpha5

data/spec/page_magic/element_context_spec.rb

@@ -1,12 +1,11 @@
 describe PageMagic::ElementContext do
-
   include_context :webapp
 
   let!(:page1) do
     Class.new do
       include PageMagic
       url '/page1'
-      link(:next, :text => "next page")
+      link(:next, text: 'next page')
     end
   end
 
@@ -14,7 +13,7 @@ describe PageMagic::ElementContext do
     Class.new do
       include PageMagic
       url '/elements'
-      link(:a_link, :text => "a link")
+      link(:a_link, text: 'a link')
     end
   end
 
@@ -23,11 +22,10 @@ describe PageMagic::ElementContext do
   end
 
   describe 'resolving field definitions' do
-
     it 'should only evaluate the targeted field definition' do
       page1.class_eval do
         link(:link, :selector) do
-          fail("should not have been evaluated")
+          fail('should not have been evaluated')
         end
       end
       page = page1.new
@@ -63,7 +61,6 @@ describe PageMagic::ElementContext do
 
   describe 'accessing page sections' do
     it 'should go through page sections' do
-
       elements_page.class_eval do
         section :form do
           selector css: '.form'
@@ -77,20 +74,14 @@ describe PageMagic::ElementContext do
       described_class.new(page, page.browser, self).form
     end
 
-
     it 'should delegate to page element if method not found' do
-      #TODO call page method, look for subelement, delagate to capybara object
+      # TODO: call page method, look for subelement, delagate to capybara object
     end
   end
 
-
-
   describe 'hooks' do
-
     subject(:page) do
-      elements_page.new.tap do|p|
-        p.visit
-      end
+      elements_page.new.tap(&:visit)
     end
 
     before do
@@ -99,20 +90,14 @@ describe PageMagic::ElementContext do
       browser.should_receive(:call_in_after_before_hook)
     end
 
-
     context 'section' do
       it 'applies the hooks' do
-
         elements_page.section(:form, id: 'form') do
           link :form_link, id: 'form_link'
 
-          before do |page_browser|
-            page_browser.call_in_before_hook
-          end
+          before(&:call_in_before_hook)
 
-          after do |page_browser|
-            page_browser.call_in_after_before_hook
-          end
+          after(&:call_in_after_before_hook)
         end
 
         described_class.new(page, page.browser, self).form.click
@@ -121,18 +106,21 @@ describe PageMagic::ElementContext do
 
     it 'should execute a before and after action that gives access to the browser' do
       elements_page.link(:create, text: 'a link') do
-        before do |page_browser|
-          page_browser.call_in_before_hook
-        end
+        before(&:call_in_before_hook)
 
-        after do |page_browser|
-          page_browser.call_in_after_before_hook
-        end
+        after(&:call_in_after_before_hook)
       end
 
       described_class.new(page, page.browser, self).create.click
     end
-
   end
 
+  describe '#respond_to?' do
+    subject do
+      described_class.new(page1.new(session), session, self)
+    end
+    it 'checks against the names of the elements passed in' do
+      expect(subject.respond_to?(:next)).to eq(true)
+    end
+  end
 end

data/spec/page_magic/elements_spec.rb

@@ -1,20 +1,17 @@
 describe PageMagic::Elements do
-
-
   let(:page_elements) do
     Class.new do
       extend(PageMagic::Elements)
     end
   end
 
-  let(:selector) { {id: 'id'} }
+  let(:selector) { { id: 'id' } }
   let(:browser_element) { double('browser_element', find: :browser_element) }
   let(:parent_page_element) do
     double('parent_page_element', browser_element: browser_element)
   end
 
   describe 'adding elements' do
-
     context 'using a selector' do
       it 'should add an element' do
         expected_element = PageMagic::Element.new(:name, parent_page_element, type: :text_field, selector: selector)
@@ -24,17 +21,12 @@ describe PageMagic::Elements do
     end
 
     context 'complex elements' do
-
-
       let!(:section_class) do
         Class.new(PageMagic::Element) do
-
-          def == other
-
-            other.name == self.name &&
-                other.browser_element == self.browser_element
+          def ==(other)
+            other.name == name &&
+              other.browser_element == browser_element
           end
-
         end
       end
 
@@ -51,7 +43,6 @@ describe PageMagic::Elements do
             section_class.stub(:name).and_return('PageSection')
             page_elements.section section_class, selector
             page_elements.elements(parent_page_element).first.name.should == :page_section
-
           end
         end
 
@@ -60,13 +51,12 @@ describe PageMagic::Elements do
         end
       end
 
-
       context 'using a block' do
-
         context 'browser_element' do
           before :each do
-
-            @browser, @element, @parent_page_element = double('browser'), double('element'), double('parent_page_element')
+            @browser = double('browser')
+            @element = double('element')
+            @parent_page_element = double('parent_page_element')
             @parent_page_element.stub(:browser_element).and_return(@browser)
             @browser.should_receive(:find).with(:css, :selector).and_return(@element)
           end
@@ -93,26 +83,24 @@ describe PageMagic::Elements do
           end
         end
 
-
         it 'should pass args through to the block' do
           page_elements.section :page_section, css: '.blah' do |arg|
             arg[:passed_through] = true
           end
 
-          arg, browser = {}, double('browser', find: :browser_element)
+          arg = {}
+          browser = double('browser', find: :browser_element)
           parent_page_element = double('parent_browser_element', browser_element: browser)
           page_elements.elements(parent_page_element, arg)
           arg[:passed_through].should be_true
         end
 
-
         it 'should return your a copy of the core definition' do
           page_elements.section section_class, :page_section, selector
           first = page_elements.element_definitions[:page_section].call(parent_page_element)
           second = page_elements.element_definitions[:page_section].call(parent_page_element)
           first.should_not equal(second)
         end
-
       end
 
       describe 'location' do
@@ -134,17 +122,14 @@ describe PageMagic::Elements do
           section = page_elements.element_definitions[:page_section].call(parent)
 
           section.session.should == :current_session
-
         end
 
         it 'should be on instances created dynamically using the section method' do
-
           browser_element = double('browser_element')
           browser_element.stub(:find)
           parent = double('parent', session: :current_session, browser_element: browser_element)
 
           page_elements.section :page_section, css: :selector do
-
           end
 
           section = page_elements.element_definitions[:page_section].call(parent)
@@ -163,15 +148,13 @@ describe PageMagic::Elements do
     end
   end
 
-
-
   describe 'restrictions' do
     it 'should not allow method names that match element names' do
       expect do
         page_elements.class_eval do
           link(:hello, text: 'world')
 
-          def hello;
+          def hello
           end
         end
       end.to raise_error(PageMagic::Elements::InvalidMethodNameException)
@@ -180,7 +163,7 @@ describe PageMagic::Elements do
     it 'should not allow element names that match method names' do
       expect do
         page_elements.class_eval do
-          def hello;
+          def hello
           end
 
           link(:hello, text: 'world')
@@ -200,10 +183,10 @@ describe PageMagic::Elements do
     it 'should not evaluate the elements when applying naming checks' do
       page_elements.class_eval do
         link(:link1, :selector) do
-          fail("should not have been evaluated")
+          fail('should not have been evaluated')
         end
         link(:link2, :selector)
       end
     end
   end
-end
+end

data/spec/page_magic/page_magic_spec.rb

@@ -0,0 +1,19 @@
+describe PageMagic do
+  context '#respond_to?' do
+    subject do
+      page_class = Class.new do
+        include PageMagic
+        element :sub_element, id: 'sub-element'
+      end
+      page_class.new
+    end
+
+    it 'checks self' do
+      expect(subject.respond_to?(:visit)).to eq(true)
+    end
+
+    it 'checks the current page' do
+      expect(subject.respond_to?(:sub_element)).to eq(true)
+    end
+  end
+end

data/spec/page_magic/session_spec.rb

@@ -1,45 +1,50 @@
 describe PageMagic::Session do
-
   let(:page) do
     Class.new do
       include PageMagic
       url '/page1'
-
-      def my_method
-        :called
-      end
     end
   end
 
-  let(:another_page_class) do
-    Class.new do
-      include PageMagic
-      url '/another_page1'
+  subject { PageMagic::Session.new(browser) }
+
+  let(:browser) { double('browser', current_url: 'url', visit: nil, current_path: :current_path) }
+
+  describe '#current_url' do
+    it "returns the browser's current url" do
+      expect(subject.current_url).to eq(browser.current_url)
     end
   end
 
-  let(:browser) { double('browser', current_url: 'url') }
+  describe '#current_path' do
+    it "returns the browser's current path" do
+      expect(subject.current_path).to eq(browser.current_path)
+    end
+  end
 
   describe '#current_page' do
-    subject do
-      PageMagic::Session.new(browser).tap do |session|
-        session.define_page_mappings '/another_page1' => another_page_class
+    let(:another_page_class) do
+      Class.new do
+        include PageMagic
+        url '/another_page1'
       end
     end
+
+    before do
+      subject.define_page_mappings another_page_class.url => another_page_class
+      subject.visit(page)
+    end
+
     context 'page url has not changed' do
       it 'returns the original page' do
-        browser.should_receive(:visit).with(page.url)
-        allow(browser).to receive(:current_path).and_return('/page1')
-        subject.visit(page)
+        allow(browser).to receive(:current_path).and_return(page.url)
         expect(subject.current_page).to be_an_instance_of(page)
       end
     end
 
     context 'page url has changed' do
       it 'returns the mapped page object' do
-        browser.should_receive(:visit).with(page.url)
-        subject.visit(page)
-        allow(browser).to receive(:current_path).and_return('/another_page1')
+        allow(browser).to receive(:current_path).and_return(another_page_class.url)
         expect(subject.current_page).to be_an_instance_of(another_page_class)
       end
     end
@@ -75,29 +80,45 @@ describe PageMagic::Session do
       it 'uses this url instead of the one defined on the page class' do
         expect(browser).to receive(:visit).with(:custom_url)
         session = PageMagic::Session.new(browser).visit(page, url: :custom_url)
-        session.current_page.should be_a(page)
+        expect(session.current_page).to be_a(page)
       end
     end
 
     it 'visits the url on defined on the page class' do
       browser.should_receive(:visit).with(page.url)
       session = PageMagic::Session.new(browser).visit(page)
-      session.current_page.should be_a(page)
+      expect(session.current_page).to be_a(page)
     end
   end
 
-
-
-  it 'should return the current url' do
-    session = PageMagic::Session.new(browser)
-    session.current_url.should == 'url'
-  end
-
-  context 'method_missing' do
+  context '#method_missing' do
     it 'should delegate to current page' do
-      browser.stub(:visit)
+      page.class_eval do
+        def my_method
+          :called
+        end
+      end
+
       session = PageMagic::Session.new(browser).visit(page)
       session.my_method.should be(:called)
     end
   end
-end
+
+  context '#respond_to?' do
+    subject do
+      PageMagic::Session.new(browser).tap do |s|
+        s.current_page = page.new
+      end
+    end
+    it 'checks self' do
+      expect(subject.respond_to?(:current_url)).to eq(true)
+    end
+
+    it 'checks the current page' do
+      page.class_eval do
+        def my_method; end
+      end
+      expect(subject.respond_to?(:my_method)).to eq(true)
+    end
+  end
+end

data/spec/page_magic/usage/defining_pages_spec.rb

@@ -1,14 +1,12 @@
 describe 'The Elements of a Page' do
-
   describe 'instances' do
-
     include_context :webapp
 
     let(:my_page_class) do
       Class.new do
         include PageMagic
         url '/page1'
-        link(:next, :text => "next page")
+        link(:next, text: 'next page')
       end
     end
 
@@ -23,7 +21,6 @@ describe 'The Elements of a Page' do
       @page = my_page_class.new
     end
 
-
     describe 'browser integration' do
       it "should use capybara's default session if a one is not supplied" do
         Capybara.default_driver = :rack_test
@@ -31,7 +28,6 @@ describe 'The Elements of a Page' do
       end
     end
 
-
     it 'should copy fields on to element' do
       new_page = my_page_class.new
       @page.element_definitions[:next].call(@page).should_not equal(new_page.element_definitions[:next].call(new_page))
@@ -59,7 +55,7 @@ describe 'The Elements of a Page' do
     let(:parent_page) do
       Class.new do
         include PageMagic
-        link(:next, :text => "next page")
+        link(:next, text: 'next page')
       end
     end
 
@@ -82,4 +78,4 @@ describe 'The Elements of a Page' do
       end
     end
   end
-end
+end

data/spec/page_magic/usage/include_page_magic_spec.rb

@@ -3,7 +3,7 @@ describe 'including PageMagic' do
 
   context 'lets you define pages' do
     let :page_class do
-      Class.new{include PageMagic}
+      Class.new { include PageMagic }
     end
 
     it 'gives a method for defining the url' do
@@ -15,4 +15,4 @@ describe 'including PageMagic' do
       page_class.is_a?(PageMagic::Elements).should be_true
     end
   end
-end
+end

data/spec/page_magic/usage/interacting_with_pages_spec.rb

@@ -51,6 +51,4 @@ describe 'interacting with pages' do
       page.next_page.tag_name.should == 'a'
     end
   end
-
 end
-

data/spec/page_magic/usage/starting_a_session_spec.rb

@@ -1,14 +1,13 @@
 describe 'PageMagic.session' do
-
   let(:app_class) do
     Class.new do
-      def call env
-        [200, {}, ["hello world!!"]]
+      def call(_env)
+        [200, {}, ['hello world!!']]
       end
     end
   end
 
-  def registered_driver browser
+  def registered_driver(browser)
     Capybara.drivers[browser].call(nil)
   end
 
@@ -20,7 +19,6 @@ describe 'PageMagic.session' do
   end
 
   context 'testing against rack applications' do
-
     it 'requires the app to be supplied' do
       session = PageMagic.session(application: app_class.new)
       session.raw_session.visit('/')
@@ -34,5 +32,4 @@ describe 'PageMagic.session' do
       session.raw_session.text.should == 'hello world!!'
     end
   end
-
-end
+end

data/spec/page_magic_spec.rb

@@ -3,9 +3,7 @@ require 'page_magic'
 describe PageMagic do
   describe '::drivers' do
     it 'returns loaded drivers' do
-      expected_drivers = described_class::Drivers.new.tap do |drivers|
-        drivers.load
-      end
+      expected_drivers = described_class::Drivers.new.tap(&:load)
 
       expect(described_class.drivers).to eq(expected_drivers)
     end
@@ -28,7 +26,7 @@ describe PageMagic do
 
     context 'specifying options' do
       it 'passes the options to the browser driver' do
-        options = {option: :config}
+        options = { option: :config }
         session = described_class.session(options: options, browser: :chrome)
 
         expect(session.raw_session.driver.options).to include(options)
@@ -37,8 +35,8 @@ describe PageMagic do
 
     context 'driver for browser not found' do
       it 'raises an error' do
-        expect{described_class.session(browser: :invalid)}.to raise_exception described_class::UnspportedBrowserException
+        expect { described_class.session(browser: :invalid) }.to raise_exception described_class::UnspportedBrowserException
       end
     end
   end
-end
+end

data/spec/spec_helper.rb

@@ -3,8 +3,7 @@ $LOAD_PATH.unshift("#{File.dirname(__FILE__)}/lib")
 if ENV['coverage']
   require 'simplecov'
   SimpleCov.start do
-
-    add_filter "/spec/"
+    add_filter '/spec/'
   end
 end
 require 'page_magic'
@@ -21,41 +20,40 @@ end
 shared_context :rack_application do
   let(:rack_application) do
     Class.new do
-      def call env
-        [200, {}, ["hello world!!"]]
+      def call(_env)
+        [200, {}, ['hello world!!']]
       end
     end
   end
 end
 
 RSpec.configure do
-
   module PageMagic
     class Element
       class << self
         def default_before_hook
-          @default_before_hook ||= Proc.new {}
+          @default_before_hook ||= proc {}
         end
 
         def default_after_hook
-          @default_after_hook ||= Proc.new {}
+          @default_after_hook ||= proc {}
         end
       end
       alias_method :initialize_backup, :initialize
-      def initialize *args, &block
+      def initialize(*args, &block)
         initialize_backup *args, &block
-        @before_hook, @after_hook = self.class.default_before_hook, self.class.default_after_hook
+        @before_hook = self.class.default_before_hook
+        @after_hook = self.class.default_after_hook
       end
 
-      def == page_element
+      def ==(page_element)
         page_element.is_a?(Element) &&
-            @type == page_element.type &&
-            @name == page_element.name &&
-            @selector == page_element.selector
-            @before_hook == page_element.before &&
-            @after_hook == page_element.after
+          @type == page_element.type &&
+          @name == page_element.name &&
+          @selector == page_element.selector
+        @before_hook == page_element.before &&
+          @after_hook == page_element.after
       end
-
     end
   end
 
@@ -64,7 +62,6 @@ RSpec.configure do
 
     rack_app = Class.new(Sinatra::Base) do
       get '/page1' do
-
         "<html><head><title>page1</title></head><body><a href='/page2'>next page</a></body></html>"
       end
 
@@ -81,11 +78,9 @@ RSpec.configure do
             <a id='form_link' href='/page2'>a in a form</a>
           </form>
         ELEMENTS
-
       end
     end
 
-
     before :each do
       Capybara.app = rack_app
     end
@@ -94,7 +89,4 @@ RSpec.configure do
       Capybara.reset!
     end
   end
-
 end
-
-