page_magic 1.0.0.alpha13 → 1.0.0.alpha17

data/spec/page_magic_spec.rb

@@ -1,6 +1,45 @@
 require 'page_magic'
 
 describe PageMagic do
+  subject do
+    Class.new { include PageMagic }
+  end
+
+  describe '.included' do
+    it 'gives a method for defining the url' do
+      subject.url :url
+      expect(subject.url).to eq(:url)
+    end
+
+    it 'lets you define elements' do
+      expect(subject).to be_a(PageMagic::Elements)
+    end
+  end
+
+  describe '.inherited' do
+    let(:parent_page) do
+      Class.new do
+        include PageMagic
+        link(:next, text: 'next page')
+      end
+    end
+
+    let(:child_page) do
+      Class.new(parent_page)
+    end
+
+    context 'children' do
+      it 'should inherit elements defined on the parent class' do
+        expect(child_page.element_definitions).to include(:next)
+      end
+
+      it 'should pass on element definitions to their children' do
+        grand_child_class = Class.new(child_page)
+        expect(grand_child_class.element_definitions).to include(:next)
+      end
+    end
+  end
+
   describe '::drivers' do
     it 'returns loaded drivers' do
       expected_drivers = described_class::Drivers.new.tap(&:load)
@@ -10,24 +49,42 @@ describe PageMagic do
   end
 
   describe '::session' do
+    let(:url) { 'http://url.com/' }
+    let(:application) { rack_application.new }
+
+    before do
+      allow_any_instance_of(Capybara::Selenium::Driver).to receive(:visit)
+    end
+
+    it "defaults to capybara's default session " do
+      Capybara.default_driver = :rack_test
+      expect(subject.new.browser.mode).to eq(:rack_test)
+    end
+
     context 'specifying the browser' do
       it 'loads the correct driver' do
-        session = described_class.session(browser: :firefox)
-        session.raw_session.driver.is_a?(Capybara::Selenium::Driver).should be_true
+        session = described_class.session(application: rack_application.new, browser: :firefox, url: :url)
+        expect(session.raw_session.driver).to be_a(Capybara::Selenium::Driver)
       end
     end
 
+    include_context :rack_application
+    it 'sets the base url for the session' do
+      session = described_class.session(application: application, url: url)
+      expect(session.current_url).to eq(url)
+    end
+
     context 'specifying a rack application' do
       it 'configures capybara to run against the app' do
-        session = described_class.session(application: :rack_application)
-        expect(session.raw_session.app).to be(:rack_application)
+        session = described_class.session(application: application, url: url)
+        expect(session.raw_session.app).to be(application)
       end
     end
 
     context 'specifying options' do
       it 'passes the options to the browser driver' do
         options = { option: :config }
-        session = described_class.session(options: options, browser: :chrome)
+        session = described_class.session(options: options, browser: :chrome, url: url)
 
         expect(session.raw_session.driver.options).to include(options)
       end
@@ -35,7 +92,8 @@ describe PageMagic do
 
     context 'driver for browser not found' do
       it 'raises an error' do
-        expect { described_class.session(browser: :invalid) }.to raise_exception described_class::UnspportedBrowserException
+        expected_exception = described_class::UnspportedBrowserException
+        expect { described_class.session(browser: :invalid, url: url) }.to raise_exception expected_exception
       end
     end
   end

data/spec/spec_helper.rb

@@ -1,99 +1,7 @@
 Bundler.require
-$LOAD_PATH.unshift("#{File.dirname(__FILE__)}/lib")
-if ENV['coverage']
-  require 'simplecov'
-  SimpleCov.start do
-    add_filter '/spec/'
-  end
-end
-require 'page_magic'
-require 'capybara/rspec'
-require 'helpers/capybara'
-
-shared_context :files do
-  require 'tmpdir'
-
-  def scratch_dir
-    @dir ||= Dir.mktmpdir
-  end
-end
-
-shared_context :rack_application do
-  let(:rack_application) do
-    Class.new do
-      def call(_env)
-        [200, {}, ['hello world!!']]
-      end
-    end
-  end
-end
-
-RSpec.configure do
-  module PageMagic
-    class Element
-      class << self
-        def default_before_hook
-          @default_before_hook ||= proc {}
-        end
-
-        def default_after_hook
-          @default_after_hook ||= proc {}
-        end
-      end
-      alias_method :initialize_backup, :initialize
-
-      def initialize(*args, &block)
-        initialize_backup *args, &block
-        # @before_hook = self.class.default_before_hook
-        # @after_hook = self.class.default_after_hook
-      end
-
-      def ==(page_element)
-        page_element.is_a?(Element) &&
-            @type == page_element.type &&
-            @name == page_element.name &&
-            @selector == page_element.selector
-        # @before_hook == page_element.before &&
-        #     @after_hook == page_element.after
-      end
-    end
-  end
+$LOAD_PATH.unshift(__dir__, "#{__dir__}/../lib")
 
-  shared_context :webapp do
-    require 'sinatra/base'
+require 'support/shared_contexts'
+require 'simplecov' if ENV['coverage']
 
-    rack_app = Class.new(Sinatra::Base) do
-      get '/page1' do
-        "<html><head><title>page1</title></head><body><a href='/page2'>next page</a></body></html>"
-      end
-
-      get '/page2' do
-        'page 2 content'
-      end
-
-      get '/elements' do
-        <<-ELEMENTS
-          <a href='#'>a link</a>
-
-
-          <div id='form' class="form">
-            <a id='form_link' href='/page2'>link in a form</a>
-            <label>enter text
-              <input id='field_id' name='field_name' class='input_class' type='text' value='filled in'/>
-            </label>
-            <input id='form_button' type='submit' value='a button'/>
-          </form>
-
-        ELEMENTS
-      end
-    end
-
-    before :each do
-      Capybara.app = rack_app
-    end
-
-    after do
-      Capybara.reset!
-    end
-  end
-end
+require 'page_magic'

data/spec/support/shared_contexts/files_context.rb

@@ -0,0 +1,7 @@
+shared_context :files do
+  require 'tmpdir'
+
+  def scratch_dir
+    @dir ||= Dir.mktmpdir
+  end
+end

data/spec/support/shared_contexts/rack_application_context.rb

@@ -0,0 +1,9 @@
+shared_context :rack_application do
+  let(:rack_application) do
+    Class.new do
+      def call(_env)
+        [200, {}, ['hello world!!']]
+      end
+    end
+  end
+end

data/spec/support/shared_contexts/webapp_context.rb

@@ -0,0 +1,37 @@
+shared_context :webapp_fixture do
+  require 'sinatra/base'
+
+  rack_app = Class.new(Sinatra::Base) do
+    get '/page1' do
+      "<html><head><title>page1</title></head><body><a href='/page2'>next page</a></body></html>"
+    end
+
+    get '/page2' do
+      'page 2 content'
+    end
+
+    get '/elements' do
+      <<-ELEMENTS
+          <a href='#'>a link</a>
+
+
+          <div id='form' class="form">
+            <a id='form_link' href='/page2'>link in a form</a>
+            <label>enter text
+              <input id='field_id' name='field_name' class='input_class' type='text' value='filled in'/>
+            </label>
+            <input id='form_button' type='submit' value='a button'/>
+          </form>
+
+      ELEMENTS
+    end
+  end
+
+  before :each do
+    Capybara.app = rack_app
+  end
+
+  after do
+    Capybara.reset!
+  end
+end

data/spec/support/shared_contexts.rb

@@ -0,0 +1,3 @@
+Dir["#{__dir__}/shared_contexts/*.rb"].each do |file|
+  require file
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: page_magic
 version: !ruby/object:Gem::Version
-  version: 1.0.0.alpha13
+  version: 1.0.0.alpha17
 platform: ruby
 authors:
 - Leon Davis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-19 00:00:00.000000000 Z
+date: 2015-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -91,12 +91,12 @@ files:
 - ".rubocop.yml"
 - ".ruby-gemset"
 - ".ruby-version"
+- ".simplecov"
 - Gemfile
 - Gemfile.lock
 - README.md
 - Rakefile
 - VERSION
-- lib/ext/string.rb
 - lib/page_magic.rb
 - lib/page_magic/driver.rb
 - lib/page_magic/drivers.rb
@@ -104,6 +104,10 @@ files:
 - lib/page_magic/drivers/rack_test.rb
 - lib/page_magic/drivers/selenium.rb
 - lib/page_magic/element.rb
+- lib/page_magic/element/method_observer.rb
+- lib/page_magic/element/query.rb
+- lib/page_magic/element/selector.rb
+- lib/page_magic/element/selector_methods.rb
 - lib/page_magic/element_context.rb
 - lib/page_magic/elements.rb
 - lib/page_magic/exceptions.rb
@@ -111,23 +115,24 @@ files:
 - lib/page_magic/session.rb
 - page_magic.gemspec
 - spec/element_spec.rb
-- spec/helpers/capybara.rb
 - spec/member_methods_spec.rb
 - spec/page_magic/driver_spec.rb
 - spec/page_magic/drivers/poltergeist_spec.rb
 - spec/page_magic/drivers/rack_test_spec.rb
 - spec/page_magic/drivers/selenium_spec.rb
 - spec/page_magic/drivers_spec.rb
+- spec/page_magic/element/query_spec.rb
+- spec/page_magic/element/selector_spec.rb
 - spec/page_magic/element_context_spec.rb
 - spec/page_magic/elements_spec.rb
 - spec/page_magic/page_magic_spec.rb
 - spec/page_magic/session_spec.rb
-- spec/page_magic/usage/defining_pages_spec.rb
-- spec/page_magic/usage/include_page_magic_spec.rb
-- spec/page_magic/usage/interacting_with_pages_spec.rb
-- spec/page_magic/usage/starting_a_session_spec.rb
 - spec/page_magic_spec.rb
 - spec/spec_helper.rb
+- spec/support/shared_contexts.rb
+- spec/support/shared_contexts/files_context.rb
+- spec/support/shared_contexts/rack_application_context.rb
+- spec/support/shared_contexts/webapp_context.rb
 homepage: https://github.com/ladtech/page_magic
 licenses:
 - ruby

data/lib/ext/string.rb

@@ -1,9 +0,0 @@
-class String
-  def to_snake_case
-    gsub(/::/, '/')
-      .gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
-      .gsub(/([a-z\d])([A-Z])/, '\1_\2')
-      .tr('-', '_')
-      .downcase
-  end
-end

data/spec/helpers/capybara.rb

@@ -1,10 +0,0 @@
-module Capybara
-  module Selenium
-    class Driver
-      def ==(driver)
-        driver.respond_to?(:options) && options == driver.options &&
-          driver.respond_to?(:app) && app == driver.app
-      end
-    end
-  end
-end

data/spec/page_magic/usage/defining_pages_spec.rb

@@ -1,81 +0,0 @@
-describe 'The Elements of a Page' do
-  describe 'instances' do
-    include_context :webapp
-
-    let(:my_page_class) do
-      Class.new do
-        include PageMagic
-        url '/page1'
-        link(:next, text: 'next page')
-      end
-    end
-
-    let(:another_page_class) do
-      Class.new do
-        include PageMagic
-        url '/another_page1'
-      end
-    end
-
-    before :each do
-      @page = my_page_class.new
-    end
-
-    describe 'browser integration' do
-      it "should use capybara's default session if a one is not supplied" do
-        Capybara.default_driver = :rack_test
-        my_page_class.new.browser.mode.should == :rack_test
-      end
-    end
-
-    it 'should copy fields on to element' do
-      new_page = my_page_class.new
-      @page.element_definitions[:next].call(@page).should_not equal(new_page.element_definitions[:next].call(new_page))
-    end
-
-    it 'gives access to the page text' do
-      @page.visit.text.should == 'next page'
-    end
-
-    it 'should access a field' do
-      @page.visit
-      @page.next.click
-      @page.text.should == 'page 2 content'
-    end
-
-    it 'are registered at class level' do
-      PageMagic.instance_variable_set(:@pages, nil)
-
-      page = Class.new { include PageMagic }
-      PageMagic.pages.should == [page]
-    end
-  end
-
-  describe 'inheritance' do
-    let(:parent_page) do
-      Class.new do
-        include PageMagic
-        link(:next, text: 'next page')
-      end
-    end
-
-    let(:child_page) do
-      Class.new(parent_page)
-    end
-
-    context 'children' do
-      it 'should inherit elements defined on the parent class' do
-        child_page.element_definitions.should include(:next)
-      end
-
-      it 'are added to PageMagic.pages list' do
-        PageMagic.pages.should include(child_page)
-      end
-
-      it 'should pass on element definitions to their children' do
-        grand_child_class = Class.new(child_page)
-        grand_child_class.element_definitions.should include(:next)
-      end
-    end
-  end
-end

data/spec/page_magic/usage/include_page_magic_spec.rb

@@ -1,18 +0,0 @@
-describe 'including PageMagic' do
-  include Capybara::DSL
-
-  context 'lets you define pages' do
-    let :page_class do
-      Class.new { include PageMagic }
-    end
-
-    it 'gives a method for defining the url' do
-      page_class.url :url
-      page_class.url.should == :url
-    end
-
-    it 'lets you define elements' do
-      page_class.is_a?(PageMagic::Elements).should be_true
-    end
-  end
-end

data/spec/page_magic/usage/interacting_with_pages_spec.rb

@@ -1,54 +0,0 @@
-describe 'interacting with pages' do
-  include_context :webapp
-
-  let :page do
-    Class.new do
-      include PageMagic
-      link(:next_page, text: 'next page')
-      url '/page1'
-    end.new
-  end
-
-  before(:each) { page.visit }
-
-  describe 'visit' do
-    it 'goes to the class define url' do
-      page.visit
-      page.session.current_path.should == '/page1'
-    end
-  end
-
-  describe 'session' do
-    it 'gives access to the page magic object wrapping the user session' do
-      page.session.raw_session.should == Capybara.current_session
-    end
-  end
-
-  describe 'text_on_page?' do
-    it 'returns true if the text is present' do
-      page.text_on_page?('next page').should be_true
-    end
-
-    it 'returns false if the text is not present' do
-      page.text_on_page?('not on page').should be_false
-    end
-  end
-
-  describe 'title' do
-    it 'returns the title' do
-      page.title.should == 'page1'
-    end
-  end
-
-  describe 'text' do
-    it 'returns the text on the page' do
-      page.text.should == 'next page'
-    end
-  end
-
-  describe 'method_missing' do
-    it 'gives access to the elements defined on your page classes' do
-      page.next_page.tag_name.should == 'a'
-    end
-  end
-end

data/spec/page_magic/usage/starting_a_session_spec.rb

@@ -1,35 +0,0 @@
-describe 'PageMagic.session' do
-  let(:app_class) do
-    Class.new do
-      def call(_env)
-        [200, {}, ['hello world!!']]
-      end
-    end
-  end
-
-  def registered_driver(browser)
-    Capybara.drivers[browser].call(nil)
-  end
-
-  context 'specificying a browser' do
-    it 'loads the driver for the specified browser' do
-      session = PageMagic.session(browser: :firefox)
-      session.raw_session.driver.is_a?(Capybara::Selenium::Driver).should be_true
-    end
-  end
-
-  context 'testing against rack applications' do
-    it 'requires the app to be supplied' do
-      session = PageMagic.session(application: app_class.new)
-      session.raw_session.visit('/')
-      session.raw_session.text.should == 'hello world!!'
-    end
-
-    it 'can run against an rack application using a particular browser' do
-      session = PageMagic.session(browser: :rack_test, application: app_class.new)
-      session.raw_session.mode.should == :rack_test
-      session.raw_session.visit('/')
-      session.raw_session.text.should == 'hello world!!'
-    end
-  end
-end