page-object 2.2.4 → 2.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 74ccca073521956e4021906e6706540428334567
-  data.tar.gz: 7eadfca835d4d213bca0e48662b853046ccb0c55
+  metadata.gz: 8e154a0c17c3a91e1bd0b15a404dd3605254fe6e
+  data.tar.gz: 0e9916491fc6a8db99fef697d289e69045a5d2fe
 SHA512:
-  metadata.gz: 6161215bfc4fe2b236632ee4d02f6dea0cd10b52ac2ca51993cbec00df754ccdba724f3fefdc5d5cd32d7265c095603c7cf056141ff3c5c47671ecf04d065bc0
-  data.tar.gz: '0434932392bb13c1814e3da9685d4d20bd7d750afa468218cb66c6ae915bc8ec0ce3d98403ae0c64adad162b2905a0a0cb0a08713caf9ad0986d79bdaa705cd0'
+  metadata.gz: 92a3431f085ef1e3692d64272ebadeed5a9cd07ab6af10750eca2df72c2091b82a3840d8560ee65fbc6d907214d8111083fd519e5a95d136c7ee117ecde198fa
+  data.tar.gz: 0af16e5f35e7235db98d8c0a5b8447e2d47e86e656255ff1c15efc391424b2e65035efd3ea788bfda017b8b82a3944e29faec175812e8e180b0886e8c1ec1b27

data/.ruby-version

@@ -1 +1 @@
-ruby-2.4.0
+ruby-2.4.1

data/ChangeLog

@@ -1,3 +1,10 @@
+Version 2.2.5 / 2018/11/21
+* Enhancements
+  * populate_page_with will work with anything that can be converted to a Hash (Thanks Titus Fortner)
+* Fixes
+  * Fixed present? when using with ActiveSupport (Thanks Justin Ko)
+  * Fixed issues with when_visible and when_not_visible (Thanks Justin Ko)
+
 Version 2.2.4 / 2017-9-23
 * Enhancements
   * Added the ability to get the values of a table column (Thanks sanvijay)

data/lib/page-object/elements/element.rb

@@ -24,6 +24,13 @@ module PageObject
         not enabled?
       end
 
+      #
+      # return true if the element exists and is visible
+      #
+      def present?
+        element.present?
+      end
+
       #
       # specify plural form of element
       #
@@ -133,6 +140,7 @@ module PageObject
         element.wait_until(timeout: timeout, message: "Element not present in #{timeout} seconds", &:present?)
         self
       end
+      alias_method :when_visible, :when_present
 
       #
       # Waits until the element is not present
@@ -143,27 +151,7 @@ module PageObject
       def when_not_present(timeout=::PageObject.default_element_wait)
         element.wait_while(timeout: timeout, message: "Element still present in #{timeout} seconds", &:present?)
       end
-
-      #
-      # Waits until the element is visible
-      #
-      # @param [Integer] (defaults to: 5) seconds to wait before timing out
-      #
-      def when_visible(timeout=::PageObject.default_element_wait)
-        when_present(timeout)
-        element.wait_until(timeout: timeout, message: "Element not visible in #{timeout} seconds", &:visible?)
-        self
-      end
-
-      #
-      # Waits until the element is not visible
-      #
-      # @param [Integer] (defaults to: 5) seconds to wait before timing out
-      #
-      def when_not_visible(timeout=::PageObject.default_element_wait)
-        when_present(timeout)
-        element.wait_while(timeout: timeout, message: "Element still visible after #{timeout} seconds", &:visible?)
-      end
+      alias_method :when_not_visible, :when_not_present
 
       #
       # Waits until the block returns true

data/lib/page-object/page_populator.rb

@@ -30,8 +30,8 @@ module PageObject
     # false for a Checkbox or RadioButton.
     #
     def populate_page_with(data)
-      data.each do |key, value|
-        populate_section(key, value) if value.is_a?(Hash)
+      data.to_h.each do |key, value|
+        populate_section(key, value) if value.respond_to?(:to_h)
         populate_value(self, key, value)
       end
     end
@@ -40,7 +40,7 @@ module PageObject
 
     def populate_section(section, data)
       return unless self.respond_to? section
-      data.each do |key, value|
+      data.to_h.each do |key, value|
         populate_value(self.send(section), key, value)
       end
     end

data/lib/page-object/version.rb

@@ -1,4 +1,4 @@
 module PageObject
   # @private
-  VERSION = "2.2.4"
+  VERSION = "2.2.5"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: page-object
 version: !ruby/object:Gem::Version
-  version: 2.2.4
+  version: 2.2.5
 platform: ruby
 authors:
 - Jeff Morgan
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-23 00:00:00.000000000 Z
+date: 2018-11-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: watir
@@ -244,7 +244,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Page Object DSL for browser testing