page-object 1.1.1 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e9da44e461744eab4d446edf6dae5566da91c771
-  data.tar.gz: 76d49ecd39139b07d5883a6ce88b29443e65e47c
+  metadata.gz: 441fe4c75e361d33bb3938c23b47d55701f83074
+  data.tar.gz: 81d70fd600660240c761665482abed0eabde01bc
 SHA512:
-  metadata.gz: ed083f8285b0c1ed5cad169b809e89263f8a4bb4d2ea99e803df0c79d7f8178ef272c9b133b01227d9fd07e92f14318900dd26f457add8e9d120e15dc0847497
-  data.tar.gz: d789f587282a2106d9543ca7e23e735e315c653d3c3b8289a3467e7c2ff0be1eafc4008b99f7eba84929fe54af92271e9d03a99560014d42b6159ca5c00ec410
+  metadata.gz: 312e009090468c99cde07ab1bdf51082018952303849f902846cfdf96c9cac8364fbb601d2f1d8db164bf54d326277aa0163c130f3dcedce1bc6b87929e7cb92
+  data.tar.gz: ee8d3bcd265dfc90ecef27c3473a2010afeafb14a7c44907fcbac8165a3ec1dadaa2ba82a2e56270005ed9dfb4224c26a15c9a6de2095182a63d9a52927e050a

data/.ruby-version

@@ -1 +1 @@
-ruby-2.1.2
+ruby-2.3.1

data/ChangeLog

@@ -1,3 +1,12 @@
+Version 1.2.0 / 2016-6-15
+* Enhancements
+  * Added array methods to section collections (Thanks Cohen Carlisle)
+  * Ensuring that method_missing is always forwarded to the root element (Thanks Cohen Carlisle)
+  * Added ability to call style method with no parameters (Thanks Justin Watts)
+    - with Watir will return all styles; with Selenium will return empty string
+  * Cleaned up frame and iframe nesting (Thanks Jon Snow)
+  * Support for adding other platforms (Thanks pvmeerbe)
+
 === Version 1.1.1 / 2016-1-7
 * Enhancements
   * Added row accessor method and support for finding row elements directly (Thanks Ethan Hedrick)

data/Gemfile

@@ -7,6 +7,7 @@ gem 'fuubar-cucumber', '>= 0.0.22'
 gem 'rb-fsevent', :require => false if RUBY_PLATFORM =~ /darwin/i
 gem 'growl'
 gem 'guard-rspec'
+gem 'listen', '3.0.8' #Last version that supports ruby 2.0
 gem 'guard-cucumber'
 gem 'net-http-persistent'
 gem 'coveralls', require: false

data/features/section.feature

@@ -116,6 +116,10 @@ Feature: Sections
     Given I search for a link in an indexed property located in a section
     Then I should see the text "Success" in the section indexed link
 
+  Scenario: Sections roots can be accessed
+    When I have a page section
+    Then methods called on the section are passed to the root if missing
+
   Scenario: Selecting multiple sections
     When I select multiple sections
     Then I should have a section collection containing the sections

data/features/step_definitions/section_steps.rb

@@ -265,4 +265,13 @@ end
 
 Given(/^I search for a link in an indexed property located in a section$/) do
   @link = @page.container.indexed_list['success'].indexed_link_element
-end
+end
+
+When(/^I have a page section$/) do
+  @section = @page.container
+end
+
+Then(/^methods called on the section are passed to the root if missing$/) do
+  expect(-> { @section.visible? }).not_to raise_error
+  expect(@section.visible?).to be true
+end

data/lib/page-object.rb

@@ -7,7 +7,7 @@ require 'page-object/page_factory'
 require 'page-object/page_populator'
 require 'page-object/javascript_framework_facade'
 require 'page-object/indexed_properties'
-require 'page-object/sections'
+require 'page-object/section_collection'
 require 'page-object/widgets'
 
 require 'watir-webdriver'
@@ -26,7 +26,7 @@ require 'selenium/webdriver/common/error'
 # button we might define our page like the one below.  We can then interact with
 # the object using the generated methods.
 #
-# @example Login page example 
+# @example Login page example
 #   class LoginPage
 #     include PageObject
 #
@@ -49,10 +49,18 @@ module PageObject
   include LoadsPlatform
   include ElementLocators
   include PagePopulator
-  extend Forwardable
 
-  # Forward visibility checks to root so page sections can be tested for existence.
-  def_delegators :root, :visible?, :present?, :exists?
+  def method_missing(method, *args, &block)
+    if @root_element && @root_element.respond_to?(method)
+      @root_element.send(method, *args, &block)
+    else
+      super
+    end
+  end
+
+  def respond_to_missing?(method, include_all = false)
+    @root_element && @root_element.respond_to?(method) || super
+  end
 
   # @return [Watir::Browser or Selenium::WebDriver::Driver] the platform browser passed to the constructor
   attr_reader :browser
@@ -61,7 +69,7 @@ module PageObject
 
   #
   # Construct a new page object.  Prior to browser initialization it will call
-  # a method named initialize_accessors if it exists. Upon initialization of 
+  # a method named initialize_accessors if it exists. Upon initialization of
   # the page it will call a method named initialize_page if it exists.
   #
   # @param [Watir::Browser, Watir::HTMLElement or Selenium::WebDriver::Driver, Selenium::WebDriver::Element] the platform browser/element to use
@@ -269,7 +277,7 @@ module PageObject
   #
   def execute_script(script, *args)
     args.map! { |e| e.kind_of?(PageObject::Elements::Element) ? e.element : e }
-    platform.execute_script(script, *args)    
+    platform.execute_script(script, *args)
   end
 
   #
@@ -313,7 +321,7 @@ module PageObject
   #
   def in_iframe(identifier, frame=nil, &block)
     platform.in_iframe(identifier, frame, &block)
-  end  
+  end
 
   #
   # Override the normal showModalDialog call is it opens a window instead

data/lib/page-object/accessors.rb

@@ -153,7 +153,7 @@ module PageObject
     # @param block that contains the calls to elements that exist inside the frame.
     #
     def in_frame(identifier, frame=nil, &block)
-      frame = [] if frame.nil?
+      frame = frame.nil? ? [] : frame.dup
       frame << {frame: identifier}
       block.call(frame)
     end
@@ -177,7 +177,7 @@ module PageObject
     # @param block that contains the calls to elements that exist inside the iframe.
     #
     def in_iframe(identifier, frame=nil, &block)
-      frame = [] if frame.nil?
+      frame = frame.nil? ? [] : frame.dup
       frame << {iframe: identifier}
       block.call(frame)
     end

data/lib/page-object/elements/button.rb

@@ -18,13 +18,6 @@ module PageObject
         super + [:value, :src, :alt]
       end
 
-      def include_platform_for platform
-        super
-        if platform[:platform] == :selenium_webdriver
-          require 'page-object/platforms/selenium_webdriver/button'
-          self.class.send :include, PageObject::Platforms::SeleniumWebDriver::Button
-        end
-      end
     end
 
     ::PageObject::Elements.type_to_class[:submit] = ::PageObject::Elements::Button

data/lib/page-object/elements/canvas.rb

@@ -2,20 +2,8 @@
 module PageObject
   module Elements
     class Canvas < Element
-      #
-      # return the width of the canvas
-      #
-      def width
-        attribute(:width).to_i
-      end
 
-      #
-      # return the height of the canvas
-      #
-      def height
-        attribute(:height).to_i
-      end
-      
+
     end
     ::PageObject::Elements.type_to_class[:canvas] = ::PageObject::Elements::Canvas
   end

data/lib/page-object/elements/check_box.rb

@@ -17,18 +17,6 @@ module PageObject
         super + [:value, :label, :css]
       end
 
-      def include_platform_for platform
-        super
-        if platform[:platform] == :watir_webdriver
-          require 'page-object/platforms/watir_webdriver/check_box'
-          self.class.send :include, PageObject::Platforms::WatirWebDriver::CheckBox
-        elsif platform[:platform] == :selenium_webdriver
-          require 'page-object/platforms/selenium_webdriver/check_box'
-          self.class.send :include, PageObject::Platforms::SeleniumWebDriver::CheckBox
-        else
-          raise ArgumentError, "expect platform to be :watir_webdriver or :selenium_webdriver"
-        end
-      end
     end
 
     ::PageObject::Elements.type_to_class[:checkbox] = ::PageObject::Elements::CheckBox

data/lib/page-object/elements/element.rb

@@ -44,7 +44,7 @@ module PageObject
       #
       # get the value of the given CSS property
       #
-      def style(property)
+      def style(property = nil)
         element.style property
       end
 
@@ -207,20 +207,63 @@ module PageObject
       end
 
       def include_platform_for platform
-        if platform[:platform] == :watir_webdriver
-          self.class.send :include,  ::PageObject::Platforms::WatirWebDriver::Element
-          @platform = ::PageObject::Platforms::WatirWebDriver::PageObject.new(@element)
-        elsif platform[:platform] == :selenium_webdriver
-          self.class.send :include, ::PageObject::Platforms::SeleniumWebDriver::Element
-          @platform = ::PageObject::Platforms::SeleniumWebDriver::PageObject.new(@element)
-        else
-          raise ArgumentError, "expect platform to be :watir_webdriver or :selenium_webdriver"
+        platform_information = PageObject::Platforms.get
+        raise ArgumentError,"Expected hash with at least a key :platform for platform information! (#{platform.inspect})" unless platform.class == Hash && platform.has_key?(:platform)
+        platform_name = platform[:platform]
+
+        raise ArgumentError, "Unknown platform #{platform_name}! Expect platform to be one of the following: #{platform_information.keys.inspect}" unless platform_information.keys.include?(platform_name)
+        base_platform_class = "#{platform_information[platform_name]}::"
+
+        self.send :extend, constantize_classname(base_platform_class + "Element")
+        @platform = constantize_classname(base_platform_class+ "PageObject").new(@element)
+
+        # include class specific code
+        class_to_include = case
+                             when self.class ==  PageObject::Elements::Element
+                               # already loaded
+                               return true
+                             when self.class.name =~/PageObject:Elements::/
+                               self.class
+                               # inherited classes for example the widgets
+                             else
+                               parent_classes = self.class.ancestors.select { |item| item.name =~/PageObject::Elements::/ }
+                               raise RuntimeError,"Could not identify page-object inherited class for #{self.class}!" if parent_classes.empty?
+                               parent_classes.first
+                           end
+
+        element_type_specific_code = File.expand_path(File.dirname(__FILE__) + "../../platforms/#{platform_name}/"+ get_element_type_underscored(class_to_include) )
+        if File.exist? element_type_specific_code + '.rb'
+          require element_type_specific_code
+          self.send :extend, constantize_classname( base_platform_class + get_element_type(class_to_include) )
         end
+
       end
 
       def to_ary
         nil
       end
+
+      private
+
+
+      def constantize_classname name
+        name.split("::").inject(Object) { |k,n| k.const_get(n) }
+      end
+
+
+      def get_element_type(class_name = self.class)
+        class_name.name.split('::').last
+      end
+
+      # retrieved from ruby on rails underscore method
+      def get_element_type_underscored(class_name = self.class)
+        get_element_type(class_name).to_s.gsub(/::/, '/').
+         gsub(/([A-Z]+)([A-Z][a-z])/,'\1_\2').
+         gsub(/([a-z\d])([A-Z])/,'\1_\2').
+         tr("-", "_").
+         downcase
+      end
+
     end
   end
 end

data/lib/page-object/elements/file_field.rb

@@ -18,18 +18,6 @@ module PageObject
         super + [:title, :label]
       end
 
-      def include_platform_for platform
-        super
-        if platform[:platform] == :watir_webdriver
-          require 'page-object/platforms/watir_webdriver/file_field'
-          self.class.send :include, PageObject::Platforms::WatirWebDriver::FileField
-        elsif platform[:platform] == :selenium_webdriver
-          require 'page-object/platforms/selenium_webdriver/file_field'
-          self.class.send :include, PageObject::Platforms::SeleniumWebDriver::FileField
-        else
-          raise ArgumentError, "expect platform to be :watir_webdriver or :selenium_webdriver"
-        end
-      end
     end
 
     ::PageObject::Elements.type_to_class[:file] = ::PageObject::Elements::FileField

data/lib/page-object/elements/form.rb

@@ -17,18 +17,6 @@ module PageObject
         super + [:action]
       end
 
-      def include_platform_for platform
-        super
-        if platform[:platform] == :watir_webdriver
-          require 'page-object/platforms/watir_webdriver/form'
-          self.class.send :include, PageObject::Platforms::WatirWebDriver::Form
-        elsif platform[:platform] == :selenium_webdriver
-          require 'page-object/platforms/selenium_webdriver/form'
-          self.class.send :include,  PageObject::Platforms::SeleniumWebDriver::Form
-        else
-          raise ArgumentError, "expect platform to be :watir_webdriver or :selenium_webdriver"
-        end
-      end
     end
 
     ::PageObject::Elements.tag_to_class[:form] = ::PageObject::Elements::Form

data/lib/page-object/elements/image.rb

@@ -16,18 +16,6 @@ module PageObject
         super + [:alt, :src, :css]
       end
 
-      def include_platform_for platform
-        super
-        if platform[:platform] == :watir_webdriver
-          require 'page-object/platforms/watir_webdriver/image'
-          self.class.send :include, PageObject::Platforms::WatirWebDriver::Image
-        elsif platform[:platform] == :selenium_webdriver
-          require 'page-object/platforms/selenium_webdriver/image'
-          self.class.send :include, PageObject::Platforms::SeleniumWebDriver::Image
-        else
-          raise ArgumentError, "expect platform to be :watir_webdriver or :selenium_webdriver"
-        end
-      end
     end
 
     ::PageObject::Elements.tag_to_class[:img] = ::PageObject::Elements::Image

data/lib/page-object/elements/link.rb

@@ -26,18 +26,6 @@ module PageObject
         super.merge(:text => :link_text)
       end
 
-      def include_platform_for platform
-        super
-        if platform[:platform] == :watir_webdriver
-          require 'page-object/platforms/watir_webdriver/link'
-          self.class.send :include, PageObject::Platforms::WatirWebDriver::Link
-        elsif platform[:platform] == :selenium_webdriver
-          require 'page-object/platforms/selenium_webdriver/link'
-          self.class.send :include, PageObject::Platforms::SeleniumWebDriver::Link
-        else
-          raise ArgumentError, "expect platform to be :watir_webdriver or :selenium_webdriver"
-        end
-      end
     end
     
     ::PageObject::Elements.tag_to_class[:a] = ::PageObject::Elements::Link

data/lib/page-object/elements/ordered_list.rb

@@ -30,19 +30,6 @@ module PageObject
         [:class, :id, :index, :xpath]
       end
 
-      def include_platform_for platform
-        super
-        if platform[:platform] == :watir_webdriver
-          require 'page-object/platforms/watir_webdriver/ordered_list'
-          self.class.send :include, PageObject::Platforms::WatirWebDriver::OrderedList
-        elsif platform[:platform] == :selenium_webdriver
-          require 'page-object/platforms/selenium_webdriver/ordered_list'
-          self.class.send :include, PageObject::Platforms::SeleniumWebDriver::OrderedList
-        else
-          raise ArgumentError, "expect platform to be :watir_webdriver or :selenium_webdriver"
-        end
-      end
-
     end
 
     ::PageObject::Elements.tag_to_class[:ol] = ::PageObject::Elements::OrderedList

data/lib/page-object/elements/radio_button.rb

@@ -18,18 +18,6 @@ module PageObject
         super + [:value, :label]
       end
 
-      def include_platform_for platform
-        super
-        if platform[:platform] == :watir_webdriver
-          require 'page-object/platforms/watir_webdriver/radio_button'
-          self.class.send :include, PageObject::Platforms::WatirWebDriver::RadioButton
-        elsif platform[:platform] == :selenium_webdriver
-          require 'page-object/platforms/selenium_webdriver/radio_button'
-          self.class.send :include, PageObject::Platforms::SeleniumWebDriver::RadioButton
-        else
-          raise ArgumentError, "expect platform to be :watir_webdriver or :selenium_webdriver"
-        end
-      end
     end
 
     ::PageObject::Elements.type_to_class[:radio] = ::PageObject::Elements::RadioButton

data/lib/page-object/elements/select_list.rb

@@ -22,19 +22,6 @@ module PageObject
         super + [:label]
       end
 
-      def include_platform_for platform
-        super
-        if platform[:platform] == :watir_webdriver
-          require 'page-object/platforms/watir_webdriver/select_list'
-          self.class.send :include, PageObject::Platforms::WatirWebDriver::SelectList
-        elsif platform[:platform] == :selenium_webdriver
-          require 'page-object/platforms/selenium_webdriver/select_list'
-          self.class.send :include, PageObject::Platforms::SeleniumWebDriver::SelectList
-        else
-          raise ArgumentError, "expect platform to be :watir_webdriver or :selenium_webdriver"
-        end
-      end
-
     end
 
     ::PageObject::Elements.tag_to_class[:select] = ::PageObject::Elements::SelectList

data/lib/page-object/elements/table.rb

@@ -59,19 +59,6 @@ module PageObject
         ::PageObject::Elements::TableRow.new(row_element, platform)
       end
 
-
-      def include_platform_for platform
-        super
-        if platform[:platform] == :watir_webdriver
-          require 'page-object/platforms/watir_webdriver/table'
-          self.class.send :include, PageObject::Platforms::WatirWebDriver::Table
-        elsif platform[:platform] == :selenium_webdriver
-          require 'page-object/platforms/selenium_webdriver/table'
-          self.class.send :include, PageObject::Platforms::SeleniumWebDriver::Table
-        else
-          raise ArgumentError, "expect platform to be :watir_webdriver or :selenium_webdriver"
-        end
-      end
     end
 
     ::PageObject::Elements.tag_to_class[:table] = ::PageObject::Elements::Table