pag_seguro 0.4.1 → 0.5.1

data/spec/pag_seguro/sender_spec.rb

@@ -2,81 +2,69 @@
 require "spec_helper"
 
 describe PagSeguro::Sender do
-  context "instance" do
-    before { @sender = PagSeguro::Sender.new }
+  context "instance" do    
+    it { should have_attribute_accessor(:email) }
+    it { should have_attribute_accessor(:name) }
+    it { should have_attribute_accessor(:phone_ddd) }
+    it { should have_attribute_accessor(:phone_number) }
     
-    it "should have an email accessor" do
-      @sender.should have_attribute_accessor(:email)
+    context "initialized with all attributes" do
+      subject { PagSeguro::Sender.new attributes_for(:sender) }
+      its(:name){ should == "Stefano Diem Benatti" }
+      its(:email){ should == "stefano@heavenstudio.com.br" }
+      its(:phone_ddd){ should == 11 }
+      its(:phone_number){ should == 993430994 }
     end
     
-    it "should have a name accessor" do
-      @sender.should have_attribute_accessor(:name)
+    context "with invalid e-mail" do
+      subject { build :sender, email: "nothing" }
+      its(:email){ should be_nil }
     end
 
-    it "should have a phone_ddd accessor" do
-      @sender.should have_attribute_accessor(:phone_ddd)
+    context "with nil name" do
+      subject { build :sender, name: nil }
+      it { should_not be_a_valid_name }
+      its(:name){ should be_nil }
     end
 
-    it "should have a phone_number" do
-      @sender.should have_attribute_accessor(:phone_number)
+    context "with name Joao" do
+      subject { build :sender, name: "Joao" }
+      it { should_not be_a_valid_name }
+      its(:name){ should be_nil }
     end
-    
-    it "should be able to initialize with all attributes" do
-      sender = PagSeguro::Sender.new(name: "Stefano Diem Benatti", email: "stefano@heavenstudio.com.br", phone_ddd: "11", phone_number: "93430994")
-      sender.name.should == "Stefano Diem Benatti"
-      sender.email.should == "stefano@heavenstudio.com.br"
-      sender.phone_ddd.should == "11"
-      sender.phone_number.should == "93430994"
-    end
-    
-    it "should tell valid e-mail appart" do
-      @sender.email = "nothing"
-      @sender.should_not be_a_valid_email
-      @sender.email = ("a" * 50) + "waytoolongemail@mail.com"
-      @sender.should_not be_a_valid_email
-      @sender.email = "stefano@heavenstudio.com.br"
-      @sender.should be_a_valid_email
-    end
-        
-    it "should not show invalid e-mail" do
-      @sender.email = "nothing"
-      @sender.email.should be_nil
-    end
-    
-    it "should not have a valid name unless name has two distict character sequences" do
-      @sender.name = nil
-      @sender.should_not be_a_valid_name
-      @sender.name = "Joao"
-      @sender.should_not be_a_valid_name
-      @sender.name = "Joao Paulo"
-      @sender.should be_a_valid_name
-      @sender.name = "José Álvez"
-      @sender.should be_a_valid_name
+
+    context "with name Joao Paulo" do
+      subject { build :sender, name: "Joao Paulo" }
+      it { should be_a_valid_name }
+      its(:name){ should == "Joao Paulo" }
     end
-    
-    it "should not show invalid names" do
-      @sender.name = "Joao"
-      @sender.name.should be_nil
+
+    context "with name João Paulo" do
+      subject { build :sender, name: "João Paulo" }
+      it { should be_a_valid_name }
+      its(:name){ should == "João Paulo" }
     end
-    
-    it "should crop the name if it is too big" do
-      @sender.name = "a" * 50 + " b" * 10
-      @sender.name.should == "a" * 50
+
+    context "with very big name" do
+      subject { build :sender, name: ("a" * 50)+" "+("b" * 10) }
+      it { should be_a_valid_name }
+      its(:name){ should == "a" * 50 }
     end
-    
-    it "should crop spaces (because double spaces raises errors on pagseguro)" do
-      @sender.name = "Stefano   Benatti"
-      @sender.name.should == "Stefano Benatti"
+        
+    context "with double spaces in name" do
+      subject { build :sender, name: "Stefano   Benatti" }
+      it { should be_a_valid_name }
+      its(:name){ should == "Stefano Benatti" }
     end
-    
-    it "should not show invalid phone ddd's" do
-      @sender.phone_ddd = "111"
-      @sender.phone_ddd.should be_nil
+
+    context "with invalid phone ddd" do
+      subject { build :sender, phone_ddd: "111" }
+      its(:phone_ddd){ should be_nil }
     end
-    
-    it "should not show invalid phone number" do
-      @sender.phone_number = "1234567"
-      @sender.phone_number.should be_nil
+
+    context "with invalid phone number" do
+      subject { build :sender, phone_number: "1234567" }
+      its(:phone_number){ should be_nil }
     end
   end
 end

data/spec/pag_seguro/shipping_spec.rb

@@ -1,61 +1,46 @@
 # encoding: utf-8
 require "spec_helper"
 
-valid_attributes = {
-  type: PagSeguro::Shipping::SEDEX,
-  state: "SP",
-  city: "São Paulo",
-  postal_code: "05363000",
-  district: "Jd. PoliPoli",
-  street: "Av. Otacilio Tomanik",
-  number: "775",
-  complement: "apto. 92",
-  cost: "12.13"
-}
-
 describe PagSeguro::Shipping do
-  context "instance" do
-    before { @shipping = PagSeguro::Shipping.new }
-    it { @shipping.should have_attribute_accessor(:type) }
-    it { @shipping.should have_attribute_accessor(:state) }
-    it { @shipping.should have_attribute_accessor(:city) }
-    it { @shipping.should have_attribute_accessor(:postal_code) }
-    it { @shipping.should have_attribute_accessor(:district) }
-    it { @shipping.should have_attribute_accessor(:street) }
-    it { @shipping.should have_attribute_accessor(:number) }
-    it { @shipping.should have_attribute_accessor(:complement) }
-    it { @shipping.should have_attribute_accessor(:cost) }
-
-    describe "types" do
-      it "should be pac if type is 1" do
-        @shipping.stub( :type ){ 1 }
-        @shipping.should be_pac
-      end
-
-      it "should be sedex if type is 2" do
-        @shipping.stub( :type ){ 2 }
-        @shipping.should be_sedex
-      end
-
-      it "should be unidentified if type is 3" do
-        @shipping.stub( :type ){ 3 }
-        @shipping.should be_unidentified
-      end
+  let(:shipping){ PagSeguro::Shipping.new }
+
+  it { should have_attribute_accessor(:type) }
+  it { should have_attribute_accessor(:state) }
+  it { should have_attribute_accessor(:city) }
+  it { should have_attribute_accessor(:postal_code) }
+  it { should have_attribute_accessor(:district) }
+  it { should have_attribute_accessor(:street) }
+  it { should have_attribute_accessor(:number) }
+  it { should have_attribute_accessor(:complement) }
+  it { should have_attribute_accessor(:cost) }
+
+  its(:type){ should == PagSeguro::Shipping::UNIDENTIFIED }
+
+  describe "instance" do
+    subject{ build(:shipping) }
+    
+    it { should be_valid }
+    its(:cost){ should == "12.13" }
+    its(:postal_code){ should == "05363000" }
+
+    context "with invalid postal_code" do
+      subject{ build(:shipping, postal_code: 1234567) }
+      its(:postal_code){ should be_blank }  
     end
-  end
 
-  describe "#cost" do
-    it "should return the same specified cost" do
-      PagSeguro::Shipping.new(valid_attributes).cost.should == "12.13"
+    context "with type 1" do
+      subject{ build(:shipping, type: 1) }
+      it { should be_pac }
     end
-  end
 
-  it "should be able to initialize all attributes" do
-    PagSeguro::Shipping.new(valid_attributes).should be_valid
-  end
+    context "with type 2" do
+      subject{ build(:shipping, type: 2) }
+      it { should be_sedex }
+    end
 
-  it "should not show postal code unless valid" do
-    PagSeguro::Shipping.new(valid_attributes).postal_code.should == "05363000"
-    PagSeguro::Shipping.new(valid_attributes.merge(postal_code: 1234567)).postal_code.should be_blank
+    context "with type 3" do
+      subject{ build(:shipping, type: 3) }
+      it { should be_unidentified }
+    end
   end
-end
+end

data/spec/spec_helper.rb

@@ -6,6 +6,11 @@ end
 require 'yaml'
 require File.dirname(__FILE__) + "/../lib/pag_seguro"
 Dir[File.dirname(__FILE__) + "/support/**/*.rb"].each {|f| require f}
+require 'shoulda-matchers'
+require 'factory_girl'
+
+include FactoryGirl::Syntax::Methods
+FactoryGirl.find_definitions
 
 config = YAML.load_file(File.dirname(__FILE__) + "/pag_seguro/integration/config.yml")
 EMAIL = config["email"]
@@ -13,26 +18,12 @@ TOKEN = config["token"]
 NOTIFICATION_CODE = config["notification_code"]
 TRANSACTION_ID = config["transaction_id"]
 
-class HaveAttributeAccessor
-  def initialize(attribute)
-    @attribute = attribute
-  end
-  
-  def matches?(target)
-    @target = target
-    @target.respond_to?(:"#{@attribute}").should == true
-    @target.respond_to?(:"#{@attribute}=").should == true
-  end
-  
-  def failure_message
-    "expected #{@target.inspect} to have '#{@expected}' attribute accessor"
+RSpec::Matchers.define :have_attribute_accessor do |attribute|
+  match do |actual|
+    actual.respond_to?(attribute) && actual.respond_to?("#{attribute}=")
   end
-  
-  def negative_failure_message
-    "expected #{@target.inspect} not to have '#{@expected}' attribute accessor"
-  end
-end
 
-def have_attribute_accessor(attribute)
-  HaveAttributeAccessor.new(attribute)
+  description do
+    "have attr_accessor :#{attribute}"
+  end
 end

data/spec/support/transaction_shared_examples.rb

@@ -179,31 +179,31 @@ shared_examples_for "a transaction" do
   end
 
   describe "::status_for" do
-    it "should return :processing when 1" do
+    it "should return :processing for 1" do
       subject.status_for(1).should == :processing
     end
 
-    it "should return :in_analysis when 2" do
+    it "should return :in_analysis for 2" do
       subject.status_for(2).should == :in_analysis
     end
 
-    it "should return :approved when 3" do
+    it "should return :approved for 3" do
       subject.status_for(3).should == :approved
     end
 
-    it "should return :available when 4" do
+    it "should return :available for 4" do
       subject.status_for(4).should == :available
     end
 
-    it "should return :disputed when 5" do
+    it "should return :disputed for 5" do
       subject.status_for(5).should == :disputed
     end
 
-    it "should return :returned when 6" do
+    it "should return :returned for 6" do
       subject.status_for(6).should == :returned
     end
 
-    it "should return :cancelled when 7" do
+    it "should return :cancelled for 7" do
       subject.status_for(7).should == :cancelled
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pag_seguro
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-26 00:00:00.000000000 Z
+date: 2013-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -27,6 +27,22 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: haml
   requirement: !ruby/object:Gem::Requirement
@@ -90,6 +106,8 @@ files:
 - Rakefile
 - lib/pag_seguro.rb
 - lib/pag_seguro/checkout.xml.haml
+- lib/pag_seguro/convert_field_to_digit.rb
+- lib/pag_seguro/day_of_year.rb
 - lib/pag_seguro/errors/invalid_data.rb
 - lib/pag_seguro/errors/unauthorized.rb
 - lib/pag_seguro/errors/unknown_error.rb
@@ -97,14 +115,20 @@ files:
 - lib/pag_seguro/notification.rb
 - lib/pag_seguro/payment.rb
 - lib/pag_seguro/payment_method.rb
+- lib/pag_seguro/pre_approval.rb
 - lib/pag_seguro/query.rb
 - lib/pag_seguro/sender.rb
 - lib/pag_seguro/shipping.rb
 - lib/pag_seguro/transaction.rb
 - lib/pag_seguro/version.rb
+- lib/pagseguro_decimal_validator.rb
 - pag_seguro.gemspec
+- spec/factories.rb
 - spec/fixtures/transaction.xml
+- spec/fixtures/transaction_history.xml
 - spec/pag_seguro/checkout_xml_spec.rb
+- spec/pag_seguro/convert_field_to_digit_spec.rb
+- spec/pag_seguro/day_of_year_spec.rb
 - spec/pag_seguro/errors/invalid_data_spec.rb
 - spec/pag_seguro/errors/unauthorized_spec.rb
 - spec/pag_seguro/errors/unknown_error_spec.rb
@@ -116,6 +140,7 @@ files:
 - spec/pag_seguro/notification_spec.rb
 - spec/pag_seguro/payment_method_spec.rb
 - spec/pag_seguro/payment_spec.rb
+- spec/pag_seguro/pre_approval_spec.rb
 - spec/pag_seguro/query_spec.rb
 - spec/pag_seguro/sender_spec.rb
 - spec/pag_seguro/shipping_spec.rb
@@ -148,8 +173,12 @@ signing_key:
 specification_version: 3
 summary: A ruby gem to handle PagSeguro's API version 2
 test_files:
+- spec/factories.rb
 - spec/fixtures/transaction.xml
+- spec/fixtures/transaction_history.xml
 - spec/pag_seguro/checkout_xml_spec.rb
+- spec/pag_seguro/convert_field_to_digit_spec.rb
+- spec/pag_seguro/day_of_year_spec.rb
 - spec/pag_seguro/errors/invalid_data_spec.rb
 - spec/pag_seguro/errors/unauthorized_spec.rb
 - spec/pag_seguro/errors/unknown_error_spec.rb
@@ -161,6 +190,7 @@ test_files:
 - spec/pag_seguro/notification_spec.rb
 - spec/pag_seguro/payment_method_spec.rb
 - spec/pag_seguro/payment_spec.rb
+- spec/pag_seguro/pre_approval_spec.rb
 - spec/pag_seguro/query_spec.rb
 - spec/pag_seguro/sender_spec.rb
 - spec/pag_seguro/shipping_spec.rb
@@ -168,4 +198,3 @@ test_files:
 - spec/pag_seguro/version_spec.rb
 - spec/spec_helper.rb
 - spec/support/transaction_shared_examples.rb
-has_rdoc: false