pacto 0.1.0 → 0.1.1

data/TODO.md

@@ -13,6 +13,7 @@
 - 'default' value to be used when it is present with an array of types
 - Support 'null' attribute type
 - Validate contract structure in a rake task. Then assume all contracts are valid.
+- When a request is not OK (200), the body may not be a json. Add support to ignore the body.
 
 ## Assumptions
 

data/lib/pacto/response.rb

@@ -13,15 +13,15 @@ module Pacto
     end
 
     def validate(response)
-      @errors = []
       if @definition['status'] != response.status
-        @errors << "Invalid status: expected #{@definition['status']} but got #{response.status}"
+        return [ "Invalid status: expected #{@definition['status']} but got #{response.status}" ]
       end
+      
       unless @definition['headers'].normalize_keys.subset_of?(response.headers.normalize_keys)
-        @errors << "Invalid headers: expected #{@definition['headers'].inspect} to be a subset of #{response.headers.inspect}"
+        return [ "Invalid headers: expected #{@definition['headers'].inspect} to be a subset of #{response.headers.inspect}" ]
       end
-      @errors << JSON::Validator.fully_validate(@definition['body'], response.body)
-      @errors.flatten
+      
+      JSON::Validator.fully_validate(@definition['body'], response.body)
     end
   end
 end

data/lib/pacto/version.rb

@@ -1,3 +1,3 @@
 module Pacto
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/pacto/response_spec.rb

@@ -44,23 +44,13 @@ module Pacto
           response.validate(fake_response).should == []
         end
       end
-      context 'when status, headers and body match' do
-        it 'should not return any errors' do
-          JSON::Validator.should_receive(:fully_validate).
-            with(definition['body'], fake_response.body).
-            and_return([])
-
-          response = described_class.new(definition)
-          response.validate(fake_response).should == []
-        end
-      end
-
+      
       context 'when status does not match' do
         let(:status) { 500 }
 
         it 'should return a status error' do
-          JSON::Validator.stub(:fully_validate).and_return([])
-
+          JSON::Validator.should_not_receive(:fully_validate)
+          
           response = described_class.new(definition)
           response.validate(fake_response).should == ["Invalid status: expected #{definition['status']} but got #{status}"]
         end
@@ -70,7 +60,7 @@ module Pacto
         let(:headers) { {'Content-Type' => 'text/html'} }
 
         it 'should return a header error' do
-          JSON::Validator.stub(:fully_validate).and_return([])
+          JSON::Validator.should_not_receive(:fully_validate)
 
           response = described_class.new(definition)
           response.validate(fake_response).should == ["Invalid headers: expected #{definition['headers'].inspect} to be a subset of #{headers.inspect}"]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pacto
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-08 00:00:00.000000000 Z
+date: 2013-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: webmock