pact_broker 2.96.0 → 2.99.0

data/lib/pact_broker/api/resources/base_resource.rb

@@ -152,6 +152,10 @@ module PactBroker
           @request_body ||= request.body.to_s
         end
 
+        def any_request_body?
+          request_body && request_body.size > 0
+        end
+
         def consumer_name
           identifier_from_path[:consumer_name]
         end

data/lib/pact_broker/api/resources/latest_pacts.rb

@@ -22,7 +22,7 @@ module PactBroker
         end
 
         def policy_name
-          :'pacts::pacts'
+          :'pacts::latest_pacts'
         end
       end
     end

data/lib/pact_broker/api/resources/pact.rb

@@ -94,14 +94,6 @@ module PactBroker
           :'pacts::pact'
         end
 
-        def policy_pacticipant
-          if resource_exists?
-            consumer
-          else
-            nil
-          end
-        end
-
         private
 
         def pact

data/lib/pact_broker/api/resources/pact_content_diff.rb

@@ -1,6 +1,7 @@
 require "pact_broker/api/resources/base_resource"
 require "pact_broker/pacts/pact_params"
 require "pact_broker/pacts/diff"
+require "timeout"
 
 module PactBroker
   module Api
@@ -19,8 +20,12 @@ module PactBroker
         end
 
         def to_text
-          output = PactBroker::Pacts::Diff.new.process pact_params.merge(base_url: base_url), comparison_pact_params, raw: false
-          response.body = output
+          Timeout::timeout(PactBroker.configuration.pact_content_diff_timeout) do
+            output = PactBroker::Pacts::Diff.new.process pact_params.merge(base_url: base_url), comparison_pact_params, raw: false
+            response.body = output
+          end
+        rescue Timeout::Error
+          408
         end
 
         def pact

data/lib/pact_broker/api/resources/pact_versions.rb

@@ -32,11 +32,7 @@ module PactBroker
         end
 
         def policy_name
-          :'pacts::pacts'
-        end
-
-        def policy_pacticipant
-          consumer
+          :'pacts::pact_versions'
         end
       end
     end

data/lib/pact_broker/api/resources/pact_versions_for_branch.rb

@@ -28,11 +28,7 @@ module PactBroker
         end
 
         def policy_name
-          :'pacts::pacts'
-        end
-
-        def policy_pacticipant
-          consumer
+          :'pacts::pact_versions'
         end
       end
     end

data/lib/pact_broker/api/resources/provider_pacts.rb

@@ -20,7 +20,7 @@ module PactBroker
         end
 
         def policy_name
-          :'pacts::pacts'
+          :'pacts::provider_pacts'
         end
 
         def to_json

data/lib/pact_broker/api/resources/tagged_pact_versions.rb

@@ -36,11 +36,7 @@ module PactBroker
         end
 
         def policy_name
-          :'pacts::pacts'
-        end
-
-        def policy_pacticipant
-          consumer
+          :'pacts::pact_versions'
         end
       end
     end

data/lib/pact_broker/api/resources/verification.rb

@@ -54,10 +54,6 @@ module PactBroker
           :'verifications::verification'
         end
 
-        def policy_pacticipant
-          provider
-        end
-
         private
 
         def verification

data/lib/pact_broker/api/resources/verifications.rb

@@ -62,10 +62,6 @@ module PactBroker
           :'verifications::verifications'
         end
 
-        def policy_pacticipant
-          provider
-        end
-
         private
 
         def pact

data/lib/pact_broker/api/resources/version.rb

@@ -25,6 +25,14 @@ module PactBroker
           !!version
         end
 
+        def malformed_request?
+          if request.put? && any_request_body?
+            invalid_json?
+          else
+            false
+          end
+        end
+
         def from_json
           if request.really_put?
             handle_request do

data/lib/pact_broker/app.rb

@@ -29,6 +29,7 @@ require "pact_broker/api/middleware/configuration"
 require "pact_broker/api/middleware/basic_auth"
 require "pact_broker/config/basic_auth_configuration"
 require "pact_broker/api/authorization/resource_access_policy"
+require "pact_broker/api/middleware/http_debug_logs"
 
 module PactBroker
 
@@ -134,17 +135,11 @@ module PactBroker
       # Keep this configuration in sync with lib/db.rb
       configuration.database_connection ||= PactBroker.create_database_connection(configuration.database_configuration, configuration.logger)
       PactBroker::DB.connection = configuration.database_connection
-      PactBroker::DB.connection.extend_datasets do
-        # rubocop: disable Lint/NestedMethodDefinition
-        def any?
-          !empty?
-        end
-        # rubocop: enable Lint/NestedMethodDefinition
-      end
       PactBroker::DB.validate_connection_config if configuration.validate_database_connection_config
       PactBroker::DB.set_mysql_strict_mode_if_mysql
       PactBroker::DB.connection.extension(:pagination)
       PactBroker::DB.connection.extension(:statement_timeout)
+      PactBroker::DB.connection.extension(:any_not_empty)
       PactBroker::DB.connection.timezone = :utc
       Sequel.datetime_class = DateTime
       Sequel.database_timezone = :utc # Store all dates in UTC, assume any date without a TZ is UTC
@@ -180,6 +175,7 @@ module PactBroker
     end
 
     def configure_middleware
+      @app_builder.use PactBroker::Api::Middleware::HttpDebugLogs if configuration.http_debug_logging_enabled
       configure_basic_auth
       configure_rack_protection
       @app_builder.use Rack::PactBroker::InvalidUriProtection

data/lib/pact_broker/config/runtime_configuration.rb

@@ -39,7 +39,8 @@ module PactBroker
         log_format: nil,
         warning_error_class_names: ["Sequel::ForeignKeyConstraintViolation"],
         hide_pactflow_messages: false,
-        log_configuration_on_startup: true
+        log_configuration_on_startup: true,
+        http_debug_logging_enabled: false
       )
 
       on_load :validate_logging_attributes!
@@ -52,9 +53,12 @@ module PactBroker
         webhook_scheme_whitelist: ["https"],
         webhook_host_whitelist: [],
         disable_ssl_verification: false,
-        webhook_certificates: [],
-        user_agent: "Pact Broker v#{PactBroker::VERSION}",
+        user_agent: "Pact Broker v#{PactBroker::VERSION}"
       )
+      # no default, if you set it to [] or nil, then anyway config blows up when it tries to merge in the
+      # numerically indexed hash from the environment variables.
+      attr_config :webhook_certificates
+      on_load :set_webhook_attribute_defaults
 
       # resource attributes
       attr_config(
@@ -67,7 +71,8 @@ module PactBroker
         badge_provider_mode: :redirect,
         enable_public_badge_access: false,
         shields_io_base_url: "https://img.shields.io",
-        use_case_sensitive_resource_names: true
+        use_case_sensitive_resource_names: true,
+        pact_content_diff_timeout: 15
       )
 
       # domain attributes
@@ -178,8 +183,14 @@ module PactBroker
       def webhook_certificates= webhook_certificates
         if webhook_certificates.is_a?(Array)
           super(webhook_certificates.collect(&:symbolize_keys))
+        elsif webhook_certificates.is_a?(Hash)
+          if all_keys_are_number_strings?(webhook_certificates)
+            super(convert_hash_with_number_string_keys_to_array(webhook_certificates).collect(&:symbolize_keys))
+          else
+            raise_validation_error("webhook_certificates must be an array, or a hash where each key is an integer in string format.")
+          end
         elsif !webhook_certificates.nil?
-          raise_validation_error("webhook_certificates must be an array")
+          raise_validation_error("webhook_certificates cannot be set using a #{webhook_certificates.class}")
         end
       end
 
@@ -208,6 +219,14 @@ module PactBroker
       def raise_validation_error(msg)
         raise PactBroker::ConfigurationError, msg
       end
+
+      def set_webhook_attribute_defaults
+        # can't set a default on this, or anyway config blows up when trying to merge the
+        # hash from the env vars into an array/nil.
+        if webhook_certificates.nil?
+          self.webhook_certificates = []
+        end
+      end
     end
   end
 end

data/lib/pact_broker/config/runtime_configuration_coercion_methods.rb

@@ -4,6 +4,17 @@ require "pact_broker/config/space_delimited_integer_list"
 module PactBroker
   module Config
     module RuntimeConfigurationCoercionMethods
+
+      def all_keys_are_number_strings?(hash)
+        hash.keys.all? { | k | k.to_s.to_i.to_s == k } # is an integer as a string
+      end
+
+      def convert_hash_with_number_string_keys_to_array(hash)
+        hash.keys.collect{ |k| [k, k.to_i]}.sort_by(&:last).collect(&:first).collect do | key |
+          hash[key]
+        end
+      end
+
       def value_to_string_array value, property_name
         if value.is_a?(String)
           PactBroker::Config::SpaceDelimitedStringList.parse(value)

data/lib/pact_broker/config/runtime_configuration_database_methods.rb

@@ -16,7 +16,7 @@ module PactBroker
             database_port: nil,
             database_url: nil,
             database_sslmode: nil,
-            sql_log_level: :debug,
+            sql_log_level: :none,
             sql_log_warn_duration: 5,
             sql_enable_caller_logging: false,
             database_max_connections: nil,
@@ -82,7 +82,7 @@ module PactBroker
           private :postgres?
 
           def driver_options
-            if postgres?
+            if postgres? && database_statement_timeout
               { options: "-c statement_timeout=#{database_statement_timeout}s" }
             end
           end

data/lib/pact_broker/config/runtime_configuration_logging_methods.rb

@@ -24,12 +24,17 @@ module PactBroker
       module InstanceMethods
         # base_url raises a not implemented error
         def log_configuration(logger)
-          to_source_trace.without("base_url").each_with_object({})do | (key, details), new_hash |
-            new_hash[key] = details.merge(value: self.send(key.to_sym))
+          source_info = to_source_trace
+          (self.class.config_attributes - [:base_url]).collect(&:to_s).each_with_object({})do | key, new_hash |
+            new_hash[key] = {
+              value: self.send(key.to_sym),
+              source: source_info.dig(key, :source) || {:type=>:defaults}
+            }
           end.sort_by { |key, _| key }.each { |key, value| log_config_inner(key, value, logger) }
         end
 
         def log_config_inner(key, value, logger)
+          # TODO fix the source display for webhook_certificates set by environment variables
           if !value.has_key? :value
             value.sort_by { |inner_key, _| inner_key }.each { |inner_key, inner_value| log_config_inner("#{key}.#{inner_key}", inner_value, logger) }
           elsif self.class.sensitive_value?(key)

data/lib/pact_broker/configuration.rb

@@ -55,6 +55,8 @@ module PactBroker
       config.version_parser = PactBroker::Versions::ParseSemanticVersion
       config.sha_generator = PactBroker::Pacts::GenerateSha
       config.example_data_seeder = lambda do
+        # Do the require in the lambda, not at the top of the file, because we need
+        # the database connection to be made before loading any Sequel::Model classes.
         require "pact_broker/db/seed_example_data"
         PactBroker::DB::SeedExampleData.call
       end

data/lib/pact_broker/db/models.rb

@@ -14,11 +14,11 @@ require "pact_broker/domain/pacticipant"
 require "pact_broker/deployments/environment"
 require "pact_broker/deployments/deployed_version"
 require "pact_broker/deployments/released_version"
-require "pact_broker/matrix/row"
-require "pact_broker/matrix/head_row"
 require "pact_broker/versions/branch"
 require "pact_broker/versions/branch_version"
 require "pact_broker/versions/branch_head"
+require "pact_broker/matrix/quick_row"
+require "pact_broker/matrix/every_row"
 
 module PactBroker
   INTEGRATIONS_TABLES = [

data/lib/pact_broker/index/service.rb

@@ -1,10 +1,9 @@
 require "pact_broker/repositories"
 require "pact_broker/logging"
 require "pact_broker/domain/index_item"
-require "pact_broker/matrix/head_row"
-require "pact_broker/matrix/aggregated_row"
 require "pact_broker/repositories/helpers"
 require "pact_broker/index/page"
+require "pact_broker/verifications/latest_verification_for_consumer_version_tag"
 
 module PactBroker
   module Index

data/lib/pact_broker/integrations/integration.rb

@@ -3,6 +3,7 @@ require "pact_broker/verifications/pseudo_branch_status"
 require "pact_broker/domain/verification"
 require "pact_broker/webhooks/latest_triggered_webhook"
 require "pact_broker/webhooks/webhook"
+require "pact_broker/verifications/latest_verification_for_consumer_and_provider"
 
 module PactBroker
   module Integrations
@@ -21,17 +22,30 @@ module PactBroker
           integration.associations[:latest_pact] = nil
         end
 
-        PactBroker::Pacts::PactPublication.overall_latest.each do | pact |
-          eo_opts[:rows].each do | integration |
-            if integration.consumer_id == pact.consumer_id && integration.provider_id == pact.provider_id
-              integration.associations[:latest_pact] = pact
-            end
+
+        # Would prefer to be able to eager load only the fields specified in the original Integrations
+        # query, but we don't seem to have that information in this context.
+        # Need the latest verification for the verification status in the index response.
+        latest_pact_publications_query = PactBroker::Pacts::PactPublication
+                                          .eager_for_domain_with_content
+                                          .eager(pact_version: :latest_verification)
+                                          .overall_latest
+
+        latest_pact_publications_query.all.each do | pact |
+          eo_opts[:id_map][[pact.consumer_id, pact.provider_id]]&.each do | integration |
+            integration.associations[:latest_pact] = pact
           end
         end
       end
 
       one_to_one(:latest_pact, class: "PactBroker::Pacts::PactPublication", :key => [:consumer_id, :provider_id], primary_key: [:consumer_id, :provider_id], :eager_loader=> LATEST_PACT_EAGER_LOADER) do | _ds |
-        PactBroker::Pacts::PactPublication.overall_latest_for_consumer_id_and_provider_id(consumer_id, provider_id)
+        # Would prefer to be able to eager load only the fields specified in the original Integrations
+        # query, but we don't seem to have that information in this context.
+        # Need the latest verification for the verification status in the index response.
+        PactBroker::Pacts::PactPublication
+          .eager_for_domain_with_content
+          .eager(pact_version: :latest_verification)
+          .overall_latest_for_consumer_id_and_provider_id(consumer_id, provider_id)
       end
 
       # When viewing the index, every webhook in the database will match at least one of the rows, so
@@ -65,6 +79,7 @@ module PactBroker
         end
       end
 
+      # TODO make this the verification status for the latest from main branch
       def verification_status_for_latest_pact
         @verification_status_for_latest_pact ||= PactBroker::Verifications::PseudoBranchStatus.new(latest_pact, latest_pact&.latest_verification)
       end

data/lib/pact_broker/integrations/service.rb

@@ -26,7 +26,7 @@ module PactBroker
         scope_for(PactBroker::Integrations::Integration)
           .eager(:consumer)
           .eager(:provider)
-          .eager(latest_pact: [:latest_verification, :pact_version])
+          .eager(:latest_pact) # latest_pact eager loader is custom, can't take any more options
           .eager(:latest_verification)
           .all
           .sort { | a, b| Integration.compare_by_last_action_date(a, b) }

data/lib/pact_broker/matrix/every_row.rb

@@ -17,15 +17,19 @@ module PactBroker
         Sequel[:p][:created_at].as(:consumer_version_created_at),
         Sequel[:p][:id].as(:pact_order)
       ]
+
       VERIFICATION_COLUMNS = [
         Sequel[:v][:id].as(:verification_id),
         Sequel[:v][:provider_version_id],
         Sequel[:v][:created_at].as(:provider_version_created_at)
       ]
 
+      JOINED_VERIFICATION_COLUMNS = [:id, :pact_version_id, :provider_id, :provider_version_id, :created_at]
+
       ALL_COLUMNS = PACT_COLUMNS + VERIFICATION_COLUMNS
 
       SELECT_ALL_COLUMN_ARGS = [:select_all_columns] + ALL_COLUMNS
+
       dataset_module do
         select(*SELECT_ALL_COLUMN_ARGS)
 
@@ -33,9 +37,23 @@ module PactBroker
           left_outer_join(:verifications, P_V_JOIN, { table_alias: :v } )
         end
 
+        def inner_join_verifications
+          join(:verifications, P_V_JOIN, { table_alias: :v } )
+        end
+
+        def inner_join_verifications_matching_one_selector_provider_or_provider_version(query_ids)
+          verifications = db[:verifications]
+            .select(*JOINED_VERIFICATION_COLUMNS)
+            .where {
+              QueryBuilder.provider_or_provider_version_matches(query_ids)
+            }
+
+          join(verifications, P_V_JOIN, { table_alias: :v } )
+        end
+
         def verifications_for(query_ids)
           db[:verifications]
-            .select(:id, :pact_version_id, :provider_id, :provider_version_id, :created_at)
+            .select(*JOINED_VERIFICATION_COLUMNS)
             .where {
               Sequel.&(
                 QueryBuilder.consumer_in_pacticipant_ids(query_ids),

data/lib/pact_broker/matrix/integration.rb

@@ -1,9 +1,9 @@
-
 # Represents the integration relationship between a consumer and a provider in the context
 # of a matrix or can-i-deploy query.
-# If the required flag is set, then one of the pacticipants (consumers) specified in the HTTP query
-# requires the provider. It would not be required if a provider was specified, and it had an
-# integration with a consumer.
+# If the required flag is set, then one of the pacticipants specified in the matrix query
+# is a consumer and it requires the provider to be already deployed. An integration would not be required if a provider
+# was specified, and it had an integration with a consumer, but that consumer wasn't deployed yet.
+#
 
 module PactBroker
   module Matrix
@@ -11,7 +11,7 @@ module PactBroker
 
       attr_reader :consumer_name, :consumer_id, :provider_name, :provider_id
 
-      def initialize consumer_id, consumer_name, provider_id, provider_name, required
+      def initialize(consumer_id, consumer_name, provider_id, provider_name, required)
         @consumer_id = consumer_id
         @consumer_name = consumer_name
         @provider_id = provider_id

data/lib/pact_broker/matrix/quick_row.rb

@@ -11,6 +11,14 @@ require "pact_broker/pacts/pact_publication"
 require "pact_broker/tags/tag_with_latest_flag"
 require "pact_broker/matrix/query_ids"
 
+# The PactBroker::Matrix::QuickRow represents a row in the table that is created when
+# the consumer versions are joined to the provider versions via the pacts and verifications tables,
+# aka "The Matrix". The difference between this class and the EveryRow class is that
+# the EveryRow class includes results for overridden pact verisons and verifications (used only when there is no latestby
+# set in the matrix query), where as the QuickRow class does not.
+# It is called the QuickRow because the initial implementation was called the Row, and this is an optimised
+# version. It needs to be renamed back to Row now that the old Row class has been deleted.
+
 # The difference between `join_verifications_for` and `join_verifications` is that
 # the left outer join is done on a pre-filtered dataset in `join_verifications_for`,
 # so that we get a row with null verification fields for a pact that has been verified
@@ -19,6 +27,7 @@ require "pact_broker/matrix/query_ids"
 
 module PactBroker
   module Matrix
+    # TODO rename this to just Row
     # rubocop: disable Metrics/ClassLength
     class QuickRow < Sequel::Model(Sequel.as(:latest_pact_publication_ids_for_consumer_versions, :p))
 
@@ -45,6 +54,15 @@ module PactBroker
         Sequel[:v][:verification_id],
         Sequel[:v][:created_at].as(:provider_version_created_at)
       ]
+
+      JOINED_VERIFICATION_COLUMNS = [
+        :verification_id,
+        :provider_version_id,
+        :pact_version_id,
+        :provider_id,
+        :created_at
+      ]
+
       LAST_ACTION_DATE = Sequel.lit("CASE WHEN (provider_version_created_at IS NOT NULL AND provider_version_created_at > consumer_version_created_at) THEN provider_version_created_at ELSE consumer_version_created_at END").as(:last_action_date)
 
       ALL_COLUMNS = PACT_COLUMNS + VERIFICATION_COLUMNS
@@ -146,10 +164,15 @@ module PactBroker
         # When we have one selector, we need to join ALL the verifications to find out
         # what integrations exist
         def matching_one_selector(selectors)
-          join_verifications
+          query_ids = QueryIds.from_selectors(selectors)
+          rows_where_selector_matches_consumer_cols = join_verifications
             .where {
-              QueryBuilder.consumer_or_consumer_version_or_provider_or_provider_or_provider_version_match(QueryIds.from_selectors(selectors), :p, :v)
+              QueryBuilder.consumer_or_consumer_version_matches(query_ids, :p)
             }
+
+          rows_where_selector_matches_provider_cols = inner_join_verifications_matching_one_selector_provider_or_provider_version(query_ids)
+
+          rows_where_selector_matches_consumer_cols.union(rows_where_selector_matches_provider_cols)
         end
 
         def pacticipant_ids_matching_one_selector_optimised(selectors)
@@ -229,9 +252,19 @@ module PactBroker
           left_outer_join(verifications_for(query_ids), LP_LV_JOIN, { table_alias: :v } )
         end
 
+        def inner_join_verifications_matching_one_selector_provider_or_provider_version(query_ids)
+          verifications = db[LV]
+            .select(*JOINED_VERIFICATION_COLUMNS)
+            .where {
+              QueryBuilder.provider_or_provider_version_matches(query_ids)
+            }
+
+          join(verifications, LP_LV_JOIN, { table_alias: :v } )
+        end
+
         def verifications_for(query_ids)
           db[LV]
-            .select(:verification_id, :provider_version_id, :pact_version_id, :provider_id, :created_at)
+            .select(*JOINED_VERIFICATION_COLUMNS)
             .where {
               Sequel.&(
                 QueryBuilder.consumer_in_pacticipant_ids(query_ids),

data/lib/pact_broker/matrix/repository.rb

@@ -1,9 +1,7 @@
 require "pact_broker/logging"
 require "pact_broker/repositories/helpers"
-require "pact_broker/matrix/row"
 require "pact_broker/matrix/quick_row"
 require "pact_broker/matrix/every_row"
-require "pact_broker/matrix/head_row"
 require "pact_broker/error"
 require "pact_broker/matrix/query_results"
 require "pact_broker/matrix/integration"
@@ -24,7 +22,8 @@ module PactBroker
 
       # TODO move latest verification logic in to database
 
-      TP_COLS = PactBroker::Matrix::Row::TP_COLS
+      # Used when using table_print to output query results
+      TP_COLS = [ :consumer_version_number, :pact_revision_number, :provider_version_number, :verification_number]
 
       GROUP_BY_PROVIDER_VERSION_NUMBER = [:consumer_name, :consumer_version_number, :provider_name, :provider_version_number]
       GROUP_BY_PROVIDER = [:consumer_name, :consumer_version_number, :provider_name]
@@ -124,6 +123,8 @@ module PactBroker
         end
       end
 
+      # Why does the consumer equivalent of this method use the QuickRow distinct_integrations_for_selector_as_consumer
+      # while this method uses the Integration?
       def integrations_where_specified_selector_is_provider(resolved_specified_selectors)
         integrations_involving_specified_providers = PactBroker::Integrations::Integration
                                                       .where(provider_id: resolved_specified_selectors.collect(&:pacticipant_id))

data/lib/pact_broker/matrix/service.rb

@@ -1,6 +1,5 @@
 require "pact_broker/logging"
 require "pact_broker/repositories"
-require "pact_broker/matrix/row"
 require "pact_broker/matrix/deployment_status_summary"
 require "pact_broker/matrix/query_results_with_deployment_status_summary"
 require "pact_broker/messages"

data/lib/pact_broker/metrics/service.rb

@@ -118,8 +118,8 @@ module PactBroker
 
       def matrix_count
         begin
-          PactBroker::Matrix::Row.db.with_statement_timeout(PactBroker.configuration.metrics_sql_statement_timeout) do
-            PactBroker::Matrix::Row.count
+          PactBroker::Matrix::EveryRow.db.with_statement_timeout(PactBroker.configuration.metrics_sql_statement_timeout) do
+            PactBroker::Matrix::EveryRow.default_scope.count
           end
         rescue Sequel::DatabaseError => _ex
           -1

data/lib/pact_broker/pacts/create_formatted_diff.rb

@@ -19,6 +19,7 @@ module PactBroker
         end
 
         difference = diff(previous_pact_hash, pact_hash)
+
         Pact::Matchers::UnixDiffFormatter.call(difference, colour: false, include_explanation: false)
       end
     end

data/lib/pact_broker/pacts/eager_loaders.rb

@@ -32,7 +32,10 @@ module PactBroker
 
           pact_publications.each do | pact_publication |
             pact_publication.consumer_version_tags.collect(&:name).sort.each do | tag_name |
-              pact_publication.associations[:head_pact_publications_for_tags] << head_pact_publications_by_tag[tag_name]
+              # Not sure how this can ever be nil, but a PF error suggests that it has happend. Maybe a timing issue?
+              if head_pact_publications_by_tag[tag_name]
+                pact_publication.associations[:head_pact_publications_for_tags] << head_pact_publications_by_tag[tag_name]
+              end
             end
           end
         end