pact_broker 2.93.4 → 2.95.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dd8313de32ee72fbd7202e9279130983eeccf2d5bc9c6ae589a5ed9700854cbd
-  data.tar.gz: 8f7d311c9cbec69ca70f4a2420409e6c4747fcb0d1ae0f9af4d04baaf10aa43a
+  metadata.gz: f65cf2bd6eb2b3f0f7fd727e61fc73005817200f8e72bbab574493e4ea9b9ba3
+  data.tar.gz: aac1fb501fc5624227e63d424c8982f266fa0a9a2d80b1184844193347ba6724
 SHA512:
-  metadata.gz: baaf854e49a5d623279b2481933fb9e033289efba9b4d9350703d9dc9737dac367b6076938f8f309426480f0745d9fe181c8f7f296f8727e17584de498ea631e
-  data.tar.gz: ea459192ee83bce3c4fe1c307ad8f2ab3c0ed2734f40162cef0ae95033b81d0e3e7bc12d2765af52ae4a06a95ddfed8dfdca7b0c421e923aaa2ba4a172552bcf
+  metadata.gz: 8272759e5880069606e56bea3893055df49543b76b237d7511ce8fa21c0414f1a0e593e98ed1f9e67c4b9048b4da1c2d3ef938b0dfea182406cda696111c2bc4
+  data.tar.gz: 426a032f0016c8952934fbf630420be42accf192baeaff3bd2651aefa75170d055d8a4ed125640a7b3cad124cf5a461d7c930e5d289f4a6e5bd666366661940a

data/CHANGELOG.md

@@ -1,3 +1,43 @@
+<a name="v2.95.1"></a>
+### v2.95.1 (2022-03-18)
+
+#### Bug Fixes
+
+* **can-i-deploy**
+  * allow new provider to be introduced to existing consumer without can-i-deploy having circular dependency issues	 ([e43974ca](/../../commit/e43974ca))
+
+<a name="v2.95.0"></a>
+### v2.95.0 (2022-03-16)
+
+#### Features
+
+* add relation for can-i-deploy branch to environment badge	 ([6ece8e93](/../../commit/6ece8e93))
+* add badge url for 'can I deploy latest version of branch to envionment' endpoint	 ([086b8c10](/../../commit/086b8c10))
+
+#### Bug Fixes
+
+* **pacts for verification**
+  * do not de-duplicate pacts with the same content but different consumers	 ([ae3bb541](/../../commit/ae3bb541))
+
+<a name="v2.94.0"></a>
+### v2.94.0 (2022-02-22)
+
+#### Features
+
+* add can-i-deploy endpoint for checking if the latest version for a branch can be deployed to a particular environment	 ([34b145e8](/../../commit/34b145e8))
+* truncate tags, branches and versions in UI when they are super long (#513)	 ([94bbf915](/../../commit/94bbf915))
+
+* **integration dashboard**
+  * add copy buttons next to the branch, tag and environment labels	 ([5b86ac88](/../../commit/5b86ac88))
+
+#### Bug Fixes
+
+* Improve Matrix request performance (#537)	 ([123f8629](/../../commit/123f8629))
+* Eagerly load pact publication fields (#536)	 ([c3f6993b](/../../commit/c3f6993b))
+
+* **hal-browser**
+  * properties accordion should be collapsed by default (#544)	 ([19466121](/../../commit/19466121))
+
 <a name="v2.93.4"></a>
 ### v2.93.4 (2022-02-21)
 

data/README.md

@@ -140,15 +140,14 @@ You can use the [Pact Broker Docker image][docker] or [Terraform on AWS][terrafo
 #### Rolling your own
 
 * Are you sure you don't just want to use the [Pact Broker Docker image][docker]? No Docker at your company yet? Ah well, keep reading.
-* Create a PostgreSQL (recommended) or MySQL (not _as_ recommended because of @bethesque's personal prejudices, but still fully supported) database.
- * To ensure you're on a supported version of the database that you choose, check the [travis.yml][travisyml] file to see which versions we're currently running our tests against.
-* If you're using PostgreSQL (did we mention this was _recommended!_) you'll find the database creation script in the [example/config.ru](https://github.com/pact-foundation/pact_broker/blob/master/example/config.ru).
-* Install ruby 2.4 or later and the latest version of bundler (if you've come this far, I'm assuming you know how to do both of these. Did I mention there was a [Docker][docker] image?)
+* Create a PostgreSQL database.
+  * To ensure you're on a supported version of the database that you choose, check the [travis.yml][travisyml] file to see which versions we're currently running our tests against.
+  * MySQL was supported for the native Ruby application until around 2021, but the official `pactfoundation/pact-broker` Docker image does not support it. New features will not be optimised for MySQL, and some new features may not even be supported on it (eg. the database clean feature).
+* You'll find a sample database creation script in the [example/config.ru](https://github.com/pact-foundation/pact_broker/blob/master/example/config.ru).
+* Install ruby 2.7 or later and the latest version of bundler (if you've come this far, I'm assuming you know how to do both of these. Did I mention there was a [Docker][docker] image?)
 * Copy the [pact\_broker](https://github.com/DiUS/pact_broker-docker/tree/master/pact_broker) directory from the Pact Broker Docker project. This will have the recommended settings for database connections, logging, basic auth etc. Note that the Docker image uses Phusion Passenger as the web application server in front of the Pact Broker Ruby application, which is the recommended set up.
-* Modify the config.ru and Gemfile as desired (eg. choose database driver gem, set your database credentials. Use the "pg" gem if using Postgres and the "mysql2" gem if using MySQL)
-    * example Sequel configuration for postgres `{adapter: "postgres", database: "pact_broker", username: 'pact_broker', password: 'pact_broker', :encoding => 'utf8'}`
-    * example Sequel configuration for mysql `{adapter: "mysql2", database: "pact_broker", username: 'pact_broker', password: 'pact_broker', :encoding => 'utf8'}`
-`
+* Modify the config.ru and Gemfile as desired (eg. choose database driver gem, set your database credentials. Use the "pg" gem for Postgres)
+  * example Sequel configuration for postgres `{ adapter: "postgres", database: "pact_broker", username: 'pact_broker', password: 'pact_broker', :encoding => 'utf8' }`
 * Please ensure you use `encoding: 'utf8'` in your Sequel options to avoid encoding issues.
 * For production usage, use a web application server like [Phusion Passenger](https://www.phusionpassenger.com) or [Nginx](http://nginx.org/) to serve the Pact Broker application. You'll need to read up on the documentation for these yourself as it is beyond the scope of this documentation. See the [wiki][reverse-proxy-docs] for instructions on using a reverse proxy with SSL.
 * Ensure the environment variable `RACK_ENV` is set to `production`.

data/db/migrations/20220303_increase_consumer_version_selector_hashes_column_size.rb

@@ -0,0 +1,14 @@
+require_relative "migration_helper"
+include PactBroker::MigrationHelper
+
+Sequel.migration do
+  up do
+    if mysql?
+      run("ALTER TABLE verifications CHANGE consumer_version_selector_hashes consumer_version_selector_hashes mediumtext")
+    end
+  end
+
+  down do
+
+  end
+end

data/lib/db.rb

@@ -38,6 +38,7 @@ module DB
     con.extension(:connection_validator)
     con.extension(:pagination)
     con.extension(:statement_timeout)
+    #con.extension(:caller_logging)
     con.extend_datasets do
       # rubocop: disable Lint/NestedMethodDefinition
       def any?

data/lib/pact_broker/api/authorization/resource_access_policy.rb

@@ -38,11 +38,7 @@ module PactBroker
           ]
 
           if enable_public_badge_access
-            rules.concat([
-              [PUBLIC, READ_METHODS, PACT_BADGE_PATH],
-              [PUBLIC, READ_METHODS, MATRIX_BADGE_PATH],
-              [PUBLIC, READ_METHODS, CAN_I_DEPLOY_BADGE_PATH]
-            ])
+            rules.concat(BADGE_PATHS.collect { | badge_path | [PUBLIC, READ_METHODS, badge_path] })
           end
 
           if allow_public_access_to_heartbeat

data/lib/pact_broker/api/decorators/format_date_time.rb

@@ -8,7 +8,7 @@ module PactBroker
 
         def self.call(date_time)
           if date_time.is_a?(String)
-            DATE_TIME_CLASS.strptime(date_time).to_time.utc.to_datetime.xmlschema
+            Sequel.string_to_datetime(date_time).to_time.utc.to_datetime.xmlschema
           elsif date_time
             date_time.to_time.utc.to_datetime.xmlschema if date_time
           end

data/lib/pact_broker/api/decorators/pacticipant_decorator.rb

@@ -90,6 +90,14 @@ module PactBroker
           }
         end
 
+        link :'pb:can-i-deploy-branch-to-environment-badge' do | options |
+          {
+            title: "Can I Deploy #{represented.name} from branch to environment badge",
+            href: templated_can_i_deploy_branch_to_environment_badge_url(represented.name, options[:base_url]),
+            templated: true
+          }
+        end
+
         curies do | options |
           [{
             name: :pb,

data/lib/pact_broker/api/pact_broker_urls.rb

@@ -255,6 +255,10 @@ module PactBroker
         templated_can_i_deploy_url(pacticipant_name, base_url) + "/badge"
       end
 
+      def templated_can_i_deploy_branch_to_environment_badge_url pacticipant_name, base_url = ""
+        pacticipant_url_from_params({ pacticipant_name: pacticipant_name }, base_url) + "/branches/{branch}/latest-version/can-i-deploy/to-environment/{environment}/badge"
+      end
+
       def label_url label, base_url
         "#{labels_url(label.pacticipant, base_url)}/#{url_encode(label.name)}"
       end

data/lib/pact_broker/api/paths.rb

@@ -3,9 +3,12 @@ module PactBroker
     module Paths
       PACT_BADGE_PATH =         %r{^/pacts/provider/[^/]+/consumer/.*/badge(?:\.[A-Za-z]+)?$}.freeze
       MATRIX_BADGE_PATH =       %r{^/matrix/provider/[^/]+/latest/[^/]+/consumer/[^/]+/latest/[^/]+/badge(?:\.[A-Za-z]+)?$}.freeze
-      CAN_I_DEPLOY_BADGE_PATH = %r{^/pacticipants/[^/]+/latest-version/[^/]+/can-i-deploy/to/[^/]+/badge(?:\.[A-Za-z]+)?$}.freeze
+      CAN_I_DEPLOY_TAG_BADGE_PATH = %r{^/pacticipants/[^/]+/latest-version/[^/]+/can-i-deploy/to/[^/]+/badge(?:\.[A-Za-z]+)?$}.freeze
+      CAN_I_DEPLOY_BRANCH_ENV_BADGE_PATH = %r{^/pacticipants/[^/]+/branches/[^/]+/latest-version/can-i-deploy/to-environment/[^/]+/badge(?:\.[A-Za-z]+)?$}.freeze
       VERIFICATION_RESULTS =    %r{^/pacts/provider/[^/]+/consumer/[^/]+/pact-version/[^/]+/verification-results/[^/]+}
 
+      BADGE_PATHS = [PACT_BADGE_PATH, MATRIX_BADGE_PATH, CAN_I_DEPLOY_TAG_BADGE_PATH, CAN_I_DEPLOY_BRANCH_ENV_BADGE_PATH]
+
       extend self
 
       def is_verification_results_path?(path)
@@ -14,7 +17,7 @@ module PactBroker
 
       def is_badge_path?(path)
         # Optimise by checking include? first - regexp slow
-        path.include?("/badge") && (path =~ PACT_BADGE_PATH || path =~ MATRIX_BADGE_PATH || path =~ CAN_I_DEPLOY_BADGE_PATH)
+        path.include?("/badge") && BADGE_PATHS.any?{ | regex | path =~ regex }
       end
     end
   end

data/lib/pact_broker/api/resources/badge.rb

@@ -1,37 +1,22 @@
 require "pact_broker/api/resources/base_resource"
 require "pact_broker/verifications/pseudo_branch_status"
 require "pact_broker/configuration"
+require "pact_broker/api/resources/badge_methods"
 
 module PactBroker
   module Api
     module Resources
       class Badge < BaseResource
-
-        def allowed_methods
-          ["GET", "OPTIONS"]
-        end
-
-        def content_types_provided
-          [["image/svg+xml", :to_svg]]
-        end
+        include BadgeMethods
 
         def resource_exists?
           !badge_service.can_provide_badge_using_redirect?
         end
 
-        # Only called if resource_exists? returns false
-        def previously_existed?
-          true
-        end
-
         def is_authorized?(authorization_header)
           super || PactBroker.configuration.enable_public_badge_access
         end
 
-        def forbidden?
-          false
-        end
-
         def to_svg
           response.headers["Cache-Control"] = "no-cache"
           comment + badge_service.pact_verification_badge(pact, label, initials, pseudo_branch_verification_status, tags)
@@ -42,10 +27,6 @@ module PactBroker
           badge_service.pact_verification_badge_url(pact, label, initials, pseudo_branch_verification_status, tags)
         end
 
-        def policy_name
-          :'badges::badge'
-        end
-
         private
 
         def pact
@@ -61,10 +42,6 @@ module PactBroker
           @pseudo_branch_verification_status ||= PactBroker::Verifications::PseudoBranchStatus.new(pact, latest_verification).to_sym
         end
 
-        def label
-          request.query["label"]
-        end
-
         def initials
           request.query["initials"] == "true"
         end

data/lib/pact_broker/api/resources/badge_methods.rb

@@ -0,0 +1,57 @@
+module PactBroker
+  module Api
+    module Resources
+      module BadgeMethods
+        def allowed_methods
+          ["GET", "OPTIONS"]
+        end
+
+        def content_types_provided
+          [["image/svg+xml", :to_svg]]
+        end
+
+        def resource_exists?
+          false
+        end
+
+        # Only called if resource_exists? returns false
+        def previously_existed?
+          true
+        end
+
+        def forbidden?
+          false
+        end
+
+        def is_authorized?(authorization_header)
+          super || PactBroker.configuration.enable_public_badge_access
+        end
+
+        def policy_name
+          :'badges::badge'
+        end
+
+        def moved_temporarily?
+          response.headers["Cache-Control"] = "no-cache"
+          begin
+            badge_url
+          rescue StandardError => e
+            # Want to render a badge, even if there's an error
+            badge_service.error_badge_url("error", ErrorResponseBodyGenerator.display_message(e, "reference: #{PactBroker::Errors.generate_error_reference}"))
+          end
+        end
+
+        def badge_url
+          raise NotImplementedError
+        end
+
+        private
+
+        def label
+          lab = request.query["label"]
+          lab && !lab.empty? ? lab : nil
+        end
+      end
+    end
+  end
+end

data/lib/pact_broker/api/resources/base_resource.rb

@@ -1,9 +1,281 @@
+# frozen_string_literal: true
 require "pact_broker/configuration"
+require "webmachine"
+require "pact_broker/services"
+require "pact_broker/api/decorators"
+require "pact_broker/logging"
+require "pact_broker/api/pact_broker_urls"
+require "pact_broker/json"
+require "pact_broker/pacts/pact_params"
+require "pact_broker/api/resources/authentication"
+require "pact_broker/api/resources/authorization"
+require "pact_broker/errors"
 
 module PactBroker
   module Api
     module Resources
-      BaseResource = PactBroker.configuration.base_resource_class_factory.call
+      class InvalidJsonError < PactBroker::Error ; end
+
+      class BaseResource < Webmachine::Resource
+        include PactBroker::Services
+        include PactBroker::Api::PactBrokerUrls
+        include PactBroker::Api::Resources::Authentication
+        include PactBroker::Api::Resources::Authorization
+
+        include PactBroker::Logging
+
+        attr_accessor :user
+
+        def initialize
+          PactBroker.configuration.before_resource.call(self)
+          application_context.before_resource&.call(self)
+        end
+
+        def options
+          { "Access-Control-Allow-Methods" => allowed_methods.join(", ")}
+        end
+
+        def known_methods
+          super + ["PATCH"]
+        end
+
+        def finish_request
+          application_context.after_resource&.call(self)
+          PactBroker.configuration.after_resource.call(self)
+        end
+
+        def is_authorized?(authorization_header)
+          authenticated?(self, authorization_header)
+        end
+
+        def forbidden?
+          if application_context.resource_authorizer
+            !application_context.resource_authorizer.call(self)
+          elsif PactBroker.configuration.authorize
+            !PactBroker.configuration.authorize.call(self, {})
+          else
+            false
+          end
+        end
+
+        # The path_info segments aren't URL decoded
+        def identifier_from_path
+          @identifier_from_path ||= request.path_info.each_with_object({}) do | (key, value), hash|
+            if value.is_a?(String)
+              hash[key] = URI.decode(value)
+            elsif value.is_a?(Symbol) || value.is_a?(Numeric)
+              hash[key] = value
+            end
+          end
+        end
+
+        alias_method :path_info, :identifier_from_path
+
+        def base_url
+          # Have to use something for the base URL here - we can't use an empty string as we can in the UI.
+          # Can't work out if cache poisoning is a vulnerability for APIs or not.
+          # Using the request base URI as a fallback if the base_url is not configured may be a vulnerability,
+          # but the documentation recommends that the
+          # base_url should be set in the configuration to mitigate this.
+          request.env["pactbroker.base_url"] || request.base_uri.to_s.chomp("/")
+        end
+
+        # See comments for base_url in lib/pact_broker/doc/controllers/app.rb
+        def ui_base_url
+          request.env["pactbroker.base_url"] || ""
+        end
+
+        def charsets_provided
+          [["utf-8", :encode]]
+        end
+
+        # We only use utf-8 so leave encoding as it is
+        def encode(body)
+          body
+        end
+
+        def resource_url
+          request.uri.to_s.gsub(/\?.*/, "").chomp("/")
+        end
+
+        def decorator_context options = {}
+          application_context.decorator_context_creator.call(self, options)
+        end
+
+        def decorator_options options = {}
+          { user_options: decorator_context(options) }
+        end
+
+        def handle_exception(error)
+          error_reference = PactBroker::Errors.generate_error_reference
+          application_context.error_logger.call(error, error_reference, request.env)
+          if PactBroker::Errors.reportable_error?(error)
+            PactBroker::Errors.report(error, error_reference, request.env)
+          end
+          response.body = application_context.error_response_body_generator.call(error, error_reference, request.env)
+        end
+
+        # rubocop: disable Metrics/CyclomaticComplexity
+        def params(options = {})
+          return options[:default] if options.key?(:default) && request_body.empty?
+
+          symbolize_names = !options.key?(:symbolize_names) || options[:symbolize_names]
+          if symbolize_names
+            @params_with_symbol_keys ||= JSON.parse(request_body, { symbolize_names: true }.merge(PACT_PARSING_OPTIONS)) #Not load! Otherwise it will try to load Ruby classes.
+          else
+            @params_with_string_keys ||= JSON.parse(request_body, { symbolize_names: false }.merge(PACT_PARSING_OPTIONS)) #Not load! Otherwise it will try to load Ruby classes.
+          end
+        rescue JSON::JSONError => e
+          raise InvalidJsonError.new("Error parsing JSON - #{e.message}")
+        end
+        # rubocop: enable Metrics/CyclomaticComplexity
+
+        def params_with_string_keys
+          params(symbolize_names: false)
+        end
+
+        def pact_params
+          @pact_params ||= PactBroker::Pacts::PactParams.from_request request, identifier_from_path
+        end
+
+        def set_json_error_message message
+          response.headers["Content-Type"] = "application/hal+json;charset=utf-8"
+          response.body = { error: message }.to_json
+        end
+
+        def set_json_validation_error_messages errors
+          response.headers["Content-Type"] = "application/hal+json;charset=utf-8"
+          response.body = { errors: errors }.to_json
+        end
+
+        def request_body
+          @request_body ||= request.body.to_s
+        end
+
+        def consumer_name
+          identifier_from_path[:consumer_name]
+        end
+
+        def consumer_version_number
+          identifier_from_path[:consumer_version_number]
+        end
+
+        def pacticipant_version_number
+          identifier_from_path[:pacticipant_version_number]
+        end
+
+        def consumer_specified?
+          identifier_from_path.key?(:consumer_name)
+        end
+
+        def provider_specified?
+          identifier_from_path.key?(:provider_name)
+        end
+
+        def provider_name
+          identifier_from_path[:provider_name]
+        end
+
+        def pacticipant_name
+          identifier_from_path[:pacticipant_name]
+        end
+
+        def pacticipant_specified?
+          identifier_from_path.key?(:pacticipant_name)
+        end
+
+        def invalid_json?
+          begin
+            params
+            false
+          rescue StandardError => e
+            logger.info "Error parsing JSON #{e} - #{request_body}"
+            set_json_error_message "Error parsing JSON - #{e.message}"
+            response.headers["Content-Type"] = "application/hal+json;charset=utf-8"
+            true
+          end
+        end
+
+        def validation_errors? model
+          if (errors = model.validate).any?
+            set_json_validation_error_messages errors
+            true
+          else
+            false
+          end
+        end
+
+        def contract_validation_errors? contract, params
+          if (invalid = !contract.validate(params))
+            set_json_validation_error_messages contract.errors.messages
+          end
+          invalid
+        end
+
+        def find_pacticipant name, role
+          pacticipant_service.find_pacticipant_by_name(name).tap do | pacticipant |
+            set_json_error_message("No #{role} with name '#{name}' found") if pacticipant.nil?
+          end
+        end
+
+        def consumer
+          @consumer ||= identifier_from_path[:consumer_name] && find_pacticipant(identifier_from_path[:consumer_name], "consumer")
+        end
+
+        def provider
+          @provider ||= identifier_from_path[:provider_name] && find_pacticipant(identifier_from_path[:provider_name], "provider")
+        end
+
+        def pacticipant
+          @pacticipant ||= identifier_from_path[:pacticipant_name] && find_pacticipant(identifier_from_path[:pacticipant_name], "pacticipant")
+        end
+
+        def pact
+          @pact ||= pact_service.find_pact(pact_params)
+        end
+
+        # Not necessarily an existing integration
+        def integration
+          if consumer_specified? && provider_specified?
+            OpenStruct.new(consumer: consumer, provider: provider)
+          else
+            nil
+          end
+        end
+
+        def database_connector
+          request.env["pactbroker.database_connector"]
+        end
+
+        def application_context
+          request.path_info[:application_context]
+        end
+
+        def decorator_class(name)
+          application_context.decorator_configuration.class_for(name)
+        end
+
+        def api_contract_class(name)
+          application_context.api_contract_configuration.class_for(name)
+        end
+
+        def schema
+          nil
+        end
+
+        def validation_errors_for_schema?(schema_to_use = schema, params_to_validate = params)
+          if (errors = schema_to_use.call(params_to_validate)).any?
+            set_json_validation_error_messages(errors)
+            true
+          else
+            false
+          end
+        end
+
+        def malformed_request_for_json_with_schema?(schema_to_use = schema, params_to_validate = params)
+          invalid_json? || validation_errors_for_schema?(schema_to_use, params_to_validate)
+        end
+      end
     end
   end
 end

data/lib/pact_broker/api/resources/can_i_deploy_pacticipant_version_by_branch_to_environment.rb

@@ -0,0 +1,67 @@
+require "pact_broker/api/resources/matrix"
+require "pact_broker/matrix/can_i_deploy_query_schema"
+require "pact_broker/matrix/parse_can_i_deploy_query"
+require "pact_broker/api/decorators/matrix_decorator"
+require "pact_broker/api/decorators/matrix_text_decorator"
+
+module PactBroker
+  module Api
+    module Resources
+      class CanIDeployPacticipantVersionByBranchToEnvironment < BaseResource
+        def allowed_methods
+          ["GET", "OPTIONS"]
+        end
+
+        def content_types_provided
+          [
+            ["application/hal+json", :to_json],
+            ["text/plain", :to_text]
+          ]
+        end
+
+        def resource_exists?
+          !!(version && environment)
+        end
+
+        def policy_name
+          :'versions::version'
+        end
+
+        private
+
+        def selectors
+          @selectors ||= [
+                            PactBroker::Matrix::UnresolvedSelector.new(
+                              pacticipant_name: pacticipant_name,
+                              latest: true,
+                              branch: identifier_from_path[:branch_name]
+                            )
+                          ]
+        end
+
+        def options
+          @options ||=  {
+                          latestby: "cvp",
+                          environment_name: identifier_from_path[:environment_name]
+                        }
+        end
+
+        def to_json
+          decorator_class(:matrix_decorator).new(results).to_json(decorator_options)
+        end
+
+        def results
+          @results ||= matrix_service.can_i_deploy(selectors, options)
+        end
+
+        def version
+          @version ||= version_service.find_latest_by_pacticipant_name_and_branch_name(identifier_from_path[:pacticipant_name], identifier_from_path[:branch_name])
+        end
+
+        def environment
+          @environment ||= environment_service.find_by_name(identifier_from_path[:environment_name])
+        end
+      end
+    end
+  end
+end