pact_broker 2.79.1 → 2.80.0

data/spec/features/create_environment_spec.rb

@@ -1,4 +1,4 @@
-require 'pact_broker/api/pact_broker_urls'
+require "pact_broker/api/pact_broker_urls"
 
 describe "Creating an environment" do
   let(:path) { PactBroker::Api::PactBrokerUrls.environments_url }

data/spec/features/create_pacticipant_spec.rb

@@ -1,12 +1,18 @@
-require 'support/test_data_builder'
-
 describe "Creating a pacticipant" do
   let(:path) { "/pacticipants" }
-  let(:headers) { {'CONTENT_TYPE' => 'application/json'} }
+  let(:headers) { {"CONTENT_TYPE" => "application/json"} }
   let(:response_body) { JSON.parse(last_response.body, symbolize_names: true)}
-  let(:pacticipant_hash) { { name: 'Foo Thing' } }
+  let(:pacticipant_hash) do
+    {
+      name: "Foo Thing",
+      mainBranch: "main",
+      repositoryUrl: "http://url",
+      repositoryName: "foo-thing",
+      repositoryNamespace: "some-group"
+    }
+  end
 
-  subject { post path, pacticipant_hash.to_json, headers; last_response }
+  subject { post(path, pacticipant_hash.to_json, headers) }
 
   it "returns a 201 response" do
     subject
@@ -15,12 +21,12 @@ describe "Creating a pacticipant" do
 
   it "returns the Location header" do
     subject
-    expect(last_response.headers['Location']).to eq 'http://example.org/pacticpants/Foo%20Thing'
+    expect(last_response.headers["Location"]).to eq "http://example.org/pacticpants/Foo%20Thing"
   end
 
   it "returns a JSON Content Type" do
     subject
-    expect(last_response.headers['Content-Type']).to eq 'application/hal+json;charset=utf-8'
+    expect(last_response.headers["Content-Type"]).to eq "application/hal+json;charset=utf-8"
   end
 
   it "returns the newly created webhook" do

data/spec/features/create_tag_spec.rb

@@ -1,6 +1,6 @@
 describe "Creating a tag" do
   let(:path) { "/pacticipants/Foo/versions/1234/tags/foo" }
-  let(:headers) { { 'CONTENT_TYPE' => 'application/json' } }
+  let(:headers) { { "CONTENT_TYPE" => "application/json" } }
   let(:response_body) { JSON.parse(subject.body, symbolize_names: true)}
 
   subject { put(path, {}, headers) }
@@ -10,7 +10,7 @@ describe "Creating a tag" do
   end
 
   it "returns a HAL JSON Content Type" do
-    expect(subject.headers['Content-Type']).to eq 'application/hal+json;charset=utf-8'
+    expect(subject.headers["Content-Type"]).to eq "application/hal+json;charset=utf-8"
   end
 
   it "returns the newly created tag" do

data/spec/features/create_version_spec.rb

@@ -1,6 +1,7 @@
 describe "Creating a pacticipant version" do
   let(:path) { "/pacticipants/Foo/versions/1234" }
-  let(:headers) { { 'CONTENT_TYPE' => 'application/json' } }
+  let(:headers) { { "CONTENT_TYPE" => content_type } }
+  let(:content_type) { "application/json" }
   let(:response_body) { JSON.parse(subject.body, symbolize_names: true)}
   let(:version_hash) do
     {
@@ -10,61 +11,48 @@ describe "Creating a pacticipant version" do
     }
   end
 
-  subject { put(path, version_hash.to_json, headers) }
+  context "with a PUT" do
+    subject { put(path, version_hash.to_json, headers) }
 
-  it "returns a 201 response" do
-    expect(subject.status).to be 201
-  end
-
-  it "returns a HAL JSON Content Type" do
-    expect(subject.headers['Content-Type']).to eq 'application/hal+json;charset=utf-8'
-  end
+    it "returns a 201 response" do
+      expect(subject.status).to be 201
+    end
 
-  it "returns the newly created version" do
-    expect(response_body).to include branch: "main", buildUrl: "http://build"
-    expect(response_body[:_embedded][:tags].size).to eq 2
-  end
+    it "returns a HAL JSON Content Type" do
+      expect(subject.headers["Content-Type"]).to eq "application/hal+json;charset=utf-8"
+    end
 
-  it "creates the specified tags" do
-    expect { subject }.to change { PactBroker::Domain::Tag.count }.by(2)
-  end
+    it "returns the newly created version" do
+      expect(response_body).to include branch: "main", buildUrl: "http://build"
+      expect(response_body[:_embedded][:tags].size).to eq 2
+    end
 
-  context "when the version already exists" do
-    before do
-      td.subtract_day
-        .create_consumer("Foo")
-        .create_consumer_version("1234", branch: "original-branch", build_url: "original-build-url")
-        .create_consumer_version_tag("dev")
+    it "creates the specified tags" do
+      expect { subject }.to change { PactBroker::Domain::Tag.count }.by(2)
     end
+  end
 
-    let(:version_hash) { { branch: "new-branch" } }
+  context "with a PATCH" do
+    let(:content_type) { "application/merge-patch+json" }
 
-    it "returns a 200" do
-      expect(subject.status).to be 200
-    end
+    subject { patch(path, version_hash.to_json, headers) }
 
-    it "overwrites the direct properties" do
-      expect(response_body[:branch]).to eq "new-branch"
-      expect(response_body).to_not have_key(:buildUrl)
+    it "returns a 201 response" do
+      expect(subject.status).to be 201
     end
 
-    context "when not tags are specified" do
-      it "does not change the tags" do
-        expect { subject }.to_not change { PactBroker::Domain::Version.for("Foo", "1234").tags }
-      end
+    it "returns a HAL JSON Content Type" do
+      expect(subject.headers["Content-Type"]).to eq "application/hal+json;charset=utf-8"
     end
 
-    context "when tags are specified" do
-      let(:version_hash) { { branch: "new-branch", tags: [ { name: "main" }] } }
-
-      it "overwrites the tags" do
-        expect(response_body[:_embedded][:tags].size).to eq 1
-        expect(response_body[:_embedded][:tags].first[:name]).to eq "main"
-      end
+    it "returns the newly created version" do
+      expect(response_body).to include branch: "main", buildUrl: "http://build"
+      expect(response_body[:_embedded][:tags].size).to eq 2
     end
 
-    it "does not change the created date" do
-      expect { subject }.to_not change { PactBroker::Domain::Version.for("Foo", "1234").created_at }
+    it "creates the specified tags" do
+      expect { subject }.to change { PactBroker::Domain::Tag.count }.by(2)
     end
   end
+
 end

data/spec/features/create_webhook_spec.rb

@@ -3,7 +3,7 @@ describe "Creating a webhook" do
     td.create_pact_with_hierarchy("Some Consumer", "1", "Some Provider")
   end
 
-  let(:headers) { {'CONTENT_TYPE' => 'application/json'} }
+  let(:headers) { {"CONTENT_TYPE" => "application/json"} }
   let(:response_body) { JSON.parse(subject.body, symbolize_names: true)}
   let(:webhook_json) { webhook_hash.to_json }
   let(:webhook_hash) do
@@ -11,16 +11,16 @@ describe "Creating a webhook" do
       description: "trigger build",
       enabled: false,
       events: [{
-        name: 'contract_content_changed'
+        name: "contract_content_changed"
       }],
       request: {
-        method: 'POST',
-        url: 'https://example.org',
+        method: "POST",
+        url: "https://example.org",
         headers: {
           :"Content-Type" => "application/json"
         },
         body: {
-          a: 'body'
+          a: "body"
         }
       }
     }
@@ -37,7 +37,7 @@ describe "Creating a webhook" do
       its(:status) { is_expected.to be 400 }
 
       it "returns a JSON content type" do
-        expect(subject.headers['Content-Type']).to eq 'application/hal+json;charset=utf-8'
+        expect(subject.headers["Content-Type"]).to eq "application/hal+json;charset=utf-8"
       end
 
       it "returns the validation errors" do
@@ -49,11 +49,11 @@ describe "Creating a webhook" do
       its(:status) { is_expected.to be 201 }
 
       it "returns the Location header" do
-        expect(subject.headers['Location']).to match(%r{http://example.org/webhooks/.+})
+        expect(subject.headers["Location"]).to match(%r{http://example.org/webhooks/.+})
       end
 
       it "returns a JSON Content Type" do
-        expect(subject.headers['Content-Type']).to eq 'application/hal+json;charset=utf-8'
+        expect(subject.headers["Content-Type"]).to eq "application/hal+json;charset=utf-8"
       end
 
       it "returns the newly created webhook" do
@@ -130,11 +130,11 @@ describe "Creating a webhook" do
     its(:status) { is_expected.to be 201 }
 
     it "returns the Location header" do
-      expect(subject.headers['Location']).to match(%r{http://example.org/webhooks/.+})
+      expect(subject.headers["Location"]).to match(%r{http://example.org/webhooks/.+})
     end
 
     it "returns a JSON Content Type" do
-      expect(subject.headers['Content-Type']).to eq 'application/hal+json;charset=utf-8'
+      expect(subject.headers["Content-Type"]).to eq "application/hal+json;charset=utf-8"
     end
 
     it "returns the newly created webhook" do

data/spec/features/delete_environment_spec.rb

@@ -1,4 +1,4 @@
-require 'pact_broker/api/pact_broker_urls'
+require "pact_broker/api/pact_broker_urls"
 
 describe "Deleting an environment" do
   before do

data/spec/features/delete_label_spec.rb

@@ -12,7 +12,7 @@ describe "Deleting a label" do
 
   let(:path) { "/pacticipants/foo/labels/ios" }
   let(:response_body_hash) { JSON.parse(subject.body, symbolize_names: true) }
-  let(:expected_response_body) { {name: 'ios'} }
+  let(:expected_response_body) { {name: "ios"} }
 
   subject { delete path; last_response  }
 

data/spec/features/delete_pact_spec.rb

@@ -1,6 +1,6 @@
 describe "Deleting a pact" do
 
-  let(:pact_content) { load_fixture('a_consumer-a_provider.json') }
+  let(:pact_content) { load_fixture("a_consumer-a_provider.json") }
   let(:path) { "/pacts/provider/A%20Provider/consumer/A%20Consumer/version/1.2.3" }
   let(:response_body_json) { JSON.parse(subject.body) }
 

data/spec/features/delete_verification_spec.rb

@@ -1,11 +1,11 @@
-require 'support/test_data_builder'
-require 'pact_broker/api/pact_broker_urls'
+require "support/test_data_builder"
+require "pact_broker/api/pact_broker_urls"
 
 describe "Delete a verification" do
   let!(:verification) do
     TestDataBuilder.new
       .create_pact_with_verification("Foo", "1", "Bar", "2")
-      .create_provider_webhook(event_names: ['provider_verification_published'])
+      .create_provider_webhook(event_names: ["provider_verification_published"])
       .create_triggered_webhook
       .create_webhook_execution
       .and_return(:verification)

data/spec/features/delete_version_spec.rb

@@ -1,4 +1,4 @@
-require 'spec/support/test_data_builder'
+require "spec/support/test_data_builder"
 
 describe "Delete version" do
 

data/spec/features/delete_webhook_spec.rb

@@ -1,4 +1,4 @@
-require 'support/test_data_builder'
+require "support/test_data_builder"
 
 describe "Delete a webhook" do
 
@@ -27,4 +27,8 @@ describe "Delete a webhook" do
     subject
     expect(last_response.status).to eq 204
   end
+
+  it "does not delete the triggered webhooks because these are needed to calculate the webhook status" do
+    expect { subject }.to_not change { PactBroker::Webhooks::TriggeredWebhook.count }
+  end
 end

data/spec/features/edit_webhook_spec.rb

@@ -1,4 +1,4 @@
-require 'support/test_data_builder'
+require "support/test_data_builder"
 
 describe "Creating a webhook" do
 
@@ -10,11 +10,11 @@ describe "Creating a webhook" do
   end
 
   let(:path) { "/webhooks/#{td.webhook.uuid}" }
-  let(:headers) { {'CONTENT_TYPE' => 'application/json'} }
+  let(:headers) { {"CONTENT_TYPE" => "application/json"} }
   let(:response_body) { JSON.parse(last_response.body, symbolize_names: true)}
   let(:webhook_json) do
-    h = load_json_fixture('webhook_valid.json')
-    h['request']['url'] = 'https://bar.com'
+    h = load_json_fixture("webhook_valid.json")
+    h["request"]["url"] = "https://bar.com"
     h.to_json
   end
 
@@ -23,7 +23,7 @@ describe "Creating a webhook" do
   subject { put path, webhook_json, headers; last_response }
 
   context "with invalid attributes" do
-    let(:webhook_json) { '{}' }
+    let(:webhook_json) { "{}" }
 
     it "returns a 400" do
       subject
@@ -36,7 +36,7 @@ describe "Creating a webhook" do
     end
 
     it "does not update the webhook" do
-      expect(reloaded_webhook.request.method).to eq 'POST'
+      expect(reloaded_webhook.request.method).to eq "POST"
     end
   end
 
@@ -50,12 +50,12 @@ describe "Creating a webhook" do
 
     it "returns a JSON Content Type" do
       subject
-      expect(last_response.headers['Content-Type']).to eq 'application/hal+json;charset=utf-8'
+      expect(last_response.headers["Content-Type"]).to eq "application/hal+json;charset=utf-8"
     end
 
     it "updates the webhook" do
       subject
-      expect(reloaded_webhook.request.url).to eq 'https://bar.com'
+      expect(reloaded_webhook.request.url).to eq "https://bar.com"
     end
   end
 end

data/spec/features/end_support_spec.rb

@@ -0,0 +1,67 @@
+RSpec.describe "End support" do
+  let!(:version) { td.create_consumer("Foo").create_consumer_version("1").and_return(:consumer_version) }
+  let!(:test_environment) { td.create_environment("test").and_return(:environment) }
+  let!(:released_version) do
+    td.create_released_version_for_consumer_version(environment_name: "test", created_at: DateTime.now - 2, currently_supported: currently_supported)
+      .and_return(:released_version)
+  end
+  let(:currently_supported) { true }
+  let(:path) { PactBroker::Api::PactBrokerUrls.released_version_url(released_version) }
+  let(:request_body) { { currentlySupported: false }.to_json }
+  let(:response_body_hash) { JSON.parse(subject.body) }
+  let(:rack_headers) do
+    { "HTTP_ACCEPT" => "application/hal+json", "CONTENT_TYPE" => "application/merge-patch+json" }
+  end
+
+  subject { patch(path, request_body, rack_headers) }
+
+  it "marks the deployed version as not currently supported" do
+    expect{ subject }.to change {
+      PactBroker::Deployments::ReleasedVersion.find(uuid: released_version.uuid).currently_supported
+    }.from(true).to(false)
+  end
+
+  it "returns the updated resource" do
+    expect(response_body_hash["currentlySupported"]).to be false
+    expect(response_body_hash["supportEndedAt"]).to_not be nil
+  end
+
+  context "with an empty body" do
+    let(:request_body) { {}.to_json }
+
+    it "does nothing to the resource" do
+      expect{ subject }.to_not change {
+        PactBroker::Deployments::ReleasedVersion.find(uuid: released_version.uuid).values
+      }
+    end
+
+    it "returns the resource" do
+      expect(response_body_hash["uuid"]).to eq released_version.uuid
+    end
+  end
+
+  context "when the version is already unsupported" do
+    let(:currently_supported) { false }
+
+    it "returns the resource" do
+      expect(response_body_hash["currentlySupported"]).to be false
+      expect(response_body_hash["supportEndedAt"]).to_not be nil
+    end
+
+    it "does not change the supportEndedAt date" do
+      expect{ subject }.to_not change {
+        PactBroker::Deployments::ReleasedVersion.find(uuid: released_version.uuid).support_ended_at
+      }
+    end
+
+    context "when trying to mark it as currentlySupported again" do
+      let(:request_body) { { currentlySupported: true }.to_json }
+
+      its(:status) { is_expected.to eq 422 }
+
+      it "returns an error" do
+        expect(response_body_hash["errors"]["currentlySupported"].first).to include "cannot be set back"
+      end
+    end
+  end
+end

data/spec/features/execute_unsaved_webhook_spec.rb

@@ -1,11 +1,8 @@
-require 'support/test_data_builder'
-require 'webmock/rspec'
-require 'rack/pact_broker/database_transaction'
+require "support/test_data_builder"
+require "webmock/rspec"
+require "rack/pact_broker/database_transaction"
 
 describe "Execute a webhook" do
-
-  let(:td) { TestDataBuilder.new }
-
   before do
     td.create_pact_with_hierarchy("Foo", "1", "Bar")
     allow(PactBroker.configuration).to receive(:webhook_scheme_whitelist).and_return(%w[http])
@@ -14,10 +11,10 @@ describe "Execute a webhook" do
   let(:params) do
     {
       request: {
-        method: 'POST',
-        url: 'http://example.org',
-        headers: {'Content-Type' => 'application/json'},
-        body: '${pactbroker.pactUrl}'
+        method: "POST",
+        url: "http://example.org",
+        headers: {"Content-Type" => "application/json"},
+        body: "${pactbroker.pactUrl}"
       }
     }
   end

data/spec/features/execute_webhook_spec.rb

@@ -1,11 +1,11 @@
-require 'support/test_data_builder'
-require 'webmock/rspec'
-require 'rack/pact_broker/database_transaction'
+require "support/test_data_builder"
+require "webmock/rspec"
+require "rack/pact_broker/database_transaction"
 
 describe "Execute a webhook" do
   before do
     td.create_pact_with_hierarchy("Foo", "1", "Bar")
-      .create_webhook(method: 'POST', body: '${pactbroker.pactUrl}')
+      .create_webhook(method: "POST", body: "${pactbroker.pactUrl}")
   end
 
   let(:td) { TestDataBuilder.new }
@@ -70,7 +70,7 @@ describe "Execute a webhook" do
     before do
       PactBroker::Database.truncate
       td.create_pact_with_hierarchy("Some Consumer", "1", "Some Provider")
-        .create_webhook(method: 'POST')
+        .create_webhook(method: "POST")
     end
 
     after do