pact_broker 2.7.0.beta.1 → 2.7.0.beta.2

data/script/seed-matrix.rb

@@ -0,0 +1,71 @@
+#!/usr/bin/env ruby
+
+raise "Please supply database path" unless ARGV[0]
+
+$LOAD_PATH.unshift './lib'
+$LOAD_PATH.unshift './spec'
+ENV['RACK_ENV'] = 'development'
+require 'sequel'
+require 'logger'
+DATABASE_CREDENTIALS = {logger: Logger.new($stdout), adapter: "sqlite", database: ARGV[0], :encoding => 'utf8'}
+connection = Sequel.connect(DATABASE_CREDENTIALS)
+connection.timezone = :utc
+require 'pact_broker/db'
+PactBroker::DB.connection = connection
+require 'pact_broker'
+require 'support/test_data_builder'
+
+
+tables_to_clean = [:labels, :webhook_executions, :triggered_webhooks, :verifications, :pact_publications, :pact_versions, :pacts, :pact_version_contents, :tags, :versions, :webhook_headers, :webhooks, :pacticipants]
+
+tables_to_clean.each do | table_name |
+  connection[table_name].delete if connection.table_exists?(table_name)
+end
+
+=begin
+
+A -> B ->  C
+
+1  s  1  f   1
+
+      2   s  2
+
+=end
+
+# TestDataBuilder.new.create_pact_with_hierarchy("A", "1.2.3", "B")
+#               .use_provider("B")
+#               .create_version("2.0.0")
+#               .create_provider("C")
+#               .create_version("3.0.0")
+#               .create_pact
+
+TestDataBuilder.new
+  .create_pact_with_hierarchy("A", "1", "B")
+  .create_verification(provider_version: '1', success: false)
+  .create_verification(provider_version: '2', number: 2)
+  .create_verification(provider_version: '4', number: 3)
+  .create_provider_version("5")
+  .use_consumer("B")
+  .use_consumer_version("1")
+  .create_provider("C")
+  .create_pact
+  .create_verification(provider_version: '1', success: false)
+  .use_consumer_version("2")
+  .create_pact
+  .create_verification(provider_version: '2', success: true)
+  .create_consumer_version("3")
+  .create_pact
+  .create_pact_with_hierarchy("the-example-application", "391c43cae8c0e83c570c191f7324fccd67e53abc", "another-example-application")
+  .create_verification(provider_version: '391c43cae8c0e83c570c191f7324fccd67e53abc')
+  .create_verification(provider_version: '57fa24e44efc4d8aa42bb855a8217f145b5b1b5b', number: 2, success: false)
+  .create_verification(provider_version: '4', number: 3)
+  .use_consumer("another-example-application")
+  .use_consumer_version("391c43cae8c0e83c570c191f7324fccd67e53abc")
+  .create_provider("a-third-example-application")
+  .create_pact
+  .create_verification(provider_version: '391c43cae8c0e83c570c191f7324fccd67e53abc', success: false)
+  .use_consumer_version("57fa24e44efc4d8aa42bb855a8217f145b5b1b5b")
+  .create_pact
+  .create_verification(provider_version: '57fa24e44efc4d8aa42bb855a8217f145b5b1b5b', success: true)
+
+

data/script/seed.rb

@@ -59,12 +59,9 @@ TestDataBuilder.new
   .create_verification(provider_version: "1.4.234", success: true, execution_date: DateTime.now - 15)
   .revise_pact
   .create_consumer_version("1.2.101")
-  .create_consumer_version_tag('prod')
   .publish_pact
-  .create_verification(provider_version: "9.9.10", success: false, execution_date: DateTime.now - 15)
   .create_consumer_version("1.2.102")
   .publish_pact(created_at: (Date.today - 7).to_datetime)
-  .create_verification(provider_version: "9.9.9", success: true, execution_date: DateTime.now - 14)
   .create_provider("Animals")
   .create_webhook(method: 'GET', url: 'http://localhost:9393/')
   .publish_pact(created_at: (Time.now - 140).to_datetime)
@@ -79,8 +76,6 @@ TestDataBuilder.new
   .create_provider("The back end")
   .create_webhook(method: 'GET', url: 'http://localhost:9393/')
   .create_consumer_version("1.2.106")
-  .create_consumer_version_tag("production")
-  .create_consumer_version_tag("feat-x")
   .publish_pact
   .create_consumer("Some other app")
   .create_provider("A service")

data/spec/features/get_matrix_spec.rb

@@ -10,7 +10,10 @@ describe "Get matrix for consumer and provider" do
   let(:path) { "/matrix" }
   let(:params) do
     {
-      selectors: ['Consumer/version/1.0.0','Provider/version/4.5.6']
+      q: [
+        { pacticipant: 'Consumer', version: '1.0.0' },
+        { pacticipant: 'Provider', version: '4.5.6' }
+      ]
     }
   end
   let(:last_response_body) { JSON.parse(subject.body, symbolize_names: true) }

data/spec/lib/pact_broker/api/decorators/matrix_decorator_spec.rb

@@ -3,10 +3,12 @@ require 'pact_broker/api/decorators/matrix_decorator'
 module PactBroker
   module Api
     module Decorators
-      describe MatrixPactDecorator do
+      describe MatrixDecorator do
         describe "to_json" do
           let(:verification_date) { DateTime.new(2017, 12, 31) }
           let(:pact_created_at) { DateTime.new(2017, 1, 1) }
+          let(:line_1_success) { true }
+          let(:line_2_success) { true }
           let(:line_1) do
             {
               consumer_name: "Consumer",
@@ -15,7 +17,7 @@ module PactBroker
               pact_created_at: pact_created_at,
               provider_version_number: "4.5.6",
               provider_name: "Provider",
-              success: true,
+              success: line_1_success,
               number: 1,
               build_url: nil,
               verification_executed_at: verification_date
@@ -30,10 +32,10 @@ module PactBroker
               pact_created_at: pact_created_at,
               provider_version_number: nil,
               provider_name: "Provider",
-              success: nil,
+              success: line_2_success,
               number: nil,
               build_url: nil,
-              verification_executed_at: nil
+              verification_executed_at: verification_date
             }
           end
 
@@ -94,7 +96,7 @@ module PactBroker
           end
 
           let(:lines){ [line_1, line_2]}
-          let(:json) { MatrixPactDecorator.new(lines).to_json(user_options: { base_url: 'http://example.org' }) }
+          let(:json) { MatrixDecorator.new(lines).to_json(user_options: { base_url: 'http://example.org' }) }
           let(:parsed_json) { JSON.parse(json, symbolize_names: true) }
 
           it "includes the consumer details" do
@@ -113,11 +115,19 @@ module PactBroker
             expect(parsed_json[:matrix][0][:pact]).to eq pact_hash
           end
 
+          it "includes a summary" do
+            expect(parsed_json[:summary][:deployable]).to eq true
+            expect(parsed_json[:summary][:reason]).to match /All verification results are published/
+          end
+
           context "when the pact has not been verified" do
-            let(:verification_hash) do
-              nil
+            before do
+              line_2[:success] = nil
+              line_2[:verification_executed_at] = nil
             end
 
+            let(:verification_hash) { nil }
+
             it "has empty provider details" do
               expect(parsed_json[:matrix][1][:provider]).to eq provider_hash.merge(version: nil)
             end
@@ -126,6 +136,30 @@ module PactBroker
               expect(parsed_json[:matrix][1][:verificationResult]).to eq verification_hash
             end
           end
+
+          context "when one or more successes are nil" do
+            let(:line_1_success) { nil }
+
+            it "has a deployable flag of nil" do
+              expect(parsed_json[:summary][:deployable]).to be nil
+            end
+
+            it "has an explanation" do
+              expect(parsed_json[:summary][:reason]).to match /Missing/
+            end
+          end
+
+          context "when one or more successes are false" do
+            let(:line_1_success) { false }
+
+            it "has a deployable flag of false" do
+              expect(parsed_json[:summary][:deployable]).to be false
+            end
+
+            it "has an explanation" do
+              expect(parsed_json[:summary][:reason]).to match /have failed/
+            end
+          end
         end
       end
     end

data/spec/lib/pact_broker/api/resources/matrix_spec.rb

@@ -7,18 +7,22 @@ module PactBroker
       describe Matrix do
         before do
           allow(PactBroker::Matrix::Service).to receive(:validate_selectors).and_return(error_messages)
+          allow(PactBroker::Matrix::Service).to receive(:find).and_return([])
+          allow(PactBroker::Matrix::ParseQuery).to receive(:call).and_return([selectors, options])
         end
 
         let(:td) { TestDataBuilder.new }
         let(:path) { "/matrix" }
         let(:json_response_body) { JSON.parse(subject.body, symbolize_names: true) }
-        let(:params) { { selectors: ['Foo/version/1', 'Bar/version/2'] } }
+        let(:params) { {q: [{pacticipant: 'Foo', version: '1'}, {pacticipant: 'Bar', version: '2'}]} }
         let(:error_messages) { [] }
+        let(:selectors) { double('selectors') }
+        let(:options) { double('options') }
 
         subject { get path, params, {'Content-Type' => 'application/hal+json'}; last_response }
 
         it "validates the selectors" do
-          expect(PactBroker::Matrix::Service).to receive(:validate_selectors).with(['Foo/version/1', 'Bar/version/2'])
+          expect(PactBroker::Matrix::Service).to receive(:validate_selectors).with(selectors)
           subject
         end
 

data/spec/lib/pact_broker/app_spec.rb

@@ -65,6 +65,75 @@ module PactBroker
       end
     end
 
+    describe "use_xxx_auth" do
+      class TestAuth
+        def initialize app, *args, &block
+          @app = Rack::Auth::Basic.new(app, "Protected") do | username, password |
+            username == 'foo' && password == 'bar'
+          end
+        end
+
+        def call(env)
+          @app.call(env)
+        end
+      end
+
+      describe "use_api_auth" do
+        it "allows the API to be protected" do
+          app.use_api_auth TestAuth
+
+          basic_authorize 'foo', 'bar'
+          get "/"
+          expect(last_response.status).to eq 200
+
+          basic_authorize 'foo', 'wrong'
+          get "/"
+          expect(last_response.status).to eq 401
+          expect(last_response.headers["WWW-Authenticate"]).to eq "Basic realm=\"Protected\""
+        end
+      end
+
+      describe "use_ui_auth" do
+        it "allows the UI to be protected" do
+          app.use_ui_auth TestAuth
+
+          basic_authorize 'foo', 'bar'
+          get "/", nil, {'HTTP_ACCEPT' => 'text/html'}
+          expect(last_response.status).to eq 200
+
+          basic_authorize 'foo', 'wrong'
+          get "/", nil, {'HTTP_ACCEPT' => 'text/html'}
+          expect(last_response.status).to eq 401
+          expect(last_response.headers["WWW-Authenticate"]).to eq "Basic realm=\"Protected\""
+        end
+      end
+
+      context "ordering of calls" do
+        class TestAuth1
+          def initialize app; end
+          def call env; end
+        end
+
+        class TestAuth2 < TestAuth1; end
+
+        before do
+          allow(TestAuth1).to receive(:new).and_return(test_auth_1)
+          allow(TestAuth2).to receive(:new).and_return(test_auth_2)
+        end
+
+        let(:test_auth_1) { instance_double('TestAuth1', call: [404, {}, []]) }
+        let(:test_auth_2) { instance_double('TestAuth2', call: [404, {}, []]) }
+
+        it "calls the UI auth before the API auth" do
+          expect(test_auth_1).to receive(:call).ordered
+          expect(test_auth_2).to receive(:call).ordered
+          app.use_ui_auth TestAuth1
+          app.use_api_auth TestAuth2
+          get "/", nil, {'HTTP_ACCEPT' => 'text/html'}
+        end
+      end
+    end
+
     describe "authenticate" do
       before do
         PactBroker.configuration.authenticate do | resource, authorization_header, options |

data/spec/lib/pact_broker/domain/relationship_spec.rb

@@ -13,7 +13,7 @@ module PactBroker
           allow(webhook_executions).to receive(:sort).and_return(webhook_executions)
         end
 
-        subject { Relationship.create(nil, nil, nil, true, nil, [], webhook_executions) }
+        subject { Relationship.create(nil, nil, nil, nil, [], webhook_executions) }
 
         it "returns the created_at date of the last execution" do
           expect(subject.last_webhook_execution_date).to eq DateTime.new(2015)

data/spec/lib/pact_broker/matrix/parse_query_spec.rb

@@ -0,0 +1,79 @@
+require 'pact_broker/matrix/parse_query'
+
+module PactBroker
+  module Matrix
+    describe ParseQuery do
+      describe ".call" do
+        let(:query) { "q[][pacticipant]=Foo&q[][version]=1.2.3&q[][pacticipant]=Bar&q[][version]=9.9.9" }
+
+        subject { ParseQuery.call(query) }
+
+        it "extracts the pacticipant names and respective versions" do
+          expect(subject.first).to eq([{ pacticipant_name: "Foo", pacticipant_version_number: "1.2.3" }, { pacticipant_name: "Bar", pacticipant_version_number: "9.9.9" }])
+        end
+
+        context "with spaces" do
+          let(:query) { "q[][pacticipant]=Name%20With%20Spaces&q[][version]=1%202" }
+
+          it "works" do
+            expect(subject.first).to eq [{pacticipant_name: "Name With Spaces", pacticipant_version_number: "1 2"}]
+          end
+        end
+
+        context "with no q" do
+          let(:query) { "foo" }
+
+          it "returns an empty hash" do
+            expect(subject.first).to eq([])
+          end
+        end
+
+        context "with an incorrect param names" do
+          let(:query) { "q[][wrong]=Foo&q[][blah]=1.2.3" }
+
+          it "returns nil keys or values" do
+            expect(subject.first).to eq [{ pacticipant_name: nil, pacticipant_version_number: nil }]
+          end
+        end
+
+        context "with no options specified" do
+          let(:query) { "" }
+
+          it "does not set any options" do
+            expect(subject.last).to eq({})
+          end
+        end
+
+        context "with just one status specified" do
+          let(:query) { "success=true" }
+          it "extracts the one status" do
+            expect(subject.last).to eq success: [true]
+          end
+        end
+
+        context "with an array of statuses" do
+          let(:query) { "success[]=true&success[]=false&success[]=" }
+          it "extracts the statuses" do
+            expect(subject.last).to eq success: [true, false, nil]
+          end
+        end
+
+        context "with success[]=" do
+          let(:query) { "success[]=&foo=bar" }
+
+          it "sets an array with a nil success" do
+            expect(subject.last).to eq(success: [nil])
+          end
+        end
+
+        context "with success=" do
+          let(:query) { "success=&foo=bar" }
+
+          it "sets an array with a nil success" do
+            expect(subject.last).to eq(success: [nil])
+          end
+        end
+      end
+    end
+  end
+end