pact_broker 2.66.0 → 2.70.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2ded381f9c89732b48d2d27f1f9dc7c26708a54c407c6a777a0f698c221d03b5
-  data.tar.gz: 9ac73a1fde0c35b5cc5870e8006556bcc74a5c3765d86ba373b9a91040657b14
+  metadata.gz: b57a2f04694ce119675cd5b4fb647e1c2faff71b890958391ca30846ef0d7fab
+  data.tar.gz: 8b6484329b0821600417fc17ad564a14de06edf2edc21939423c34ea2795cee1
 SHA512:
-  metadata.gz: 15667e1349e7ff6a2484016659d1eee0a26d95471ea6f0f959135f72b2fcf68714a550421a1ff239efa089514ef0064a07602cd84c22f60fedfc82b30a2337a0
-  data.tar.gz: e1c836e2cc3b82096ee5d03c9fe215e5010a7b0eef2aad43781a8713e5e8f8b987fbc86c19d5b5c95c819831a6d07f953a3b8b552d6104b3daddc5a1e62680d0
+  metadata.gz: e4d1c82adbbb041f38d64200ccb0f1fc8d4672f3a9e445db0dcf428b25c8353c5922a3fb579b74560114df476886fb8aee93d2b793643ae9bbbbd8f786fec443
+  data.tar.gz: dc130a9cea4a62c741c401290b385f807c4597073a1ae467d3b334bd058267eca2179ebb6be60d53c2f6cf7046c7b567edf473738a2642e122d1c6e40938301a

data/.github/workflows/release_gem.yml

@@ -19,11 +19,17 @@ jobs:
     #     checkInterval: 15
     #   env:
     #     GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
-    - uses: pact-foundation/release-gem@v0.0.11
+    - id: release-gem
+      uses: pact-foundation/release-gem@v0.0.11
       env:
         GEM_HOST_API_KEY: '${{ secrets.RUBYGEMS_API_KEY }}'
         GITHUB_TOKEN: '${{ secrets.GITHUB_TOKEN }}'
         INCREMENT: '${{ github.event.client_payload.increment }}'
+    outputs:
+      gem_name: "${{ steps.release-gem.outputs.gem_name }}"
+      version: "${{ steps.release-gem.outputs.version }}"
+      increment: "${{ steps.release-gem.outputs.increment }}"
+
   notify-gem-released:
     needs: release
     strategy:

data/.github/workflows/test.yml

@@ -0,0 +1,62 @@
+name: Test
+
+on: push
+
+jobs:
+  postgres:
+    runs-on: "ubuntu-latest"
+    strategy:
+      matrix:
+        ruby_version: ["2.5", "2.7"]
+    services:
+      postgres:
+        image: postgres
+        env:
+          POSTGRES_PASSWORD: postgres
+        options: >-
+          --health-cmd pg_isready
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+        ports:
+          - 5432:5432
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby_version }}
+      - run: "bundle install"
+        env:
+          INSTALL_PG: "true"
+      - run: "bundle exec rake"
+        env:
+          DATABASE_ADAPTER: github_actions_postgres
+          INSTALL_PG: "true"
+  mysql:
+    runs-on: "ubuntu-latest"
+    strategy:
+      matrix:
+        ruby_version: ["2.5", "2.7"]
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby_version }}
+      - uses: mirromutth/mysql-action@v1.1
+        with:
+          host port: 3306 # Optional, default value is 3306. The port of host
+          #container port: 3307 # Optional, default value is 3306. The port of container
+          character set server: 'utf8' # Optional, default value is 'utf8mb4'. The '--character-set-server' option for mysqld
+          collation server: 'utf8_general_ci' # Optional, default value is 'utf8mb4_general_ci'. The '--collation-server' option for mysqld
+          mysql version: '8.0' # Optional, default value is "latest". The version of the MySQL
+          mysql database: 'pact_broker' # Optional, default value is "test". The specified database which will be create
+          mysql root password: 'pact_broker' # Required if "mysql user" is empty, default is empty. The root superuser password
+          mysql user: 'pact_broker' # Required if "mysql root password" is empty, default is empty. The superuser for the specified database. Can use secrets, too
+          mysql password: 'pact_broker' # Required if "mysql user" exists. The password for the "mysql user"
+      - run: "bundle install"
+        env:
+          INSTALL_MYSQL: "true"
+      - run: "bundle exec rake"
+        env:
+          DATABASE_ADAPTER: github_actions_mysql
+          INSTALL_MYSQL: "true"

data/CHANGELOG.md

@@ -1,3 +1,73 @@
+<a name="v2.70.0"></a>
+### v2.70.0 (2020-11-28)
+
+#### Features
+
+* allow limit to be applied to clean task	 ([d29e5c62](/../../commit/d29e5c62))
+* optimise the query to load the tags with latest flags	 ([bc47613f](/../../commit/bc47613f))
+* optimise query to find head tags for a pact	 ([67309e37](/../../commit/67309e37))
+
+* **wip pacts**
+  * experimental feature - if no provider versions exist, consider all head pacts wip	 ([a635cc53](/../../commit/a635cc53))
+
+#### Bug Fixes
+
+* return empty body when group csv is requested for a pacticipant that does not have any integrations	 ([fb4e28ce](/../../commit/fb4e28ce))
+
+<a name="v2.69.0"></a>
+### v2.69.0 (2020-11-24)
+
+#### Features
+
+* **wip**
+  * keep pacts as WIP when verified via the pactUrl passed though the webhook template parameters - experimental.	 ([a9b3fef0](/../../commit/a9b3fef0))
+
+* add link to the pact content version	 ([8eefba5f](/../../commit/8eefba5f))
+* display V3 provider states in HTML (#357)	 ([8e06a7f2](/../../commit/8e06a7f2))
+* optimise query for determining latest verification for consumer and provider	 ([7889b051](/../../commit/7889b051))
+
+#### Bug Fixes
+
+* return a 404 when the base pact for a pact diff doesn't exist	 ([74d3644d](/../../commit/74d3644d))
+* Add consumer name to inclusion reason log (#358)	 ([82901891](/../../commit/82901891))
+
+<a name="v2.68.1"></a>
+### v2.68.1 (2020-10-24)
+
+#### Bug Fixes
+
+* set default User-Agent header in webhook requests	 ([caa71f9b](/../../commit/caa71f9b))
+
+<a name="v2.68.0"></a>
+### v2.68.0 (2020-10-23)
+
+#### Features
+
+* use a sequence for the version order on postgres	 ([da497a76](/../../commit/da497a76))
+* only cascade apps for 404s (not 405s)	 ([4e1b3083](/../../commit/4e1b3083))
+* use a sequence for the verification number on postgres	 ([b8f029ee](/../../commit/b8f029ee))
+* optimise query to find latest verification for pact	 ([db17ef5a](/../../commit/db17ef5a))
+
+<a name="v2.67.0"></a>
+### v2.67.0 (2020-10-16)
+
+#### Features
+
+* **wip pacts**
+  * if a pact was successfully verified because it was included as a WIP pact, keep it as WIP	 ([16cae55d](/../../commit/16cae55d))
+  * add 'wip' column to verification results	 ([34f98592](/../../commit/34f98592))
+
+#### Bug Fixes
+
+* typo when rendering created webhook for old webhooks path	 ([1e6a06a0](/../../commit/1e6a06a0))
+* include can-i-deploy badge in is_badge_path? logic	 ([31ea5f34](/../../commit/31ea5f34))
+
+* **pacts for verification**
+  * gracefully log empty request body	 ([0e48d13a](/../../commit/0e48d13a))
+
+* **can-i-deploy**
+  * gracefully handle pacticipant not found	 ([f6903b23](/../../commit/f6903b23))
+
 <a name="v2.66.0"></a>
 ### v2.66.0 (2020-10-01)
 

data/DEVELOPER_SETUP.md

@@ -28,6 +28,12 @@ This allows you to open a shell to a development environment where you can run t
 
 Remember to rebuild the image if you change any of the gems or gem versions.
 
+* Run the server on the docker image
+
+    ```sh
+    docker run --rm -v $(PWD):/home -w /home --entrypoint /bin/sh -p 9292:9292 -it pact_broker:dev /usr/local/bin/start
+    ```
+
 ### With native install
 
 * You will need to install Ruby 2.5, and preferably a ruby version manager. I recommend using [chruby][chruby] and [ruby-install][ruby-install].

data/Dockerfile

@@ -26,6 +26,7 @@ RUN wget https://github.com/jwilder/dockerize/releases/download/$DOCKERIZE_VERSI
 
 
 COPY Gemfile /home/Gemfile
+COPY Gemfile.lock /home/Gemfile.lock
 COPY pact_broker.gemspec /home/pact_broker.gemspec
 COPY lib/pact_broker/version.rb /home/lib/pact_broker/version.rb
 COPY .gitignore /home/.gitignore
@@ -33,9 +34,9 @@ COPY .gitignore /home/.gitignore
 RUN gem install bundler -v '~>2.0.0' \
     && bundle install --jobs 3 --retry 3
 
-RUN echo '#!/bin/sh' >> /home/start.sh
-RUN echo 'bundle exec rackup -o 0.0.0.0 -p 9292' >> /home/start.sh
-RUN chmod +x /home/start.sh
+RUN echo '#!/bin/sh' >> /usr/local/bin/start
+RUN echo 'bundle exec rackup -o 0.0.0.0 -p 9292' >> /usr/local/bin/start
+RUN chmod +x /usr/local/bin/start
 
 RUN echo '#!/bin/sh' >> /home/init-db.sh
 RUN echo 'bundle exec rake db:prepare:test' >> /home/init-db.sh

data/Gemfile

@@ -18,13 +18,15 @@ group :test do
   gem 'rspec-pact-matchers', '~>0.1'
   gem 'bundler-audit', '~>0.4'
   gem 'fakefs', '~>0.4'
-  gem 'webmock', '~>2.3'
+  gem 'webmock', '~>3.9'
   gem 'rspec', '~>3.0'
   gem 'rspec-its', '~>1.2'
   gem 'database_cleaner', '~>1.8', '>= 1.8.1'
   gem 'timecop', '~> 0.9'
   gem 'faraday', '~>0.15'
+  gem 'faraday_middleware', '~> 0.14'
   gem 'docker-api', '~>1.34'
+  gem 'approvals', '>=0.0.1', '<1.0.0'
 end
 
 if ENV['INSTALL_MYSQL'] == "true"
@@ -34,3 +36,7 @@ end
 if ENV['INSTALL_PG'] == 'true'
   gem 'pg', '~>1.2'
 end
+
+if ENV['X_PACT_DEVELOPMENT'] == 'true'
+  gem 'pact-support', path: '../pact-support'
+end

data/ISSUES.md

@@ -0,0 +1,23 @@
+# Issues
+
+## Reproducing an issue
+
+In [script/reproduce-issue.rb](script/reproduce-issue.rb) you will find a fluent API that allows you to simulate client libraries interacting with the Pact Broker.
+
+You can use it to easily reproduce issues.
+
+To use it:
+
+* Run the Pact Broker using the latest development code:
+
+    ```
+    docker-compose -f docker-compose-issue-repro.yml up --build pact-broker
+    ```
+
+* Run the reproduction script.
+
+    ```
+    docker-compose -f docker-compose-issue-repro.yml up repro-issue
+    ```
+
+You can modify `script/reproduce-issue.rb` and then re-run it with the change applied.

data/config/database.yml

@@ -36,6 +36,20 @@ test:
     <<: *default
     adapter: mysql2
     host: "192.168.0.9"
+  github_actions_postgres:
+    adapter: postgres
+    database: postgres
+    username: postgres
+    password: postgres
+    host: localhost
+    port: "5432"
+  github_actions_mysql:
+    adapter: mysql2
+    database: pact_broker
+    username: pact_broker
+    password: pact_broker
+    host: localhost
+    port: 3306
 
 development:
   default:

data/db/ddl_statements/latest_verification_ids_for_consumer_and_provider.rb

@@ -0,0 +1,25 @@
+LATEST_VERIFICATION_IDS_FOR_CONSUMER_AND_PROVIDER_V1 = "select
+        pv.pacticipant_id as provider_id,
+        lpp.consumer_id,
+        max(v.id) as latest_verification_id
+      from verifications v
+      join latest_pact_publications_by_consumer_versions lpp
+        on v.pact_version_id = lpp.pact_version_id
+      join versions pv
+        on v.provider_version_id = pv.id
+      group by pv.pacticipant_id, lpp.consumer_id"
+
+LATEST_VERIFICATION_IDS_FOR_CONSUMER_AND_PROVIDER_V2 = "select
+        provider_id,
+        consumer_id,
+        max(id) as latest_verification_id
+        from verifications v
+        group by provider_id, consumer_id"
+
+
+LATEST_VERIFICATION_IDS_FOR_CONSUMER_AND_PROVIDER_V3 = "select
+        provider_id,
+        consumer_id,
+        max(verification_id) as latest_verification_id
+        from latest_verification_id_for_pact_version_and_provider_version v
+        group by provider_id, consumer_id"

data/db/migrations/20180524_create_latest_verifications_for_consumer_and_provider.rb

@@ -1,17 +1,10 @@
+require_relative '../ddl_statements/latest_verification_ids_for_consumer_and_provider'
+
 Sequel.migration do
   up do
-    # The latest verification id for each consumer version tag
+    # The latest verification id for each consumer/provider
     create_view(:latest_verification_ids_for_consumer_and_provider,
-      "select
-        pv.pacticipant_id as provider_id,
-        lpp.consumer_id,
-        max(v.id) as latest_verification_id
-      from verifications v
-      join latest_pact_publications_by_consumer_versions lpp
-        on v.pact_version_id = lpp.pact_version_id
-      join versions pv
-        on v.provider_version_id = pv.id
-      group by pv.pacticipant_id, lpp.consumer_id")
+      LATEST_VERIFICATION_IDS_FOR_CONSUMER_AND_PROVIDER_V1)
 
     # The most recent verification for each consumer/consumer version tag/provider
     latest_verifications = from(:verifications)

data/db/migrations/20180614_update_latest_verification_ids_for_consumer_and_provider.rb

@@ -1,27 +1,15 @@
+require_relative '../ddl_statements/latest_verification_ids_for_consumer_and_provider'
+
 Sequel.migration do
   up do
-    # The latest verification id for each consumer version tag
+    # The latest verification id for each consumer/provider
     create_or_replace_view(:latest_verification_ids_for_consumer_and_provider,
-      "select
-        provider_id,
-        consumer_id,
-        max(id) as latest_verification_id
-        from verifications v
-        group by provider_id, consumer_id")
+          LATEST_VERIFICATION_IDS_FOR_CONSUMER_AND_PROVIDER_V2)
   end
 
   down do
-    # The latest verification id for each consumer version tag
+    # The latest verification id for each consumer/provider
     create_or_replace_view(:latest_verification_ids_for_consumer_and_provider,
-      "select
-        pv.pacticipant_id as provider_id,
-        lpp.consumer_id,
-        max(v.id) as latest_verification_id
-      from verifications v
-      join latest_pact_publications_by_consumer_versions lpp
-        on v.pact_version_id = lpp.pact_version_id
-      join versions pv
-        on v.provider_version_id = pv.id
-      group by pv.pacticipant_id, lpp.consumer_id")
+      LATEST_VERIFICATION_IDS_FOR_CONSUMER_AND_PROVIDER_V1)
   end
 end

data/db/migrations/20201006_add_wip_to_verification.rb

@@ -0,0 +1,5 @@
+Sequel.migration do
+  change do
+    add_column(:verifications, :wip, TrueClass, default: false, null: false)
+  end
+end

data/db/migrations/20201023_create_verification_number_sequence.rb

@@ -0,0 +1,20 @@
+require_relative 'migration_helper'
+
+Sequel.migration do
+  up do
+    if PactBroker::MigrationHelper.postgres?
+      row = from(:verification_sequence_number).select(:value).limit(1).first
+      start = row ? row[:value] + 100 : 1
+      run("CREATE SEQUENCE verification_number_sequence START WITH #{start}")
+    end
+  end
+
+  down do
+    if PactBroker::MigrationHelper.postgres?
+      nextval = execute("SELECT nextval('verification_number_sequence') as val") { |v| v.first["val"].to_i }
+      # Add a safety margin!
+      from(:verification_sequence_number).update(value: nextval + 100)
+      run("DROP SEQUENCE verification_number_sequence")
+    end
+  end
+end

data/db/migrations/20201024_create_version_order_sequence.rb

@@ -0,0 +1,20 @@
+require_relative 'migration_helper'
+
+Sequel.migration do
+  up do
+    if PactBroker::MigrationHelper.postgres?
+      row = from(:version_sequence_number).select(:value).limit(1).first
+      start = row ? row[:value] + 100 : 1
+      run("CREATE SEQUENCE version_order_sequence START WITH #{start}")
+    end
+  end
+
+  down do
+    if PactBroker::MigrationHelper.postgres?
+      nextval = execute("SELECT nextval('version_order_sequence') as val") { |v| v.first["val"].to_i }
+      # Add a safety margin!
+      from(:version_sequence_number).update(value: nextval + 100)
+      run("DROP SEQUENCE version_order_sequence")
+    end
+  end
+end

data/db/migrations/20201026_update_latest_verification_ids_for_consumer_and_provider.rb

@@ -0,0 +1,14 @@
+require_relative 'migration_helper'
+require_relative '../ddl_statements/latest_verification_ids_for_consumer_and_provider'
+
+Sequel.migration do
+  up do
+    create_or_replace_view(:latest_verification_ids_for_consumer_and_provider,
+      LATEST_VERIFICATION_IDS_FOR_CONSUMER_AND_PROVIDER_V3)
+  end
+
+  down do
+    create_or_replace_view(:latest_verification_ids_for_consumer_and_provider,
+      LATEST_VERIFICATION_IDS_FOR_CONSUMER_AND_PROVIDER_V2)
+  end
+end

data/docker-compose-issue-repro.yml

@@ -0,0 +1,22 @@
+version: "3"
+
+services:
+  pact-broker:
+    build: .
+    ports:
+      - "9292:9292"
+    entrypoint: /usr/local/bin/start
+    environment:
+      - RACK_ENV=production
+    volumes:
+      - $PWD:/home
+
+  repro-issue:
+    build: .
+    depends_on:
+      - pact-broker
+    command: dockerize -wait http://pact-broker:9292 -timeout 30s /home/script/reproduce-issue.rb
+    environment:
+      - PACT_BROKER_BASE_URL=http://pact-broker:9292
+    volumes:
+      - $PWD:/home