pact_broker 2.47.1 → 2.48.0

data/spec/lib/pact_broker/api/decorators/verifiable_pact_decorator_spec.rb

@@ -5,53 +5,41 @@ module PactBroker
     module Decorators
       describe VerifiablePactDecorator do
         before do
-          allow_any_instance_of(PactBroker::Api::PactBrokerUrls).to receive(:pact_version_url).and_return('/pact-version-url')
-          allow_any_instance_of(PactBroker::Pacts::VerifiablePactMessages).to receive(:inclusion_reason).and_return("the inclusion reason")
-          allow_any_instance_of(PactBroker::Pacts::VerifiablePactMessages).to receive(:pending_reason).and_return(pending_reason)
-          allow_any_instance_of(PactBroker::Pacts::VerifiablePactMessages).to receive(:verification_success_true_published_false).and_return('verification_success_true_published_false')
-          allow_any_instance_of(PactBroker::Pacts::VerifiablePactMessages).to receive(:verification_success_false_published_false).and_return('verification_success_false_published_false')
-          allow_any_instance_of(PactBroker::Pacts::VerifiablePactMessages).to receive(:verification_success_true_published_true).and_return('verification_success_true_published_true')
-          allow_any_instance_of(PactBroker::Pacts::VerifiablePactMessages).to receive(:verification_success_false_published_true).and_return('verification_success_false_published_true')
+          allow_any_instance_of(PactBroker::Api::PactBrokerUrls).to receive(:pact_version_url).and_return('http://pact')
+          allow(PactBroker::Pacts::BuildVerifiablePactNotices).to receive(:call).and_return(notices)
+          allow_any_instance_of(PactBroker::Pacts::VerifiablePactMessages).to receive(:pact_version_short_description).and_return('short desc')
         end
+
         let(:pending_reason) { "the pending reason" }
+        let(:notices) do
+          [
+            {
+              some: "notice"
+            }
+          ]
+        end
         let(:expected_hash) do
           {
+            "shortDescription" => "short desc",
             "verificationProperties" => {
               "pending" => true,
               "notices" => [
                 {
-                  "when" => "before_verification",
-                  "text" => "the inclusion reason"
-                },{
-                  "when" => "before_verification",
-                  "text" => pending_reason
-                },{
-                  "when" => "after_verification:success_true_published_false",
-                  "text" => "verification_success_true_published_false"
-                },{
-                  "when" => "after_verification:success_false_published_false",
-                  "text" => "verification_success_false_published_false"
-                },{
-                  "when" => "after_verification:success_true_published_true",
-                  "text" => "verification_success_true_published_true"
-                },{
-                  "when" => "after_verification:success_false_published_true",
-                  "text" => "verification_success_false_published_true"
+                  "some" => "notice"
                 }
               ]
             },
             "_links" => {
               "self" => {
-                "href" => "/pact-version-url",
+                "href" => "http://pact",
                 "name" => "name"
               }
             }
           }
         end
-
         let(:decorator) { VerifiablePactDecorator.new(pact) }
         let(:pact) do
-          double('pact',
+          double('PactBroker::Pacts::VerifiablePact',
             pending: true,
             wip: wip,
             name: "name",
@@ -61,10 +49,10 @@ module PactBroker
         end
         let(:pending_provider_tags) { %w[dev] }
         let(:consumer_tags) { %w[dev] }
-        let(:json) { decorator.to_json(options) }
         let(:options) { { user_options: { base_url: 'http://example.org', include_pending_status: include_pending_status } } }
         let(:include_pending_status) { true }
         let(:wip){ false }
+        let(:json) { decorator.to_json(options) }
 
         subject { JSON.parse(json) }
 
@@ -77,27 +65,17 @@ module PactBroker
           subject
         end
 
-        it "creates the inclusion message" do
-          expect(PactBroker::Pacts::VerifiablePactMessages).to receive(:new).with(pact, '/pact-version-url').and_call_original
+        it "creates the notices" do
+          allow(PactBroker::Pacts::BuildVerifiablePactNotices).to receive(:call).with(pact, 'http://pact', include_pending_status: include_pending_status)
           subject
         end
 
         context "when include_pending_status is false" do
           let(:include_pending_status) { false }
-          let(:notices) { subject['verificationProperties']['notices'].collect{ | notice | notice['text'] } }
 
           it "does not include the pending flag" do
             expect(subject['verificationProperties']).to_not have_key('pending')
           end
-
-          it "does not include the pending reason" do
-            expect(subject['verificationProperties']).to_not have_key('pendingReason')
-            expect(notices).to_not include(pending_reason)
-          end
-
-          it "does not include the pending notices" do
-            expect(subject['verificationProperties']['notices'].size).to eq 1
-          end
         end
 
         context "when wip is true" do

data/spec/lib/pact_broker/api/decorators/verifiable_pacts_query_decorator_spec.rb

@@ -18,12 +18,16 @@ module PactBroker
           end
 
           let(:consumer_version_selectors) do
-            [{"tag" => "dev", "ignored" => "foo", "latest" => true}]
+            [{ "tag" => "dev", "ignored" => "foo", "latest" => true }]
+          end
+
+          it "parses the consumer_version_selectors to a Selectors collection" do
+            expect(subject.consumer_version_selectors).to be_a(PactBroker::Pacts::Selectors)
           end
 
           context "when latest is not specified" do
             let(:consumer_version_selectors) do
-              [{"tag" => "dev"}]
+              [{ "tag" => "dev" }]
             end
 
             it "defaults to nil" do
@@ -31,15 +35,25 @@ module PactBroker
             end
           end
 
+          context "with a fallback" do
+            let(:consumer_version_selectors) do
+              [{ "tag" => "feat-x", "fallbackTag" => "dev", "latest" => true }]
+            end
+
+            it "sets the fallback" do
+              expect(subject.consumer_version_selectors.first.fallback_tag).to eq "dev"
+            end
+          end
+
           it "parses the latest as a boolean" do
-            expect(subject.consumer_version_selectors.first.latest).to be true
+            expect(subject.consumer_version_selectors.first).to eq PactBroker::Pacts::Selector.new(tag: "dev", latest: true)
           end
 
           context "when there are no consumer_version_selectors" do
             let(:params) { {} }
 
             it "returns an empty array" do
-              expect(subject.consumer_version_selectors).to eq []
+              expect(subject.consumer_version_selectors).to eq PactBroker::Pacts::Selectors.new
             end
           end
 
@@ -61,7 +75,7 @@ module PactBroker
           end
 
           let(:consumer_version_selectors) do
-            [{"tag" => "dev", "latest" => "true"}]
+            [{ "tag" => "dev", "latest" => "true" }]
           end
 
           it "parses the provider_version_tags" do
@@ -69,7 +83,7 @@ module PactBroker
           end
 
           it "parses a string 'latest' to a boolean" do
-            expect(subject.consumer_version_selectors.first.latest).to be true
+            expect(subject.consumer_version_selectors.first).to eq PactBroker::Pacts::Selector.new(tag: "dev", latest: true)
           end
         end
 

data/spec/lib/pact_broker/api/decorators/version_decorator_spec.rb

@@ -42,6 +42,10 @@ module PactBroker
           expect(subject[:_links][:'pb:pacticipant']).to eq title: "Pacticipant", name: "Consumer", href: "http://example.org/pacticipants/Consumer"
         end
 
+        it "includes a link to get, create or delete a tag" do
+          expect(subject[:_links][:'pb:tag']).to include href: "http://example.org/pacticipants/Consumer/versions/1.2.3/tags/{tag}", templated: true
+        end
+
         it "includes a list of the tags" do
           expect(subject[:_embedded][:tags]).to be_instance_of(Array)
           expect(subject[:_embedded][:tags].first[:name]).to eq "prod"

data/spec/lib/pact_broker/api/resources/provider_pacts_for_verification_spec.rb

@@ -31,7 +31,7 @@ module PactBroker
             expect(PactBroker::Pacts::Service).to receive(:find_for_verification).with(
               "Bar",
               ["master"],
-              [OpenStruct.new(tag: "dev", latest: true)],
+              PactBroker::Pacts::Selectors.new([PactBroker::Pacts::Selector.latest_for_tag("dev")]),
               {
                 include_wip_pacts_since: DateTime.parse('2018-01-01'),
                 include_pending_status: true
@@ -77,7 +77,7 @@ module PactBroker
             expect(PactBroker::Pacts::Service).to receive(:find_for_verification).with(
               "Bar",
               ["master"],
-              [OpenStruct.new(tag: "dev", latest: true)],
+              PactBroker::Pacts::Selectors.new([PactBroker::Pacts::Selector.latest_for_tag("dev")]),
               {
                 include_wip_pacts_since: DateTime.parse('2018-01-01'),
                 include_pending_status: true

data/spec/lib/pact_broker/pacts/build_verifiable_pact_notices_spec.rb

@@ -0,0 +1,76 @@
+require 'pact_broker/pacts/build_verifiable_pact_notices'
+
+module PactBroker
+  module Pacts
+    describe BuildVerifiablePactNotices do
+      before do
+        allow(VerifiablePactMessages).to receive(:new).and_return(verifiable_pact_messages)
+      end
+
+      let(:verifiable_pact_messages) do
+        instance_double(VerifiablePactMessages,
+          inclusion_reason: 'the inclusion reason',
+          pending_reason: 'pending reason',
+          verification_success_true_published_false: 'verification_success_true_published_false',
+          verification_success_false_published_false: 'verification_success_false_published_false',
+          verification_success_true_published_true: 'verification_success_true_published_true',
+          verification_success_false_published_true: 'verification_success_false_published_true'
+        )
+      end
+
+      let(:options) { {} }
+      let(:pact_url) { 'http://pact' }
+      let(:verifiable_pact) { instance_double('PactBroker::Pacts::VerifiablePact') }
+
+      subject { BuildVerifiablePactNotices.call(verifiable_pact, pact_url, options) }
+
+
+      context "when include_pending_status is true" do
+        let(:expected_notices) do
+          [
+            {
+              :when => "before_verification",
+              :text => "the inclusion reason"
+            },{
+              :when => "before_verification",
+              :text => 'pending reason'
+            },{
+              :when => "after_verification:success_true_published_false",
+              :text => "verification_success_true_published_false"
+            },{
+              :when => "after_verification:success_false_published_false",
+              :text => "verification_success_false_published_false"
+            },{
+              :when => "after_verification:success_true_published_true",
+              :text => "verification_success_true_published_true"
+            },{
+              :when => "after_verification:success_false_published_true",
+              :text => "verification_success_false_published_true"
+            }
+          ]
+        end
+
+        let(:options) { { include_pending_status: true } }
+
+        it "it returns a list of notices with information about the pending status" do
+          expect(subject).to eq expected_notices
+        end
+      end
+
+      context "when include_pending_status is not true" do
+        let(:expected_notices) do
+          [
+            {
+              :when => "before_verification",
+              :text => "the inclusion reason"
+            }
+          ]
+        end
+
+        it "it returns a list of notices without information about the pending status" do
+          expect(subject).to eq expected_notices
+        end
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/pacts/repository_find_for_verification_fallback_spec.rb

@@ -0,0 +1,73 @@
+require 'pact_broker/pacts/repository'
+
+module PactBroker
+  module Pacts
+    describe Repository do
+      let(:td) { TestDataBuilder.new }
+
+      describe "#find_for_verification" do
+        def find_by_consumer_version_number(consumer_version_number)
+          subject.find{ |pact| pact.consumer_version_number == consumer_version_number }
+        end
+
+        def find_by_consumer_name_and_consumer_version_number(consumer_name, consumer_version_number)
+          subject.find{ |pact| pact.consumer_name == consumer_name && pact.consumer_version_number == consumer_version_number }
+        end
+
+        subject { Repository.new.find_for_verification("Bar", consumer_version_selectors) }
+
+        context "when there is a fallback tag specified" do
+          before do
+            td.create_pact_with_consumer_version_tag("Foo", "1", "master", "Bar")
+              .create_pact_with_consumer_version_tag("Foo", "2", "feat-x", "Bar")
+          end
+
+          let(:tag) { "feat-x" }
+          let(:fallback_tag) { "master" }
+          let(:selector) { Selector.new(tag: tag, fallback_tag: fallback_tag, latest: true) }
+          let(:consumer_version_selectors) { Selectors.new(selector) }
+
+          context "when a pact exists for the main tag" do
+            it "returns the pact with the main tag" do
+              expect(find_by_consumer_version_number("2")).to_not be nil
+              expect(find_by_consumer_version_number("2").selectors.first).to eq Selector.latest_for_tag(tag)
+            end
+
+            it "does not set the fallback_tag on the selector" do
+              expect(find_by_consumer_version_number("2").selectors.first.fallback_tag).to be nil
+            end
+          end
+
+          context "when a pact does not exist for the main tag and pact exists for the fallback tag" do
+            let(:tag) { "no-existy" }
+
+            it "returns the pact with the fallback tag" do
+              expect(find_by_consumer_version_number("1")).to_not be nil
+            end
+
+            it "sets the fallback_tag on the selector" do
+              expect(find_by_consumer_version_number("1").selectors.first.fallback_tag).to eq fallback_tag
+            end
+
+            it "sets the tag on the selector" do
+              expect(find_by_consumer_version_number("1").selectors.first.tag).to eq tag
+            end
+
+            it "sets the latest flag on the selector" do
+              expect(find_by_consumer_version_number("1").selectors.first.latest).to be true
+            end
+          end
+
+          context "when a pact does not exist for either tag or fallback_tag" do
+            let(:tag) { "no-existy" }
+            let(:fallback_tag) { "also-no-existy" }
+
+            it "returns an empty list" do
+              expect(subject).to be_empty
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/pacts/repository_find_for_verification_spec.rb

@@ -15,7 +15,6 @@ module PactBroker
           subject.find{ |pact| pact.consumer_name == consumer_name && pact.consumer_version_number == consumer_version_number }
         end
 
-
         subject { Repository.new.find_for_verification("Bar", consumer_version_selectors) }
 
         context "when there are no selectors" do
@@ -32,7 +31,7 @@ module PactBroker
               .create_pact
           end
 
-          let(:consumer_version_selectors) { [] }
+          let(:consumer_version_selectors) { Selectors.new }
 
           it "returns the latest pact for each consumer" do
             expect(subject.size).to eq 2
@@ -57,10 +56,10 @@ module PactBroker
               .create_pact
           end
 
-          let(:pact_selector_1) { double('selector', tag: 'dev', latest: true) }
-          let(:pact_selector_2) { double('selector', tag: 'prod', latest: true) }
+          let(:pact_selector_1) { Selector.latest_for_tag('dev') }
+          let(:pact_selector_2) { Selector.latest_for_tag('prod') }
           let(:consumer_version_selectors) do
-            [pact_selector_1, pact_selector_2]
+            Selectors.new(pact_selector_1, pact_selector_2)
           end
 
           it "returns the latest pact with the specified tags for each consumer" do
@@ -85,8 +84,8 @@ module PactBroker
               .create_pact
           end
 
-          let(:consumer_version_selectors) { [pact_selector_1] }
-          let(:pact_selector_1) { double('selector', tag: 'prod', latest: nil) }
+          let(:consumer_version_selectors) { Selectors.new(pact_selector_1) }
+          let(:pact_selector_1) { Selector.all_for_tag('prod') }
 
           subject { Repository.new.find_for_verification("Bar2", consumer_version_selectors) }
 
@@ -111,10 +110,9 @@ module PactBroker
               .create_consumer_version_tag("prod")
           end
 
-          let(:consumer_version_selectors) { [pact_selector_1, pact_selector_2] }
-          let(:pact_selector_1) { double('selector1', tag: 'prod', latest: nil) }
-          let(:pact_selector_2) { double('selector2', tag: 'dev', latest: true) }
-          let(:consumer_version_selectors) { [pact_selector_1, pact_selector_2] }
+          let(:pact_selector_1) { Selector.all_for_tag('prod') }
+          let(:pact_selector_2) { Selector.latest_for_tag('dev') }
+          let(:consumer_version_selectors) { Selectors.new(pact_selector_1, pact_selector_2) }
 
           it "returns a single selected pact with multiple selectors" do
             expect(subject.size).to eq 1
@@ -136,7 +134,7 @@ module PactBroker
               .create_pact
           end
 
-          let(:consumer_version_selectors) { [] }
+          let(:consumer_version_selectors) { Selectors.new }
 
           it "returns the latest pact for each provider" do
             expect(find_by_consumer_version_number("foo-latest-dev-version")).to_not be nil

data/spec/lib/pact_broker/pacts/selector_spec.rb

@@ -0,0 +1,28 @@
+require 'pact_broker/pacts/selector'
+
+module PactBroker
+  module Pacts
+    describe Selector do
+      describe "<=>" do
+        let(:overall_latest_1) { Selector.overall_latest }
+        let(:overall_latest_2) { Selector.overall_latest }
+        let(:latest_for_tag_prod) { Selector.latest_for_tag('prod') }
+        let(:latest_for_tag_dev) { Selector.latest_for_tag('dev') }
+        let(:all_prod) { Selector.all_for_tag('prod') }
+        let(:all_dev) { Selector.all_for_tag('dev') }
+
+        let(:unsorted_selectors) do
+          [all_prod, all_dev, latest_for_tag_prod, overall_latest_1, overall_latest_1, latest_for_tag_dev]
+        end
+
+        let(:expected_sorted_selectors) do
+          [overall_latest_1, overall_latest_1, latest_for_tag_dev, latest_for_tag_prod, all_dev, all_prod]
+        end
+
+        it "sorts the selectors" do
+          expect(unsorted_selectors.sort).to eq(expected_sorted_selectors)
+        end
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/pacts/selectors_spec.rb

@@ -0,0 +1,30 @@
+require 'pact_broker/pacts/selectors'
+require 'pact_broker/pacts/selector'
+
+module PactBroker
+  module Pacts
+    describe Selectors do
+      let(:selector_1) { Selector.overall_latest }
+      let(:selector_2) { Selector.latest_for_tag('dev') }
+      let(:selectors_1) { Selectors.new([selector_1]) }
+      let(:selectors_2) { Selectors.new([selector_2]) }
+      let(:selectors_array) { [selectors_1, selectors_2] }
+
+      describe "intialize" do
+        it "allows an array of Selector objects" do
+          expect(Selectors.new([selector_1, selector_2]).size).to eq 2
+        end
+
+        it "allows arguments of Selector objects" do
+          expect(Selectors.new(selector_1, selector_2).size).to eq 2
+        end
+      end
+
+      describe "+" do
+        it "returns an object of type Selector" do
+          expect(selectors_1 + selectors_2).to be_a(Selectors)
+        end
+      end
+    end
+  end
+end