pact_broker 2.2.0 → 2.3.0

data/spec/lib/pact_broker/messages_spec.rb

@@ -19,6 +19,8 @@ The name "Contracts" is very similar to the following existing consumers/provide
 If you meant to specify one of the above names, please correct the pact configuration, and re-publish the pact.
 If the pact is intended to be for a new consumer or provider, please manually create "Contracts" using the following command, and then re-publish the pact:
 $ curl -v -XPOST -H "Content-Type: application/json" -d "{\\\"name\\\": \\\"Contracts\\\"}" http://example.org/pacticipants
+If the pact broker requires authentication, include the '-u' flag with the proper credentials:
+$ curl -v -XPOST -u <username>:<password> -H "Content-Type: application/json" -d "{\\\"name\\\": \\\"Contracts\\\"}" http://example.org/pacticipants
 EOS
       }
       subject { Messages.potential_duplicate_pacticipant_message new_name, potential_duplicate_pacticipants, 'http://example.org' }

data/spec/lib/pact_broker/pacticipants/find_potential_duplicate_pacticipant_names_spec.rb

@@ -7,76 +7,58 @@ module PactBroker
 
     describe FindPotentialDuplicatePacticipantNames do
 
-      describe ".call" do
-
-        subject { FindPotentialDuplicatePacticipantNames.call(new_name, existing_names) }
-
-        context "when an existing name exactly equals the new name" do
-          let(:new_name) { 'Contracts Service' }
-          let(:existing_names) { ['Contracts Service', 'Contracts', 'Something'] }
-
-          it "does not return any potential duplicate names" do
-            expect(subject).to eq []
-          end
-        end
-
-        context "when an existing name mostly includes the new name" do
-          let(:new_name) { 'Contracts' }
-          let(:existing_names) { ['Contract Service', 'Contacts', 'Something'] }
-
-          it "returns the existing names that match" do
-            expect(subject).to eq ['Contract Service']
-          end
-        end
-
-        context "when a new name mostly includes an existing name" do
-          let(:new_name) { 'Contract Service' }
-          let(:existing_names) { ['Contracts', 'Contacts', 'Something'] }
-
-          it "returns the existing names that match" do
-            expect(subject).to eq ['Contracts']
-          end
-        end
-
-        context 'when a new name is the same but a different case' do
-          let(:new_name) { 'Contract Service' }
-          let(:existing_names) { ['contracts', 'Contacts', 'Something'] }
-
-          it "returns the existing names that match" do
-            expect(subject).to eq ['contracts']
-          end
-        end
-
-        context "when a new name is the same as an existing name but without spaces" do
-          let(:new_name) { 'ContractService' }
-          let(:existing_names) { ['Contracts Service', 'Contacts', 'Something'] }
-
-          it "returns the existing names that match" do
-            expect(subject).to eq ['Contracts Service']
+      describe "split" do
+        TEST_CASES = [
+          ["a-foo-service", ["a", "foo", "service"]],
+          ["a_foo_service", ["a", "foo", "service"]],
+          ["FooAService", ["foo", "a", "service"]],
+          ["Foo A Service", ["foo", "a", "service"]],
+          ["S3 Bucket Service", ["s3", "bucket", "service"]],
+          ["S3BucketService", ["s3", "bucket", "service"]],
+          ["S3-Bucket-Service", ["s3", "bucket", "service"]],
+          ["S3_Bucket_Service", ["s3", "bucket", "service"]],
+        ]
+
+        TEST_CASES.each do | input, output |
+          it "splits #{input} into #{output.inspect}" do
+            expect(FindPotentialDuplicatePacticipantNames.split(input)).to eq output
           end
         end
+      end
 
-        context "when an existing name is the same as the new name but without spaces" do
-          let(:new_name) { 'Contract Service' }
-          let(:existing_names) { ['ContractsService', 'Contacts', 'Something'] }
+      describe ".call" do
 
-          it "returns the existing names that match" do
-            expect(subject).to eq ['ContractsService']
-          end
-        end
+        subject { FindPotentialDuplicatePacticipantNames.call(new_name, existing_names) }
 
-        context "when the new name is similar to an existing but with underscores or dashes instead of spaces" do
-          let(:new_name) { 'Contract_Service' }
-          let(:existing_names) { ['ContractsService', 'Contracts Service', 'contracts-service', 'Contacts', 'Something'] }
 
-          it "returns the existing names that match" do
-            expect(subject).to eq ['ContractsService', 'Contracts Service', 'contracts-service']
+        TEST_CASES = [
+          ["accounts", ["accounts-receivable"], []],
+          ["Accounts", ["Accounts Receivable"], []],
+          ["The Accounts", ["Accounts"], []],
+          ["accounts", ["account-service", "account-api", "account-provider"], ["account-service", "account-api", "account-provider"]],
+          ["accounts-api", ["account-service", "account-provider"], ["account-service", "account-provider"]],
+          ['Contracts Service', ['Contracts Service', 'Contracts', 'Something'], []],
+          ['Contracts', ['Contract Service', 'Contacts', 'Something'], ['Contract Service']],
+          ['Contracts Service', ['Contract', 'Contacts', 'Something'], ['Contract']],
+          ['Contract Service', ['Contracts', 'Contacts', 'Something'], ['Contracts']],
+          ['Contract Service', ['contracts', 'Contacts', 'Something'], ['contracts']],
+          ['ContractService', ['Contracts Service', 'Contacts', 'Something'], ['Contracts Service']],
+          ['Contract Service', ['ContractsService', 'Contacts', 'Something'], ['ContractsService']],
+          ['Contract_Service', ['ContractsService', 'Contracts Service', 'contracts-service', 'Contacts', 'Something'], ['ContractsService', 'Contracts Service', 'contracts-service']]
+        ]
+
+        TEST_CASES.each do | the_new_name, the_existing_names, the_expected_duplicates |
+          context "when the new name is #{the_new_name} and the existing names are #{the_existing_names.inspect}" do
+            let(:new_name) { the_new_name }
+            let(:existing_names) { the_existing_names }
+            let(:expected_duplicates) { the_expected_duplicates}
+
+            it "returns #{the_expected_duplicates.inspect} as the potential duplicates" do
+              expect(subject).to eq expected_duplicates
+            end
           end
         end
-
       end
-
     end
-
   end
-end
+end

data/spec/lib/pact_broker/pacts/service_spec.rb

@@ -27,7 +27,6 @@ module PactBroker
       end
 
       describe "#pact_has_changed_since_previous_version?" do
-
         let(:json_content) { { 'some' => 'json'}.to_json }
         let(:pact) { instance_double(PactBroker::Domain::Pact, json_content: json_content)}
 
@@ -61,9 +60,7 @@ module PactBroker
             expect(subject).to be_falsey
           end
         end
-
       end
-
     end
   end
 end

data/spec/lib/pact_broker/ui/view_models/relationship_spec.rb

@@ -23,9 +23,7 @@ module PactBroker
         describe "verification_status" do
           let(:domain_relationship) do
             instance_double("PactBroker::Domain::Relationship",
-              ever_verified?: ever_verified,
-              pact_changed_since_last_verification?: pact_changed,
-              latest_verification_successful?: success,
+              verification_status: verification_status,
               provider_name: "Foo",
               latest_verification_provider_version: "4.5.6")
           end
@@ -36,28 +34,28 @@ module PactBroker
           subject { Relationship.new(domain_relationship) }
 
           context "when the pact has never been verified" do
-            let(:ever_verified) { false }
+            let(:verification_status) { :never }
             its(:verification_status) { is_expected.to eq "" }
             its(:warning?) { is_expected.to be false }
             its(:verification_tooltip) { is_expected.to eq nil }
           end
 
           context "when the pact has changed since the last successful verification" do
-            let(:pact_changed) { true }
+            let(:verification_status) { :stale }
             its(:verification_status) { is_expected.to eq "warning" }
             its(:warning?) { is_expected.to be true }
             its(:verification_tooltip) { is_expected.to eq "Pact has changed since last successful verification by Foo (v4.5.6)" }
           end
 
           context "when the pact has not changed since the last successful verification" do
-            let(:pact_changed) { false }
+            let(:verification_status) { :success }
             its(:verification_status) { is_expected.to eq "success" }
             its(:warning?) { is_expected.to be false }
             its(:verification_tooltip) { is_expected.to eq "Successfully verified by Foo (v4.5.6)" }
           end
 
           context "when the pact verification failed" do
-            let(:success) { false }
+            let(:verification_status) { :failed }
             its(:verification_status) { is_expected.to eq "danger" }
             its(:warning?) { is_expected.to be false }
             its(:verification_tooltip) { is_expected.to eq "Verification by Foo (v4.5.6) failed" }

data/spec/lib/pact_broker/verifications/repository_spec.rb

@@ -25,8 +25,10 @@ module PactBroker
             .and_return(:pact)
         end
 
+        subject { Repository.new.verification_count_for_pact(pact_1) }
+
         it "returns the number of verifications for the given pact" do
-          expect(Repository.new.verification_count_for_pact(pact_1)).to eq 2
+          expect(subject).to eq 2
         end
       end
 
@@ -56,13 +58,13 @@ module PactBroker
           pact
         end
 
-        let(:verification) { Repository.new.find "Consumer1", "Provider1", pact.pact_version_sha, 2}
+        subject { Repository.new.find "Consumer1", "Provider1", pact.pact_version_sha, 2}
 
         it "finds the latest verifications for the given consumer version" do
-          expect(verification.provider_version).to eq "3.7.4"
-          expect(verification.consumer_name).to eq "Consumer1"
-          expect(verification.provider_name).to eq "Provider1"
-          expect(verification.pact_version_sha).to eq pact.pact_version_sha
+          expect(subject.provider_version).to eq "3.7.4"
+          expect(subject.consumer_name).to eq "Consumer1"
+          expect(subject.provider_name).to eq "Provider1"
+          expect(subject.pact_version_sha).to eq pact.pact_version_sha
         end
       end
 
@@ -90,37 +92,109 @@ module PactBroker
             .create_verification(number: 1)
         end
 
-        let(:latest_verifications) { Repository.new.find_latest_verifications_for_consumer_version("Consumer1", "1.2.3")}
+        subject { Repository.new.find_latest_verifications_for_consumer_version("Consumer1", "1.2.3")}
 
         it "finds the latest verifications for the given consumer version" do
-          expect(latest_verifications.first.provider_version).to eq "7.8.9"
-          expect(latest_verifications.last.provider_version).to eq "6.5.4"
+          expect(subject.first.provider_version).to eq "7.8.9"
+          expect(subject.last.provider_version).to eq "6.5.4"
         end
       end
 
       describe "#find_latest_verification_for" do
-        before do
-          TestDataBuilder.new
-            .create_provider("Provider1")
-            .create_consumer("Consumer1")
-            .create_consumer_version("1.2.3")
-            .create_pact
-            .create_verification(number: 1, provider_version: "2.3.4")
-            .create_verification(number: 2, provider_version: "7.8.9")
-            .create_consumer_version("1.0.0")
-            .create_pact
-            .create_verification(number: 1, provider_version: "5.4.3")
-            .create_provider("Provider2")
-            .create_pact
-            .create_verification(number: 1, provider_version: "6.5.4")
-            .create_consumer_version("2.0.0")
-            .create_pact
+        context "when no tag is specified" do
+          before do
+            TestDataBuilder.new
+              .create_provider("Provider1")
+              .create_consumer("Consumer1")
+              .create_consumer_version("1.2.3")
+              .create_pact
+              .create_verification(number: 1, provider_version: "2.3.4")
+              .create_verification(number: 2, provider_version: "7.8.9")
+              .create_consumer_version("1.0.0")
+              .create_pact
+              .create_verification(number: 1, provider_version: "5.4.3")
+              .create_provider("Provider2")
+              .create_pact
+              .create_verification(number: 1, provider_version: "6.5.4")
+              .create_consumer_version("2.0.0")
+              .create_pact
+          end
+
+          subject { Repository.new.find_latest_verification_for("Consumer1", "Provider1")}
+
+          it "finds the latest verifications for the given consumer version" do
+            expect(subject.provider_version).to eq "7.8.9"
+          end
         end
 
-        let(:latest_verification) { Repository.new.find_latest_verification_for("Consumer1", "Provider1")}
+        context "when a tag is specified" do
+          before do
+            TestDataBuilder.new
+              .create_provider("Provider1")
+              .create_consumer("Consumer1")
+              .create_consumer_version("1.0.0")
+              .create_consumer_version_tag("prod")
+              .create_pact
+              .create_verification(number: 1, provider_version: "1.0.0")
+              .create_verification(number: 2, provider_version: "5.4.3")
+              .create_consumer_version("1.1.0")
+              .create_consumer_version_tag("prod")
+              .create_pact
+              .create_consumer_version("1.2.3")
+              .create_pact
+              .create_verification(number: 1, provider_version: "2.3.4")
+              .create_verification(number: 2, provider_version: "7.8.9")
+              .create_provider("Provider2")
+              .create_pact
+              .create_verification(number: 1, provider_version: "6.5.4")
+              .create_consumer_version("2.0.0")
+              .create_pact
+          end
 
-        it "finds the latest verifications for the given consumer version" do
-          expect(latest_verification.provider_version).to eq "7.8.9"
+          subject { Repository.new.find_latest_verification_for("Consumer1", "Provider1", 'prod')}
+
+          it "finds the latest verifications for the given consumer version with the specified tag" do
+            expect(subject.provider_version).to eq "5.4.3"
+          end
+
+          context "when no verification exists" do
+            subject { Repository.new.find_latest_verification_for("Consumer1", "Provider1", 'foo')}
+
+            it "returns nil" do
+              expect(subject).to be nil
+            end
+          end
+        end
+
+        context "when the latest untagged verification is required" do
+          before do
+            TestDataBuilder.new
+              .create_provider("Provider1")
+              .create_consumer("Consumer1")
+              .create_consumer_version("1.0.0")
+              .create_pact
+              .create_verification(number: 1, provider_version: "1.0.0")
+              .create_verification(number: 2, provider_version: "5.4.3")
+              .create_consumer_version("1.1.0")
+              .create_consumer_version_tag("prod")
+              .create_pact
+              .create_consumer_version("1.2.3")
+              .create_consumer_version_tag("prod")
+              .create_pact
+              .create_verification(number: 1, provider_version: "2.3.4")
+              .create_verification(number: 2, provider_version: "7.8.9")
+              .create_provider("Provider2")
+              .create_pact
+              .create_verification(number: 1, provider_version: "6.5.4")
+              .create_consumer_version("2.0.0")
+              .create_pact
+          end
+
+          subject { Repository.new.find_latest_verification_for("Consumer1", "Provider1", :untagged)}
+
+          it "finds the latest verifications for the given consumer version with no tag" do
+            expect(subject.provider_version).to eq "5.4.3"
+          end
         end
       end
     end

data/spec/lib/pact_broker/verifications/verification_status_spec.rb

@@ -0,0 +1,48 @@
+require 'pact_broker/verifications/verification_status'
+
+module PactBroker
+  module Verifications
+    describe Status do
+      describe "verification_status" do
+
+        let(:latest_verification) { instance_double("PactBroker::Domain::Verification", pact_version_sha: latest_verification_pact_version_sha, success: success) }
+        let(:latest_pact) { instance_double("PactBroker::Domain::Pact", pact_version_sha: pact_pact_version_sha) }
+        let(:pact_pact_version_sha) { '1234' }
+        let(:latest_verification_pact_version_sha) { '1234' }
+        let(:success) { true }
+
+        subject { PactBroker::Verifications::Status.new(latest_pact, latest_verification) }
+
+        context "when the pact is nil (used in badge resource)" do
+          let(:latest_pact) { nil }
+          its(:to_sym) { is_expected.to eq :never }
+        end
+
+        context "when the pact has never been verified" do
+          let(:latest_verification) { nil }
+          its(:to_sym) { is_expected.to eq :never }
+        end
+
+        context "when the pact has not changed since the last successful verification" do
+          its(:to_sym) { is_expected.to eq :success }
+        end
+
+        context "when the pact has not changed since the last failed verification" do
+          let(:success) { false }
+          its(:to_sym) { is_expected.to eq :failed }
+        end
+
+        context "when the pact has changed since the last successful verification" do
+          let(:pact_pact_version_sha) { '4566' }
+          its(:to_sym) { is_expected.to eq :stale }
+        end
+
+        context "when the pact has changed since the last failed verification" do
+          let(:pact_pact_version_sha) { '4566' }
+          let(:success) { false }
+          its(:to_sym) { is_expected.to eq :failed }
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pact_broker
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.3.0
 platform: ruby
 authors:
 - Bethany Skurrie
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-04 00:00:00.000000000 Z
+date: 2017-07-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -519,6 +519,7 @@ files:
 - lib/pact_broker/api/pact_broker_urls.rb
 - lib/pact_broker/api/renderers/html_pact_renderer.rb
 - lib/pact_broker/api/resources/authentication.rb
+- lib/pact_broker/api/resources/badge.rb
 - lib/pact_broker/api/resources/base_resource.rb
 - lib/pact_broker/api/resources/group.rb
 - lib/pact_broker/api/resources/index.rb
@@ -545,6 +546,7 @@ files:
 - lib/pact_broker/api/resources/webhook_resource_methods.rb
 - lib/pact_broker/api/resources/webhooks.rb
 - lib/pact_broker/app.rb
+- lib/pact_broker/badges/service.rb
 - lib/pact_broker/config/load.rb
 - lib/pact_broker/config/save.rb
 - lib/pact_broker/config/setting.rb
@@ -639,6 +641,7 @@ files:
 - lib/pact_broker/verifications/repository.rb
 - lib/pact_broker/verifications/service.rb
 - lib/pact_broker/verifications/summary_for_consumer_version.rb
+- lib/pact_broker/verifications/verification_status.rb
 - lib/pact_broker/version.rb
 - lib/pact_broker/versions/parse_semantic_version.rb
 - lib/pact_broker/versions/repository.rb
@@ -672,6 +675,11 @@ files:
 - public/fonts/glyphicons-halflings-regular.woff
 - public/images/doc-text.svg
 - public/images/favicon.ico
+- public/images/pact-changed-orange.svg
+- public/images/pact-failed-red.svg
+- public/images/pact-unknown-lightgrey.svg
+- public/images/pact-verified-brightgreen.svg
+- public/images/pact_not_found-unknown-lightgrey.svg
 - public/javascripts/d3.v3.js.pagespeed.ce.dFNRrGTALe.js
 - public/javascripts/highlight.pack.js
 - public/javascripts/jquery-2.1.1.min.js
@@ -696,7 +704,10 @@ files:
 - spec/features/delete_version_spec.rb
 - spec/features/delete_webhook_spec.rb
 - spec/features/get_diff_spec.rb
+- spec/features/get_latest_pact_badge_spec.rb
+- spec/features/get_latest_tagged_pact_badge_spec.rb
 - spec/features/get_latest_tagged_pact_spec.rb
+- spec/features/get_latest_untagged_pact_badge_spec.rb
 - spec/features/get_latest_untagged_pact_spec.rb
 - spec/features/get_pact_spec.rb
 - spec/features/get_pact_versions_spec.rb
@@ -746,6 +757,7 @@ files:
 - spec/lib/pact_broker/api/decorators/webhook_request_decorator_spec.rb
 - spec/lib/pact_broker/api/decorators/webhooks_decorator_spec.rb
 - spec/lib/pact_broker/api/renderers/html_pact_renderer_spec.rb
+- spec/lib/pact_broker/api/resources/badge_spec.rb
 - spec/lib/pact_broker/api/resources/group_spec.rb
 - spec/lib/pact_broker/api/resources/latest_pact_spec.rb
 - spec/lib/pact_broker/api/resources/latest_verifications_for_consumer_version_spec.rb
@@ -759,6 +771,7 @@ files:
 - spec/lib/pact_broker/api/resources/webhook_spec.rb
 - spec/lib/pact_broker/api/resources/webhooks_spec.rb
 - spec/lib/pact_broker/app_spec.rb
+- spec/lib/pact_broker/badges/service_spec.rb
 - spec/lib/pact_broker/config/load_spec.rb
 - spec/lib/pact_broker/config/save_and_load_spec.rb
 - spec/lib/pact_broker/config/save_spec.rb
@@ -796,6 +809,7 @@ files:
 - spec/lib/pact_broker/verifications/repository_spec.rb
 - spec/lib/pact_broker/verifications/service_spec.rb
 - spec/lib/pact_broker/verifications/summary_for_consumer_version_spec.rb
+- spec/lib/pact_broker/verifications/verification_status_spec.rb
 - spec/lib/pact_broker/versions/parse_semantic_version_spec.rb
 - spec/lib/pact_broker/versions/repository_spec.rb
 - spec/lib/pact_broker/versions/service_spec.rb
@@ -892,7 +906,10 @@ test_files:
 - spec/features/delete_version_spec.rb
 - spec/features/delete_webhook_spec.rb
 - spec/features/get_diff_spec.rb
+- spec/features/get_latest_pact_badge_spec.rb
+- spec/features/get_latest_tagged_pact_badge_spec.rb
 - spec/features/get_latest_tagged_pact_spec.rb
+- spec/features/get_latest_untagged_pact_badge_spec.rb
 - spec/features/get_latest_untagged_pact_spec.rb
 - spec/features/get_pact_spec.rb
 - spec/features/get_pact_versions_spec.rb
@@ -942,6 +959,7 @@ test_files:
 - spec/lib/pact_broker/api/decorators/webhook_request_decorator_spec.rb
 - spec/lib/pact_broker/api/decorators/webhooks_decorator_spec.rb
 - spec/lib/pact_broker/api/renderers/html_pact_renderer_spec.rb
+- spec/lib/pact_broker/api/resources/badge_spec.rb
 - spec/lib/pact_broker/api/resources/group_spec.rb
 - spec/lib/pact_broker/api/resources/latest_pact_spec.rb
 - spec/lib/pact_broker/api/resources/latest_verifications_for_consumer_version_spec.rb
@@ -955,6 +973,7 @@ test_files:
 - spec/lib/pact_broker/api/resources/webhook_spec.rb
 - spec/lib/pact_broker/api/resources/webhooks_spec.rb
 - spec/lib/pact_broker/app_spec.rb
+- spec/lib/pact_broker/badges/service_spec.rb
 - spec/lib/pact_broker/config/load_spec.rb
 - spec/lib/pact_broker/config/save_and_load_spec.rb
 - spec/lib/pact_broker/config/save_spec.rb
@@ -992,6 +1011,7 @@ test_files:
 - spec/lib/pact_broker/verifications/repository_spec.rb
 - spec/lib/pact_broker/verifications/service_spec.rb
 - spec/lib/pact_broker/verifications/summary_for_consumer_version_spec.rb
+- spec/lib/pact_broker/verifications/verification_status_spec.rb
 - spec/lib/pact_broker/versions/parse_semantic_version_spec.rb
 - spec/lib/pact_broker/versions/repository_spec.rb
 - spec/lib/pact_broker/versions/service_spec.rb