pact_broker 2.18.0 → 2.19.0

data/spec/features/get_pact_version.rb

@@ -0,0 +1,13 @@
+describe "retrieving a pact" do
+  subject { get path; last_response  }
+
+  context "when differing case is used in the consumer and provider names" do
+    let(:td) { TestDataBuilder.new }
+    let(:pact) { td.create_pact_with_hierarchy("Foo", "1", "Bar").and_return(:pact) }
+    let!(:path) { "/pacts/provider/Bar/consumer/Foo/pact-version/#{pact.pact_version_sha}" }
+
+    it "returns a 200 Success" do
+      expect(subject.status).to be 200
+    end
+  end
+end

data/spec/features/get_provider_pacts_spec.rb

@@ -1,18 +1,16 @@
-require 'spec/support/test_data_builder'
-
 describe "Get provider pacts" do
-
-  let(:path) { "/pacts/provider/Provider/latest" }
   let(:last_response_body) { JSON.parse(subject.body, symbolize_names: true) }
-
+  let(:pact_links) { last_response_body[:_links][:'pb:pacts'] }
   subject { get path; last_response }
 
   context "when the provider exists" do
-
     before do
       TestDataBuilder.new
         .create_provider("Provider")
         .create_consumer("Consumer")
+        .create_consumer_version("0.0.1")
+        .create_consumer_version_tag("prod")
+        .create_pact
         .create_consumer_version("1.0.0")
         .create_consumer_version_tag("prod")
         .create_pact
@@ -20,22 +18,23 @@ describe "Get provider pacts" do
         .create_pact
         .create_consumer("Consumer 2")
         .create_consumer_version("4.5.6")
+        .create_consumer_version_tag("prod")
         .create_pact
     end
 
     context "with no tag specified" do
+      let(:path) { "/pacts/provider/Provider/latest" }
 
       it "returns a 200 HAL JSON response" do
         expect(subject).to be_a_hal_json_success_response
       end
 
       it "returns a list of links to the pacts" do
-        expect(last_response_body[:_links][:pacts].size).to eq 2
+        expect(pact_links.size).to eq 2
       end
     end
 
     context "with a tag specified" do
-
       let(:path) { "/pacts/provider/Provider/latest/prod" }
 
       it "returns a 200 HAL JSON response" do
@@ -43,12 +42,11 @@ describe "Get provider pacts" do
       end
 
       it "returns a list of links to the pacts" do
-        expect(last_response_body[:_links][:pacts].size).to eq 1
+        expect(pact_links.size).to eq 2
       end
     end
 
     context "with a tag with no pacts" do
-
       let(:path) { "/pacts/provider/Provider/latest/foo" }
 
       it "returns a 200 HAL JSON response" do
@@ -56,17 +54,40 @@ describe "Get provider pacts" do
       end
 
       it "returns a list of links to the pacts" do
-        expect(last_response_body[:_links][:pacts].size).to eq 0
+        expect(pact_links.size).to eq 0
       end
     end
 
+    context "with a tag for all pacts" do
+      let(:path) { "/pacts/provider/Provider/tag/prod" }
+
+      it "returns a 200 HAL JSON response" do
+        expect(subject).to be_a_hal_json_success_response
+      end
+
+      it "returns a list of links to the pacts" do
+        expect(pact_links.size).to eq 3
+      end
+    end
+
+    context "with no tag for all pacts" do
+      let(:path) { "/pacts/provider/Provider" }
+
+      it "returns a 200 HAL JSON response" do
+        expect(subject).to be_a_hal_json_success_response
+      end
+
+      it "returns a list of links to the pacts" do
+        expect(last_response_body[:_links][:'pb:pacts'].size).to eq 4
+      end
+    end
   end
 
   context "when the provider does not exist" do
+    let(:path) { "/pacts/provider/Provider" }
 
     it "returns a 404 response" do
       expect(subject).to be_a_404_response
     end
-
   end
 end

data/spec/lib/pact_broker/api/decorators/pacticipant_decorator_spec.rb

@@ -20,13 +20,15 @@ module PactBroker
 
         let(:created_at) { Time.new(2014, 3, 4) }
         let(:updated_at) { Time.new(2014, 3, 5) }
+        let(:base_url) { 'http://example.org' }
 
         before do
           pacticipant.created_at = created_at
           pacticipant.updated_at = updated_at
+          allow_any_instance_of(PacticipantDecorator).to receive(:templated_tag_url_for_pacticipant).and_return('version_tag_url')
         end
 
-        subject { JSON.parse PacticipantDecorator.new(pacticipant).to_json(user_options: {base_url: 'http://example.org'}), symbolize_names: true }
+        subject { JSON.parse PacticipantDecorator.new(pacticipant).to_json(user_options: {base_url: base_url}), symbolize_names: true }
 
         it "includes timestamps" do
           expect(subject[:createdAt]).to eq created_at.xmlschema
@@ -38,6 +40,15 @@ module PactBroker
           expect(subject[:_embedded][:labels].first[:_links][:self][:href]).to match %r{http://example.org/.*foo}
         end
 
+        it "creates the URL for a version tag" do
+          expect_any_instance_of(PacticipantDecorator).to receive(:templated_tag_url_for_pacticipant).with("Name", base_url)
+          subject
+        end
+
+        it "includes a relation for a version tag" do
+          expect(subject[:_links][:'pb:version-tag'][:href]).to eq "version_tag_url"
+        end
+
         context "when there is a latest_version" do
           before { test_data_builder.create_version("1.2.107") }
           it "includes an embedded latestVersion" do

data/spec/lib/pact_broker/api/decorators/provider_pacts_decorator_spec.rb

@@ -0,0 +1,57 @@
+require 'pact_broker/api/decorators/provider_pacts_decorator'
+
+module PactBroker
+  module Api
+    module Decorators
+      describe ProviderPactsDecorator do
+
+        let(:pacts) { [pact]}
+        let(:pact) do
+          double('pact', name: 'Pact name', consumer_name: 'Foo')
+        end
+        let(:user_options) do
+          {
+            base_url: 'http://example.org',
+            resource_url: 'http://example.org/provider-pacts',
+            title: 'title'
+          }
+        end
+
+        before do
+          allow_any_instance_of(ProviderPactsDecorator).to receive(:pact_url).and_return('pact_url')
+        end
+
+        subject { JSON.parse ProviderPactsDecorator.new(pacts).to_json(user_options: user_options), symbolize_names: true }
+
+        let(:expected) do
+          {
+            :_links => {
+              :self=> {
+                :href=> "http://example.org/provider-pacts",
+                :title => "title"
+              },
+              :provider => {
+                :href => "http://example.org/pacticipants/",
+                :title => nil
+              },
+              :"pb:pacts" =>[{
+                :href => "pact_url",
+                :title => "Pact name",
+                :name => "Foo" }],
+              :pacts => [{
+                :href => "pact_url",
+                :title => "DEPRECATED - please use the pb:pacts relation",
+                :name => "Foo"
+                }
+              ]
+            }
+          }
+        end
+
+        it "matches the expected JSON" do
+          expect(subject).to match_pact(expected)
+        end
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/api/pact_broker_urls_spec.rb

@@ -0,0 +1,16 @@
+require 'pact_broker/api/pact_broker_urls'
+
+module PactBroker
+  module Api
+    describe PactBrokerUrls do
+
+      let(:base_url) { "http://example.org" }
+
+      describe "templated_tag_url_for_pacticipant" do
+        subject { PactBrokerUrls.templated_tag_url_for_pacticipant("Bar", base_url) }
+
+        it { is_expected.to eq "http://example.org/pacticipants/Bar/versions/{version}/tags/{tag}" }
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/api/resources/badge_spec.rb

@@ -16,10 +16,10 @@ module PactBroker
           allow(PactBroker::Verifications::Status).to receive(:new).and_return(verification_status)
         end
 
-        let(:pact) { instance_double("PactBroker::Domain::Pact", consumer: consumer, provider: provider, consumer_version_number: "2") }
+        let(:pact) { instance_double("PactBroker::Domain::Pact", consumer: consumer, provider: provider, consumer_version_number: "2", revision_number: "1") }
         let(:consumer) { double('consumer') }
         let(:provider) { double('provider') }
-        let(:verification) { double("verification", provider_version_number: "3") }
+        let(:verification) { double("verification", provider_version_number: "3", number: "7") }
         let(:verification_status) { instance_double("PactBroker::Verifications::Status", to_sym: :verified) }
 
 
@@ -86,7 +86,7 @@ module PactBroker
           end
 
           it "returns a comment with the consumer and provider numbers" do
-            expect(subject.body).to include "<!-- consumer version 2 provider version 3 -->"
+            expect(subject.body).to include "<!-- consumer version 2 revision 1 provider version 3 number 7 -->"
           end
 
           context "when the label param is specified" do

data/spec/lib/pact_broker/api/resources/error_handler_spec.rb

@@ -5,7 +5,7 @@ module PactBroker
     module Resources
       describe ErrorHandler do
         describe "call" do
-          let(:error) { PactBroker::Error.new('test error') }
+          let(:error) { StandardError.new('test error') }
           let(:thing) { double('thing', call: nil, another_call: nil) }
           let(:options) { { env: env } }
           let(:request) { double('request' ) }
@@ -31,6 +31,24 @@ module PactBroker
             subject
           end
 
+          context "when the error is a PactBroker::Error or subclass" do
+            let(:error) { Class.new(PactBroker::Error).new('test error') }
+
+            it "does not invoke the api error reporters" do
+              expect(thing).to_not receive(:call).with(error, options)
+              subject
+            end
+          end
+
+          context "when the error is a PactBroker::TestError" do
+            let(:error) { PactBroker::TestError.new('test error') }
+
+            it "invokes the api error reporters" do
+              expect(thing).to receive(:call).with(error, options)
+              subject
+            end
+          end
+
           context "when the error reporter raises an error itself" do
             class TestError < StandardError; end
 

data/spec/lib/pact_broker/api/resources/latest_provider_pacts_spec.rb

@@ -0,0 +1,52 @@
+require 'pact_broker/api/resources/latest_provider_pacts'
+
+module PactBroker
+  module Api
+    module Resources
+      describe LatestProviderPacts do
+        before do
+          allow(PactBroker::Pacts::Service).to receive(:find_latest_pact_versions_for_provider).and_return(pacts)
+          allow(PactBroker::Api::Decorators::ProviderPactsDecorator).to receive(:new).and_return(decorator)
+          allow_any_instance_of(LatestProviderPacts).to receive(:resource_exists?).and_return(provider)
+        end
+
+        let(:provider) { double('provider') }
+        let(:pacts) { double('pacts') }
+        let(:path) { '/pacts/provider/Bar/latest' }
+        let(:decorator) { instance_double('PactBroker::Api::Decorators::ProviderPactsDecorator') }
+
+        subject { get path; last_response }
+
+        context "with no tag" do
+          it "finds the pacts" do
+            expect(PactBroker::Pacts::Service).to receive(:find_latest_pact_versions_for_provider).with("Bar", tag: nil)
+            subject
+          end
+
+          it "sets the correct resource title" do
+            expect(decorator).to receive(:to_json) do | options |
+              expect(options[:user_options][:title]).to eq "Latest pact versions for the provider Bar"
+            end
+            subject
+          end
+        end
+
+        context "with a tag" do
+          let(:path) { '/pacts/provider/Bar/latest/prod' }
+
+          it "finds the pacts with a tag" do
+            expect(PactBroker::Pacts::Service).to receive(:find_latest_pact_versions_for_provider).with("Bar", tag: "prod")
+            subject
+          end
+
+          it "sets the correct resource title" do
+            expect(decorator).to receive(:to_json) do | options |
+              expect(options[:user_options][:title]).to eq "Latest pact versions for the provider Bar with consumer version tag 'prod'"
+            end
+            subject
+          end
+        end
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/api/resources/provider_pacts_spec.rb

@@ -0,0 +1,75 @@
+require 'pact_broker/api/resources/provider_pacts'
+
+module PactBroker
+  module Api
+    module Resources
+      describe ProviderPacts do
+        before do
+          allow(PactBroker::Pacts::Service).to receive(:find_latest_pact_versions_for_provider).and_return(pacts)
+          allow(PactBroker::Api::Decorators::ProviderPactsDecorator).to receive(:new).and_return(decorator)
+          allow(PactBroker::Pacticipants::Service).to receive(:find_pacticipant_by_name).and_return(provider)
+        end
+
+        let(:provider) { double('provider') }
+        let(:pacts) { double('pacts') }
+        let(:decorator) { instance_double('PactBroker::Api::Decorators::ProviderPactsDecorator', to_json: json) }
+        let(:json) { {some: 'json'}.to_json }
+        let(:path) { '/pacts/provider/Bar' }
+
+        subject { get path; last_response }
+
+        it "finds the pacticipant" do
+          expect(PactBroker::Pacticipants::Service).to receive(:find_pacticipant_by_name).with("Bar")
+          subject
+        end
+
+        it "returns a 200 response status" do
+          expect(subject.status).to eq 200
+        end
+
+        it "returns a json response" do
+          expect(subject.headers['Content-Type']).to eq "application/hal+json;charset=utf-8"
+          expect(subject.body).to eq json
+        end
+
+        context "with no tag" do
+          it "finds all the pacts for the given provider" do
+            expect(PactBroker::Pacts::Service).to receive(:find_pact_versions_for_provider).with("Bar", tag: nil)
+            subject
+          end
+
+          it "sets the correct resource title" do
+            expect(decorator).to receive(:to_json) do | options |
+              expect(options[:user_options][:title]).to eq "All pact versions for the provider Bar"
+            end
+            subject
+          end
+        end
+
+        context "with a tag" do
+          let(:path) { '/pacts/provider/Bar/tag/prod' }
+
+          it "finds all the pacts with the given tag for the provider" do
+            expect(PactBroker::Pacts::Service).to receive(:find_pact_versions_for_provider).with("Bar", tag: "prod")
+            subject
+          end
+
+          it "sets the correct resource title" do
+            expect(decorator).to receive(:to_json) do | options |
+              expect(options[:user_options][:title]).to eq "All pact versions for the provider Bar with consumer version tag 'prod'"
+            end
+            subject
+          end
+        end
+
+        context "with the pacticipant does not exist" do
+          let(:provider) { nil }
+
+          it "returns a 404" do
+            expect(subject.status).to eq 404
+          end
+        end
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/matrix/repository_spec.rb

@@ -479,6 +479,58 @@ module PactBroker
           end
         end
 
+        context "when compability is required with all versions with a given tag" do
+          before do
+            td.create_pact_with_hierarchy("android app", "1", "BFF")
+              .create_consumer_version_tag("prod")
+              .create_verification(provider_version: "5", comment: "included")
+              .create_consumer_version("2", tag_name: "prod")
+              .create_pact
+              .create_verification(provider_version: "5", comment: "included")
+              .create_consumer_version("3")
+              .create_pact
+              .create_verification(provider_version: "5", comment: "not included")
+              .create_consumer("ios app")
+              .create_consumer_version("20", tag_name: "prod")
+              .create_pact
+              .create_verification(provider_version: "5", comment: "not included")
+          end
+
+          context "when the other service is specifically named" do
+            let(:selectors) do
+              [
+                { pacticipant_name: "android app", tag: "prod" },
+                { pacticipant_name: "BFF", pacticipant_version_number: "5" }
+              ]
+            end
+
+            let(:options) { {} }
+
+            it "returns the matrix for all of the versions for the specified pacticipants with the given tag" do
+              expect(subject).to include_hash_matching(consumer_version_number: "1")
+              expect(subject).to include_hash_matching(consumer_version_number: "2")
+              expect(subject).to_not include_hash_matching(consumer_version_number: "3")
+              expect(subject).to_not include_hash_matching(consumer_name: "ios app")
+            end
+          end
+
+          context "when the other service is not specifically named" do
+            let(:selectors) do
+              [
+                { pacticipant_name: "BFF", pacticipant_version_number: "5" }
+              ]
+            end
+
+            let(:options) { { tag: "prod" } }
+
+            it "returns the matrix for all of the versions with the given tag" do
+              expect(subject).to include_hash_matching(consumer_name: "android app", consumer_version_number: "1")
+              expect(subject).to include_hash_matching(consumer_name: "android app", consumer_version_number: "2")
+              expect(subject).to include_hash_matching(consumer_name: "ios app", consumer_version_number: "20")
+            end
+          end
+        end
+
         context "using the success option" do
           before do
             td.create_pact_with_hierarchy("A", "1.2.3", "B")