pact_broker 2.0.5 → 2.1.0

data/spec/lib/pact_broker/domain/order_versions_spec.rb

@@ -1,5 +1,5 @@
 require 'spec_helper'
-require 'spec/support/provider_state_builder'
+require 'spec/support/test_data_builder'
 require 'pact_broker/domain/order_versions.rb'
 
 describe PactBroker::Domain::OrderVersions do
@@ -9,7 +9,7 @@ describe PactBroker::Domain::OrderVersions do
   end
   context "when order_versions_by_date is false (the default)" do
     before do
-      ProviderStateBuilder.new
+      TestDataBuilder.new
         .create_condor
         .create_condor_version('1.5.0')
         .create_condor_version('1.4.0')
@@ -28,7 +28,7 @@ describe PactBroker::Domain::OrderVersions do
     before do
       allow(PactBroker.configuration).to receive(:order_versions_by_date).and_return(true)
     end
-    let(:consumer) { ProviderStateBuilder.new.create_consumer.and_return(:consumer) }
+    let(:consumer) { TestDataBuilder.new.create_consumer.and_return(:consumer) }
     let!(:version_1) { PactBroker::Domain::Version.create(pacticipant_id: consumer.id, number: '2') }
     let!(:version_2) { PactBroker::Domain::Version.create(pacticipant_id: consumer.id, number: '1') }
     let!(:version_3) { PactBroker::Domain::Version.create(pacticipant_id: consumer.id, number: '3') }
@@ -44,7 +44,7 @@ describe PactBroker::Domain::OrderVersions do
 
   context "when an existing version number in the database that Versionomy could parse cannot be parsed by SemVer" do
     let!(:consumer) do
-      ProviderStateBuilder.new
+      TestDataBuilder.new
         .create_consumer
         .create_consumer_version('1')
         .create_consumer_version('2')

data/spec/lib/pact_broker/domain/verification_spec.rb

@@ -7,7 +7,7 @@ module PactBroker
 
       describe "#consumer" do
         let!(:consumer) do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_consumer
             .create_provider
             .create_consumer_version
@@ -23,7 +23,7 @@ module PactBroker
 
       describe "#provider" do
         let!(:provider) do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_consumer
             .create_provider
             .create_consumer_version

data/spec/lib/pact_broker/domain/version_spec.rb

@@ -7,7 +7,7 @@ module PactBroker
     describe Version do
       describe "#latest_pact_publication" do
         let!(:pact) do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_consumer
             .create_provider
             .create_consumer_version
@@ -24,7 +24,7 @@ module PactBroker
 
       describe "uq_ver_ppt_ord" do
         let(:consumer) do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_consumer
             .and_return(:consumer)
         end

data/spec/lib/pact_broker/pacticipants/repository_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 require 'pact_broker/pacticipants/repository'
-require 'support/provider_state_builder'
+require 'support/test_data_builder'
 
 module PactBroker
   module Pacticipants
@@ -8,7 +8,7 @@ module PactBroker
 
       describe "#find_by_name" do
         before do
-          ProviderStateBuilder.new.create_pacticipant("Foo Bar")
+          TestDataBuilder.new.create_pacticipant("Foo Bar")
         end
 
         subject { Repository.new.find_by_name('foo bar') }
@@ -40,7 +40,7 @@ module PactBroker
       describe "#pacticipant_names" do
 
         before do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_pacticipant("Plants")
             .create_pacticipant("Animals")
         end
@@ -55,7 +55,7 @@ module PactBroker
 
       describe "#find_all_pacticipant_versions_in_reverse_order" do
         before do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_consumer("Foo")
             .create_consumer_version("1.2.3")
             .create_consumer_version("4.5.6")

data/spec/lib/pact_broker/pacticipants/service_spec.rb

@@ -130,7 +130,7 @@ module PactBroker
       describe "delete" do
 
         before do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_consumer("Consumer")
             .create_consumer_version("2.3.4")
             .create_provider("Provider")

data/spec/lib/pact_broker/pacts/diff_spec.rb

@@ -17,7 +17,7 @@ module PactBroker
         let(:pact_content_version_3) { pact_content_version_2 }
 
         before do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_consumer("Consumer")
             .create_provider("Provider")
             .create_consumer_version("1")

data/spec/lib/pact_broker/pacts/merger_spec.rb

@@ -1,5 +1,5 @@
 require 'spec_helper'
-require 'spec/support/provider_state_builder'
+require 'spec/support/test_data_builder'
 require 'pact_broker/pacts/merger'
 require 'json'
 

data/spec/lib/pact_broker/pacts/pact_version_spec.rb

@@ -6,7 +6,7 @@ module PactBroker
 
       describe "pacticipant names" do
         subject(:pact_version) do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_consumer("consumer")
             .create_provider("provider")
             .create_consumer_version("1.0.1")
@@ -20,7 +20,7 @@ module PactBroker
 
       describe "#latest_pact_publication" do
         before do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_provider("Bar")
             .create_consumer("Foo")
             .create_consumer_version("1.2.100")
@@ -47,7 +47,7 @@ module PactBroker
 
       describe "#latest_consumer_version_number" do
         before do
-          builder = ProviderStateBuilder.new
+          builder = TestDataBuilder.new
           builder
             .create_consumer
             .create_provider

data/spec/lib/pact_broker/pacts/repository_spec.rb

@@ -1,7 +1,7 @@
 # Yes, I know this file is too bug, but cmd+shift+t is too useful!
 
 require 'pact_broker/pacts/repository'
-require 'spec/support/provider_state_builder'
+require 'spec/support/test_data_builder'
 require 'pact_broker/pacts/pact_params'
 require 'pact_broker/versions/repository'
 require 'pact_broker/pacticipants/repository'
@@ -90,7 +90,7 @@ module PactBroker
       describe "update" do
 
         let(:existing_pact) do
-          ProviderStateBuilder.new.create_pact_with_hierarchy "A Consumer", "1.2.3", "A Provider", original_json_content
+          TestDataBuilder.new.create_pact_with_hierarchy "A Consumer", "1.2.3", "A Provider", original_json_content
         end
 
         before do
@@ -165,7 +165,7 @@ module PactBroker
 
       describe "delete" do
         before do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_consumer(consumer_name)
             .create_consumer_version("1.2.3")
             .create_provider(provider_name)
@@ -193,7 +193,7 @@ module PactBroker
 
       describe "delete_by_version_id" do
         let!(:version) do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_consumer
             .create_provider
             .create_consumer_version("4.5.6")
@@ -217,7 +217,7 @@ module PactBroker
       describe "#find_all_pact_versions_between" do
 
         before do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_consumer(consumer_name)
             .create_consumer_version("1.2.3")
             .create_provider(provider_name)
@@ -247,7 +247,7 @@ module PactBroker
 
         context "with no tag specified" do
           before do
-            ProviderStateBuilder.new
+            TestDataBuilder.new
               .create_consumer(consumer_name)
               .create_consumer_version("1.0.0")
               .create_provider(provider_name)
@@ -277,7 +277,7 @@ module PactBroker
 
         context "with a tag specified" do
           before do
-            ProviderStateBuilder.new
+            TestDataBuilder.new
               .create_consumer(consumer_name)
               .create_consumer_version("1.2.3")
               .create_consumer_version_tag("prod")
@@ -313,7 +313,7 @@ module PactBroker
 
       describe "find_pact" do
         let!(:pact) do
-          builder = ProviderStateBuilder.new
+          builder = TestDataBuilder.new
           pact = builder
             .create_consumer("Consumer")
             .create_consumer_version("1.2.2")
@@ -360,7 +360,7 @@ module PactBroker
 
       describe "find_previous_pact" do
         before do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_consumer("Consumer")
             .create_consumer_version("1.2.2")
             .create_provider("Provider")
@@ -390,7 +390,7 @@ module PactBroker
 
       describe "find_next_pact" do
         before do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_consumer("Consumer")
             .create_consumer_version("1.2.2")
             .create_provider("Provider")
@@ -435,7 +435,7 @@ module PactBroker
         end
 
         before do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_consumer("Consumer")
             .create_provider("Provider")
             .create_consumer_version("1")
@@ -473,11 +473,10 @@ module PactBroker
       end
 
       describe "find_latest_pact" do
-
         context "with a tag" do
           context "when a version with a pact exists with the given tag" do
             before do
-              ProviderStateBuilder.new
+              TestDataBuilder.new
                 .create_consumer("Consumer")
                 .create_consumer_version("2.3.4")
                 .create_provider("Provider")
@@ -503,11 +502,59 @@ module PactBroker
           end
 
         end
+
+        context "without a tag" do
+          context "when one or more versions of a pact exist without any tags" do
+            before do
+              TestDataBuilder.new
+                .create_consumer("Consumer")
+                .create_provider("Provider")
+                .create_consumer_version("1.0.0")
+                .create_pact
+                .create_consumer_version("1.2.3")
+                .create_pact
+                .create_consumer_version("2.3.4")
+                .create_consumer_version_tag("prod")
+                .create_pact
+            end
+
+            let(:pact) { Repository.new.find_latest_pact("Consumer", "Provider", :untagged) }
+
+            it "returns the latest" do
+              expect(pact.consumer_version.number).to eq("1.2.3")
+            end
+
+            it "has JSON content" do
+              expect(pact.json_content).to_not be nil
+            end
+
+            it "has timestamps" do
+              expect(pact.created_at).to be_datey
+            end
+          end
+
+          context "when all versions have a tag" do
+            before do
+              TestDataBuilder.new
+                .create_consumer("Consumer")
+                .create_provider("Provider")
+                .create_consumer_version("2.3.4")
+                .create_consumer_version_tag("prod")
+                .create_pact
+            end
+
+            let(:pact) { Repository.new.find_latest_pact("Consumer", "Provider", :untagged) }
+
+            it "returns nil" do
+              expect(pact).to be nil
+            end
+          end
+        end
       end
 
       describe "find_latest_pacts" do
         before do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_condor
             .create_condor_version('1.3.0')
             .create_pricing_service

data/spec/lib/pact_broker/tags/repository_spec.rb

@@ -15,8 +15,8 @@ module PactBroker
         let(:options) { {pacticipant_name: pacticipant_name, pacticipant_version_number: version_number, tag_name: tag_name} }
         let(:find_tag) { subject.find options }
 
-        let!(:provider_state_builder) do
-          ProviderStateBuilder.new
+        let!(:test_data_builder) do
+          TestDataBuilder.new
             .create_pacticipant("wrong_pacticipant")
             .create_version(version_number)
             .create_tag(tag_name) #Tag with wrong pacticipant
@@ -30,7 +30,7 @@ module PactBroker
         context "when the tag exists" do
 
           before do
-            provider_state_builder.create_tag(tag_name) # Right tag!
+            test_data_builder.create_tag(tag_name) # Right tag!
           end
 
           it "returns the tag" do
@@ -64,7 +64,7 @@ module PactBroker
 
       describe "delete_by_version_id" do
         let!(:version) do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_consumer
             .create_provider
             .create_consumer_version("4.5.6")

data/spec/lib/pact_broker/tags/service_spec.rb

@@ -10,7 +10,7 @@ module PactBroker
       let(:tag_name) { "prod" }
 
       let(:options) { {pacticipant_name: pacticipant_name, pacticipant_version_number: version_number, tag_name: tag_name}}
-      let(:provider_state_builder) { ProviderStateBuilder.new }
+      let(:test_data_builder) { TestDataBuilder.new }
 
       describe ".create" do
 

data/spec/lib/pact_broker/ui/controllers/relationships_spec.rb

@@ -16,7 +16,7 @@ module PactBroker
           describe "GET" do
 
             before do
-              ProviderStateBuilder.new
+              TestDataBuilder.new
                 .create_consumer
                 .create_provider
                 .create_consumer_version

data/spec/lib/pact_broker/verifications/repository_spec.rb

@@ -6,7 +6,7 @@ module PactBroker
 
       describe "#verification_count_for_pact" do
         let!(:pact_1) do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_consumer("Consumer")
             .create_provider("Provider")
             .create_consumer_version("1.2.3")
@@ -16,7 +16,7 @@ module PactBroker
             .and_return(:pact)
         end
         let!(:pact_2) do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_consumer("Foo")
             .create_provider("Bar")
             .create_consumer_version("4.5.6")
@@ -32,7 +32,7 @@ module PactBroker
 
       describe "#find" do
         let!(:pact) do
-          builder = ProviderStateBuilder.new
+          builder = TestDataBuilder.new
           pact = builder
             .create_provider("Provider1")
             .create_consumer("Consumer1")
@@ -47,7 +47,7 @@ module PactBroker
             .create_pact
             .create_verification(number: 1)
 
-            ProviderStateBuilder.new
+            TestDataBuilder.new
             .create_provider("Provider3")
             .create_consumer("Consumer2")
             .create_consumer_version("1.2.3")
@@ -68,7 +68,7 @@ module PactBroker
 
       describe "#find_latest_verifications_for_consumer_version" do
         before do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_provider("Provider1")
             .create_consumer("Consumer1")
             .create_consumer_version("1.0.0")
@@ -82,7 +82,7 @@ module PactBroker
             .create_pact
             .create_verification(number: 1, provider_version: "6.5.4")
 
-            ProviderStateBuilder.new
+            TestDataBuilder.new
             .create_provider("Provider3")
             .create_consumer("Consumer2")
             .create_consumer_version("1.2.3")
@@ -100,7 +100,7 @@ module PactBroker
 
       describe "#find_latest_verification_for" do
         before do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_provider("Provider1")
             .create_consumer("Consumer1")
             .create_consumer_version("1.2.3")

data/spec/lib/pact_broker/verifications/service_spec.rb

@@ -23,7 +23,7 @@ module PactBroker
 
       describe "#create" do
         let(:params) { {'success' => true, 'providerApplicationVersion' => '4.5.6'} }
-        let(:pact) { ProviderStateBuilder.new.create_pact_with_hierarchy }
+        let(:pact) { TestDataBuilder.new.create_pact_with_hierarchy }
         let(:create_verification) { subject.create 3, params, pact }
 
         it "logs the creation" do

data/spec/lib/pact_broker/versions/repository_spec.rb

@@ -12,7 +12,7 @@ module PactBroker
         context "when a previous version exists" do
 
           let!(:existing_order) do
-            ProviderStateBuilder.new.create_version_with_hierarchy pacticipant_name, version_number
+            TestDataBuilder.new.create_version_with_hierarchy pacticipant_name, version_number
           end
 
           subject { Repository.new.create pacticipant_id: existing_order.pacticipant_id, number: "1.2.4" }
@@ -26,7 +26,7 @@ module PactBroker
 
       describe "#delete_by_id" do
         let!(:version) do
-          ProviderStateBuilder.new
+          TestDataBuilder.new
             .create_consumer
             .create_consumer_version("1.2.3")
             .create_consumer_version("4.5.6")
@@ -46,7 +46,7 @@ module PactBroker
 
         context "when the version exists" do
           before do
-            ProviderStateBuilder.new
+            TestDataBuilder.new
               .create_consumer("Another Consumer")
               .create_consumer(pacticipant_name)
               .create_consumer_version(version_number)