pact_broker 1.3.2.rc1 → 1.4.0

data/spec/fixtures/consumer-provider.json

@@ -1,14 +1,15 @@
 {
   "consumer": {
-    "name": "A Consumer"
+    "name": "Consumer"
   },
   "provider": {
-    "name": "A Provider"
+    "name": "Provider"
   },
   "interactions": [
     {
+      "description" : "a request for something",
+      "provider_state": null,
       "request": {
-        "description" : "a request for something",
         "method": "get",
         "path" : "/something"
       },

data/spec/integration/app_spec.rb

@@ -43,7 +43,7 @@ module PactBroker
         it "returns the relationships page" do
           expect(subject.status).to eq 200
           expect(subject.headers['Content-Type']).to include 'text/html'
-          expect(subject.body).to include 'Relationships'
+          expect(subject.body).to include 'Pacts'
         end
       end
 
@@ -56,6 +56,11 @@ module PactBroker
           expect(subject.body).to include 'Network graph'
           expect(subject.body).to include 'Some Consumer'
         end
+
+        it "does not screw up the HTML escaping, haven't you heard of semantic versioning padrino?? Seriously." do
+          expect(subject.body).to include "<html"
+          expect(subject.body).to_not include "&lt;html"
+        end
       end
 
       describe "a request for /doc/:rel_name" do

data/spec/lib/pact_broker/api/decorators/embedded_tag_decorator_spec.rb

@@ -0,0 +1,40 @@
+require 'pact_broker/api/decorators/embedded_tag_decorator'
+require 'pact_broker/repositories/tag_repository'
+require 'support/provider_state_builder'
+
+module PactBroker
+
+  module Api
+
+    module Decorators
+
+      describe EmbeddedTagDecorator do
+
+        let(:tag) do
+          ProviderStateBuilder.new
+            .create_consumer("Consumer")
+            .create_version("1.2.3")
+            .create_tag("prod")
+          PactBroker::Repositories::TagRepository.new.find tag_name: 'prod', pacticipant_version_number: '1.2.3', pacticipant_name: 'Consumer'
+        end
+
+        let(:options) { {base_url: 'http://example.org' }}
+
+        subject { JSON.parse TagDecorator.new(tag).to_json(options), symbolize_names: true }
+
+        it "includes the tag name" do
+          expect(subject[:name]).to eq "prod"
+        end
+
+        it "includes a link to itself" do
+          expect(subject[:_links][:self][:href]).to eq "http://example.org/pacticipants/Consumer/versions/1.2.3/tags/prod"
+        end
+
+        it "includes the tag name" do
+          expect(subject[:_links][:self][:name]).to eq "prod"
+        end
+
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/api/decorators/embedded_version_decorator_spec.rb

@@ -0,0 +1,39 @@
+require 'spec_helper'
+require 'pact_broker/api/decorators/embedded_version_decorator'
+
+module PactBroker
+  module Api
+    module Decorators
+      describe EmbeddedVersionDecorator do
+
+        let(:version) do
+          ProviderStateBuilder.new
+            .create_consumer("Consumer")
+            .create_version("1.2.3")
+          PactBroker::Repositories::VersionRepository.new.find_by_pacticipant_name_and_number "Consumer", "1.2.3"
+        end
+
+        let(:options) { {base_url: 'http://example.org' }}
+
+        subject { JSON.parse EmbeddedVersionDecorator.new(version).to_json(options), symbolize_names: true }
+
+        it "includes a link to itself" do
+          expect(subject[:_links][:self][:href]).to eq "http://example.org/pacticipants/Consumer/versions/1.2.3"
+        end
+
+        xit "includes the version number in the link" do
+          expect(subject[:_links][:self][:name]).to eq "1.2.3"
+        end
+
+        xit "includes its title in the link" do
+          expect(subject[:_links][:self][:title]).to eq "Version"
+        end
+
+        it "includes the version number" do
+          expect(subject[:number]).to eq "1.2.3"
+        end
+
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/api/decorators/pact_decorator_spec.rb

@@ -21,10 +21,19 @@ module PactBroker
         let(:base_url) { 'http://example.org' }
         let(:created_at) { Time.new(2014, 3, 4) }
         let(:updated_at) { Time.new(2014, 3, 5) }
-        let(:pact) { double('pact', json_content: json_content, created_at: created_at, updated_at: updated_at, consumer: consumer, provider: provider, consumer_version: consumer_version)}
-        let(:consumer) { instance_double(PactBroker::Domain::Pacticipant, name: 'Consumer')}
-        let(:provider) { instance_double(PactBroker::Domain::Pacticipant, name: 'Provider')}
-        let(:consumer_version) { instance_double(PactBroker::Domain::Version, number: '1234')}
+        let(:pact) { double('pact',
+          json_content: json_content,
+          created_at: created_at,
+          updated_at: updated_at,
+          consumer: consumer,
+          provider: provider,
+          consumer_version: consumer_version,
+          consumer_version_number: '1234',
+          name: 'A Pact'
+        )}
+        let(:consumer) { instance_double(PactBroker::Domain::Pacticipant, name: 'A Consumer')}
+        let(:provider) { instance_double(PactBroker::Domain::Pacticipant, name: 'A Provider')}
+        let(:consumer_version) { instance_double(PactBroker::Domain::Version, number: '1234', pacticipant: consumer)}
 
         subject { JSON.parse PactDecorator.new(pact).to_json(base_url: base_url), symbolize_names: true}
 
@@ -38,18 +47,51 @@ module PactBroker
             expect(subject[:createdAt]).to eq created_at.xmlschema
           end
 
+          it "includes a link to itself" do
+            expect(subject[:_links][:self]).to eq href: 'http://example.org/pacts/provider/A%20Provider/consumer/A%20Consumer/version/1234', name: 'A Pact', title: 'Pact'
+          end
+
+          it "includes a link to the diff with the previous distinct version" do
+            expect(subject[:_links][:'pb:diff-previous-distinct']).to eq({href: 'http://example.org/pacts/provider/A%20Provider/consumer/A%20Consumer/version/1234/diff/previous-distinct',
+              title: 'Diff',
+              name: 'Diff with previous distinct version of this pact'})
+          end
+
+          it "includes a link to the previous distinct pact version" do
+            expect(subject[:_links][:'pb:previous-distinct']).to eq({href: 'http://example.org/pacts/provider/A%20Provider/consumer/A%20Consumer/version/1234/previous-distinct',
+              title: 'Pact',
+              name: 'Previous distinct version of this pact'})
+          end
+
+          it "includes a link to tag this version" do
+            expect(subject[:_links][:'pb:tag-version'][:href]).to eq "http://example.org/pacticipants/A%20Consumer/versions/1234/tags/{tag}"
+          end
+
+          it "includes a link to the consumer" do
+            expect(subject[:_links][:'pb:consumer']).to eq name: 'A Consumer', title: 'Consumer', href: "http://example.org/pacticipants/A%20Consumer"
+          end
+
+          it "includes a link to the provider" do
+            expect(subject[:_links][:'pb:provider']).to eq name: 'A Provider', title: 'Provider', href: "http://example.org/pacticipants/A%20Provider"
+          end
+
           it "includes a link to the webhooks for this pact" do
-            expect(subject[:_links][:'pact-webhooks'][:href]).to eq "http://example.org/webhooks/provider/Provider/consumer/Consumer"
+            expect(subject[:_links][:'pb:pact-webhooks'][:href]).to eq "http://example.org/webhooks/provider/A%20Provider/consumer/A%20Consumer"
           end
 
           it "includes a link to the latest pact" do
-            expect(subject[:_links][:'latest-pact'][:title]).to eq "Latest version of the pact between Consumer and Provider"
-            expect(subject[:_links][:'latest-pact'][:href]).to eq "http://example.org/pacts/provider/Provider/consumer/Consumer/latest"
+            expect(subject[:_links][:'pb:latest-pact-version'][:title]).to eq "Pact"
+            expect(subject[:_links][:'pb:latest-pact-version'][:name]).to eq "Latest version of this pact"
+            expect(subject[:_links][:'pb:latest-pact-version'][:href]).to eq "http://example.org/pacts/provider/A%20Provider/consumer/A%20Consumer/latest"
+          end
+
+          xit "includes a link to the pact versions" do
+            expect(subject[:_links][:'pb:pact-versions'][:title]).to eq "All versions of the pact between A Consumer and A Provider"
+            expect(subject[:_links][:'pb:pact-versions'][:href]).to eq "http://example.org/pacts/provider/A%20Provider/consumer/A%20Consumer/versions"
           end
 
-          it "includes a link to the pact versions" do
-            expect(subject[:_links][:'pact-versions'][:title]).to eq "All versions of the pact between Consumer and Provider"
-            expect(subject[:_links][:'pact-versions'][:href]).to eq "http://example.org/pacts/provider/Provider/consumer/Consumer/versions"
+          it "includes a curie" do
+            expect(subject[:_links][:curies]).to eq [{ name: "pb", href: "http://example.org/doc/{rel}", templated: true }]
           end
         end
 

data/spec/lib/pact_broker/api/decorators/pact_version_decorator_spec.rb

@@ -21,7 +21,15 @@ module PactBroker
         let(:base_url) { 'http://example.org' }
         let(:created_at) { Time.new(2014, 3, 4) }
         let(:updated_at) { Time.new(2014, 3, 5) }
-        let(:pact) { double('pact', json_content: json_content, created_at: created_at, updated_at: updated_at, consumer: consumer, provider: provider, consumer_version: consumer_version, name: 'pact_name')}
+        let(:pact) { double('pact',
+          json_content: json_content,
+          created_at: created_at,
+          updated_at: updated_at,
+          consumer: consumer,
+          provider: provider,
+          consumer_version: consumer_version,
+          consumer_version_number: '1234',
+          name: 'pact_name')}
         let(:consumer) { instance_double(PactBroker::Domain::Pacticipant, name: 'Consumer')}
         let(:provider) { instance_double(PactBroker::Domain::Pacticipant, name: 'Provider')}
         let(:consumer_version) { instance_double(PactBroker::Domain::Version, number: '1234', pacticipant: consumer)}

data/spec/lib/pact_broker/api/decorators/pacticipant_collection_decorator_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+require 'pact_broker/api/decorators/pacticipant_collection_decorator'
+require 'pact_broker/domain/pacticipant'
+
+module PactBroker
+
+  module Api
+
+    module Decorators
+
+      describe PacticipantCollectionRepresenter do
+
+        subject { JSON.parse PacticipantCollectionRepresenter.new(pacticipants).to_json, symbolize_names: true }
+
+        context "with no pacticipants" do
+          let(:pacticipants) { [] }
+
+          it "doesn't blow up" do
+            subject
+          end
+        end
+
+        context "with pacticipants" do
+          let(:pacticipant) { PactBroker::Domain::Pacticipant.new(name: 'Name', created_at: DateTime.new, updated_at: DateTime.new)}
+          let(:pacticipants) { [pacticipant] }
+
+          it "displays a list of pacticipants" do
+            expect(subject[:pacticipants]).to be_instance_of(Array)
+            expect(subject[:pacticipants].size).to eq 1
+          end
+        end
+
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/api/decorators/tag_decorator_spec.rb

@@ -0,0 +1,57 @@
+require 'pact_broker/api/decorators/tag_decorator'
+require 'pact_broker/repositories/tag_repository'
+
+require 'support/provider_state_builder'
+
+module PactBroker
+
+  module Api
+
+    module Decorators
+
+      describe TagDecorator do
+
+        let(:tag) do
+          ProviderStateBuilder.new
+            .create_consumer("Consumer")
+            .create_version("1.2.3")
+            .create_tag("prod")
+          PactBroker::Repositories::TagRepository.new.find tag_name: 'prod', pacticipant_version_number: '1.2.3', pacticipant_name: 'Consumer'
+        end
+
+        let(:options) { {base_url: 'http://example.org' }}
+
+        subject { JSON.parse TagDecorator.new(tag).to_json(options), symbolize_names: true }
+
+        it "includes the tag name" do
+          expect(subject[:name]).to eq "prod"
+        end
+
+        it "includes a link to itself" do
+          expect(subject[:_links][:self][:href]).to eq "http://example.org/pacticipants/Consumer/versions/1.2.3/tags/prod"
+        end
+
+        it "includes the tag name" do
+          expect(subject[:_links][:self][:name]).to eq "prod"
+        end
+
+        it "includes a link to the version" do
+          expect(subject[:_links][:version][:href]).to eq "http://example.org/pacticipants/Consumer/versions/1.2.3"
+        end
+
+        it "includes the version number" do
+          expect(subject[:_links][:version][:name]).to eq "1.2.3"
+        end
+
+        it "includes a link to the pacticipant" do
+          expect(subject[:_links][:pacticipant][:href]).to eq "http://example.org/pacticipants/Consumer"
+        end
+
+        it "includes the pacticipant name" do
+          expect(subject[:_links][:pacticipant][:name]).to eq "Consumer"
+        end
+
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/api/decorators/version_decorator_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+require 'pact_broker/api/decorators/version_decorator'
+
+module PactBroker
+  module Api
+    module Decorators
+      describe VersionDecorator do
+
+        let(:version) do
+          ProviderStateBuilder.new
+            .create_consumer("Consumer")
+            .create_consumer_version("1.2.3")
+            .create_consumer_version_tag("prod")
+          PactBroker::Repositories::VersionRepository.new.find_by_pacticipant_name_and_number "Consumer", "1.2.3"
+        end
+
+        let(:options) { {base_url: 'http://example.org' }}
+
+        subject { JSON.parse VersionDecorator.new(version).to_json(options), symbolize_names: true }
+
+        it "includes a link to itself" do
+          expect(subject[:_links][:self][:href]).to eq "http://example.org/pacticipants/Consumer/versions/1.2.3"
+        end
+
+        it "includes the version number in the link" do
+          expect(subject[:_links][:self][:name]).to eq "1.2.3"
+        end
+
+        it "includes its title in the link" do
+          expect(subject[:_links][:self][:title]).to eq "Version"
+        end
+
+        it "includes the version number" do
+          expect(subject[:number]).to eq "1.2.3"
+        end
+
+        it "includes a link to the pacticipant" do
+          expect(subject[:_links][:pacticipant]).to eq title: "Pacticipant", name: "Consumer", href: "http://example.org/pacticipants/Consumer"
+        end
+
+        it "includes a list of the tags" do
+          expect(subject[:_embedded][:tags]).to be_instance_of(Array)
+          expect(subject[:_embedded][:tags].first[:name]).to eq "prod"
+        end
+
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/api/decorators/webhooks_decorator_spec.rb

@@ -25,8 +25,8 @@ module PactBroker
           subject { JSON.parse(json, symbolize_names: true) }
 
           it "includes a link to itself with a title" do
-            expect(subject[:_links][:'pb:self'][:href]).to eq resource_url
-            expect(subject[:_links][:'pb:self'][:title]).to eq 'Title'
+            expect(subject[:_links][:self][:href]).to eq resource_url
+            expect(subject[:_links][:self][:title]).to eq 'Title'
           end
 
           it "includes a list of links to the webhooks" do

data/spec/lib/pact_broker/pacts/create_formatted_diff_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+require 'pact_broker/pacts/create_formatted_diff'
+require 'pact_broker/pacts/repository'
+
+module PactBroker
+  module Pacts
+    describe CreateFormattedDiff do
+
+      describe ".call" do
+
+        let(:pact_content_version_1) do
+          hash = load_json_fixture('consumer-provider.json')
+          hash['interactions'].first['request']['method'] = 'post'
+          hash.to_json
+        end
+
+        let(:pact_content_version_2) { load_fixture('consumer-provider.json') }
+
+        subject { CreateFormattedDiff.call(pact_content_version_2, pact_content_version_1) }
+
+        it "returns the formatted diff" do
+          puts subject
+          expect(subject).to include 'interactions'
+          expect(subject).to match /\-.*post/
+          expect(subject).to match /\+.*get/
+          expect(subject).to_not include 'Key'
+        end
+
+      end
+
+    end
+  end
+end

data/spec/lib/pact_broker/pacts/diff_spec.rb

@@ -0,0 +1,72 @@
+require 'spec_helper'
+require 'pact_broker/pacts/diff'
+require 'pact_broker/pacts/pact_params'
+
+module PactBroker
+  module Pacts
+    describe Diff do
+
+      describe "#process" do
+
+        let(:pact_content_version_1) do
+          hash = load_json_fixture('consumer-provider.json')
+          hash['interactions'].first['request']['method'] = 'post'
+          hash.to_json
+        end
+        let(:pact_content_version_2) { load_fixture('consumer-provider.json') }
+        let(:pact_content_version_3) { pact_content_version_2 }
+
+        before do
+          ProviderStateBuilder.new
+            .create_consumer("Consumer")
+            .create_provider("Provider")
+            .create_consumer_version("1")
+            .create_pact(pact_content_version_1)
+            .create_consumer_version("2")
+            .create_pact(pact_content_version_2)
+            .create_consumer_version("3")
+            .create_pact(pact_content_version_3)
+          allow(DateHelper).to receive(:local_date_in_words).and_return("a date")
+        end
+
+        subject { Diff.new.process(pact_params, base_url: 'http://example.org') }
+
+        context "when there is a previous distinct version" do
+
+          let(:pact_params) do
+            PactBroker::Pacts::PactParams.new(
+              consumer_name: 'Consumer',
+              provider_name: 'Provider',
+              consumer_version_number: '3'
+            )
+          end
+
+          it "indicates when the previous change was made" do
+            expect(subject).to include "The following changes were made less than a minute ago (a date)"
+          end
+
+          it "returns the formatted diff" do
+            expect(subject).to include 'interactions'
+            expect(subject).to include 'post'
+            expect(subject).to include 'get'
+          end
+        end
+
+        context "when there is not a previous distinct version (this needs to be moved into the resource)" do
+          let(:pact_params) do
+            PactBroker::Pacts::PactParams.new(
+              consumer_name: 'Consumer',
+              provider_name: 'Provider',
+              consumer_version_number: '1'
+            )
+          end
+
+          it "returns a message indicating there was no previous distinct version found" do
+            expect(subject).to include("No previous distinct version was found")
+          end
+        end
+      end
+
+    end
+  end
+end