pact_broker 1.2.0 → 1.3.0

data/spec/integration/endpoints/pact_put_spec.rb

@@ -0,0 +1,43 @@
+describe "pacts/provider/:provider/consumer/:consumer/version/:version" do
+  describe "PUT" do
+
+    let(:pact_content) { load_fixture('consumer-provider.json') }
+    let(:path) { "/pacts/provider/A%20Provider/consumer/A%20Consumer/version/1.2.3" }
+    let(:response_body_json) { JSON.parse(subject.body) }
+
+    subject { put path, pact_content, {'CONTENT_TYPE' => 'application/json' }; last_response  }
+
+    context "when the pact does not exist" do
+      it "returns a 201 Created" do
+        expect(subject.status).to be 201
+      end
+
+      it "returns a json body" do
+        expect(subject.headers['Content-Type']).to eq "application/json"
+      end
+
+      it "returns the pact in the body" do
+        expect(response_body_json).to include JSON.parse(pact_content)
+      end
+    end
+
+    context "when the pact does exist" do
+
+      before do
+        ProviderStateBuilder.new.create_pact_with_hierarchy "A Consumer", "1.2.3", "A Provider"
+      end
+
+      it "returns a 200 Success" do
+        expect(subject.status).to be 200
+      end
+
+      it "returns a json body" do
+        expect(subject.headers['Content-Type']).to eq "application/json"
+      end
+
+      it "returns the pact in the body" do
+        expect(response_body_json).to include JSON.parse(pact_content)
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/api/decorators/latest_pact_decorator_spec.rb

@@ -0,0 +1,42 @@
+require 'spec_helper'
+require 'pact_broker/api/decorators/latest_pact_decorator'
+
+module PactBroker
+
+  module Api
+
+    module Decorators
+
+      describe LatestPactDecorator do
+
+        let(:pact) { RepresentablePact.new(ProviderStateBuilder.new.create_pact_with_hierarchy 'Consumer', '1.2.3', 'Provider') }
+        let(:base_url) { 'http://example.org' }
+
+        subject { JSON.parse LatestPactDecorator.new(pact).to_json(base_url: base_url), symbolize_names: true}
+
+        it "includes the createdAt date" do
+          expect(subject[:createdAt]).to_not be_nil
+        end
+
+        context "when the updatedAt is the same as the createdAt" do
+          it "does not include the updatedAt date" do
+            expect(subject[:updatedAt]).to be_nil
+          end
+        end
+
+        context "when the updatedAt is not the same as the createdAt" do
+          let(:pact) do
+            pact = ProviderStateBuilder.new.create_pact_with_hierarchy 'Consumer', '1.2.3', 'Provider'
+            pact.updated_at = pact.created_at + 1
+            RepresentablePact.new(pact)
+          end
+
+          it "includes the updatedAt date" do
+            expect(subject[:updatedAt]).to_not be_nil
+          end
+        end
+
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/api/decorators/pact_version_decorator_spec.rb

@@ -43,6 +43,11 @@ module PactBroker
           expect(subject[:_embedded][:consumerVersion][:_links][:self][:href]).to eq "http://example.org/pacticipants/Consumer/versions/1234"
         end
 
+        it "includes timestamps" do
+          expect(subject[:createdAt]).to_not be_nil
+          expect(subject[:updatedAt]).to_not be_nil
+        end
+
       end
     end
   end

data/spec/lib/pact_broker/api/decorators/pacticipant_decorator_spec.rb

@@ -16,8 +16,9 @@ module PactBroker
 
         subject { JSON.parse PacticipantRepresenter.new(pacticipant).to_json, symbolize_names: true }
 
-        it "includes the createdAt timestamp" do
+        it "includes timestamps" do
           expect(subject[:createdAt]).to eq created_at.xmlschema
+          expect(subject[:updatedAt]).to eq updated_at.xmlschema
         end
       end
     end

data/spec/lib/pact_broker/api/decorators/webhook_decorator_spec.rb

@@ -22,6 +22,8 @@ module PactBroker
 
         let(:consumer) { Models::Pacticipant.new(name: 'Consumer') }
         let(:provider) { Models::Pacticipant.new(name: 'Provider') }
+        let(:created_at) { DateTime.now }
+        let(:updated_at) { created_at + 1 }
 
         let(:webhook) do
           Models::Webhook.new(
@@ -29,8 +31,8 @@ module PactBroker
             uuid: 'some-uuid',
             consumer: consumer,
             provider: provider,
-            created_at: DateTime.now,
-            updated_at: DateTime.now)
+            created_at: created_at,
+            updated_at: updated_at)
         end
 
         subject { WebhookDecorator.new(webhook) }
@@ -83,6 +85,11 @@ module PactBroker
             expect(parsed_json[:_links][:execute][:href]).to eq 'http://example.org/webhooks/some-uuid/execute'
           end
 
+          it "includes timestamps" do
+            expect(parsed_json[:createdAt]).to eq created_at.xmlschema
+            expect(parsed_json[:updatedAt]).to eq updated_at.xmlschema
+          end
+
           context "when the headers are empty" do
             let(:headers) { nil }
             it "does not include the headers" do

data/spec/lib/pact_broker/api/renderers/html_pact_renderer_spec.rb

@@ -6,8 +6,17 @@ module PactBroker
     module Renderers
       describe HtmlPactRenderer do
 
+        before do
+          ENV['BACKUP_TZ'] = ENV['TZ']
+          ENV['TZ'] = "Australia/Melbourne"
+        end
+
+        after do
+          ENV['TZ'] = ENV['BACKUP_TZ']
+        end
+
         let(:consumer) { double('consumer', name: 'Consumer')}
-        let(:created_at) { DateTime.now }
+        let(:created_at) { DateTime.new(2014, 02, 27) }
         let(:json_content) { load_fixture('renderer_pact.json') }
         let(:pact) { double('pact', json_content: json_content, updated_at: created_at, consumer_version_number: '1.2.3', consumer: consumer)}
         let(:pact_url) { '/pact/url' }
@@ -22,12 +31,14 @@ module PactBroker
           it "renders the pact as HTML" do
             expect(subject).to include("<html>")
             expect(subject).to include("</html>")
-            expect(subject).to include('<link rel="stylesheet"')
-            expect(subject).to include('href="/stylesheets/github.css"')
+            expect(subject).to include("<link rel='stylesheet'")
+            expect(subject).to include("href='/stylesheets/github.css'")
             expect(subject).to include('<pre><code')
             expect(subject).to include('&quot;method&quot;:')
             expect(subject).to match /<h\d>.*Some Consumer/
             expect(subject).to match /<h\d>.*Some Provider/
+            expect(subject).to include("Date published:")
+            expect(subject).to include("27/02/2014 11:00AM +11:00")
           end
         end
 

data/spec/lib/pact_broker/repositories/pact_repository_spec.rb

@@ -5,6 +5,90 @@ module PactBroker
   module Repositories
     describe PactRepository do
 
+      describe "create" do
+        let(:consumer) { PacticipantRepository.new.create name: 'Consumer' }
+        let(:provider) { PacticipantRepository.new.create name: 'Provider' }
+        let(:version) { VersionRepository.new.create number: '1.2.3', pacticipant_id: consumer.id }
+        let(:json_content) { {some: 'json'}.to_json }
+
+        subject { PactRepository.new.create version_id: version.id, provider_id: provider.id, json_content: json_content}
+
+        it "saves the pact" do
+          expect{subject}.to change{ Pact.count }.by(1)
+        end
+
+        it "returns a Pact::Model" do
+          expect(subject).to be_instance_of(PactBroker::Models::Pact)
+        end
+
+        it "sets all the Pact::Model attributes" do
+          expect(subject.consumer).to eq consumer
+          expect(subject.provider).to eq provider
+          expect(subject.consumer_version_number).to eq '1.2.3'
+          expect(subject.consumer_version).to eq version
+          expect(subject.json_content).to eq json_content
+          expect(subject.created_at).to be_instance_of(DateTime)
+          expect(subject.updated_at).to be_instance_of(DateTime)
+        end
+      end
+
+      describe "update" do
+
+        let(:existing_pact) do
+          ProviderStateBuilder.new.create_pact_with_hierarchy "A Consumer", "1.2.3", "A Provider"
+        end
+
+        before do
+          ::DB::PACT_BROKER_DB[:pacts]
+            .where(id: existing_pact.id)
+            .update(
+              created_at: created_at,
+              updated_at: updated_at)
+        end
+
+        let(:created_at) { DateTime.new(2014, 3, 2) }
+        let(:updated_at) { DateTime.new(2014, 3, 4) }
+
+        let(:json_content) { {some: 'json'}.to_json }
+
+        subject { PactRepository.new.update existing_pact.id, json_content: json_content }
+
+        context "when the attributes have changed" do
+
+          it "updates the existing content" do
+            expect(subject.json_content).to eq json_content
+          end
+
+          it "updates the updated_at timestamp" do
+            expect(subject.updated_at).to_not eq updated_at
+          end
+
+          it "does not update the created_at timestamp" do
+            expect(subject.created_at).to eq created_at
+          end
+
+        end
+
+        context "when the attributes have not changed" do
+          before do
+            ::DB::PACT_BROKER_DB[:pacts]
+              .where(id: existing_pact.id)
+              .update(
+                json_content: json_content)
+          end
+
+          it "does not update the updated_at timestamp" do
+            expect(subject.updated_at).to eq updated_at
+          end
+
+          it "does not update the created_at timestamp" do
+            expect(subject.created_at).to eq created_at
+          end
+
+        end
+
+      end
+
       describe "#find_all_pacts_between" do
         let(:consumer_name) { 'Consumer' }
         let(:provider_name) { 'Provider' }
@@ -81,8 +165,9 @@ module PactBroker
               expect(latest_prod_pact.consumer_version.number).to eq("1.2.3")
             end
 
-            xit "has timestamps" do
-
+            it "has timestamps" do
+              expect(latest_prod_pact.created_at).to be_instance_of(DateTime)
+              expect(latest_prod_pact.updated_at).to be_instance_of(DateTime)
             end
           end
 
@@ -116,7 +201,6 @@ module PactBroker
           expect(pacts[0].provider.name).to eq("Pricing Service")
           expect(pacts[0].provider.id).to_not be nil
           expect(pacts[0].consumer_version.number).to eq("1.4.0")
-          expect(pacts[0].consumer_version_number).to eq("1.4.0")
 
           expect(pacts[1].consumer_version.pacticipant.name).to eq("Contract Email Service")
           expect(pacts[1].consumer.name).to eq("Contract Email Service")
@@ -124,7 +208,7 @@ module PactBroker
           expect(pacts[1].consumer_version.number).to eq("2.7.0")
         end
 
-        xit "includes the timestamps" do
+        it "includes the timestamps - need to update view" do
           pacts = PactRepository.new.find_latest_pacts
 
           expect(pacts[0].updated_at).to be_instance_of DateTime

data/spec/lib/pact_broker/repositories/tag_repository_spec.rb

@@ -37,6 +37,8 @@ module PactBroker
             expect(find_tag.name).to eq tag_name
             expect(find_tag.version.number).to eq version_number
             expect(find_tag.version.pacticipant.name).to eq pacticipant_name
+            expect(find_tag.created_at).to be_instance_of(DateTime)
+            expect(find_tag.updated_at).to be_instance_of(DateTime)
           end
 
         end

data/spec/lib/pact_broker/repositories/version_repository_spec.rb

@@ -5,10 +5,27 @@ module PactBroker
   module Repositories
     describe VersionRepository do
 
+      let(:pacticipant_name) { "test_pacticipant" }
+      let(:version_number) { "1.2.3" }
+
+      describe "#create" do
+        context "when a previous version exists" do
+
+          let!(:existing_order) do
+            ProviderStateBuilder.new.create_version_with_hierarchy pacticipant_name, version_number
+          end
+
+          subject { VersionRepository.new.create pacticipant_id: existing_order.pacticipant_id, number: "1.2.4" }
+
+          it "sets the order to the previous version's order plus one" do
+            expect(subject.order).to eq existing_order.order + 1
+          end
+
+        end
+      end
+
       describe "#find_by_pacticipant_name_and_number" do
 
-        let(:pacticipant_name) { "test_pacticipant" }
-        let(:version_number) { "1.2.3" }
 
         subject { described_class.new.find_by_pacticipant_name_and_number pacticipant_name, version_number }
 
@@ -21,6 +38,7 @@ module PactBroker
           it "returns the version" do
             expect(subject.number).to eq version_number
             expect(subject.pacticipant.name).to eq pacticipant_name
+            expect(subject.order).to eq 0
           end
         end
 

data/spec/lib/pact_broker/services/pacticipant_service_spec.rb

@@ -155,7 +155,7 @@ module PactBroker
 
         it "deletes the child pacts" do
           expect{ delete_pacticipant }.to change{
-            PactBroker::Models::Pact.count
+            PactBroker::Repositories::Pact.count
             }.by(-2)
         end
       end

data/spec/service_consumers/pact_helper.rb

@@ -1,27 +1,12 @@
 require './spec/spec_helper'
 require 'pact/provider/rspec'
-require 'sequel'
-require 'db'
-require 'pact_broker/api'
-require 'uri'
-require_relative 'provider_states_for_pact_broker_client'
-
-require 'pact_broker/api/resources/pact'
 
-Pact.configure do | config |
-  config.logger.level = Logger::DEBUG
-  #config.diff_format = :plus_and_minus
-end
+require_relative 'provider_states_for_pact_broker_client'
 
 Pact.service_provider "Pact Broker" do
-#  app { PactBroker::API }
 
   honours_pact_with "Pact Broker Client" do
-    pact_uri "../pact_broker-client/spec/pacts/pact_broker_client-pact_broker.json"
+    pact_uri "https://raw.githubusercontent.com/bethesque/pact_broker-client/master/spec/pacts/pact_broker_client-pact_broker.json"
   end
 
-  # honours_pact_with "Pact Broker Client", :ref => :head do
-  #   pact_uri URI.encode("http://rea-pact-broker.biq.vpc.realestate.com.au/pacts/provider/Pact Broker/consumer/Pact Broker Client/latest")
-  # end
-
 end

data/spec/spec_helper.rb

@@ -4,45 +4,27 @@ RACK_ENV = 'test'
 $: << File.expand_path("../../", __FILE__)
 require 'rack/test'
 require 'db'
-require 'support/provider_state_builder'
-require 'support/shared_examples_for_responses'
 require 'pact_broker/api'
 require 'rspec/its'
 
+Dir.glob("./spec/support/**/*.rb") { |file| require file  }
+
 YAML::ENGINE.yamler = 'psych'
 I18n.config.enforce_available_locales = false
 
-def load_fixture(file_name)
-  File.read(File.expand_path(File.join(File.dirname(__FILE__), 'fixtures', file_name)))
-end
-
-def load_json_fixture(file_name)
-  require 'json'
-  JSON.parse(load_fixture(file_name))
-end
-
 RSpec.configure do | config |
   config.before :suite do
     raise "Wrong environment!!! Don't run this script!! ENV['RACK_ENV'] is #{ENV['RACK_ENV']} and RACK_ENV is #{RACK_ENV}" if ENV['RACK_ENV'] != 'test' || RACK_ENV != 'test'
     PactBroker::DB.connection = DB::PACT_BROKER_DB
   end
 
-
-  config.before :each do
-    # TODO: Change this to transactional!
-    DB::PACT_BROKER_DB[:webhook_headers].truncate
-    DB::PACT_BROKER_DB[:webhooks].truncate
-    DB::PACT_BROKER_DB[:pacts].truncate
-    DB::PACT_BROKER_DB[:tags].truncate
-    DB::PACT_BROKER_DB[:versions].truncate
-    DB::PACT_BROKER_DB[:pacticipants].truncate
-  end
-
   config.include Rack::Test::Methods
   config.mock_with :rspec do |mocks|
     mocks.verify_partial_doubles = true
   end
 
+  config.include FixtureHelpers
+
   def app
     PactBroker::API
   end

data/spec/support/database_cleaner.rb

@@ -0,0 +1,18 @@
+require 'database_cleaner'
+
+RSpec.configure do |config|
+  config.before(:suite) do
+    if defined?(::DB)
+      DatabaseCleaner.strategy = :transaction
+      DatabaseCleaner.clean_with :truncation
+    end
+  end
+
+  config.before(:each) do
+    DatabaseCleaner.start if defined?(::DB)
+  end
+
+  config.after(:each) do
+    DatabaseCleaner.clean if defined?(::DB)
+  end
+end