pact_broker 1.18.0 → 2.0.0.beta.1

data/spec/fixtures/a_consumer-a_provider-2.json

@@ -8,7 +8,7 @@
   "interactions": [
     {
       "description" : "a request for something",
-      "providerState": null,
+      "provider_state": null,
       "request": {
         "method": "post",
         "path" : "/something"

data/spec/fixtures/a_consumer-a_provider-3.json

@@ -8,7 +8,7 @@
   "interactions": [
     {
       "description" : "another request for something",
-      "providerState": null,
+      "provider_state": null,
       "request": {
         "method": "get",
         "path" : "/something_else"

data/spec/fixtures/a_consumer-a_provider-conflict.json

@@ -8,7 +8,7 @@
   "interactions": [
     {
       "description" : "a request for something",
-      "providerState": null,
+      "provider_state": null,
       "request": {
         "method": "post",
         "path" : "/something"

data/spec/fixtures/a_consumer-a_provider-merged.json

@@ -8,7 +8,7 @@
   "interactions": [
     {
       "description" : "a request for something",
-      "providerState": null,
+      "provider_state": null,
       "request": {
         "method": "get",
         "path" : "/something"
@@ -20,7 +20,7 @@
     },
     {
       "description" : "another request for something",
-      "providerState": null,
+      "provider_state": null,
       "request": {
         "method": "get",
         "path" : "/something_else"

data/spec/fixtures/a_consumer-a_provider.json

@@ -8,7 +8,7 @@
   "interactions": [
     {
       "description" : "a request for something",
-      "providerState": null,
+      "provider_state": null,
       "request": {
         "method": "get",
         "path" : "/something"

data/spec/fixtures/consumer-provider.json

@@ -8,7 +8,7 @@
   "interactions": [
     {
       "description" : "a request for something",
-      "providerState": null,
+      "provider_state": null,
       "request": {
         "method": "get",
         "path" : "/something",

data/spec/fixtures/renderer_pact.json

@@ -8,7 +8,7 @@
   "interactions": [
     {
       "description": "a request for alligators",
-      "providerState": "alligators exist",
+      "provider_state": "alligators exist",
       "request": {
         "method": "get",
         "path": "/alligators"

data/spec/fixtures/verification.json

@@ -0,0 +1,4 @@
+{
+  "success": true,
+  "providerApplicationVersion": "4.5.6"
+}

data/spec/lib/pact_broker/api/contracts/verification_contract_spec.rb

@@ -0,0 +1,91 @@
+require 'pact_broker/api/contracts/verification_contract'
+require 'pact_broker/api/decorators/verification_decorator'
+require 'pact_broker/domain/verification'
+
+module PactBroker
+  module Api
+    module Contracts
+      describe VerificationContract do
+
+        subject { VerificationContract.new(verification) }
+        let(:verification) { PactBroker::Domain::Verification.new }
+        let(:valid_params) { {success: success, providerApplicationVersion: provider_version, buildUrl: build_url} }
+        let(:params) { valid_params }
+
+
+        let(:success) { true }
+        let(:provider_version) { "4.5.6" }
+        let(:build_url) { 'http://foo' }
+
+        def modify hash, options
+          hash.delete(options.fetch(:without))
+          hash
+        end
+
+        describe "errors" do
+
+          before do
+            subject.validate(params)
+          end
+
+          context "with valid fields" do
+            its(:errors) { is_expected.to be_empty }
+          end
+
+          context "with no success property" do
+            let(:success) { nil }
+
+            it "has an error" do
+              expect(subject.errors[:success]).to include(match("blank"))
+            end
+          end
+
+          context "when success is a non-boolean string" do
+            let(:success) { "foo" }
+            it "has an error" do
+              expect(subject.errors[:success]).to include(match("boolean"))
+            end
+          end
+
+          context "when buildUrl is not a URL" do
+            let(:build_url) { "foo bar" }
+            it "has an error" do
+              expect(subject.errors[:build_url]).to include(match("URL"))
+            end
+          end
+
+          context "when buildUrl is nil" do
+            let(:build_url) { nil }
+            its(:errors) { is_expected.to be_empty }
+          end
+
+          context "when the buildURL is not present" do
+            let(:params) { modify valid_params, without: :buildUrl }
+            its(:errors) { is_expected.to be_empty }
+          end
+
+          context "when the providerApplicationVersion is not present" do
+            let(:params) { modify valid_params, without: :providerApplicationVersion }
+            it "has an error" do
+              expect(subject.errors[:provider_version]).to include(match("can't be blank"))
+            end
+          end
+
+          context "when the providerApplicationVersion is blank" do
+            let(:provider_version) { " " }
+            it "has an error" do
+              expect(subject.errors[:provider_version]).to include(match("can't be blank"))
+            end
+          end
+
+          context "when the providerApplicationVersion is not a semantic version" do
+            let(:provider_version) { "#" }
+            it "has an error" do
+              expect(subject.errors[:provider_version]).to include(match("#.*cannot be parsed"))
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/api/decorators/latest_pact_decorator_spec.rb

@@ -18,24 +18,6 @@ module PactBroker
           expect(subject[:createdAt]).to_not be_nil
         end
 
-        context "when the updatedAt is the same as the createdAt" do
-          it "does not include the updatedAt date" do
-            expect(subject[:updatedAt]).to be_nil
-          end
-        end
-
-        context "when the updatedAt is not the same as the createdAt" do
-          let(:pact) do
-            pact = ProviderStateBuilder.new.create_pact_with_hierarchy 'Consumer', '1.2.3', 'Provider'
-            pact.updated_at = pact.created_at + 1
-            RepresentablePact.new(pact)
-          end
-
-          it "includes the updatedAt date" do
-            expect(subject[:updatedAt]).to_not be_nil
-          end
-        end
-
       end
     end
   end

data/spec/lib/pact_broker/api/decorators/pact_decorator_spec.rb

@@ -20,15 +20,15 @@ module PactBroker
 
         let(:base_url) { 'http://example.org' }
         let(:created_at) { Time.new(2014, 3, 4) }
-        let(:updated_at) { Time.new(2014, 3, 5) }
         let(:pact) { double('pact',
           content_hash: content_hash,
           created_at: created_at,
-          updated_at: updated_at,
           consumer: consumer,
           provider: provider,
           consumer_version: consumer_version,
           consumer_version_number: '1234',
+          pact_version_sha: '9999',
+          revision_number: 2,
           name: 'A Pact'
         )}
         let(:consumer) { instance_double(PactBroker::Domain::Pacticipant, name: 'A Consumer')}
@@ -90,6 +90,10 @@ module PactBroker
             expect(subject[:_links][:'pb:pact-versions'][:href]).to eq "http://example.org/pacts/provider/A%20Provider/consumer/A%20Consumer/versions"
           end
 
+          it "includes a link to publish a verification" do
+            expect(subject[:_links][:'pb:publish-verification'][:href]).to match %r{http://example.org/.*/verifications}
+          end
+
           it "includes a curie" do
             expect(subject[:_links][:curies]).to eq [{ name: "pb", href: "http://example.org/doc/{rel}", templated: true }]
           end

data/spec/lib/pact_broker/api/decorators/pact_version_decorator_spec.rb

@@ -20,11 +20,9 @@ module PactBroker
 
         let(:base_url) { 'http://example.org' }
         let(:created_at) { Time.new(2014, 3, 4) }
-        let(:updated_at) { Time.new(2014, 3, 5) }
         let(:pact) { double('pact',
           json_content: json_content,
           created_at: created_at,
-          updated_at: updated_at,
           consumer: consumer,
           provider: provider,
           consumer_version: consumer_version,
@@ -53,7 +51,6 @@ module PactBroker
 
         it "includes timestamps" do
           expect(subject[:createdAt]).to_not be_nil
-          expect(subject[:updatedAt]).to_not be_nil
         end
 
       end

data/spec/lib/pact_broker/api/decorators/verification_decorator_spec.rb

@@ -0,0 +1,61 @@
+require 'pact_broker/api/decorators/verification_decorator'
+
+module PactBroker
+  module Api
+    module Decorators
+      describe VerificationDecorator do
+
+        let(:verification) do
+          instance_double('PactBroker::Domain::Verification',
+            number: 1,
+            success: true,
+            provider_version: "4.5.6",
+            provider_name: 'Provider',
+            consumer_name: 'Consumer',
+            build_url: 'http://build-url',
+            pact_version: pact_version,
+            latest_pact_publication: pact_publication)
+        end
+
+        let(:pact_version) do
+          instance_double('PactBroker::Pacts::PactVersion',
+            sha: '1234'
+          )
+        end
+
+        let(:pact_publication) do
+          instance_double('PactBroker::Pacts::PactPublication',
+            name: 'A name',
+            provider_name: 'Provider',
+            consumer_name: 'Consumer',
+            consumer_version_number: '1.2.3'
+          )
+        end
+
+        let(:options) { { user_options: { base_url: 'http://example.org' } } }
+
+        subject { JSON.parse VerificationDecorator.new(verification).to_json(options), symbolize_names: true }
+
+        it "includes the success status" do
+          expect(subject[:success]).to eq true
+        end
+
+        it "includes the provider version" do
+          expect(subject[:providerApplicationVersion]).to eq "4.5.6"
+        end
+
+        it "includes the build URL" do
+          expect(subject[:buildUrl]).to eq "http://build-url"
+        end
+
+        it "includes a link to itself" do
+          expect(subject[:_links][:self][:href]).to match %r{http://example.org/.*/verifications/1}
+        end
+
+        it "includes a link to its pact" do
+          expect(subject[:_links][:'pb:pact-version'][:href]).to match %r{http://example.org/pacts/}
+        end
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/api/decorators/verifications_decorator_spec.rb

@@ -0,0 +1,42 @@
+require 'pact_broker/api/decorators/verifications_decorator'
+
+module PactBroker
+  module Api
+    module Decorators
+      describe VerificationsDecorator do
+        let(:verifications) { [verification] }
+        let(:verification) do
+          instance_double("PactBroker::Domain::Verification",
+            success: true, number: 1,
+            provider_version: '4.5.6',
+            build_url: 'http://some-build',
+            latest_pact_publication: pact,
+            provider_name: 'provider',
+            consumer_name: 'consumer',
+            pact_version: pact_version,
+            latest_pact_publication: pact)
+        end
+        let(:pact_version) do
+          instance_double("PactBroker::Pacts::PactVersion", sha: '1234', name: 'Name')
+        end
+        let(:pact) { instance_double("PactBroker::Domain::Pact", name: "Some pact", consumer_name: "Foo", provider_name: "Bar", consumer_version_number: "1.2.3") }
+        let(:options) { {base_url: 'http://example.org', consumer_name: "Foo", consumer_version_number: "1.2.3", resource_url: "http://self"} }
+
+        subject { JSON.parse VerificationsDecorator.new(verifications).to_json(user_options: options), symbolize_names: true }
+
+        it "includes a list of verifications" do
+          expect(subject[:_embedded][:verifications]).to be_instance_of(Array)
+          expect(subject[:_embedded][:verifications].size).to eq 1
+        end
+
+        it "includes a title" do
+          expect(subject[:_links][:self][:title]).to eq "Latest verifications for consumer Foo version 1.2.3"
+        end
+
+        it "includes a link to itself" do
+          expect(subject[:_links][:self][:href]).to eq "http://self"
+        end
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/api/decorators/version_decorator_spec.rb

@@ -43,6 +43,10 @@ module PactBroker
           expect(subject[:_embedded][:tags].first[:name]).to eq "prod"
         end
 
+        it "includes a link to the latest verifications for the pacts for this version" do
+          expect(subject[:_links][:'pb:latest-verifications'][:href]).to match(%r{http://.*/verifications/latest})
+        end
+
       end
     end
   end

data/spec/lib/pact_broker/api/renderers/html_pact_renderer_spec.rb

@@ -19,7 +19,7 @@ module PactBroker
         let(:provider) { double('provider', name: 'Provider')}
         let(:created_at) { DateTime.new(2014, 02, 27) }
         let(:json_content) { load_fixture('renderer_pact.json') }
-        let(:pact) { double('pact', json_content: json_content, updated_at: created_at, consumer_version_number: '1.2.3', consumer: consumer, provider: provider)}
+        let(:pact) { double('pact', json_content: json_content, consumer_version_number: '1.2.3', consumer: consumer, provider: provider, created_at: created_at)}
         let(:pact_url) { '/pact/url' }
 
         before do

data/spec/lib/pact_broker/api/resources/latest_verifications_for_consumer_version_spec.rb

@@ -0,0 +1,68 @@
+require 'pact_broker/api/resources/latest_verifications_for_consumer_version'
+require 'pact_broker/versions/service'
+
+module PactBroker
+  module Api
+    module Resources
+
+      describe LatestVerificationsForConsumerVersion do
+        describe "GET" do
+          let(:url) { '/pacts/consumer/Consumer/versions/1.2.3/verifications/latest' }
+          let(:response_body) { JSON.parse(subject.body, {symbolize_names: true}) }
+          let(:version) { double(:version) }
+
+          subject { get url; last_response }
+
+          before do
+            allow(PactBroker::Versions::Service).to receive(:find_by_pacticipant_name_and_number).and_return(version)
+          end
+
+          it "looks up the consumer version" do
+            expect(PactBroker::Versions::Service).to receive(:find_by_pacticipant_name_and_number).with(hash_including(pacticipant_name: 'Consumer', pacticipant_version_number: '1.2.3'))
+            subject
+          end
+
+          context "when the consumer version exists" do
+            let(:decorator) { double(:decorator, to_json: json) }
+            let(:verifications) { double(:verifications) }
+            let(:json) { {some: 'json'}.to_json }
+
+            before do
+              allow(PactBroker::Api::Decorators::VerificationsDecorator).to receive(:new).and_return(decorator)
+              allow(PactBroker::Verifications::Service).to receive(:find_latest_verifications_for_consumer_version).and_return(verifications)
+            end
+
+            it { is_expected.to be_a_hal_json_success_response }
+
+            it "finds the latest verifications for the consumer version" do
+              expect(PactBroker::Verifications::Service).to receive(:find_latest_verifications_for_consumer_version).with(hash_including(consumer_name: 'Consumer', consumer_version_number: '1.2.3'))
+              subject
+            end
+
+            it "serialises the verifications" do
+              expect(PactBroker::Api::Decorators::VerificationsDecorator).to receive(:new).with(verifications)
+              expect(decorator).to receive(:to_json) do | args |
+                expect(args[:user_options][:consumer_name]).to eq 'Consumer'
+                expect(args[:user_options][:consumer_version_number]).to eq '1.2.3'
+                expect(args[:user_options][:resource_url]).to include(url)
+                expect(args[:user_options][:base_url]).to eq "http://example.org"
+              end
+              subject
+            end
+
+            it "returns the serialised verifications in the response" do
+              expect(subject.body).to eq(json)
+            end
+          end
+
+          context "when the consumer version does not exist" do
+            let(:version) { nil }
+
+            it { is_expected.to be_a_404_response }
+          end
+
+        end
+      end
+    end
+  end
+end