pact_broker-client 1.6.0 → 1.7.0

data/spec/lib/pact_broker/client/cli/version_selector_options_parser_spec.rb

@@ -0,0 +1,43 @@
+require 'pact_broker/client/cli/version_selector_options_parser'
+
+module PactBroker
+  module Client
+    module CLI
+      describe VersionSelectorOptionsParser do
+
+        TEST_CASES = [
+          [
+            ["--name", "Foo", "--version", "1.2.3"],
+            [{ name: "Foo", version: "1.2.3" } ]
+          ],[
+            ["-n", "Foo", "-a", "1.2.3"],
+            [{ name: "Foo", version: "1.2.3" } ]
+          ],[
+            ["--name", "Foo"],
+            [{ name: "Foo" } ]
+          ],[
+            ["--name", "Foo", "Bar"],
+            [{ name: "Bar" } ]
+          ],[
+            ["--name", "Foo", "--name", "Bar", "--version", "1.2.3"],
+            [{ name: "Foo" }, { name: "Bar", version: "1.2.3" } ]
+          ],[
+            ["--name", "Foo", "--wrong", "Bar", "--version", "1.2.3"],
+            [{ name: "Foo", version: "1.2.3" } ]
+          ],[
+            ["--name", "the-thing", "--version", "1.2.3"],
+            [{ name: "the-thing", version: "1.2.3" } ]
+          ]
+        ]
+
+        TEST_CASES.each do | input, output |
+
+          it "parses #{input.join(' ')}" do
+            expect(VersionSelectorOptionsParser.call(input)).to eq output
+          end
+
+        end
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/client/matrix/text_formatter_spec.rb

@@ -0,0 +1,29 @@
+require 'pact_broker/client/matrix/text_formatter'
+
+module PactBroker
+  module Client
+    describe Matrix::TextFormatter do
+      let(:matrix_lines) { JSON.parse(File.read('spec/support/matrix.json'), symbolize_names: true) }
+      let(:expected_matrix_lines) { File.read('spec/support/matrix.txt') }
+
+      # SublimeText removes whitespace from the end of files when you save them,
+      # so removing trailing whitespace before comparing
+      subject { Matrix::TextFormatter.call(matrix_lines).split("\n").collect(&:strip).join("\n") }
+
+      context "with valid data" do
+        it "it has the right text" do
+          expect(subject).to eq expected_matrix_lines
+        end
+      end
+
+      context "with invalid data" do
+        let(:expected_matrix_lines) { File.read('spec/support/matrix_error.txt') }
+        let(:matrix_lines) { [{}] }
+
+        it "doesn't blow up" do
+          expect(subject).to eq expected_matrix_lines
+        end
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/client/matrix_spec.rb

@@ -0,0 +1,16 @@
+require 'pact_broker/client/matrix'
+
+module PactBroker
+  module Client
+    describe Matrix do
+      context "when the matrix resource is not found because the broker is the wrong version" do
+        let(:matrix) { Matrix.new(base_url: 'http://example.org') }
+        let!(:request) { stub_request(:get, /matrix/).to_return(status: 404) }
+
+        it "raises a helpful error" do
+          expect { matrix.get([{name: "Foo", version: "1"}]) }.to raise_error PactBroker::Client::Error, %r{Matrix resource not found at http://example.org/matrix}
+        end
+      end
+    end
+  end
+end

data/spec/pacts/pact_broker_client-pact_broker.json

@@ -198,6 +198,89 @@
         }
       }
     },
+    {
+      "description": "a request for the compatibility matrix for Foo version 1.2.3 and Bar version 4.5.6",
+      "providerState": "the pact for Foo version 1.2.3 has been verified by Bar version 4.5.6",
+      "request": {
+        "method": "get",
+        "path": "/matrix",
+        "query": "selectors[]=Foo%2Fversion%2F1.2.3&selectors[]=Bar%2Fversion%2F4.5.6"
+      },
+      "response": {
+        "status": 200,
+        "headers": {
+        },
+        "body": {
+          "matrix": {
+            "json_class": "Pact::SomethingLike",
+            "contents": [
+              {
+                "consumer": {
+                  "name": "Foo",
+                  "version": {
+                    "number": "4"
+                  }
+                },
+                "provider": {
+                  "name": "Bar",
+                  "version": {
+                    "number": "5"
+                  }
+                },
+                "verificationResult": {
+                  "verifiedAt": "2017-10-10T12:49:04+11:00",
+                  "success": true
+                },
+                "pact": {
+                  "createdAt": "2017-10-10T12:49:04+11:00"
+                }
+              }
+            ]
+          }
+        }
+      }
+    },
+    {
+      "description": "a request for the compatibility matrix where one or more versions does not exist",
+      "providerState": "the pact for Foo version 1.2.3 has been verified by Bar version 4.5.6",
+      "request": {
+        "method": "get",
+        "path": "/matrix",
+        "query": "selectors[]=Foo%2Fversion%2F1.2.3&selectors[]=Bar%2Fversion%2F9.9.9"
+      },
+      "response": {
+        "status": 400,
+        "headers": {
+        },
+        "body": {
+          "errors": {
+            "json_class": "Pact::ArrayLike",
+            "contents": "an error message",
+            "min": 1
+          }
+        }
+      }
+    },
+    {
+      "description": "a request for the compatibility matrix for a pacticipant that does not exist",
+      "request": {
+        "method": "get",
+        "path": "/matrix",
+        "query": "selectors[]=Foo%2Fversion%2F1.2.3&selectors[]=Bar%2Fversion%2F9.9.9"
+      },
+      "response": {
+        "status": 400,
+        "headers": {
+        },
+        "body": {
+          "errors": {
+            "json_class": "Pact::ArrayLike",
+            "contents": "an error message",
+            "min": 1
+          }
+        }
+      }
+    },
     {
       "description": "a request to publish a pact",
       "providerState": "the 'Pricing Service' already exists in the pact-broker",

data/spec/service_providers/pact_broker_client_matrix_spec.rb

@@ -0,0 +1,119 @@
+require_relative 'pact_helper'
+require 'pact_broker/client'
+
+module PactBroker::Client
+  describe Matrix, :pact => true do
+
+    include_context "pact broker"
+
+    describe "retriving the compatibility matrix" do
+      let(:matrix_response_body) { { matrix: Pact.like(matrix) } }
+      let(:matrix) { JSON.parse(File.read('spec/support/matrix.json')) }
+      let(:selectors) { [{ name: "Foo", version: "1.2.3" }, { name: "Bar", version: "4.5.6" }] }
+
+      context "when results are found" do
+        before do
+          pact_broker.
+            given("the pact for Foo version 1.2.3 has been verified by Bar version 4.5.6").
+            upon_receiving("a request for the compatibility matrix for Foo version 1.2.3 and Bar version 4.5.6").
+            with(
+              method: :get,
+              path: "/matrix",
+              query: {
+                'selectors[]' => ['Foo/version/1.2.3', 'Bar/version/4.5.6']
+              }
+            ).
+            will_respond_with(
+              status: 200,
+              headers: pact_broker_response_headers,
+              body: matrix_response_body
+            )
+        end
+
+        it 'a matrix of compatible versions' do
+          matrix = pact_broker_client.matrix.get(selectors)
+          expect(matrix.size).to eq 1
+        end
+      end
+
+      # context "with only one version selector" do
+      #   before do
+      #     pact_broker.
+      #       given("the pact for Foo version 1.2.3 has been verified by Bar version 4.5.6").
+      #       upon_receiving("a request for the compatibility matrix where only the version of Foo is specified").
+      #       with(
+      #         method: :get,
+      #         path: "/matrix",
+      #         query: {
+      #           'selectors[]' => ['Foo/version/1.2.3']
+      #         }
+      #       ).
+      #       will_respond_with(
+      #         status: 200,
+      #         headers: pact_broker_response_headers,
+      #         body: matrix_response_body
+      #       )
+      #   end
+      # end
+
+      context "when one or more of the versions does not exist" do
+        before do
+          pact_broker.
+            given("the pact for Foo version 1.2.3 has been verified by Bar version 4.5.6").
+            upon_receiving("a request for the compatibility matrix where one or more versions does not exist").
+            with(
+              method: :get,
+              path: "/matrix",
+              query: {
+                'selectors[]' => ['Foo/version/1.2.3', 'Bar/version/9.9.9']
+              }
+            ).
+            will_respond_with(
+              status: 400,
+              headers: pact_broker_response_headers,
+              body: {
+                errors: Pact.each_like("an error message")
+              }
+            )
+        end
+
+        let(:selectors) { [{ name: "Foo", version: "1.2.3" }, { name: "Bar", version: "9.9.9" }] }
+
+        it 'returns a list of errors' do
+          expect {
+            pact_broker_client.matrix.get(selectors)
+          }.to raise_error PactBroker::Client::Error, "an error message"
+        end
+      end
+
+      context "when results are not found" do
+        before do
+          pact_broker.
+            upon_receiving("a request for the compatibility matrix for a pacticipant that does not exist").
+            with(
+              method: :get,
+              path: "/matrix",
+              query: {
+                'selectors[]' => ['Foo/version/1.2.3', 'Bar/version/9.9.9']
+              }
+            ).
+            will_respond_with(
+              status: 400,
+              headers: pact_broker_response_headers,
+              body: {
+                errors: Pact.each_like("an error message")
+              }
+            )
+        end
+
+        let(:selectors) { [{ name: "Foo", version: "1.2.3" }, { name: "Bar", version: "9.9.9" }] }
+
+        it 'returns a list of errors' do
+          expect {
+            pact_broker_client.matrix.get(selectors)
+          }.to raise_error PactBroker::Client::Error, "an error message"
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,10 +1,5 @@
-require 'rspec/fire'
 require 'webmock/rspec'
 
 WebMock.disable_net_connect!(allow_localhost: true)
 
-RSpec.configure do | config |
-  config.include RSpec::Fire
-end
-
 require "./spec/support/shared_context.rb"

data/spec/support/matrix.json

@@ -0,0 +1,23 @@
+[
+  {
+    "consumer": {
+      "name": "Foo",
+      "version": {
+        "number": "4"
+      }
+    },
+    "provider": {
+      "name": "Bar",
+      "version": {
+        "number": "5"
+      }
+    },
+    "verificationResult": {
+      "verifiedAt": "2017-10-10T12:49:04+11:00",
+      "success": true
+    },
+    "pact": {
+      "createdAt": "2017-10-10T12:49:04+11:00"
+    }
+  }
+]

data/spec/support/matrix.txt

@@ -0,0 +1,3 @@
+CONSUMER | CONSUMER_VERSION | PROVIDER | PROVIDER_VERSION | SUCCESS
+---------|------------------|----------|------------------|--------
+Foo      | 4                | Foo      | 5                | true

data/spec/support/matrix_error.txt

@@ -0,0 +1,3 @@
+CONSUMER | CONSUMER_VERSION | PROVIDER | PROVIDER_VERSION | SUCCESS
+---------|------------------|----------|------------------|--------
+???      | ???              | ???      | ???              | ???

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pact_broker-client
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.7.0
 platform: ruby
 authors:
 - Bethany Skurrie
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-01 00:00:00.000000000 Z
+date: 2017-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -53,19 +53,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: table_print
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+        version: '1.5'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.5'
 - !ruby/object:Gem::Dependency
   name: fakefs
   requirement: !ruby/object:Gem::Requirement
@@ -80,20 +80,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.4'
-- !ruby/object:Gem::Dependency
-  name: rspec-fire
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
@@ -150,10 +136,25 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.16'
+- !ruby/object:Gem::Dependency
+  name: pry-byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Publishes pacts to, and retrieves pacts from, the pact broker server.
 email:
 - bskurrie@dius.com.au
 executables:
+- pact-broker
 - pact-publish
 extensions: []
 extra_rdoc_files: []
@@ -167,6 +168,7 @@ files:
 - README.md
 - RELEASING.md
 - Rakefile
+- bin/pact-broker
 - bin/pact-publish
 - ci.sh
 - doc/markdown/Pact Broker Client - Pact Broker.md
@@ -177,9 +179,16 @@ files:
 - gemfiles/ruby_under_22.gemfile.lock
 - lib/pact_broker/client.rb
 - lib/pact_broker/client/base_client.rb
+- lib/pact_broker/client/can_i_deploy.rb
+- lib/pact_broker/client/cli/broker.rb
 - lib/pact_broker/client/cli/custom_thor.rb
 - lib/pact_broker/client/cli/publish.rb
+- lib/pact_broker/client/cli/version_selector_options_parser.rb
 - lib/pact_broker/client/error.rb
+- lib/pact_broker/client/matrix.rb
+- lib/pact_broker/client/matrix/formatter.rb
+- lib/pact_broker/client/matrix/json_formatter.rb
+- lib/pact_broker/client/matrix/text_formatter.rb
 - lib/pact_broker/client/merge_pacts.rb
 - lib/pact_broker/client/pact_broker_client.rb
 - lib/pact_broker/client/pact_file.rb
@@ -195,8 +204,13 @@ files:
 - lib/pact_broker_client.rb
 - pact-broker-client.gemspec
 - spec/lib/pact_broker/client/base_client_spec.rb
+- spec/lib/pact_broker/client/can_i_deploy_spec.rb
+- spec/lib/pact_broker/client/cli/broker_spec.rb
 - spec/lib/pact_broker/client/cli/custom_thor_spec.rb
 - spec/lib/pact_broker/client/cli/publish_spec.rb
+- spec/lib/pact_broker/client/cli/version_selector_options_parser_spec.rb
+- spec/lib/pact_broker/client/matrix/text_formatter_spec.rb
+- spec/lib/pact_broker/client/matrix_spec.rb
 - spec/lib/pact_broker/client/merge_pacts_spec.rb
 - spec/lib/pact_broker/client/pact_broker_client_spec.rb
 - spec/lib/pact_broker/client/pacticipants_spec.rb
@@ -205,6 +219,7 @@ files:
 - spec/lib/pact_broker/client/versions_spec.rb
 - spec/pacts/pact_broker_client-pact_broker.json
 - spec/service_providers/extra_goodies_spec.rb
+- spec/service_providers/pact_broker_client_matrix_spec.rb
 - spec/service_providers/pact_broker_client_pacticipant_version_spec.rb
 - spec/service_providers/pact_broker_client_publish_spec.rb
 - spec/service_providers/pact_broker_client_register_repository_spec.rb
@@ -216,6 +231,9 @@ files:
 - spec/support/cli_test_pacts/bar.json
 - spec/support/cli_test_pacts/foo.json
 - spec/support/latest_pacts_for_provider.json
+- spec/support/matrix.json
+- spec/support/matrix.txt
+- spec/support/matrix_error.txt
 - spec/support/pacticipant_get.json
 - spec/support/pacticipants_list.json
 - spec/support/pacts_latest_list.json
@@ -241,14 +259,19 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: See description
 test_files:
 - spec/lib/pact_broker/client/base_client_spec.rb
+- spec/lib/pact_broker/client/can_i_deploy_spec.rb
+- spec/lib/pact_broker/client/cli/broker_spec.rb
 - spec/lib/pact_broker/client/cli/custom_thor_spec.rb
 - spec/lib/pact_broker/client/cli/publish_spec.rb
+- spec/lib/pact_broker/client/cli/version_selector_options_parser_spec.rb
+- spec/lib/pact_broker/client/matrix/text_formatter_spec.rb
+- spec/lib/pact_broker/client/matrix_spec.rb
 - spec/lib/pact_broker/client/merge_pacts_spec.rb
 - spec/lib/pact_broker/client/pact_broker_client_spec.rb
 - spec/lib/pact_broker/client/pacticipants_spec.rb
@@ -257,6 +280,7 @@ test_files:
 - spec/lib/pact_broker/client/versions_spec.rb
 - spec/pacts/pact_broker_client-pact_broker.json
 - spec/service_providers/extra_goodies_spec.rb
+- spec/service_providers/pact_broker_client_matrix_spec.rb
 - spec/service_providers/pact_broker_client_pacticipant_version_spec.rb
 - spec/service_providers/pact_broker_client_publish_spec.rb
 - spec/service_providers/pact_broker_client_register_repository_spec.rb
@@ -268,6 +292,9 @@ test_files:
 - spec/support/cli_test_pacts/bar.json
 - spec/support/cli_test_pacts/foo.json
 - spec/support/latest_pacts_for_provider.json
+- spec/support/matrix.json
+- spec/support/matrix.txt
+- spec/support/matrix_error.txt
 - spec/support/pacticipant_get.json
 - spec/support/pacticipants_list.json
 - spec/support/pacts_latest_list.json