pact_broker-client 1.30.0 → 1.35.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d7be73ef3705005ce0808a1d74dba560c4f590fce09871ae7597c06479ce2316
-  data.tar.gz: ec3b757187ce7c60dbc4835933debbe68fa2f5fb2b08ffdb6f9e5cb7141943e1
+  metadata.gz: 1bf1176c39519652e60c6aab383a941a2dd5a1c8e968b746741a290e68c736e9
+  data.tar.gz: 04b1f3aa9f25b353e61eb558d393d108750cd97b4645fe81313b1d04dca33ba5
 SHA512:
-  metadata.gz: 5f035fa2d68c909fc2d3865ebcd76be24ae9af0a0a4bc4cd0e2503f3a1da822456a6439b61364a83a73ff6e9021a5fa5caa24addeb4f9d9a10980ab33e1ffb74
-  data.tar.gz: 2fe9a489c6c2824f1d218b693559bf1be1713d2989c62283979acc7ddda0684a0b60607fce0abd5d813dbb279c7ff5a4b5ca6bb186c79af3911855803f79837a
+  metadata.gz: cbb4fe27ce2979d3daea2c597ca7509b6d4136ac53d139a738fd672f30d114fcce23ce4f3ba3c108aef13ec88b9793715bf57ec05a2fda6255dfcd7ed9c99875
+  data.tar.gz: 443c3e2e5fb75bcbfa3850ce1498f859c45872145f813c50b260a9a7d28a32f5aa7618c1f55b0c798b34975ec7b35d7e44b0937c6bd2575dea1b86356eb8ca5b

data/.github/workflows/test.yml

@@ -0,0 +1,23 @@
+name: Test
+
+on: push
+
+jobs:
+  test:
+    runs-on: "ubuntu-latest"
+    continue-on-error: ${{ matrix.experimental }}
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby_version: ["2.2", "2.7"]
+        experimental: [false]
+        include:
+          - ruby_version: "3.0"
+            experimental: true
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby_version }}
+      - run: "bundle install"
+      - run: "bundle exec rake"

data/CHANGELOG.md

@@ -1,3 +1,49 @@
+<a name="v1.35.0"></a>
+### v1.35.0 (2021-01-21)
+
+#### Features
+
+* **can-i-deploy**
+  * display links to verification results in the output of can-i-deploy when using text format	 ([976950d](/../../commit/976950d))
+
+<a name="v1.34.0"></a>
+### v1.34.0 (2020-11-20)
+
+#### Features
+
+* **pact publish**
+  * strip new lines from version numbers and tags	 ([5842d24](/../../commit/5842d24))
+
+* **publish**
+  * update output text when pact already exists and merging	 ([9b849d3](/../../commit/9b849d3))
+
+<a name="v1.33.0"></a>
+### v1.33.0 (2020-11-10)
+
+#### Features
+
+* **publish**
+  * allow pacts to be merged on the server side	 ([bd80f10](/../../commit/bd80f10))
+
+<a name="v1.32.0"></a>
+### v1.32.0 (2020-10-26)
+
+#### Features
+
+* Improve HTTP errors handling (#76)	 ([d8eaf16](/../../commit/d8eaf16))
+
+#### Bug Fixes
+
+* **list-latest-pact-versions**
+  * correct json output	 ([cf77666](/../../commit/cf77666))
+
+<a name="v1.31.0"></a>
+### v1.31.0 (2020-10-22)
+
+#### Features
+
+* update thor dependancy (#75)	 ([2078f31](/../../commit/2078f31))
+
 <a name="v1.30.0"></a>
 ### v1.30.0 (2020-10-09)
 

data/README.md

@@ -2,7 +2,9 @@
 
 A client for the Pact Broker. Publishes and retrieves pacts, verification results, pacticipants, pacticipant versions and tags. The functionality is available via a CLI, or via Ruby Rake tasks. You can also use the [Pact CLI Docker image](https://hub.docker.com/r/pactfoundation/pact-cli).
 
-[![Build Status](https://travis-ci.org/pact-foundation/pact_broker-client.svg?branch=master)](https://travis-ci.org/pact-foundation/pact_broker-client)
+![Build status](https://github.com/pact-foundation/pact_broker-client/workflows/Test/badge.svg)
+
+[![Gem Version](https://badge.fury.io/rb/pact_broker-client.svg)](http://badge.fury.io/rb/pact_broker-client)
 
 ![Trigger update to docs.pact.io](https://github.com/pact-foundation/pact_broker-client/workflows/Trigger%20update%20to%20docs.pact.io/badge.svg)
 
@@ -16,9 +18,19 @@ Download the latest [pact-ruby-standalone][pact-ruby-standalone] package. You do
 
 Add `gem 'pact_broker-client'` to your Gemfile and run `bundle install`, or install the gem directly by running `gem install pact_broker-client`.
 
+## Connecting to a Pact Broker with a self signed certificate
+
+To connect to a Pact Broker that uses custom SSL cerificates, set the environment variable `$SSL_CERT_FILE` or `$SSL_CERT_DIR` to a path that contains the appropriate certificate. Read more at https://docs.pact.io/pact_broker/advanced_topics/using-tls#for-non-jvm
+
 ## Usage - CLI
 
-To connect to a Pact Broker that uses custom SSL cerificates, set the environment variable `$SSL_CERT_FILE` or `$SSL_CERT_DIR` to a path that contains the appropriate certificate.
+The Pact Broker base URL can be specified either using the environment variable `$PACT_BROKER_BASE_URL` or the `-b` or `--broker-base-url` parameters.
+
+Pact Broker authentication can be performed either using basic auth or a bearer token.
+
+Basic auth parameters can be specified using the `$PACT_BROKER_USERNAME` and `$PACT_BROKER_PASSWORD` environment variables, or the `-u` or `--broker-username` and `-p` or `--broker-password` parameters.
+
+Authentication using a bearer token can be specified using the environment variable `$PACT_BROKER_TOKEN` or the `-k` or `--broker-token` parameters. This authentication system is used by [Pactflow](pactflow.io).
 
 ### publish
 
@@ -188,7 +200,7 @@ Can I deploy all the applications in my monorepo to prod?
                                --pacticipant B --version a7e28207 \
                                --pacticipant C --version a7e28207 \
                                --to prod \
-                               --broker-base-url BROKER_BASE_URL                               
+                               --broker-base-url BROKER_BASE_URL
 
 Mobile provider use case - can I deploy version b80e7b1b of Bar, all versions of Foo with tag "prod", and the latest version tagged "prod" of any other automatically calculated dependencies together? (Eg. where Bar is a provider and Foo is a mobile consumer with multiple versions in production, and Bar also has its own providers it needs to be compatible with.)
 

data/doc/pacts/markdown/Pact Broker Client - Pact Broker.md

@@ -164,7 +164,12 @@ Pact Broker will respond with:
         },
         "verificationResult": {
           "verifiedAt": "2017-10-10T12:49:04+11:00",
-          "success": true
+          "success": true,
+          "_links": {
+            "self": {
+              "href": "http://result"
+            }
+          }
         },
         "pact": {
           "createdAt": "2017-10-10T12:49:04+11:00"
@@ -185,7 +190,12 @@ Pact Broker will respond with:
         },
         "verificationResult": {
           "verifiedAt": "2017-10-10T12:49:04+11:00",
-          "success": true
+          "success": true,
+          "_links": {
+            "self": {
+              "href": "http://result"
+            }
+          }
         },
         "pact": {
           "createdAt": "2017-10-10T12:49:04+11:00"
@@ -233,7 +243,12 @@ Pact Broker will respond with:
         },
         "verificationResult": {
           "verifiedAt": "2017-10-10T12:49:04+11:00",
-          "success": true
+          "success": true,
+          "_links": {
+            "self": {
+              "href": "http://result"
+            }
+          }
         },
         "pact": {
           "createdAt": "2017-10-10T12:49:04+11:00"
@@ -281,7 +296,12 @@ Pact Broker will respond with:
         },
         "verificationResult": {
           "verifiedAt": "2017-10-10T12:49:04+11:00",
-          "success": true
+          "success": true,
+          "_links": {
+            "self": {
+              "href": "http://result"
+            }
+          }
         },
         "pact": {
           "createdAt": "2017-10-10T12:49:04+11:00"
@@ -329,7 +349,12 @@ Pact Broker will respond with:
         },
         "verificationResult": {
           "verifiedAt": "2017-10-10T12:49:04+11:00",
-          "success": true
+          "success": true,
+          "_links": {
+            "self": {
+              "href": "http://result"
+            }
+          }
         },
         "pact": {
           "createdAt": "2017-10-10T12:49:04+11:00"
@@ -413,7 +438,12 @@ Pact Broker will respond with:
         },
         "verificationResult": {
           "verifiedAt": "2017-10-10T12:49:04+11:00",
-          "success": true
+          "success": true,
+          "_links": {
+            "self": {
+              "href": "http://result"
+            }
+          }
         },
         "pact": {
           "createdAt": "2017-10-10T12:49:04+11:00"
@@ -484,7 +514,12 @@ Pact Broker will respond with:
         },
         "verificationResult": {
           "verifiedAt": "2017-10-10T12:49:04+11:00",
-          "success": true
+          "success": true,
+          "_links": {
+            "self": {
+              "href": "http://result"
+            }
+          }
         },
         "pact": {
           "createdAt": "2017-10-10T12:49:04+11:00"
@@ -735,7 +770,12 @@ Pact Broker will respond with:
         },
         "verificationResult": {
           "verifiedAt": "2017-10-10T12:49:04+11:00",
-          "success": true
+          "success": true,
+          "_links": {
+            "self": {
+              "href": "http://result"
+            }
+          }
         },
         "pact": {
           "createdAt": "2017-10-10T12:49:04+11:00"

data/lib/pact_broker/client/base_client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'erb'
 require 'httparty'
 require 'pact_broker/client/error'
@@ -30,6 +32,12 @@ module PactBroker
     end
 
     class BaseClient
+      ERROR_CODE_MAPPING = {
+        401 => "Authentication failed",
+        403 => "Authorization failed (insufficient permissions)",
+        409 => "Potential duplicate pacticipants"
+      }.freeze
+
       include UrlHelpers
       include HTTParty
       include StringToSymbol
@@ -69,14 +77,8 @@ module PactBroker
           yield response
         elsif response.code == 404
           nil
-        elsif response.code == 403
-          message = "Authorization failed (insufficient permissions)"
-          if response.body && response.body.size > 0
-            message = message + ": #{response.body}"
-          end
-          raise Error.new(message)
-        elsif response.code == 401
-          message = "Authentication failed"
+        elsif ERROR_CODE_MAPPING.key?(response.code)
+          message = ERROR_CODE_MAPPING.fetch(response.code)
           if response.body && response.body.size > 0
             message = message + ": #{response.body}"
           end
@@ -93,7 +95,7 @@ module PactBroker
               response.body
             end
           rescue
-            raise Error.new(response.body)
+            raise Error.new("status=#{response.code} #{response.body}")
           end
           raise Error.new(error_message)
         end

data/lib/pact_broker/client/cli/broker.rb

@@ -50,6 +50,7 @@ module PactBroker
         method_option :broker_token, aliases: "-k", desc: "Pact Broker bearer token"
         method_option :tag, aliases: "-t", type: :array, banner: "TAG", desc: "Tag name for consumer version. Can be specified multiple times."
         method_option :tag_with_git_branch, aliases: "-g", type: :boolean, default: false, required: false, desc: "Tag consumer version with the name of the current git branch. Default: false"
+        method_option :merge, type: :boolean, default: false, require: false, desc: "If a pact already exists for this consumer version and provider, merge the contents. Useful when running Pact tests concurrently on different build nodes."
         method_option :verbose, aliases: "-v", type: :boolean, default: false, required: false, desc: "Verbose output. Default: false"
 
         def publish(*pact_files)
@@ -209,13 +210,14 @@ module PactBroker
 
           def publish_pacts pact_files
             require 'pact_broker/client/publish_pacts'
+            write_options = options[:merge] ? { write: :merge } : {}
 
             PactBroker::Client::PublishPacts.call(
               options.broker_base_url,
               file_list(pact_files),
               options.consumer_app_version,
               tags,
-              pact_broker_client_options
+              pact_broker_client_options.merge(write_options)
             )
           end
 

data/lib/pact_broker/client/matrix.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_client'
 require 'pact_broker/client/matrix/resource'
 
@@ -39,7 +41,7 @@ module PactBroker
               response.body
             end
           rescue
-            raise Error.new(response.body)
+            raise Error.new("status=#{response.code} #{response.body}")
           end
           raise Error.new(error_message)
         end

data/lib/pact_broker/client/matrix/text_formatter.rb

@@ -1,41 +1,74 @@
 require 'table_print'
+require 'dig_rb'
 
 module PactBroker
   module Client
     class Matrix
       class TextFormatter
 
-        Line = Struct.new(:consumer, :consumer_version, :provider, :provider_version, :success)
+        Line = Struct.new(:consumer, :consumer_version, :provider, :provider_version, :success, :ref)
 
         OPTIONS = [
           { consumer: {} },
           { consumer_version: {display_name: 'C.VERSION'} },
           { provider: {} },
           { provider_version: {display_name: 'P.VERSION'} },
-          { success: {display_name: 'SUCCESS?'} }
+          { success: {display_name: 'SUCCESS?'} },
+          { ref: { display_name: 'RESULT#' }}
         ]
 
         def self.call(matrix)
           matrix_rows = matrix[:matrix]
           return "" if matrix_rows.size == 0
-          data = matrix_rows.collect do | line |
+          verification_result_number = 0
+          data = matrix_rows.each_with_index.collect do | line |
+            has_verification_result_url = lookup(line, nil, :verificationResult, :_links, :self, :href)
+            if has_verification_result_url
+              verification_result_number += 1
+            end
             Line.new(
-              lookup(line, :consumer, :name),
-              lookup(line, :consumer, :version, :number),
-              lookup(line, :provider, :name),
-              lookup(line, :provider, :version, :number),
-              lookup(line, :verificationResult, :success).to_s
+              lookup(line, "???", :consumer, :name),
+              lookup(line, "???", :consumer, :version, :number),
+              lookup(line, "???", :provider, :name) ,
+              lookup(line, "???", :provider, :version, :number),
+              (lookup(line, "???", :verificationResult, :success)).to_s,
+              has_verification_result_url ? verification_result_number : ""
             )
           end
 
           printer = TablePrint::Printer.new(data, OPTIONS)
-          printer.table_print
+          printer.table_print + verification_result_urls_text(matrix)
         end
 
-        def self.lookup line, *keys
+        def self.lookup line, default, *keys
           keys.reduce(line) { | line, key | line[key] }
         rescue NoMethodError
-          "???"
+          default
+        end
+
+        def self.verification_results_urls_and_successes(matrix)
+          (matrix[:matrix] || []).collect do | row |
+            url = row.dig(:verificationResult, :_links, :self, :href)
+            if url
+              success = row.dig(:verificationResult, :success)
+              [url, success]
+            else
+              nil
+            end
+          end.compact
+        end
+
+        def self.verification_result_urls_text(matrix)
+          text = self.verification_results_urls_and_successes(matrix).each_with_index.collect do |(url, success), i|
+            status = success ? 'success' : 'failure'
+            "#{i+1}. #{url} (#{status})"
+          end.join("\n")
+
+          if text.size > 0
+            "\n\nVERIFICATION RESULTS\n--------------------\n#{text}"
+          else
+            text
+          end
         end
       end
     end

data/lib/pact_broker/client/pacts/list_latest_versions.rb

@@ -20,7 +20,7 @@ module PactBroker
 
         def call
           message = if output == 'json'
-            versions_resource.response.body
+            versions_resource.response.raw_body
           else
             to_text(versions)
           end

data/lib/pact_broker/client/publish_pacts.rb

@@ -16,8 +16,8 @@ module PactBroker
       def initialize pact_broker_base_url, pact_file_paths, consumer_version, tags, pact_broker_client_options={}
         @pact_broker_base_url = pact_broker_base_url
         @pact_file_paths = pact_file_paths
-        @consumer_version = consumer_version
-        @tags = tags
+        @consumer_version = consumer_version.respond_to?(:strip) ? consumer_version.strip : consumer_version
+        @tags = tags ? tags.collect{ |tag| tag.respond_to?(:strip) ? tag.strip : tag } : tags
         @pact_broker_client_options = pact_broker_client_options
       end
 
@@ -37,6 +37,10 @@ module PactBroker
         @pact_broker_client ||= PactBroker::Client::PactBrokerClient.new(base_url: pact_broker_base_url, client_options: pact_broker_client_options)
       end
 
+      def merge_on_server?
+        pact_broker_client_options[:write] == :merge
+      end
+
       def publish_pacts
         pact_files.group_by(&:pact_name).collect do | pact_name, pact_files |
           $stdout.puts "Merging #{pact_files.collect(&:path).join(", ")}" if pact_files.size > 1
@@ -77,13 +81,13 @@ module PactBroker
         versions = pact_broker_client.pacticipants.versions
         Retry.while_error do
           consumer_names.collect do | consumer_name |
-            $stdout.puts "Tagging version #{consumer_version} of #{consumer_name} as #{tag.inspect}"
             versions.tag(pacticipant: consumer_name, version: consumer_version, tag: tag)
+            $stdout.puts "Tagged version #{consumer_version} of #{consumer_name} as #{tag.inspect}"
             true
           end
         end
       rescue => e
-        $stderr.puts "Failed to tag versions due to error: #{e.class} - #{e}"
+        $stderr.puts "Failed to tag version due to error: #{e.class} - #{e}"
         false
       end
 
@@ -91,7 +95,11 @@ module PactBroker
         Retry.while_error do
           pacts = pact_broker_client.pacticipants.versions.pacts
           if pacts.version_published?(consumer: pact.consumer_name, provider: pact.provider_name, consumer_version: consumer_version)
-            $stdout.puts ::Term::ANSIColor.yellow("A pact for this consumer version is already published. Overwriting. (Note: Overwriting pacts is not recommended as it can lead to race conditions. Best practice is to provide a unique consumer version number for each publication.)")
+            if merge_on_server?
+              $stdout.puts "A pact for this consumer version is already published. Merging contents."
+            else
+              $stdout.puts ::Term::ANSIColor.yellow("A pact for this consumer version is already published. Overwriting. (Note: Overwriting pacts is not recommended as it can lead to race conditions. Best practice is to provide a unique consumer version number for each publication.)")
+            end
           end
 
           latest_pact_url = pacts.publish(pact_hash: pact, consumer_version: consumer_version)

data/lib/pact_broker/client/version.rb

@@ -1,5 +1,5 @@
 module PactBroker
   module Client
-    VERSION = '1.30.0'
+    VERSION = '1.35.0'
   end
 end

data/pact-broker-client.gemspec

@@ -24,11 +24,13 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency 'httparty', '~>0.18'
   gem.add_runtime_dependency 'term-ansicolor', '~> 1.7'
   gem.add_runtime_dependency 'table_print', '~> 1.5'
-  gem.add_runtime_dependency 'thor', '~> 0.20'
+  gem.add_runtime_dependency 'thor', '>= 0.20', '< 2.0'
   gem.add_runtime_dependency 'rake', '~> 13.0' #For FileList
+  gem.add_runtime_dependency 'dig_rb', '~> 1.0'
 
   gem.add_development_dependency 'fakefs', '~> 0.4'
   gem.add_development_dependency 'webmock', '~> 3.0'
   gem.add_development_dependency 'conventional-changelog', '~>1.3'
   gem.add_development_dependency 'pact', '~> 1.16'
+  gem.add_development_dependency 'pact-support', '1.15.0'
 end

data/spec/lib/pact_broker/client/base_client_spec.rb

@@ -2,10 +2,11 @@ require 'pact_broker/client/base_client'
 module PactBroker
   module Client
     describe BaseClient do
-      describe '#initialize' do
-        subject { BaseClient.new(base_url: base_url) }
+      subject { BaseClient.new(base_url: base_url) }
+
+      let(:base_url) { 'http://pact_broker_base_url'}
 
-        let(:base_url) { 'http://pact_broker_base_url'}
+      describe '#initialize' do
         let(:username) { 'pact_repo_username'}
         let(:password) { 'pact_repo_password'}
         let(:token) { '123456789' }
@@ -119,6 +120,63 @@ module PactBroker
           end
         end
       end
+
+      describe '#handle_response' do
+        let(:response) { double('Response', success?: true) }
+
+        it 'yields response object' do
+          expect { |block| subject.handle_response(response, &block) }.to yield_with_args(response)
+        end
+
+        context 'with 404 response' do
+          let(:response) { double('Response', success?: false, code: 404) }
+          it 'returns nil' do
+            expect(subject.handle_response(response)).to be_nil
+          end
+        end
+
+        context 'with 401 response' do
+          let(:response) { double('Response', success?: false, code: 401, body: 'body') }
+          it 'raise an exception with meaningful message' do
+            expect { subject.handle_response(response) }
+              .to raise_error(PactBroker::Client::Error, "Authentication failed: body")
+          end
+        end
+
+        context 'with 403 response' do
+          let(:response) { double('Response', success?: false, code: 403, body: 'body') }
+          it 'raise an exception with meaningful message' do
+            expect { subject.handle_response(response) }
+              .to raise_error(PactBroker::Client::Error, "Authorization failed (insufficient permissions): body")
+          end
+        end
+
+        context 'with 409 response' do
+          let(:response) { double('Response', success?: false, code: 409, body: 'body') }
+          it 'raise an exception with meaningful message' do
+            expect { subject.handle_response(response) }
+              .to raise_error(PactBroker::Client::Error, "Potential duplicate pacticipants: body")
+          end
+        end
+
+        context 'with unsuccessful JSON response' do
+          let(:response) do
+            double('Response', success?: false, code: 500, body: '{"errors": ["Internal server error"]}')
+          end
+          it 'raise an exception with meaningful message' do
+            expect { subject.handle_response(response) }
+              .to raise_error(PactBroker::Client::Error, "Internal server error")
+          end
+        end
+
+        context 'with unsucessful nono-JSON response ' do
+          let(:response) { double('Response', success?: false, code: 500, body: 'Internal server error') }
+          it 'raise an exception with meaningful message' do
+            expect { subject.handle_response(response) }
+              .to raise_error(PactBroker::Client::Error, "status=500 Internal server error")
+          end
+        end
+      end
     end
   end
-end
+end

data/spec/lib/pact_broker/client/matrix/text_formatter_spec.rb

@@ -1,29 +1,54 @@
+require 'pact_broker/client/matrix/resource'
 require 'pact_broker/client/matrix/text_formatter'
 
 module PactBroker
   module Client
     describe Matrix::TextFormatter do
-      let(:matrix_lines) { JSON.parse(File.read('spec/support/matrix.json'), symbolize_names: true)[:matrix] }
+      let(:matrix) { PactBroker::Client::Matrix::Resource.new(JSON.parse(File.read('spec/support/matrix.json'), symbolize_names: true)) }
       let(:expected_matrix_lines) { File.read('spec/support/matrix.txt') }
 
       # SublimeText removes whitespace from the end of files when you save them,
       # so removing trailing whitespace before comparing
-      subject { Matrix::TextFormatter.call(matrix: matrix_lines).split("\n").collect(&:strip).join("\n") }
+      def strip_trailing_whitespace(text)
+        text.split("\n").collect(&:strip).join("\n")
+      end
+
+      subject { strip_trailing_whitespace(Matrix::TextFormatter.call(matrix)) }
 
       context "with valid data" do
         it "it has the right text" do
-          expect(subject).to eq expected_matrix_lines
+          expect(subject).to start_with expected_matrix_lines
         end
       end
 
       context "with invalid data" do
         let(:expected_matrix_lines) { File.read('spec/support/matrix_error.txt') }
-        let(:matrix_lines) { [{}] }
+        let(:matrix) { PactBroker::Client::Matrix::Resource.new(matrix: [{}]) }
 
         it "doesn't blow up" do
           expect(subject).to eq expected_matrix_lines
         end
       end
+
+      context "when some rows have a verification result URL and some don't" do
+        let(:matrix_lines) do
+          line_creator = -> { JSON.parse(File.read('spec/support/matrix.json'), symbolize_names: true)[:matrix].first }
+          line_1 = line_creator.call
+          line_2 = line_creator.call
+          line_3 = line_creator.call
+          line_2[:verificationResult] = nil
+          line_3[:verificationResult][:success] = false
+          [line_1, line_2, line_3]
+        end
+
+        let(:matrix) { PactBroker::Client::Matrix::Resource.new(matrix: matrix_lines) }
+
+        let(:expected_matrix_lines) { File.read('spec/support/matrix_with_results.txt') }
+
+        it "only provides a result number for the lines that have a result URL" do
+          expect(subject).to eq expected_matrix_lines
+        end
+      end
     end
   end
 end

data/spec/lib/pact_broker/client/publish_pacts_spec.rb

@@ -62,12 +62,12 @@ module PactBroker
         end
 
         context "when publishing is successful" do
-
           it "puts the location of the latest pact" do
             allow($stdout).to receive(:puts)
             expect($stdout).to receive(:puts).with(/#{latest_pact_url}/)
             subject.call
           end
+
           it "returns true" do
             expect(subject.call).to be true
           end
@@ -142,6 +142,15 @@ module PactBroker
           end
         end
 
+        context "when consumer_version has a new line" do
+          let(:consumer_version) { "1\n" }
+
+          it "strips the new line" do
+            expect(pacts_client).to receive(:publish).with(pact_hash: pact_hash, consumer_version: "1")
+            subject.call
+          end
+        end
+
         context "when pact_broker_base_url is blank" do
           let(:pact_broker_base_url) { " " }
           it "raises a validation errror" do
@@ -164,6 +173,16 @@ module PactBroker
             subject.call
           end
 
+          context "when the tag has a new line on the end of it" do
+            let(:tags) { ["foo\n"] }
+
+            it "strips the newline" do
+              expect(pact_versions_client).to receive(:tag).with({pacticipant: "Consumer",
+                version: consumer_version, tag: "foo"})
+              subject.call
+            end
+          end
+
           context "when an error occurs tagging the pact" do
 
             before do

data/spec/pacts/pact_broker_client-pact_broker.json

@@ -221,7 +221,12 @@
               },
               "verificationResult": {
                 "verifiedAt": "2017-10-10T12:49:04+11:00",
-                "success": true
+                "success": true,
+                "_links": {
+                  "self": {
+                    "href": "http://result"
+                  }
+                }
               },
               "pact": {
                 "createdAt": "2017-10-10T12:49:04+11:00"
@@ -271,7 +276,12 @@
               },
               "verificationResult": {
                 "verifiedAt": "2017-10-10T12:49:04+11:00",
-                "success": true
+                "success": true,
+                "_links": {
+                  "self": {
+                    "href": "http://result"
+                  }
+                }
               },
               "pact": {
                 "createdAt": "2017-10-10T12:49:04+11:00"
@@ -321,7 +331,12 @@
               },
               "verificationResult": {
                 "verifiedAt": "2017-10-10T12:49:04+11:00",
-                "success": true
+                "success": true,
+                "_links": {
+                  "self": {
+                    "href": "http://result"
+                  }
+                }
               },
               "pact": {
                 "createdAt": "2017-10-10T12:49:04+11:00"
@@ -418,7 +433,12 @@
               },
               "verificationResult": {
                 "verifiedAt": "2017-10-10T12:49:04+11:00",
-                "success": true
+                "success": true,
+                "_links": {
+                  "self": {
+                    "href": "http://result"
+                  }
+                }
               },
               "pact": {
                 "createdAt": "2017-10-10T12:49:04+11:00"
@@ -439,7 +459,12 @@
               },
               "verificationResult": {
                 "verifiedAt": "2017-10-10T12:49:04+11:00",
-                "success": true
+                "success": true,
+                "_links": {
+                  "self": {
+                    "href": "http://result"
+                  }
+                }
               },
               "pact": {
                 "createdAt": "2017-10-10T12:49:04+11:00"
@@ -492,7 +517,12 @@
               },
               "verificationResult": {
                 "verifiedAt": "2017-10-10T12:49:04+11:00",
-                "success": true
+                "success": true,
+                "_links": {
+                  "self": {
+                    "href": "http://result"
+                  }
+                }
               },
               "pact": {
                 "createdAt": "2017-10-10T12:49:04+11:00"
@@ -542,7 +572,12 @@
               },
               "verificationResult": {
                 "verifiedAt": "2017-10-10T12:49:04+11:00",
-                "success": true
+                "success": true,
+                "_links": {
+                  "self": {
+                    "href": "http://result"
+                  }
+                }
               },
               "pact": {
                 "createdAt": "2017-10-10T12:49:04+11:00"
@@ -592,7 +627,12 @@
               },
               "verificationResult": {
                 "verifiedAt": "2017-10-10T12:49:04+11:00",
-                "success": true
+                "success": true,
+                "_links": {
+                  "self": {
+                    "href": "http://result"
+                  }
+                }
               },
               "pact": {
                 "createdAt": "2017-10-10T12:49:04+11:00"

data/spec/support/matrix.json

@@ -20,7 +20,12 @@
       },
       "verificationResult": {
         "verifiedAt": "2017-10-10T12:49:04+11:00",
-        "success": true
+        "success": true,
+        "_links": {
+          "self": {
+            "href": "http://result"
+          }
+        }
       },
       "pact": {
         "createdAt": "2017-10-10T12:49:04+11:00"

data/spec/support/matrix.txt

@@ -1,3 +1,3 @@
-CONSUMER | C.VERSION | PROVIDER | P.VERSION | SUCCESS?
----------|-----------|----------|-----------|---------
-Foo      | 4         | Bar      | 5         | true
+CONSUMER | C.VERSION | PROVIDER | P.VERSION | SUCCESS? | RESULT#
+---------|-----------|----------|-----------|----------|--------
+Foo      | 4         | Bar      | 5         | true     | 1

data/spec/support/matrix_error.txt

@@ -1,3 +1,3 @@
-CONSUMER | C.VERSION | PROVIDER | P.VERSION | SUCCESS?
----------|-----------|----------|-----------|---------
-???      | ???       | ???      | ???       | ???
+CONSUMER | C.VERSION | PROVIDER | P.VERSION | SUCCESS? | RESULT#
+---------|-----------|----------|-----------|----------|--------
+???      | ???       | ???      | ???       | ???      |

data/spec/support/matrix_with_results.txt

@@ -0,0 +1,10 @@
+CONSUMER | C.VERSION | PROVIDER | P.VERSION | SUCCESS? | RESULT#
+---------|-----------|----------|-----------|----------|--------
+Foo      | 4         | Bar      | 5         | true     | 1
+Foo      | 4         | Bar      | 5         | ???      |
+Foo      | 4         | Bar      | 5         | false    | 2
+
+VERIFICATION RESULTS
+--------------------
+1. http://result (success)
+2. http://result (failure)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pact_broker-client
 version: !ruby/object:Gem::Version
-  version: 1.30.0
+  version: 1.35.0
 platform: ruby
 authors:
 - Beth Skurrie
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-09 00:00:00.000000000 Z
+date: 2021-01-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -56,16 +56,22 @@ dependencies:
   name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.20'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.20'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -80,6 +86,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '13.0'
+- !ruby/object:Gem::Dependency
+  name: dig_rb
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: fakefs
   requirement: !ruby/object:Gem::Requirement
@@ -136,6 +156,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.16'
+- !ruby/object:Gem::Dependency
+  name: pact-support
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.15.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.15.0
 description: Client for the Pact Broker. Publish, retrieve and query pacts and verification
   results.
 email:
@@ -146,10 +180,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".github/workflows/release_gem.yml"
+- ".github/workflows/test.yml"
 - ".github/workflows/trigger_pact_docs_update.yml"
 - ".gitignore"
 - ".rspec"
-- ".travis.yml"
 - CHANGELOG.md
 - Dockerfile
 - Gemfile
@@ -271,6 +305,7 @@ files:
 - spec/support/matrix.json
 - spec/support/matrix.txt
 - spec/support/matrix_error.txt
+- spec/support/matrix_with_results.txt
 - spec/support/pacticipant_get.json
 - spec/support/pacticipants_list.json
 - spec/support/pacts_latest_list.json
@@ -295,7 +330,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.2.6
 signing_key: 
 specification_version: 4
 summary: See description
@@ -350,6 +385,7 @@ test_files:
 - spec/support/matrix.json
 - spec/support/matrix.txt
 - spec/support/matrix_error.txt
+- spec/support/matrix_with_results.txt
 - spec/support/pacticipant_get.json
 - spec/support/pacticipants_list.json
 - spec/support/pacts_latest_list.json

data/.travis.yml

@@ -1,11 +0,0 @@
-language: ruby
-rvm:
-  - 2.2.4
-  - 2.4.1
-
-# before_install:
-#   - (git show-ref | grep $(git log --pretty=%h -1) | sed 's|.*/\(.*\)|\1|' | sort -u | grep -v HEAD) || true
-#   - (git show -s --pretty=%d HEAD) || true
-#   - (git for-each-ref --format='%(objectname) %(refname:short)' refs/heads | awk "/^$(git rev-parse HEAD)/ {print \$2}") || true
-#   - (git show -s --pretty=%D HEAD | tr -s ', ' '\n' | grep -v HEAD | head -n1) || true
-#   - (git name-rev --name-only HEAD) || true