pact 1.52.0 → 1.55.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9cfa158c1bfe5e29903a33e219b080a26a5fe89983197703f4b41776c5c9308d
-  data.tar.gz: 03d4a346421f6aefee8cc1e17c1466233f795ab12d4824c8a0643230e80a914a
+  metadata.gz: b5bc7edfd2afca203239799e173f2245076887f4d38df625bbaec1ddfc655fda
+  data.tar.gz: c71945880bf5878c9e712b67f5b87262b7f72444b1628c12dc8eaec725022653
 SHA512:
-  metadata.gz: bb71d3477f275efd899a8fd0bf6fac7bf840d2ea39c1e550e38e78b5f7e6479872e8833d005e893d5c7084eea42ce9aac94039ec7aa9edd8acdfcf3cc4a4a9f6
-  data.tar.gz: 28bf0a523d3024cd06b48a71a85bef70471679f9c78951b3c04391c91be7f948458b3acde5dbe060ff6e58ead6a1949f5965f51f944b5815dbeb578968959400
+  metadata.gz: b8d062c28996f29d6424577b3514baa14510b546d3d914abd8d3d12ad2c626cef82a4dd6a7251b2d05fd3fa1c593e2d86862d3dac1b91c7e6757e9b7d7eaf9d7
+  data.tar.gz: 73feb7558cec7e7dc0b78469951c79a0313e0df86d7c85a677963a499c633b2e0d0877783f57ac2b141bb612cf0de8f9474eb5ccf5c8e7d5d2465d22ae16b73f

data/CHANGELOG.md

@@ -1,3 +1,43 @@
+<a name="v1.55.2"></a>
+### v1.55.2 (2020-09-26)
+
+#### Bug Fixes
+
+* correctly calculate exit code when a mix of pending and non pending pacts are verified	 ([533faa1](/../../commit/533faa1))
+
+<a name="v1.55.1"></a>
+### v1.55.1 (2020-09-26)
+
+#### Bug Fixes
+
+* remove accidentally committed debug logging	 ([081423e](/../../commit/081423e))
+
+<a name="v1.55.0"></a>
+### v1.55.0 (2020-09-26)
+
+#### Features
+
+* add consumer_version_selectors to pact verification DSL, and convert consumer_version_tags to selectors	 ([39e6c4a](/../../commit/39e6c4a))
+* allow verification task to set just a pact_helper without a URI	 ([303077d](/../../commit/303077d))
+* split pending and failed rerun commands into separate sections	 ([f839391](/../../commit/f839391))
+* update output during verification so the pact info shows before the describe blocks of the pact that is being verified	 ([15ec231](/../../commit/15ec231))
+
+<a name="v1.54.0"></a>
+### v1.54.0 (2020-09-12)
+
+#### Features
+
+* use pb relation in preference to beta relation when fetching pacts for verification	 ([7563fcf](/../../commit/7563fcf))
+* allow include_wip_pacts_since to use a Date, DateTime or Time	 ([dd35366](/../../commit/dd35366))
+* add support for include_wip_pacts_since	 ([f2247b8](/../../commit/f2247b8))
+
+<a name="v1.53.0"></a>
+### v1.53.0 (2020-09-11)
+
+#### Features
+
+* add support for the enable_pending flag	 ([16866f4](/../../commit/16866f4))
+
 <a name="v1.52.0"></a>
 ### v1.52.0 (2020-09-10)
 

data/lib/pact/pact_broker/fetch_pact_uris_for_verification.rb

@@ -12,7 +12,8 @@ module Pact
       include PactSelectionDescription
       attr_reader :provider, :consumer_version_selectors, :provider_version_tags, :broker_base_url, :http_client_options, :http_client, :options
 
-      PACTS_FOR_VERIFICATION_RELATION = 'beta:provider-pacts-for-verification'.freeze
+      PACTS_FOR_VERIFICATION_RELATION = 'pb:provider-pacts-for-verification'.freeze
+      PACTS_FOR_VERIFICATION_RELATION_BETA = 'beta:provider-pacts-for-verification'.freeze
       PACTS = 'pacts'.freeze
       HREF = 'href'.freeze
       LINKS = '_links'.freeze
@@ -22,7 +23,7 @@ module Pact
       def initialize(provider, consumer_version_selectors, provider_version_tags, broker_base_url, http_client_options, options = {})
         @provider = provider
         @consumer_version_selectors = consumer_version_selectors || []
-        @provider_version_tags = provider_version_tags || []
+        @provider_version_tags = [*provider_version_tags]
         @http_client_options = http_client_options
         @broker_base_url = broker_base_url
         @http_client = Pact::Hal::HttpClient.new(http_client_options)
@@ -34,13 +35,15 @@ module Pact
       end
 
       def call
-        if index.can?(PACTS_FOR_VERIFICATION_RELATION)
+        if index.can?(PACTS_FOR_VERIFICATION_RELATION) || index.can?(PACTS_FOR_VERIFICATION_RELATION_BETA)
           log_message
           pacts_for_verification
         else
+          old_selectors = consumer_version_selectors.collect do | selector |
+            { name: selector[:tag], all: !selector[:latest], fallback: selector[:fallbackTag]}
+          end
           # Fall back to old method of fetching pacts
-          consumer_version_tags = consumer_version_selectors.collect{ | selector | selector[:tag] }
-          FetchPacts.call(provider, consumer_version_tags, broker_base_url, http_client_options)
+          FetchPacts.call(provider, old_selectors, broker_base_url, http_client_options)
         end
       end
 
@@ -63,7 +66,7 @@ module Pact
 
       def pacts_for_verification_entity
         index
-          ._link(PACTS_FOR_VERIFICATION_RELATION)
+          ._link(PACTS_FOR_VERIFICATION_RELATION, PACTS_FOR_VERIFICATION_RELATION_BETA)
           .expand(provider: provider)
           .post!(query)
       end

data/lib/pact/pact_broker/pact_selection_description.rb

@@ -7,7 +7,6 @@ module Pact
         if consumer_version_selectors.any?
           desc = consumer_version_selectors.collect do |selector|
             all_or_latest = !selector[:latest] ? "all for tag" : "latest for tag"
-            # TODO support fallback
             fallback = selector[:fallback] || selector[:fallbackTag]
             name = fallback ? "#{selector[:tag]} (or #{fallback} if not found)" : selector[:tag]
             "#{all_or_latest} #{name}"

data/lib/pact/provider/configuration/pact_verification_from_broker.rb

@@ -2,6 +2,7 @@ require 'pact/shared/dsl'
 require 'pact/provider/world'
 require 'pact/pact_broker/fetch_pact_uris_for_verification'
 require 'pact/errors'
+require 'pact/utils/string'
 
 module Pact
   module Provider
@@ -14,12 +15,15 @@ module Pact
         # in parent scope, it will clash with these ones,
         # so put an underscore in front of the name to be safer.
 
-        attr_accessor :_provider_name, :_pact_broker_base_url, :_consumer_version_tags, :_provider_version_tags, :_basic_auth_options, :_verbose
+        attr_accessor :_provider_name, :_pact_broker_base_url, :_consumer_version_tags, :_provider_version_tags, :_basic_auth_options, :_enable_pending, :_include_wip_pacts_since, :_verbose, :_consumer_version_selectors
 
         def initialize(provider_name, provider_version_tags)
           @_provider_name = provider_name
           @_provider_version_tags = provider_version_tags
           @_consumer_version_tags = []
+          @_consumer_version_selectors = []
+          @_enable_pending = false
+          @_include_wip_pacts_since = nil
           @_verbose = false
         end
 
@@ -33,6 +37,22 @@ module Pact
             self._consumer_version_tags = *consumer_version_tags
           end
 
+          def consumer_version_selectors consumer_version_selectors
+            self._consumer_version_selectors = *consumer_version_selectors
+          end
+
+          def enable_pending enable_pending
+            self._enable_pending = enable_pending
+          end
+
+          def include_wip_pacts_since since
+            self._include_wip_pacts_since = if since.respond_to?(:xmlschema)
+              since.xmlschema
+            else
+              since
+            end
+          end
+
           def verbose verbose
             self._verbose = verbose
           end
@@ -51,19 +71,41 @@ module Pact
             consumer_version_selectors,
             _provider_version_tags,
             _pact_broker_base_url,
-            _basic_auth_options.merge(verbose: _verbose)
+            _basic_auth_options.merge(verbose: _verbose),
+            { include_pending_status: _enable_pending, include_wip_pacts_since: _include_wip_pacts_since }
           )
 
           Pact.provider_world.add_pact_uri_source fetch_pacts
         end
 
         def consumer_version_selectors
-          # TODO support "all"
+          convert_tags_to_selectors + convert_consumer_version_selectors
+        end
+
+        def convert_tags_to_selectors
           _consumer_version_tags.collect do | tag |
-            {
-              tag: tag,
-              latest: true
-            }
+            if tag.is_a?(Hash)
+              {
+                tag: tag.fetch(:name),
+                latest: !tag[:all],
+                fallbackTag: tag[:fallback]
+              }
+            elsif tag.is_a?(String)
+              {
+                tag: tag,
+                latest: true
+              }
+            else
+              raise Pact::Error.new("The value supplied for consumer_version_tags must be a String or a Hash. Found #{tag.class}")
+            end
+          end
+        end
+
+        def convert_consumer_version_selectors
+          _consumer_version_selectors.collect do | selector |
+            selector.each_with_object({}) do | (key, value), new_selector |
+              new_selector[Pact::Utils::String.camelcase(key.to_s).to_sym] = value
+            end
           end
         end
 

data/lib/pact/provider/pact_source.rb

@@ -20,6 +20,10 @@ module Pact
         @pact_hash ||= JSON.load(pact_json, nil, { max_nesting: 50 })
       end
 
+      def pending?
+        uri.metadata[:pending]
+      end
+
       def hal_entity
         http_client_keys = [:username, :password, :token]
         http_client_options = uri.options.reject{ |k, _| !http_client_keys.include?(k) }

data/lib/pact/provider/pact_spec_runner.rb

@@ -11,6 +11,7 @@ require 'pact/provider/verification_results/publish_all'
 require 'pact/provider/rspec/pact_broker_formatter'
 require 'pact/provider/rspec/json_formatter'
 require 'pact/provider/rspec'
+require 'pact/provider/rspec/calculate_exit_code'
 
 module Pact
   module Provider
@@ -79,6 +80,7 @@ module Pact
         executing_with_ruby = executing_with_ruby?
 
         config.after(:suite) do | suite |
+          Pact.provider_world.failed_examples = suite.reporter.failed_examples
           Pact::Provider::Help::Write.call(Pact.provider_world.pact_sources) if executing_with_ruby
         end
       end
@@ -90,7 +92,12 @@ module Pact
           ::RSpec::Core::CommandLine.new(NoConfigurationOptions.new)
             .run(::RSpec.configuration.output_stream, ::RSpec.configuration.error_stream)
         end
-        pending_mode? ? 0 : exit_code
+
+        if options[:ignore_failures]
+          0
+        else
+          Pact::Provider::RSpec::CalculateExitCode.call(pact_sources, Pact.provider_world.failed_examples)
+        end
       end
 
       def rspec_runner_options
@@ -147,8 +154,6 @@ module Pact
         end
 
         ::RSpec.configuration.full_backtrace = @options[:full_backtrace]
-
-        ::RSpec.configuration.failure_color = :yellow if pending_mode?
       end
 
       def ordered_pact_json(pact_json)
@@ -159,20 +164,12 @@ module Pact
         consumer_contract.to_json
       end
 
-      def all_pacts_pending?
-        pact_urls.all?{ | pact_url| pact_url.metadata[:pending] }
-      end
-
       def class_exists? name
         Kernel.const_get name
       rescue NameError
         false
       end
 
-      def pending_mode?
-        (all_pacts_pending? || options[:ignore_failures])
-      end
-
       def executing_with_ruby?
         ENV['PACT_EXECUTING_LANGUAGE'] == 'ruby'
       end

data/lib/pact/provider/rspec.rb

@@ -24,28 +24,34 @@ module Pact
         def honour_pactfile pact_source, pact_json, options
           pact_uri = pact_source.uri
           Pact.configuration.output_stream.puts "INFO: Reading pact at #{pact_uri}"
-          if pact_uri.metadata[:notices]
-            pact_uri.metadata[:notices].before_verification_notices_text.each do | text |
-              Pact.configuration.output_stream.puts("DEBUG: #{text}")
-            end
-          end
-
-          Pact.configuration.output_stream.puts "DEBUG: Filtering interactions by: #{options[:criteria]}" if options[:criteria] && options[:criteria].any?
           consumer_contract = Pact::ConsumerContract.from_json(pact_json)
           suffix = pact_uri.metadata[:pending] ? " [PENDING]": ""
+
           ::RSpec.describe "Verifying a pact between #{consumer_contract.consumer.name} and #{consumer_contract.provider.name}#{suffix}", pactfile_uri: pact_uri do
-            honour_consumer_contract consumer_contract, options.merge(pact_json: pact_json, pact_uri: pact_uri, pact_source: pact_source, consumer_contract: consumer_contract)
+            honour_consumer_contract consumer_contract, options.merge(
+              pact_json: pact_json,
+              pact_uri: pact_uri,
+              pact_source: pact_source,
+              consumer_contract: consumer_contract,
+              criteria: options[:criteria]
+              )
           end
         end
 
         def honour_consumer_contract consumer_contract, options = {}
-          describe_consumer_contract consumer_contract, options.merge(consumer: consumer_contract.consumer.name)
+          describe_consumer_contract consumer_contract, options.merge(consumer: consumer_contract.consumer.name, pact_context: InteractionContext.new)
         end
 
         private
 
         def describe_consumer_contract consumer_contract, options
-          consumer_interactions(consumer_contract, options).each do |interaction|
+          consumer_interactions(consumer_contract, options).tap{ |interactions|
+            if interactions.empty?
+              # If there are no interactions, the documentation formatter never fires to print this out,
+              # so print it out here.
+              Pact.configuration.output_stream.puts "DEBUG: All interactions for #{options[:pact_uri]} have been filtered out by criteria: #{options[:criteria]}" if options[:criteria] && options[:criteria].any?
+            end
+          }.each do |interaction|
             describe_interaction_with_provider_state interaction, options
           end
         end
@@ -54,7 +60,7 @@ module Pact
           if options[:criteria].nil?
             consumer_contract.interactions
           else
-            consumer_contract.find_interactions options[:criteria]
+            consumer_contract.find_interactions(options[:criteria])
           end
         end
 
@@ -83,13 +89,15 @@ module Pact
             pact_interaction_example_description: interaction_description_for_rerun_command(interaction),
             pact_uri: options[:pact_uri],
             pact_source: options[:pact_source],
-            pact_ignore_failures: options[:pact_uri].metadata[:pending] || options[:ignore_failures],
-            pact_consumer_contract: options[:consumer_contract]
+            pact_ignore_failures: options[:pact_source].pending? || options[:ignore_failures],
+            pact_consumer_contract: options[:consumer_contract],
+            pact_criteria: options[:criteria]
           }
 
           describe description_for(interaction), metadata do
 
             interaction_context = InteractionContext.new
+            pact_context = options[:pact_context]
 
             before do | example |
               interaction_context.run_once :before do

data/lib/pact/provider/rspec/calculate_exit_code.rb

@@ -0,0 +1,18 @@
+module Pact
+  module Provider
+    module RSpec
+      module CalculateExitCode
+        def self.call(pact_sources, failed_examples)
+          any_non_pending_failures = pact_sources.any? do |pact_source|
+            if pact_source.pending?
+              nil
+            else
+              failed_examples.select { |e| e.metadata[:pact_source] == pact_source }.any?
+            end
+          end
+          any_non_pending_failures ? 1 : 0
+        end
+      end
+    end
+  end
+end

data/lib/pact/provider/rspec/formatter_rspec_3.rb

@@ -24,6 +24,25 @@ module Pact
 
         C = ::Term::ANSIColor
 
+        def example_group_started(notification)
+          if @group_level == 0
+            Pact.configuration.output_stream.puts
+            pact_uri = notification.group.metadata[:pactfile_uri]
+            ::RSpec.configuration.failure_color = pact_uri.metadata[:pending] ? :yellow : :red
+
+            if pact_uri.metadata[:notices]
+              pact_uri.metadata[:notices].before_verification_notices_text.each do | text |
+                Pact.configuration.output_stream.puts("DEBUG: #{text}")
+              end
+            end
+
+            criteria = notification.group.metadata[:pact_criteria]
+            Pact.configuration.output_stream.puts "DEBUG: Filtering interactions by: #{criteria}" if criteria && criteria.any?
+          end
+          super
+        end
+
+
         def dump_summary(summary)
           output.puts "\n" + colorized_totals_line(summary)
           return if summary.failure_count == 0
@@ -35,28 +54,26 @@ module Pact
         private
 
         def interactions_count(summary)
-          summary.examples.collect{ |e| e.metadata[:pact_interaction_example_description] }.uniq.size
+          summary.examples.collect{ |e| interaction_unique_key(e) }.uniq.size
         end
 
         def failed_interactions_count(summary)
-          summary.failed_examples.collect{ |e| e.metadata[:pact_interaction_example_description] }.uniq.size
+          failed_interaction_examples(summary).size
         end
 
-        def ignore_failures?(summary)
-          summary.failed_examples.any?{ |e| e.metadata[:pact_ignore_failures] }
+        def pending_interactions_count(summary)
+          pending_interaction_examples(summary).size
         end
 
         def failure_title summary
-          if ignore_failures?(summary)
-            "#{failed_interactions_count(summary)} pending"
-          else
-            ::RSpec::Core::Formatters::Helpers.pluralize(failed_interactions_count(summary), "failure")
-          end
+          ::RSpec::Core::Formatters::Helpers.pluralize(failed_interactions_count(summary), "failure")
         end
 
         def totals_line summary
           line = ::RSpec::Core::Formatters::Helpers.pluralize(interactions_count(summary), "interaction")
           line << ", " << failure_title(summary)
+          pending_count = pending_interactions_count(summary)
+          line << ", " << "#{pending_count} pending" if pending_count > 0
           line
         end
 
@@ -69,13 +86,20 @@ module Pact
         end
 
         def print_rerun_commands summary
-          if ignore_failures?(summary)
+          if pending_interactions_count(summary) > 0
+            set_rspec_failure_color(:yellow)
             output.puts("\nPending interactions: (Failures listed here are expected and do not affect your suite's status)\n\n")
-          else
-            output.puts("\nFailed interactions:\n\n")
+            interaction_rerun_commands(pending_interaction_examples(summary)).each do | message |
+              output.puts(message)
+            end
+            set_rspec_failure_color(:red)
           end
-          interaction_rerun_commands(summary).each do | message |
-            output.puts(message)
+
+          if failed_interactions_count(summary) > 0
+            output.puts("\nFailed interactions:\n\n")
+            interaction_rerun_commands(failed_interaction_examples(summary)).each do | message |
+              output.puts(message)
+            end
           end
         end
 
@@ -85,10 +109,34 @@ module Pact
           end
         end
 
-        def interaction_rerun_commands summary
-          summary.failed_examples.collect do |example|
+        def pending_interaction_examples(summary)
+          one_failed_example_per_interaction(summary).select do | example |
+            example.metadata[:pactfile_uri].metadata[:pending]
+          end
+        end
+
+        def failed_interaction_examples(summary)
+          one_failed_example_per_interaction(summary).select do | example |
+            !example.metadata[:pactfile_uri].metadata[:pending]
+          end
+        end
+
+        def one_failed_example_per_interaction(summary)
+          summary.failed_examples.group_by{| e| interaction_unique_key(e)}.values.collect(&:first)
+        end
+
+        def interaction_rerun_commands examples
+          examples.collect do |example|
             interaction_rerun_command_for example
-          end.uniq.compact
+          end.compact
+        end
+
+        def interaction_unique_key(example)
+          # pending is just to make the counting easier, it isn't required for the unique key
+          {
+            pactfile_uri: example.metadata[:pactfile_uri],
+            index: example.metadata[:pact_interaction].index,
+          }
         end
 
         def interaction_rerun_command_for example
@@ -137,6 +185,10 @@ module Pact
         def executing_with_ruby?
           ENV['PACT_EXECUTING_LANGUAGE'] == 'ruby'
         end
+
+        def set_rspec_failure_color color
+          ::RSpec.configuration.failure_color = color
+        end
       end
     end
   end

data/lib/pact/provider/verification_results/publish.rb

@@ -81,7 +81,7 @@ module Pact
             Pact.configuration.output_stream.puts "INFO: Tagging version #{provider_application_version} of #{provider_name} as #{tag.inspect}"
             tag_entity = tag_link.expand(version: provider_application_version, tag: tag).put
             unless tag_entity.success?
-              raise PublicationError.new("Error returned from tagging request #{tag_entity.response.code} #{tag_entity.response.body}")
+              raise PublicationError.new("Error returned from tagging request: status=#{tag_entity.response.code} body=#{tag_entity.response.body}")
             end
           end
         end

data/lib/pact/provider/world.rb

@@ -14,7 +14,7 @@ module Pact
   module Provider
     class World
 
-      attr_accessor :pact_sources
+      attr_accessor :pact_sources, :failed_examples
 
       def provider_states
         @provider_states_proxy ||= Pact::Provider::State::ProviderStateProxy.new

data/lib/pact/tasks/verification_task.rb

@@ -31,6 +31,7 @@ module Pact
     attr_reader :pact_spec_configs
     attr_accessor :rspec_opts
     attr_accessor :ignore_failures
+    attr_accessor :_pact_helper
 
     def initialize(name)
       @rspec_opts = nil
@@ -41,6 +42,10 @@ module Pact
       rake_task
     end
 
+    def pact_helper(pact_helper)
+      @pact_spec_configs << { pact_helper: pact_helper }
+    end
+
     def uri(uri, options = {})
       @pact_spec_configs << {uri: uri, pact_helper: options[:pact_helper]}
     end
@@ -82,6 +87,7 @@ module Pact
           Pact::TaskHelper.handle_verification_failure do
             exit_statuses.count{ | status | status != 0 }
           end
+
         end
       end
     end

data/lib/pact/utils/string.rb

@@ -0,0 +1,35 @@
+# Can't use refinements because of Travelling Ruby
+
+module Pact
+  module Utils
+    module String
+
+      extend self
+
+      # ripped from rubyworks/facets, thank you
+      def camelcase(string, *separators)
+        case separators.first
+        when Symbol, TrueClass, FalseClass, NilClass
+          first_letter = separators.shift
+        end
+
+        separators = ['_', '\s'] if separators.empty?
+
+        str = string.dup
+
+        separators.each do |s|
+          str = str.gsub(/(?:#{s}+)([a-z])/){ $1.upcase }
+        end
+
+        case first_letter
+        when :upper, true
+          str = str.gsub(/(\A|\s)([a-z])/){ $1 + $2.upcase }
+        when :lower, false
+          str = str.gsub(/(\A|\s)([A-Z])/){ $1 + $2.downcase }
+        end
+
+        str
+      end
+    end
+  end
+end

data/lib/pact/version.rb

@@ -1,4 +1,4 @@
 # Remember to bump pact-provider-proxy when this changes major version
 module Pact
-  VERSION = "1.52.0"
+  VERSION = "1.55.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pact
 version: !ruby/object:Gem::Version
-  version: 1.52.0
+  version: 1.55.2
 platform: ruby
 authors:
 - James Fraser
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-10 00:00:00.000000000 Z
+date: 2020-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -352,6 +352,7 @@ files:
 - lib/pact/provider/request.rb
 - lib/pact/provider/rspec.rb
 - lib/pact/provider/rspec/backtrace_formatter.rb
+- lib/pact/provider/rspec/calculate_exit_code.rb
 - lib/pact/provider/rspec/custom_options_file
 - lib/pact/provider/rspec/formatter_rspec_2.rb
 - lib/pact/provider/rspec/formatter_rspec_3.rb
@@ -377,6 +378,7 @@ files:
 - lib/pact/tasks/verification_task.rb
 - lib/pact/templates/help.erb
 - lib/pact/templates/provider_state.erb
+- lib/pact/utils/string.rb
 - lib/pact/version.rb
 - lib/tasks/pact.rake
 - pact.gemspec