pact 1.0.39 → 1.1.0.rc1

data/spec/lib/pact/matchers/plus_minus_diff_decorator_spec.rb

@@ -0,0 +1,186 @@
+require 'spec_helper'
+require 'pact/matchers/plus_minus_diff_decorator'
+
+module Pact
+  module Matchers
+    describe PlusMinusDiffDecorator do
+
+      describe "#to_s" do
+
+        subject { PlusMinusDiffDecorator.new(diff).to_s }
+
+        let(:line_count) { subject.split("\n").size }
+
+        context "with class based matching" do
+          xit "displays nicely"
+        end
+
+        context "with an incorrect value in a hash" do
+          let(:diff) { {thing: {alligator: Difference.new({name: 'Mary'}, "Joe" )}} }
+
+          it "displays '+' next to the unexpected value, and '-' next to the missing one" do
+            expect(subject).to match /alligator/
+            expect(subject).to match /\-.*Mary/
+            expect(subject).to match /\+.*Joe/
+          end
+
+          it "generates the right number of lines, even with ActiveSupport loaded" do
+            expect(line_count).to eq 10
+          end
+
+        end
+
+        context "with an incorrect value in an array" do
+          let(:diff) { [NoDiffIndicator.new, Difference.new({name: 'Mary'}, "Joe"), NoDiffIndicator.new] }
+
+          it "displays '+' next to the incorrect values and '-' next to the missing ones" do
+            expect(subject).to match /no difference here!/
+            expect(subject).to match /\-.*{/
+            expect(subject).to match /\-.*}/
+            expect(subject).to match /\-.*Mary/
+            expect(subject).to match /\+.*Joe/
+            expect(subject).to match /no.*Mary.*Joe.*no/m
+          end
+
+          it "doesn't display the no difference indicator as a change" do
+            expect(subject).to match(/^\s+no difference here!,$/)
+          end
+
+          it "generates the right number of lines, even with ActiveSupport loaded" do
+            expect(line_count).to eq 10
+          end
+
+        end
+
+        context "with a regular expression that was not matched" do
+          let(:regexp) { %r{http://.*/thing/1234} }
+          let(:diff) { {thing: Difference.new(regexp, "pear")} }
+
+          it "displays the regular expression" do
+            expect(subject).to include(regexp.inspect)
+            expect(subject).to include(regexp.inspect)
+            expect(subject).to match /\-.*thing/
+            expect(subject).to match /\+.*pear/
+          end
+
+          it "does not put quotes around the regular expression" do
+            expect(subject).to match /\/$/
+            expect(subject).to match /: \//
+          end
+
+          it "generates the right number of lines, even with ActiveSupport loaded" do
+            expect(line_count).to eq 6
+          end
+
+        end
+
+        context "with a missing key" do
+
+          let(:diff) { {thing: {alligator: Difference.new({name: 'Mary'}, KeyNotFound.new )}} }
+
+          it "it displays '-' next to the missing key and its value" do
+            expect(subject).to match /\-.*{/
+            expect(subject).to match /\-.*}/
+            expect(subject).to match /\-.*alligator/
+            expect(subject).to match /\-.*name/
+            expect(subject).to match /\-.*Mary/
+          end
+
+          it "does not display the missing key in the actual output" do
+            expect(subject).to_not match /\+.*alligator/
+          end
+
+          it "generates the right number of lines, even with ActiveSupport loaded" do
+            expect(line_count).to eq 9
+          end
+        end
+
+        context "with an unexpected key" do
+          let(:diff) { {thing: {alligator: Difference.new(UnexpectedKey.new, {name: 'Mary'} )}} }
+
+          it "displays '+' next to the unexpected key and its value" do
+            expect(subject).to match /\+.*name/
+            expect(subject).to match /\+.*Mary/
+            expect(subject).to match /\+.*alligator/
+            expect(subject).to match /\+.*}/
+            expect(subject).to match /\+.*{/
+          end
+
+          it "does not display the unexpected key in the expected output" do
+            expect(subject).to_not match /\-.*alligator/
+          end
+
+          it "generates the right number of lines, even with ActiveSupport loaded" do
+            expect(line_count).to eq 9
+          end
+
+        end
+
+        context "with a missing index" do
+          let(:diff) { [NoDiffIndicator.new, Difference.new({name: 'Mary'}, IndexNotFound.new)] }
+
+          it "displays '-' next to the missing items" do
+            expect(subject).to match /\-.*Mary/
+            expect(subject).to match /\-.*{/
+            expect(subject).to match /\-.*}/
+          end
+
+          it "does not display IndexNotFound" do
+            expect(subject).to_not match /#{IndexNotFound.new.to_s}/
+          end
+
+          it "generates the right number of lines, even with ActiveSupport loaded" do
+            expect(line_count).to eq 9
+          end
+
+        end
+
+        context "with an unexpected index" do
+          let(:diff) { [NoDiffIndicator.new, Difference.new(UnexpectedIndex.new, {name: 'Mary'})] }
+
+          it "displays '+' next to the unexpected item" do
+            expect(subject).to match /\+.*{/
+            expect(subject).to match /\+.*}/
+            expect(subject).to match /\+.*name/
+            expect(subject).to match /\+.*Mary/
+          end
+
+          xit "doesn't mark the 'no difference' as a change" do
+            expect(subject).to match /#{NoDiffIndicator.new.to_s},/
+            expect(subject).to_not match /\-.*#{NoDiffIndicator.new.to_s}/
+            expect(subject).to_not match /\+.*#{NoDiffIndicator.new.to_s}/
+          end
+
+          it "does not display the UnexpectedIndex" do
+            expect(subject).to_not match UnexpectedIndex.new.to_s
+          end
+
+          it "generates the right number of lines, even with ActiveSupport loaded" do
+            expect(line_count).to eq 9
+          end
+
+        end
+
+        context "with 2 unexpected indexes" do
+          let(:diff) { [NoDiffIndicator.new, Difference.new(UnexpectedIndex.new, {name: 'Mary'}), Difference.new(UnexpectedIndex.new, {name: 'Joe'})] }
+
+          it "displays '+' next to the unexpected item" do
+            expect(subject).to match /\+.*Mary/
+            expect(subject).to match /\+.*Joe/
+          end
+
+          it "does not display the UnexpectedIndex" do
+            expect(subject).to_not match UnexpectedIndex.new.to_s
+          end
+
+          it "generates the right number of lines, even with ActiveSupport loaded" do
+            expect(line_count).to eq 12
+          end
+
+        end
+
+      end
+
+    end
+  end
+end

data/spec/lib/pact/provider/configuration_spec.rb

@@ -3,162 +3,191 @@ require 'pact/provider/configuration'
 
 module Pact::Provider::Configuration
 
-  describe "service_provider" do
+  describe ConfigurationExtension do
 
     before do
       Pact.clear_configuration
     end
 
-    let(:mock_config) { MockConfig.new }
-    context "when a provider is configured" do
-      before do
-        Pact.service_provider "Fred" do
-          app { "An app" }
-        end
-      end
-      it "should allow configuration of the test app" do
-        expect(Pact.configuration.provider.app).to eql "An app"
-      end
-    end
+    describe "diff_formatter_class" do
 
-    context "when a provider is not configured" do
-      it "raises an error" do
-        expect{ Pact.configuration.provider }.to raise_error(/Please configure your provider/)
+      it "returns the Pact::Matchers::NestedJsonDiffDecorator by default" do
+        expect(Pact.configuration.diff_formatter_class).to eq(Pact::Matchers::NestedJsonDiffDecorator)
       end
-    end
 
-    context "when a provider is configured without an app" do
-      before do
-        Pact.service_provider "Fred" do
+      context "when plus_and_minus formatter is configured" do
+        it "returns the Pact::Matchers::PlusMinusDiffDecorator" do
+          Pact.configuration.diff_format = :plus_and_minus
+          expect(Pact.configuration.diff_formatter_class).to eq(Pact::Matchers::PlusMinusDiffDecorator)
         end
       end
-      it "uses the app from config.ru" do
-        expect( Pact.configuration.provider.app ).to be(AppForConfigRu)
-      end
+
     end
-  end
 
-  describe PactVerification do
+    describe "service_provider" do
 
-    describe 'create_verification' do
-      let(:url) {'http://some/uri'}
-      let(:consumer_name) {'some consumer'}
-      let(:ref) {:prod}
-      let(:options) { {:ref => :prod} }
-      context "with valid values" do
-        subject do
-          uri = url
-          PactVerification.build(consumer_name, options) do
-            pact_uri uri
-          end
-        end
 
-        it "creates a Verification" do
-          Pact::Provider::PactVerification.should_receive(:new).with(consumer_name, url, ref)
-          subject
-        end
+      it "allows configuration of colour_enabled" do
+        Pact.configuration.color_enabled = false
+        expect(Pact.configuration.color_enabled).to be_false
       end
 
-      context "with a nil uri" do
-        subject do
-          PactVerification.build(consumer_name, options) do
-            pact_uri nil
+      it "sets color_enabled to be true by default" do
+        expect(Pact.configuration.color_enabled).to be_true
+      end
+
+      context "when a provider is configured" do
+        before do
+          Pact.service_provider "Fred" do
+            app { "An app" }
           end
         end
-
-        it "raises a validation error" do
-          expect{ subject }.to raise_error /Please provide a pact_uri/
+        it "should allow configuration of the test app" do
+          expect(Pact.configuration.provider.app).to eql "An app"
         end
       end
-    end
-  end
 
-  describe ServiceProviderDSL do
-
-    describe "initialize" do
+      context "when a provider is not configured" do
+        it "raises an error" do
+          expect{ Pact.configuration.provider }.to raise_error(/Please configure your provider/)
+        end
+      end
 
-      context "with an object instead of a block" do
-        subject do
-          ServiceProviderDSL.build 'name' do
-            app 'blah'
+      context "when a provider is configured without an app" do
+        before do
+          Pact.service_provider "Fred" do
           end
         end
-        it "raises an error" do
-          expect{ subject }.to raise_error /wrong number of arguments/
+        it "uses the app from config.ru" do
+          expect( Pact.configuration.provider.app ).to be(AppForConfigRu)
         end
       end
 
     end
 
-    describe "validate" do
-      context "when no name is provided" do
-        subject do
-          ServiceProviderDSL.new ' ' do
-            app { Object.new }
+    describe PactVerification do
+
+      describe 'create_verification' do
+        let(:url) {'http://some/uri'}
+        let(:consumer_name) {'some consumer'}
+        let(:ref) {:prod}
+        let(:options) { {:ref => :prod} }
+        context "with valid values" do
+          subject do
+            uri = url
+            PactVerification.build(consumer_name, options) do
+              pact_uri uri
+            end
           end
-        end
-        it "raises an error" do
-          expect{ subject.send(:validate)}.to raise_error("Please provide a name for the Provider")
-        end
-      end
-      context "when nil name is provided" do
-        subject do
-          ServiceProviderDSL.new nil do
-            app { Object.new }
+
+          it "creates a Verification" do
+            Pact::Provider::PactVerification.should_receive(:new).with(consumer_name, url, ref)
+            subject
           end
         end
-        it "raises an error" do
-          expect{ subject.send(:validate)}.to raise_error("Please provide a name for the Provider")
+
+        context "with a nil uri" do
+          subject do
+            PactVerification.build(consumer_name, options) do
+              pact_uri nil
+            end
+          end
+
+          it "raises a validation error" do
+            expect{ subject }.to raise_error /Please provide a pact_uri/
+          end
         end
       end
     end
 
-    describe 'honours_pact_with' do
-      before do
-        Pact.clear_configuration
+    describe ServiceProviderDSL do
+
+      describe "initialize" do
+
+        context "with an object instead of a block" do
+          subject do
+            ServiceProviderDSL.build 'name' do
+              app 'blah'
+            end
+          end
+          it "raises an error" do
+            expect{ subject }.to raise_error /wrong number of arguments/
+          end
+        end
+
       end
 
-      context "with no optional params" do
-        subject do
-          ServiceProviderDSL.build 'some-provider' do
-            app {}
-            honours_pact_with 'some-consumer' do
-              pact_uri 'blah'
+      describe "validate" do
+        context "when no name is provided" do
+          subject do
+            ServiceProviderDSL.new ' ' do
+              app { Object.new }
             end
           end
+          it "raises an error" do
+            expect{ subject.send(:validate)}.to raise_error("Please provide a name for the Provider")
+          end
         end
-        it 'adds a verification to the Pact.configuration' do
-          subject
-          expect(Pact.configuration.pact_verifications.first).to eq(Pact::Provider::PactVerification.new('some-consumer', 'blah', :head))
+        context "when nil name is provided" do
+          subject do
+            ServiceProviderDSL.new nil do
+              app { Object.new }
+            end
+          end
+          it "raises an error" do
+            expect{ subject.send(:validate)}.to raise_error("Please provide a name for the Provider")
+          end
         end
       end
 
-      context "with all params specified" do
-        subject do
-          ServiceProviderDSL.build 'some-provider' do
-            app {}
-            honours_pact_with 'some-consumer', :ref => :prod do
-              pact_uri 'blah'
+      describe 'honours_pact_with' do
+        before do
+          Pact.clear_configuration
+        end
+
+        context "with no optional params" do
+          subject do
+            ServiceProviderDSL.build 'some-provider' do
+              app {}
+              honours_pact_with 'some-consumer' do
+                pact_uri 'blah'
+              end
             end
           end
+          it 'adds a verification to the Pact.configuration' do
+            subject
+            expect(Pact.configuration.pact_verifications.first).to eq(Pact::Provider::PactVerification.new('some-consumer', 'blah', :head))
+          end
         end
-        it 'adds a verification to the Pact.configuration' do
-          subject
-          expect(Pact.configuration.pact_verifications.first).to eq(Pact::Provider::PactVerification.new('some-consumer', 'blah', :prod))
+
+        context "with all params specified" do
+          subject do
+            ServiceProviderDSL.build 'some-provider' do
+              app {}
+              honours_pact_with 'some-consumer', :ref => :prod do
+                pact_uri 'blah'
+              end
+            end
+          end
+          it 'adds a verification to the Pact.configuration' do
+            subject
+            expect(Pact.configuration.pact_verifications.first).to eq(Pact::Provider::PactVerification.new('some-consumer', 'blah', :prod))
+          end
+
         end
 
       end
-
     end
-  end
 
-  describe ServiceProviderConfig do
-    describe "app" do
-      subject { ServiceProviderConfig.new { Object.new } }
-      it "should execute the app_block each time" do
-        expect(subject.app.object_id).to_not equal(subject.app.object_id)
+    describe ServiceProviderConfig do
+      describe "app" do
+        subject { ServiceProviderConfig.new { Object.new } }
+        it "should execute the app_block each time" do
+          expect(subject.app.object_id).to_not equal(subject.app.object_id)
+        end
       end
     end
   end
 
+
 end