pact 1.0.28 → 1.0.29

data/CHANGELOG.md

@@ -2,6 +2,11 @@ Do this to generate your change history
 
     git log --date=relative --pretty=format:'  * %h - %s (%an, %ad)'
 
+### 1.0.29 (12 December 2013)
+
+* 8ffde69 - Providing before :all like functionality using before :each to get the dual benefits of faster tests and the ability to use stubbing (Beth, 53 seconds ago)
+* d30a78b - Added test to ensure rspec stubbing always works (Beth Skurrie, 15 hours ago)
+
 ### 1.0.28 (11 December 2013)
 
 * 24f9ea0 - Changed provider set up and tear down back to running in before :each, as rspec stubbing is not supported in before :all (Beth, 15 seconds ago)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    pact (1.0.28)
+    pact (1.0.29)
       awesome_print (~> 1.1)
       find_a_port (~> 1.0.1)
       json

data/lib/pact/provider/rspec.rb

@@ -62,25 +62,32 @@ module Pact
 
           describe description_for(interaction), :pact => :verify do
 
+            interaction_context = InteractionContext.new
+
             before do
-              set_up_provider_state interaction.provider_state, options[:consumer]
-              replay_interaction interaction
+              interaction_context.run_once :before do
+                set_up_provider_state interaction.provider_state, options[:consumer]
+                replay_interaction interaction
+                interaction_context.last_response = last_response
+              end
             end
 
             after do
-              tear_down_provider_state interaction.provider_state, options[:consumer]
+              interaction_context.run_once :after do
+                tear_down_provider_state interaction.provider_state, options[:consumer]
+              end
             end
 
-            describe_response interaction.response
+            describe_response interaction.response, interaction_context
           end
 
         end
 
-        def describe_response response
+        def describe_response response, interaction_context
           describe "returns a response which" do
             if response['status']
               it "has status code #{response['status']}" do
-                expect(last_response.status).to eql response['status']
+                expect(interaction_context.last_response.status).to eql response['status']
               end
             end
 
@@ -88,7 +95,7 @@ module Pact
               describe "includes headers" do
                 response['headers'].each do |name, value|
                   it "\"#{name}\" with value \"#{value}\"" do
-                    expect(last_response.headers[name]).to match_term value
+                    expect(interaction_context.last_response.headers[name]).to match_term value
                   end
                 end
               end
@@ -96,7 +103,7 @@ module Pact
 
             if response['body']
               it "has a matching body" do
-                expect(parse_body_from_response(last_response)).to match_term response['body']
+                expect(parse_body_from_response(interaction_context.last_response)).to match_term response['body']
               end
             end
           end
@@ -111,6 +118,30 @@ module Pact
         end
 
       end
+
+      # The "arrange" and "act" parts of the test really only need to be run once,
+      # however, stubbing is not supported in before :all, so this is a
+      # wee hack to enable before :all like functionality using before :each.
+      # In an ideal world, the test setup and execution should be quick enough for
+      # the difference between :all and :each to be unnoticable, but the annoying
+      # reality is, sometimes it does make a difference. This is for you, V!
+
+      class InteractionContext
+
+        attr_accessor :last_response
+
+        def initialize
+          @already_run = []
+        end
+
+        def run_once id
+          unless @already_run.include?(id)
+            yield
+            @already_run << id
+          end
+        end
+
+      end
     end
   end
 end

data/lib/pact/version.rb

@@ -1,3 +1,3 @@
 module Pact
-  VERSION = "1.0.28"
+  VERSION = "1.0.29"
 end

data/spec/support/stubbing.json

@@ -0,0 +1,22 @@
+{
+    "consumer": {
+        "name": "Consumer"
+    },
+    "provider": {
+        "name": "Provider"
+    },
+    "interactions": [
+        {
+            "description": "A test request",
+            "request": {
+                "method": "get",
+                "path": "/"
+            },
+            "response": {
+                "status": 200,
+                "body": "stubbing works"
+            },
+            "provider_state": "something is stubbed"
+        }
+    ]
+}

data/spec/support/stubbing.rb

@@ -0,0 +1,25 @@
+require 'pact/provider/rspec'
+require 'rspec/mocks'
+
+class StubbedThing
+  def self.stub_me
+  end
+end
+
+class App
+  def self.call env
+    [200, {}, [StubbedThing.stub_me]]
+  end
+end
+
+Pact.provider_states_for 'Consumer' do
+  provider_state 'something is stubbed' do
+    set_up do
+      StubbedThing.stub(:stub_me).and_return("stubbing works")
+    end
+  end
+end
+
+Pact.service_provider 'Provider' do
+  app { App }
+end

data/tasks/pact-test.rake

@@ -1,8 +1,13 @@
+require 'pact/tasks'
+
+Pact::VerificationTask.new(:stubbing) do | pact |
+	pact.uri './spec/support/stubbing.json', :pact_helper => './spec/support/stubbing.rb'
+end
 
 namespace :pact do
 
 	desc 'Runs pact tests against a sample application, testing failure and success.'
-	task :tests do
+	task :tests => ['pact:verify:stubbing'] do
 
 		require 'pact/provider/pact_spec_runner'
 		require 'open3'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pact
 version: !ruby/object:Gem::Version
-  version: 1.0.28
+  version: 1.0.29
   prerelease: 
 platform: ruby
 authors:
@@ -415,6 +415,8 @@ files:
 - spec/support/missing_provider_states_output.txt
 - spec/support/pact_helper.rb
 - spec/support/shared_examples_for_request.rb
+- spec/support/stubbing.json
+- spec/support/stubbing.rb
 - spec/support/test_app_fail.json
 - spec/support/test_app_pass.json
 - tasks/pact-test.rake
@@ -432,18 +434,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -54424747332292177
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -54424747332292177
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23
@@ -502,5 +498,7 @@ test_files:
 - spec/support/missing_provider_states_output.txt
 - spec/support/pact_helper.rb
 - spec/support/shared_examples_for_request.rb
+- spec/support/stubbing.json
+- spec/support/stubbing.rb
 - spec/support/test_app_fail.json
 - spec/support/test_app_pass.json