pact 1.0.18 → 1.0.19

data/.gitignore

@@ -26,3 +26,4 @@ spec/pacts
 .ruby-gemset
 .ruby-version
 log
+.idea

data/CHANGELOG.md

@@ -2,13 +2,17 @@ Do this to generate your change history
 
     git log --date=relative --pretty=format:'  * %h - %s (%an, %ad)'
 
+### 1.0.19 (29 October 2013)
+ * e4b990e - Gsub '-' to '_' in request headers. (Sebastian Glazebrook, 4 minutes ago)
+ * 52ac8f8 - Added documentation for PACT_DESCRIPTION and PACT_PROVIDER_STATE to README. (Beth, 13 hours ago)
+
 ### 1.0.18 (29 October 2013)
 
-* f2892d4 - Fixed bug where an exception is thrown when a key is not found and is attempted to be matched to a regexp (Beth, 60 seconds ago)
+ * f2892d4 - Fixed bug where an exception is thrown when a key is not found and is attempted to be matched to a regexp (Beth, 60 seconds ago)
 
 ### 1.0.17 (29 October 2013)
 
-* 74bdf09 - Added missing require for Regexp json deserialisation (Beth, 3 minutes ago)
+ * 74bdf09 - Added missing require for Regexp json deserialisation (Beth, 3 minutes ago)
  * d69482e - Removed JsonWarning for ActiveSupport JSON. (Beth, 3 hours ago)
  * 5f72720 - Fixing ALL THE REGEXPS that ActiveSupport JSON broke. The pact gem should now serialise and deserialise its own JSON properly even when ActiveSupport is loaded by the call
  * c3e6430 - Added config.ru parsing to best practices. (Beth, 9 hours ago)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    pact (1.0.18)
+    pact (1.0.19)
       awesome_print (~> 1.1.0)
       find_a_port (~> 1.0.1)
       json

data/README.md

@@ -284,13 +284,20 @@ end
 
 Be aware that the Rack::Builder.parse_file seems to require files even if they have already been required, so make sure your boot files are idempotent.
 
-#### Do not stub your database calls in the provider project
+#### Use the real database
 
-This is the best time for you to test your database integration. If you stub your database calls, you are getting little more assurance that the real end-to-end will work than if you'd used a unit test. It's the appropriate time to incur the overhead of a database call.
+Do not stub your database calls for pact:verify. This is the best time for you to test your database integration. If you stub your database calls, you are getting little more assurance that the real end-to-end will work than if you'd used a unit test. It's the appropriate time to incur the overhead of a database call.
 
 ## Advanced
 
+### Filtering the pact:verify specs
+
+To execute a subset of the specs when running any of the pact verification tasks, define the environment variables PACT_DESCRIPTION and/or PACT_PROVIDER_STATE.
+
+    $ PACT_DESCRIPTION="a request for something" PACT_PROVIDER_STATE="something exists" rake pact:verify
+
 ### Running a standalone mock server
+
 A pact service can be run locally and is really useful for debugging purposes.
 
     $ bundle exec pact service -p <port-num>
@@ -298,7 +305,7 @@ A pact service can be run locally and is really useful for debugging purposes.
 The service prints messages it recieves to stdout which can be really useful
 when diagnosing issues with pacts.
 
-### Notes on pact file write mode
+### Pact file write mode
 
 By default, the pact file will be overwritten (started from scratch) every time any rspec runs any spec using pacts. This means that if there are interactions that haven't been executed in the most recent rspec run, they are effectively removed from the pact file. If you have long running pact specs (e.g. they are generated using the browser with Capybara) and you are developing both consumer and provider in parallel, or trying to fix a broken interaction, it can be tedius to run all the specs at once. In this scenario, you can set the pactfile_write_mode to :update. This will keep all existing interactions, and update only the changed ones, identified by description and provider state. The down side of this is that if either of those fields change, the old interactions will not be removed from the pact file. As a middle path, you can set pactfile_write_mode to :smart. This will use :overwrite mode when running rake (as determined by a call to system using 'ps') and :update when running an individual spec.
 

data/lib/pact/provider/request.rb

@@ -36,7 +36,7 @@ module Pact
             if key.match(/CONTENT.TYPE/)
               request_headers['CONTENT_TYPE'] = value
             else
-              request_headers['HTTP_' + key.to_s] = value
+              request_headers[formatted_request_header_key(key)] = value
             end
           end
           request_headers
@@ -53,6 +53,10 @@ module Pact
             JSON.dump(rb)
           end
         end
+
+        def formatted_request_header_key(key)
+          'HTTP_' + key.to_s.gsub('-', '_')
+        end
       end      
     end
   end

data/lib/pact/version.rb

@@ -1,3 +1,3 @@
 module Pact
-  VERSION = "1.0.18"
+  VERSION = "1.0.19"
 end

data/spec/lib/pact/provider/request_spec.rb

@@ -62,8 +62,8 @@ describe Pact::Provider::Request::Replayable do
 
   describe "headers" do
     context "when headers are expected" do
-      let(:headers) { {"Content-Type" => "text/plain", "Accept" => "application/json"} }
-      let(:expected_headers) { {"CONTENT_TYPE" => "text/plain", "HTTP_ACCEPT" => "application/json"} }
+      let(:headers) { {"Content-Type" => "text/plain", "Accept" => "application/json", "Access-Control-Request-Method" => "POST"} }
+      let(:expected_headers) { {"CONTENT_TYPE" => "text/plain", "HTTP_ACCEPT" => "application/json", "HTTP_ACCESS_CONTROL_REQUEST_METHOD" => "POST"} }
       it "transforms the headers into Rack format" do
         expect(subject.headers).to eq( expected_headers )
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pact
 version: !ruby/object:Gem::Version
-  version: 1.0.18
+  version: 1.0.19
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-29 00:00:00.000000000 Z
+date: 2013-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: randexp
@@ -430,21 +430,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -1950289785278429589
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -1950289785278429589
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: Define a pact between service consumers and providers