packwerk 3.2.0 → 3.2.1

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: packwerk
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.2.1
 platform: ruby
 authors:
 - Shopify Inc.
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-02-16 00:00:00.000000000 Z
+date: 2024-05-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -128,14 +128,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.24.0
+        version: 0.25.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.24.0
+        version: 0.25.0
 - !ruby/object:Gem::Dependency
   name: better_html
   requirement: !ruby/object:Gem::Requirement
@@ -174,38 +174,10 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- ".github/ISSUE_TEMPLATE/bug_report.md"
-- ".github/pull_request_template.md"
-- ".github/workflows/ci.yml"
-- ".github/workflows/cla.yml"
-- ".gitignore"
-- ".rubocop.yml"
-- ".ruby-version"
 - CHANGELOG.md
-- CODEOWNERS
-- CODE_OF_CONDUCT.md
-- CONTRIBUTING.md
-- Gemfile
-- Gemfile.lock
 - LICENSE.md
 - README.md
-- RESOLVING_VIOLATIONS.md
-- Rakefile
-- TROUBLESHOOT.md
-- UPGRADING.md
-- USAGE.md
-- bin/console
-- bin/m
-- bin/rake
-- bin/rubocop
-- bin/setup
-- bin/srb
-- bin/tapioca
-- dev.yml
-- docs/cohesion.png
 - exe/packwerk
-- gemfiles/Gemfile-rails-6-0
-- gemfiles/Gemfile-rails-6-1
 - lib/packwerk.rb
 - lib/packwerk/application_validator.rb
 - lib/packwerk/association_inspector.rb
@@ -272,66 +244,42 @@ files:
 - lib/packwerk/validator/result.rb
 - lib/packwerk/validators/dependency_validator.rb
 - lib/packwerk/version.rb
-- packwerk.gemspec
-- shipit.rubygems.yml
 - sorbet/config
-- sorbet/rbi/gems/actioncable@7.0.3.1.rbi
-- sorbet/rbi/gems/actionmailbox@7.0.3.1.rbi
-- sorbet/rbi/gems/actionmailer@7.0.3.1.rbi
 - sorbet/rbi/gems/actionpack@7.0.3.1.rbi
-- sorbet/rbi/gems/actiontext@7.0.3.1.rbi
 - sorbet/rbi/gems/actionview@7.0.3.1.rbi
-- sorbet/rbi/gems/activejob@7.0.3.1.rbi
-- sorbet/rbi/gems/activemodel@7.0.3.1.rbi
-- sorbet/rbi/gems/activerecord@7.0.3.1.rbi
-- sorbet/rbi/gems/activestorage@7.0.3.1.rbi
 - sorbet/rbi/gems/activesupport@7.0.3.1.rbi
 - sorbet/rbi/gems/ast@2.4.2.rbi
-- sorbet/rbi/gems/better_html@1.0.16.rbi
+- sorbet/rbi/gems/better_html@2.0.1.rbi
 - sorbet/rbi/gems/builder@3.2.4.rbi
 - sorbet/rbi/gems/byebug@11.1.3.rbi
-- sorbet/rbi/gems/coderay@1.1.3.rbi
 - sorbet/rbi/gems/concurrent-ruby@1.1.10.rbi
 - sorbet/rbi/gems/constant_resolver@0.2.0.rbi
 - sorbet/rbi/gems/crass@1.0.6.rbi
-- sorbet/rbi/gems/diff-lcs@1.5.0.rbi
-- sorbet/rbi/gems/digest@3.1.0.rbi
 - sorbet/rbi/gems/erubi@1.11.0.rbi
-- sorbet/rbi/gems/globalid@1.0.0.rbi
 - sorbet/rbi/gems/i18n@1.12.0.rbi
 - sorbet/rbi/gems/json@2.6.2.rbi
 - sorbet/rbi/gems/language_server-protocol@3.16.0.3.rbi
 - sorbet/rbi/gems/loofah@2.18.0.rbi
 - sorbet/rbi/gems/m@1.6.0.rbi
-- sorbet/rbi/gems/mail@2.7.1.rbi
-- sorbet/rbi/gems/marcel@1.0.2.rbi
-- sorbet/rbi/gems/method_source@1.0.0.rbi
-- sorbet/rbi/gems/mini_mime@1.1.2.rbi
+- sorbet/rbi/gems/method_source@1.1.0.rbi
 - sorbet/rbi/gems/minitest-focus@1.3.1.rbi
 - sorbet/rbi/gems/minitest@5.16.2.rbi
 - sorbet/rbi/gems/mocha@1.14.0.rbi
-- sorbet/rbi/gems/net-imap@0.2.3.rbi
-- sorbet/rbi/gems/net-pop@0.1.1.rbi
-- sorbet/rbi/gems/net-protocol@0.1.3.rbi
-- sorbet/rbi/gems/net-smtp@0.3.1.rbi
 - sorbet/rbi/gems/netrc@0.11.0.rbi
-- sorbet/rbi/gems/nio4r@2.5.8.rbi
 - sorbet/rbi/gems/nokogiri@1.15.3.rbi
-- sorbet/rbi/gems/parallel@1.22.1.rbi
-- sorbet/rbi/gems/parser@3.2.2.0.rbi
+- sorbet/rbi/gems/parallel@1.24.0.rbi
+- sorbet/rbi/gems/parser@3.3.1.0.rbi
 - sorbet/rbi/gems/prettier_print@0.1.0.rbi
-- sorbet/rbi/gems/prism@0.24.0.rbi
-- sorbet/rbi/gems/pry@0.14.1.rbi
-- sorbet/rbi/gems/racc@1.6.0.rbi
+- sorbet/rbi/gems/prism@0.27.0.rbi
+- sorbet/rbi/gems/racc@1.7.1.rbi
 - sorbet/rbi/gems/rack-test@2.0.2.rbi
 - sorbet/rbi/gems/rack@2.2.4.rbi
 - sorbet/rbi/gems/rails-dom-testing@2.0.3.rbi
 - sorbet/rbi/gems/rails-html-sanitizer@1.4.3.rbi
-- sorbet/rbi/gems/rails@7.0.3.1.rbi
 - sorbet/rbi/gems/railties@7.0.3.1.rbi
 - sorbet/rbi/gems/rainbow@3.1.1.rbi
 - sorbet/rbi/gems/rake@13.0.6.rbi
-- sorbet/rbi/gems/rbi@0.0.15.rbi
+- sorbet/rbi/gems/rbi@0.1.12.rbi
 - sorbet/rbi/gems/regexp_parser@2.5.0.rbi
 - sorbet/rbi/gems/rexml@3.2.5.rbi
 - sorbet/rbi/gems/rubocop-ast@1.21.0.rbi
@@ -339,24 +287,18 @@ files:
 - sorbet/rbi/gems/rubocop-shopify@2.9.0.rbi
 - sorbet/rbi/gems/rubocop-sorbet@0.6.11.rbi
 - sorbet/rbi/gems/rubocop@1.34.1.rbi
-- sorbet/rbi/gems/ruby-lsp@0.2.1.rbi
+- sorbet/rbi/gems/ruby-lsp@0.2.3.rbi
 - sorbet/rbi/gems/ruby-progressbar@1.11.0.rbi
 - sorbet/rbi/gems/smart_properties@1.17.0.rbi
-- sorbet/rbi/gems/spoom@1.1.11.rbi
+- sorbet/rbi/gems/spoom@1.3.2.rbi
 - sorbet/rbi/gems/spring@4.0.0.rbi
-- sorbet/rbi/gems/strscan@3.0.4.rbi
 - sorbet/rbi/gems/syntax_tree@3.3.0.rbi
-- sorbet/rbi/gems/tapioca@0.9.2.rbi
-- sorbet/rbi/gems/thor@1.2.1.rbi
-- sorbet/rbi/gems/timeout@0.3.0.rbi
+- sorbet/rbi/gems/tapioca@0.13.3.rbi
+- sorbet/rbi/gems/thor@1.3.1.rbi
 - sorbet/rbi/gems/tzinfo@2.0.5.rbi
 - sorbet/rbi/gems/unicode-display_width@2.2.0.rbi
-- sorbet/rbi/gems/unparser@0.6.5.rbi
-- sorbet/rbi/gems/webrick@1.7.0.rbi
-- sorbet/rbi/gems/websocket-driver@0.7.5.rbi
-- sorbet/rbi/gems/websocket-extensions@0.1.5.rbi
-- sorbet/rbi/gems/yard-sorbet@0.6.1.rbi
-- sorbet/rbi/gems/yard@0.9.28.rbi
+- sorbet/rbi/gems/yard-sorbet@0.8.1.rbi
+- sorbet/rbi/gems/yard@0.9.36.rbi
 - sorbet/rbi/gems/zeitwerk@2.6.4.rbi
 - sorbet/rbi/shims/minitest/test.rb
 - sorbet/rbi/shims/packwerk/reference.rbi
@@ -387,7 +329,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.6
+rubygems_version: 3.5.9
 signing_key: 
 specification_version: 4
 summary: Packages for applications based on the zeitwerk autoloader

data/.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,27 +0,0 @@
----
-name: Bug / Issue Report
-about: Create a report to help us improve
-title: '[Bug Report]'
-labels: bug
-assignees: ''
-
----
-
-**Description**
-A clear and concise description of what the bug/issue is.
-
-**To Reproduce**
-Steps to reproduce the behavior.
-
-**Expected Behaviour**
-A clear and concise description of what you expected to happen.
-
-**Screenshots**
-If applicable, add screenshots to help explain your problem.
-
-**Version Information**
- - Packwerk: [e.g. v0.1.7]
- - Ruby [e.g. v1.7]
-
-**Additional Context**
-How have you tried to solve the issue? Add any other context about the problem here.

data/.github/pull_request_template.md

@@ -1,28 +0,0 @@
-## What are you trying to accomplish?
-
-
-## What approach did you choose and why?
-
-
-## What should reviewers focus on?
-
-
-## Type of Change
-
-- [ ] Bugfix
-- [ ] New feature
-- [ ] Non-breaking change (a change that doesn't alter functionality - i.e., code refactor, configs, etc.)
-
-### Additional Release Notes
-
-- [ ] Breaking change (fix or feature that would cause existing functionality to change)
-
-Include any notes here to include in the release description. For example, if you selected "breaking change" above, leave notes on how users can transition to this version.
-
-If no additional notes are necessary, delete this section or leave it unchanged.
-
-## Checklist
-
-- [ ] I have updated the documentation accordingly.
-- [ ] I have added tests to cover my changes.
-- [ ] It is safe to rollback this change.

data/.github/workflows/ci.yml

@@ -1,93 +0,0 @@
-name: CI
-
-on:
-  push:
-    branches:
-      - main
-      - '*-stable'
-  pull_request:
-
-jobs:
-  tests:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        gemfile:
-          - Gemfile
-          - gemfiles/Gemfile-rails-6-0
-          - gemfiles/Gemfile-rails-6-1
-        ruby:
-          - "2.7"
-          - "3.0"
-          - "3.1"
-          - "3.2"
-    env:
-      BUNDLE_GEMFILE: ${{ matrix.gemfile }}
-    name: "Tests: Ruby ${{ matrix.ruby }} ${{ matrix.gemfile }}"
-    steps:
-      - uses: actions/checkout@v2
-      - name: Set up Ruby ${{ matrix.ruby }}
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: ${{ matrix.ruby }}
-          bundler-cache: true
-      - name: Run tests
-        run: bin/rake test
-  loading-tests:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        gemfile:
-          - Gemfile
-        ruby:
-          - "2.7"
-          - "3.0"
-          - "3.1"
-          - "3.2"
-    env:
-      BUNDLE_GEMFILE: ${{ matrix.gemfile }}
-    name: "Loading Tests: Ruby ${{ matrix.ruby }} ${{ matrix.gemfile }}"
-    steps:
-      - uses: actions/checkout@v2
-      - name: Set up Ruby ${{ matrix.ruby }}
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: ${{ matrix.ruby }}
-          bundler-cache: true
-      - name: Run tests
-        run: bin/rake test:loading
-  lint:
-    runs-on: ubuntu-latest
-    name: Lint
-    steps:
-      - uses: actions/checkout@v2
-      - name: Set up Ruby
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: "3.1"
-          bundler-cache: true
-      - name: Run style checks
-        run: bin/rubocop
-  static_type_checking:
-    runs-on: ubuntu-latest
-    name: Type Checking
-    steps:
-      - uses: actions/checkout@v2
-      - name: Set up Ruby
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: "3.1"
-          # bundler-cache: true
-      - name: Run static type checks
-        run: |
-          bundle install --jobs 4 --retry 3
-          bin/srb tc
-  buildall:
-    if: ${{ always() }}
-    runs-on: ubuntu-latest
-    name: Build (matrix)
-    needs: [lint, tests, static_type_checking]
-    steps:
-      - name: Check build matrix status
-        if: ${{ needs.tests.result != 'success' || needs.lint.result != 'success' || needs.static_type_checking.result != 'success' }}
-        run: exit 1

data/.github/workflows/cla.yml

@@ -1,22 +0,0 @@
-name: Contributor License Agreement (CLA)
-
-on:
-  pull_request_target:
-    types: [opened, synchronize]
-  issue_comment:
-    types: [created]
-
-jobs:
-  cla:
-    runs-on: ubuntu-latest
-    if: |
-      (github.event.issue.pull_request 
-        && !github.event.issue.pull_request.merged_at
-        && contains(github.event.comment.body, 'signed')
-      ) 
-      || (github.event.pull_request && !github.event.pull_request.merged)
-    steps:
-      - uses: Shopify/shopify-cla-action@v1
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          cla-token: ${{ secrets.CLA_TOKEN }}

data/.gitignore

@@ -1,13 +0,0 @@
-/.bundle/
-/.yardoc
-/_yardoc/
-/coverage/
-/doc/
-/pkg/
-/spec/reports/
-/tmp/
-/.bundle/
-/tmp/
-.rubocop-*
-.byebug_history
-sorbet/rbi/hidden-definitions/errors.txt

data/.rubocop.yml

@@ -1,75 +0,0 @@
-inherit_gem:
-    rubocop-shopify: rubocop.yml
-
-require:
-  - rubocop-performance
-  - rubocop-sorbet
-
-AllCops:
-  TargetRubyVersion: 2.7
-  NewCops: disable
-  UseCache: true
-  SuggestExtensions: false
-  CacheRootDirectory: tmp
-  Exclude:
-    - 'test/fixtures/**/*'
-
-Sorbet/ConstantsFromStrings:
-  Enabled: true
-
-Sorbet/ForbidIncludeConstLiteral:
-  Enabled: true
-
-Sorbet/SignatureBuildOrder:
-  Enabled: true
-
-Sorbet/KeywordArgumentOrdering:
-  Enabled: true
-
-Sorbet/ValidSigil:
-  Enabled: true
-
-Performance/AncestorsInclude: # new in 1.7
-  Enabled: true
-
-Performance/BigDecimalWithNumericArgument: # new in 1.7
-  Enabled: true
-
-Performance/BlockGivenWithExplicitBlock: # new in 1.9
-  Enabled: true
-
-Performance/CollectionLiteralInLoop: # new in 1.8
-  Enabled: true
-
-Performance/ConstantRegexp: # new in 1.9
-  Enabled: true
-
-Performance/MethodObjectAsBlock: # new in 1.9
-  Enabled: true
-
-Performance/RedundantEqualityComparisonBlock: # new in 1.10
-  Enabled: true
-
-Performance/RedundantSortBlock: # new in 1.7
-  Enabled: true
-
-Performance/RedundantSplitRegexpArgument: # new in 1.10
-  Enabled: true
-
-Performance/RedundantStringChars: # new in 1.7
-  Enabled: true
-
-Performance/ReverseFirst: # new in 1.7
-  Enabled: true
-
-Performance/SortReverse: # new in 1.7
-  Enabled: true
-
-Performance/Squeeze: # new in 1.7
-  Enabled: true
-
-Performance/StringInclude: # new in 1.7
-  Enabled: true
-
-Performance/Sum: # new in 1.8
-  Enabled: true

data/.ruby-version

@@ -1 +0,0 @@
-3.2.2

data/CODEOWNERS

@@ -1 +0,0 @@
-*    @Shopify/packwerk

data/CODE_OF_CONDUCT.md

@@ -1,76 +0,0 @@
-# Contributor Covenant Code of Conduct
-
-## Our Pledge
-
-In the interest of fostering an open and welcoming environment, we as
-contributors and maintainers pledge to make participation in our project and
-our community a harassment-free experience for everyone, regardless of age, body
-size, disability, ethnicity, sex characteristics, gender identity and expression,
-level of experience, education, socio-economic status, nationality, personal
-appearance, race, religion, or sexual identity and orientation.
-
-## Our Standards
-
-Examples of behavior that contributes to creating a positive environment
-include:
-
-* Using welcoming and inclusive language
-* Being respectful of differing viewpoints and experiences
-* Gracefully accepting constructive criticism
-* Focusing on what is best for the community
-* Showing empathy towards other community members
-
-Examples of unacceptable behavior by participants include:
-
-* The use of sexualized language or imagery and unwelcome sexual attention or
-  advances
-* Trolling, insulting/derogatory comments, and personal or political attacks
-* Public or private harassment
-* Publishing others' private information, such as a physical or electronic
-  address, without explicit permission
-* Other conduct which could reasonably be considered inappropriate in a
-  professional setting
-
-## Our Responsibilities
-
-Project maintainers are responsible for clarifying the standards of acceptable
-behavior and are expected to take appropriate and fair corrective action in
-response to any instances of unacceptable behavior.
-
-Project maintainers have the right and responsibility to remove, edit, or
-reject comments, commits, code, wiki edits, issues, and other contributions
-that are not aligned to this Code of Conduct, or to ban temporarily or
-permanently any contributor for other behaviors that they deem inappropriate,
-threatening, offensive, or harmful.
-
-## Scope
-
-This Code of Conduct applies within all project spaces, and it also applies when
-an individual is representing the project or its community in public spaces.
-Examples of representing a project or community include using an official
-project e-mail address, posting via an official social media account, or acting
-as an appointed representative at an online or offline event. Representation of
-a project may be further defined and clarified by project maintainers.
-
-## Enforcement
-
-Instances of abusive, harassing, or otherwise unacceptable behavior may be
-reported by contacting the project team at opensource@shopify.com. All
-complaints will be reviewed and investigated and will result in a response that
-is deemed necessary and appropriate to the circumstances. The project team is
-obligated to maintain confidentiality with regard to the reporter of an incident.
-Further details of specific enforcement policies may be posted separately.
-
-Project maintainers who do not follow or enforce the Code of Conduct in good
-faith may face temporary or permanent repercussions as determined by other
-members of the project's leadership.
-
-## Attribution
-
-This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
-available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
-
-[homepage]: https://www.contributor-covenant.org
-
-For answers to common questions about this code of conduct, see
-https://www.contributor-covenant.org/faq

data/CONTRIBUTING.md

@@ -1,17 +0,0 @@
-# Contributing
-
-## Issue reporting
-* Check to make sure the same issue has not already been reported or fixed
-* Open an issue with a descriptive title and summary
-* Be clear and concise and provide as many details as possible (e.g. Ruby version, Packwerk version, etc.)
-* Include relevant code, where necessary
-
-## Pull requests
-* Read and understand our [Code of Conduct](https://github.com/Shopify/packwerk/blob/main/CODE_OF_CONDUCT.md)
-* Make sure tests are added for any changes to the code
-* [Squash related commits together](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)
-* If the change includes any new keys to `packwerk.yml`, make sure that the [application validator](https://github.com/Shopify/packwerk/blob/1c711748b4a28b65220e2cefba764ffd8eb1a101/lib/packwerk/application_validator.rb#L116) is aligned with that change
-* Open a pull request once the change is ready to be reviewed
-* Be descriptive about the problem and reason about the proposed solution
-* Include release notes describing the potential impact of the change in the pull request
-* Make sure there has been at least one approval from Shopify before merging

data/Gemfile

@@ -1,27 +0,0 @@
-# frozen_string_literal: true
-
-source("https://rubygems.org")
-git_source(:github) { |repo_name| "https://github.com/#{repo_name}.git" }
-
-gemspec
-
-# Specify the same dependency sources as the application Gemfile
-
-gem("spring")
-gem("constant_resolver", require: false)
-gem("rubocop-performance", require: false)
-gem("rubocop-sorbet", require: false)
-gem("mocha", require: false)
-gem("rubocop-shopify", require: false)
-gem("tapioca", require: false)
-
-group :development do
-  gem("byebug", require: false)
-  gem("minitest-focus", require: false)
-  gem("ruby-lsp", "~> 0.2.1")
-
-  gem("m")
-  gem("rake")
-  gem("sorbet-static-and-runtime")
-  gem("zeitwerk")
-end