packwerk 3.1.0 → 3.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d72fbde4259baa5a5e7f8bc2ca4406d9bc6a835051efafefc23ef6ef3ae13f32
-  data.tar.gz: 65bff304e2be348e16800b0d4f65ab33a1b5fb84ab15ba495e03904d099be4a0
+  metadata.gz: f8766d43b92fcc7bedad92604cde48e11433afdf474b21515f363b595c7fae23
+  data.tar.gz: 0d386a1d690b6c07d41a6d63b0907f38d57fffd87d2ab370ee580cbcd0826a17
 SHA512:
-  metadata.gz: e25488e4af51932d503d4120e458fe92bc4ae2945ca8009219e01f4f2e7756e0430a0d9a6176f01d864d55644f262a06fb88494234b43aae43ba254437d7fb49
-  data.tar.gz: 2c821f3e11a16c52d84f7f4e68f01e788e95d5723fd77305f69e15aba07f5f1f81ea43e9c60b6c00ca4503df036eb2b3ea0e0ae1378f0c584d7252614064f9d9
+  metadata.gz: a64ccf65829b48691341b0abc09013213bd266ca9d2ec7a37fa1735856ae6b707d904ad75012c91bcd5a6d3ec4991ed6d7f1545140232d34f6d27452f5ac5a27
+  data.tar.gz: f231695cf34fc0fb109d70efcff6874d5268b70c4af80688813734448f5c3d1ee3a705dbe3ece0bbb156733585f581f941917ed43f1666bb58f9617932858e18

data/lib/packwerk/checker.rb

@@ -11,7 +11,7 @@ module Packwerk
     class << self
       extend T::Sig
 
-      sig { params(base: Class).void }
+      sig { params(base: T::Class[T.anything]).void }
       def included(base)
         checkers << base
       end
@@ -34,9 +34,9 @@ module Packwerk
         require("packwerk/reference_checking/checkers/dependency_checker")
       end
 
-      sig { returns(T::Array[Class]) }
+      sig { returns(T::Array[T::Class[T.anything]]) }
       def checkers
-        @checkers ||= T.let([], T.nilable(T::Array[Class]))
+        @checkers ||= T.let([], T.nilable(T::Array[T::Class[T.anything]]))
       end
 
       sig { params(name: String).returns(Checker) }
@@ -51,8 +51,8 @@ module Packwerk
     sig { abstract.returns(String) }
     def violation_type; end
 
-    sig { abstract.params(listed_offense: ReferenceOffense).returns(T::Boolean) }
-    def strict_mode_violation?(listed_offense); end
+    sig { abstract.params(offense: ReferenceOffense).returns(T::Boolean) }
+    def strict_mode_violation?(offense); end
 
     sig { abstract.params(reference: Reference).returns(T::Boolean) }
     def invalid_reference?(reference); end

data/lib/packwerk/commands/check_command.rb

@@ -31,17 +31,19 @@ module Packwerk
         end
         offense_collection.add_offenses(all_offenses)
 
+        unlisted_strict_mode_violations = offense_collection.unlisted_strict_mode_violations
+
         messages = [
           offenses_formatter.show_offenses(offense_collection.outstanding_offenses),
           offenses_formatter.show_stale_violations(offense_collection, @files_for_processing.files),
-          offenses_formatter.show_strict_mode_violations(offense_collection.strict_mode_violations),
+          offenses_formatter.show_strict_mode_violations(unlisted_strict_mode_violations),
         ]
 
         out.puts(messages.select(&:present?).join("\n") + "\n")
 
         offense_collection.outstanding_offenses.empty? &&
           !offense_collection.stale_violations?(@files_for_processing.files) &&
-          offense_collection.strict_mode_violations.empty?
+          unlisted_strict_mode_violations.empty?
       end
 
       private

data/lib/packwerk/file_processor.rb

@@ -59,7 +59,7 @@ module Packwerk
         For now, you can add this file to `packwerk.yml` `exclude` list.
         Please file an issue and include this error message and stacktrace:
 
-        #{e.message} #{e.backtrace}"
+        #{e.message} #{e.backtrace&.join("\n")}"
       MSG
 
       offense = Parsers::ParseResult.new(file: relative_file, message: message)

data/lib/packwerk/generators/templates/package.yml

@@ -2,8 +2,8 @@
 # Please validate the configuration using `packwerk validate` (for Rails applications) or running the auto generated
 # test case (for non-Rails projects). You can then use `packwerk check` to check your code.
 
-# Turn on dependency checks for this package
-enforce_dependencies: true
+# Change to `true` to turn on dependency checks for this package
+enforce_dependencies: false
 
 # A list of this package's dependencies
 # Note that packages in this list require their own `package.yml` file

data/lib/packwerk/offenses_formatter.rb

@@ -20,7 +20,7 @@ module Packwerk
     class << self
       extend T::Sig
 
-      sig { params(base: Class).void }
+      sig { params(base: T::Class[T.anything]).void }
       def included(base)
         offenses_formatters << base
       end
@@ -43,9 +43,9 @@ module Packwerk
         require("packwerk/formatters/default_offenses_formatter")
       end
 
-      sig { returns(T::Array[Class]) }
+      sig { returns(T::Array[T::Class[T.anything]]) }
       def offenses_formatters
-        @offenses_formatters ||= T.let([], T.nilable(T::Array[Class]))
+        @offenses_formatters ||= T.let([], T.nilable(T::Array[T::Class[T.anything]]))
       end
 
       sig { params(name: String).returns(OffensesFormatter) }

data/lib/packwerk/package_todo.rb

@@ -113,10 +113,7 @@ module Packwerk
     sig { params(package: String, violations: Entry).returns(T::Boolean) }
     def stale_violation_for_package?(package, violations:)
       violations.any? do |constant_name, entries_for_constant|
-        new_entries_violation_types = T.cast(
-          new_entries.dig(package, constant_name, "violations"),
-          T.nilable(T::Array[String]),
-        )
+        new_entries_violation_types = new_entries.dig(package, constant_name, "violations")
         # If there are no NEW entries that match the old entries `for_files`,
         # new_entries is from the list of violations we get when we check this file.
         # If this list is empty, we also must have stale violations.

data/lib/packwerk/parsers/factory.rb

@@ -24,7 +24,7 @@ module Packwerk
       def initialize
         @ruby_parser = T.let(nil, T.nilable(ParserInterface))
         @erb_parser = T.let(nil, T.nilable(ParserInterface))
-        @erb_parser_class = T.let(nil, T.nilable(Class))
+        @erb_parser_class = T.let(nil, T.nilable(T::Class[T.anything]))
       end
 
       sig { params(path: String).returns(T.nilable(ParserInterface)) }
@@ -37,12 +37,12 @@ module Packwerk
         end
       end
 
-      sig { returns(Class) }
+      sig { returns(T::Class[T.anything]) }
       def erb_parser_class
         @erb_parser_class ||= Erb
       end
 
-      sig { params(klass: T.nilable(Class)).void }
+      sig { params(klass: T.nilable(T::Class[T.anything])).void }
       def erb_parser_class=(klass)
         @erb_parser_class = klass
         @erb_parser = nil

data/lib/packwerk/parsers/ruby.rb

@@ -2,7 +2,7 @@
 # frozen_string_literal: true
 
 require "parser"
-require "parser/current"
+require "prism"
 
 module Packwerk
   module Parsers
@@ -11,7 +11,7 @@ module Packwerk
 
       include ParserInterface
 
-      class RaiseExceptionsParser < Parser::CurrentRuby
+      class RaiseExceptionsParser < Prism::Translation::Parser
         extend T::Sig
 
         sig { params(builder: T.untyped).void }
@@ -19,6 +19,13 @@ module Packwerk
           super(builder)
           super.diagnostics.all_errors_are_fatal = true
         end
+
+        private
+
+        sig { params(error: Prism::ParseError).returns(T::Boolean) }
+        def valid_error?(error)
+          error.type != :invalid_yield
+        end
       end
 
       class TolerateInvalidUtf8Builder < Parser::Builders::Default

data/lib/packwerk/reference_checking/checkers/dependency_checker.rb

@@ -47,9 +47,9 @@ module Packwerk
           EOS
         end
 
-        sig { override.params(listed_offense: ReferenceOffense).returns(T::Boolean) }
-        def strict_mode_violation?(listed_offense)
-          referencing_package = listed_offense.reference.package
+        sig { override.params(offense: ReferenceOffense).returns(T::Boolean) }
+        def strict_mode_violation?(offense)
+          referencing_package = offense.reference.package
           referencing_package.config["enforce_dependencies"] == "strict"
         end
 

data/lib/packwerk/reference_offense.rb

@@ -23,7 +23,7 @@ module Packwerk
         .void
     end
     def initialize(reference:, violation_type:, message:, location: nil)
-      super(file: reference.relative_path, message: message, location: location)
+      super(file: T.must(reference.relative_path), message: message, location: location)
       @reference = reference
       @violation_type = violation_type
     end

data/lib/packwerk/validator.rb

@@ -18,7 +18,7 @@ module Packwerk
     class << self
       extend T::Sig
 
-      sig { params(base: Class).void }
+      sig { params(base: T::Class[T.anything]).void }
       def included(base)
         validators << base
       end
@@ -36,9 +36,9 @@ module Packwerk
         require("packwerk/validators/dependency_validator")
       end
 
-      sig { returns(T::Array[Class]) }
+      sig { returns(T::Array[T::Class[T.anything]]) }
       def validators
-        @validators ||= T.let([], T.nilable(T::Array[Class]))
+        @validators ||= T.let([], T.nilable(T::Array[T::Class[T.anything]]))
       end
     end
 

data/lib/packwerk/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module Packwerk
-  VERSION = "3.1.0"
+  VERSION = "3.2.1"
 end