packwerk 3.0.0 → 3.2.2

data/USAGE.md

@@ -1,367 +0,0 @@
-# Packwerk usage
-
-## Table of Contents
-
-* [What problem does Packwerk solve?](#what-problem-does-packwerk-solve)
-* [What is a package?](#what-is-a-package)
-  * [Package principles](#package-principles)
-* [Getting started](#getting-started)
-  * [Setting up Spring](#setting-up-spring)
-* [Configuring Packwerk](#configuring-packwerk)
-  * [Using a custom ERB parser](#using-a-custom-erb-parser)
-* [Validating the package system](#validating-the-package-system)
-* [Defining packages](#defining-packages)
-  * [Package metadata](#package-metadata)
-* [Types of boundary checks](#types-of-boundary-checks)
-  * [Enforcing dependency boundary](#enforcing-dependency-boundary)
-* [Using strict mode](#using-strict-mode)
-* [Checking for violations](#checking-for-violations)
-* [Resolving new violations](#resolving-new-violations)
-  * [Understanding how to respond to new violations](#understanding-how-to-respond-to-new-violations)
-* [Recording existing violations](#recording-existing-violations)
-  * [Understanding the package todo file](#understanding-the-package-todo-file)
-  * [Understanding the list of deprecated references](#understanding-the-list-of-deprecated-references)
-* [Loading extensions](#loading-extensions)
-
-## What problem does Packwerk solve?
-
-Large applications need clear boundaries to avoid turning into a [ball of mud](https://en.wikipedia.org/wiki/Big_ball_of_mud). However, Ruby does not provide a good solution to enforcing boundaries between code.
-
-Packwerk is a gem that can be used to enforce boundaries between groups of code we call packages.
-
-## What is a package?
-
-A package is a folder containing autoloaded code. To decide whether code belongs together in a package, these are some design best practices:
-
-- We should package things together that have high functional [cohesion](https://en.wikipedia.org/wiki/Cohesion_(computer_science)).
-- Packages should be relatively loosely coupled to each other.
-
-![cohesion](docs/cohesion.png)
-
-### Package principles
-
-Package principles help to guide the organization of classes in a large system. These principles can also be applied to packages in large and complex codebases.
-
-The [package principles](https://en.wikipedia.org/wiki/Package_principles) page on Wikipedia does a good job explaining what well designed packages look like.
-
-## Getting started
-
-After including Packwerk in the Gemfile, you will first want to generate a binstub:
-You can do this by running `bundle binstub packwerk`, which will generate a [binstub](https://bundler.io/man/bundle-binstubs.1.html#DESCRIPTION) at `bin/packwerk`.
-
-Then, you can generate the necessary files to get Packwerk running by executing:
-
-    bin/packwerk init
-
-Here is a list of files generated:
-
-| File                        | Location     | Description |
-|-----------------------------|--------------|------------|
-| Packwerk configuration      | packwerk.yml | See [Setting up the configuration file](#configuring-packwerk) |
-| Root package                | package.yml  | A package for the root folder |
-
-After that, you may begin creating packages for your application. See [Defining packages](#Defining-packages)
-
-### Setting up Spring
-
-[Spring](https://github.com/rails/spring) is a preloader for Rails. Because `packwerk` loads `Rails`, it can be sped up dramatically by enabling spring.  Packwerk supports the usage of Spring.
-Firstly, spring needs to know about the packwerk spring command when spring is loading. To do that, add `require 'packwerk/spring_command'` to `config/spring.rb` in your application.
-Secondly, to enable Spring, first run `bin/spring binstub packwerk` which will "springify" the generated binstub.
-
-
-## Configuring Packwerk
-
-Packwerk reads from the `packwerk.yml` configuration file in the root directory. Packwerk will run with the default configuration if any of these settings are not specified.
-
-| Key                  | Default value                             | Description  |
-|----------------------|-------------------------------------------|--------------|
-| include              | **/*.{rb,rake,erb}                        | list of patterns for folder paths to include |
-| exclude              | {bin,node_modules,script,tmp,vendor}/**/* | list of patterns for folder paths to exclude |
-| package_paths        | **/                                       | a single pattern or a list of patterns to find package configuration files, see: [Defining packages](#Defining-packages) |
-| custom_associations  | N/A                                       | list of custom associations, if any |
-| parallel             | true                                      | when true, fork code parsing out to subprocesses |
-| cache                | false                                     | when true, caches the results of parsing files |
-| cache_directory      | tmp/cache/packwerk                        | the directory that will hold the packwerk cache |
-
-### Using a custom ERB parser
-
-You can specify a custom ERB parser if needed. For example, if you're using `<%graphql>` tags from https://github.com/github/graphql-client in your ERBs, you can use a custom parser subclass to comment them out so that Packwerk can parse the rest of the file:
-
-```ruby
-class CustomParser < Packwerk::Parsers::Erb
-  def parse_buffer(buffer, file_path:)
-    preprocessed_source = buffer.source
-
-    # Comment out <%graphql ... %> tags. They won't contain any object
-    # references anyways.
-    preprocessed_source = preprocessed_source.gsub(/<%graphql/, "<%#")
-
-    preprocessed_buffer = Parser::Source::Buffer.new(file_path)
-    preprocessed_buffer.source = preprocessed_source
-    super(preprocessed_buffer, file_path: file_path)
-  end
-end
-
-Packwerk::Parsers::Factory.instance.erb_parser_class = CustomParser
-```
-
-## Using the cache
-Packwerk ships with an cache to help speed up file parsing. You can turn this on by setting `cache: true` in `packwerk.yml`.
-
-This will write to `tmp/cache/packwerk`.
-
-## Validating the package system
-
-There are some criteria that an application must meet in order to have a valid package system. These criteria include having a valid autoload path cache, package definition files, and application folder structure. The dependency graph within the package system also has to be acyclic.
-
-We recommend setting up the package system validation for your Rails application in a CI step (or through a test suite for Ruby projects) separate from `bin/packwerk check`.
-
-Use the following command to validate the application:
-
-    bin/packwerk validate
-
-![](static/packwerk_validate.gif)
-
-## Defining packages
-
-You can create a `package.yml` in any folder to make it a package. The package name is the path to the folder from the project root.
-
-_Note: It is helpful to define a namespace that corresponds to the package name and contains at least all the public constants of the package. This makes it more obvious which package a constant is defined in._
-
-### Package metadata
-
-Package metadata can be included in the `package.yml`. Metadata won't be validated, and can thus be anything. We recommend including information on ownership and stewardship of the package.
-
-Example:
-```yaml
-    # components/sales/package.yml
-    metadata:
-      stewards:
-      - "@Shopify/sales"
-      slack_channels:
-      - "#sales"
-```
-
-## Types of boundary checks
-
-Packwerk ships with dependency boundary checking only. See [`packwerk-extensions`](https://github.com/rubyatscale/packwerk-extensions) to incorporate privacy checks into your use of `packwerk`.
-
-#### Enforcing dependency boundary
-
-A package's dependency boundary is violated whenever it references a constant in some package that has not been declared as a dependency.
-
-Specify `enforce_dependencies: true` to start enforcing the dependencies of a package. The intentional dependencies of the package are specified as a list under a `dependencies:` key.
-
-Example:
-
-```yaml
-# components/shop_identity/package.yml
-enforce_dependencies: true
-dependencies:
-  - components/platform
-```
-
-It will be a dependency violation when `components/shop_identity` tries to reference a constant that is not within `components/platform` or itself.
-
-#### Using strict mode
-
-Once there are no more violations in a package, you can turn on `strict` mode, which will prevent new violations from being added to the package's `package_todo.yml`. To use this, simply change `enforce_dependencies: true` to `enforce_dependencies: strict` in your `package.yml`.
-
-Then, when you run `bin/packwerk check`, new violations will cause the following error to be displayed:
-```
-packs/referencing_package cannot have dependency violations on packs/defining_package because strict mode is enabled for dependency violations in packs/referencing_package/package.yml
-```
-
-## Checking for violations
-
-After enforcing the boundary checks for a package, you may execute:
-
-    bin/packwerk check
-
-Packwerk will check the entire codebase for any new or stale violations.
-
-You can also specify folders for a shorter run time. When checking against folders all subfolders will be analyzed, irrespective of nested package boundaries.
-
-    bin/packwerk check components/your_package
-
-You can also specify packages for a shorter run time. When checking against packages any packages nested underneath the specified packages will not be checked. This can be helpful to test packages like the root package, which can have many nested packages.
-
-    bin/packwerk check --packages=components/your_package,components/your_other_package
-
-![](static/packwerk_check.gif)
-
-In order to keep the package system valid at each version of the application, we recommend running `bin/packwerk check` in your CI pipeline.
-
-See: [TROUBLESHOOT.md - Sample violations](TROUBLESHOOT.md#Sample-violations)
-
-## Resolving new violations
-
-### Understanding how to respond to new violations
-
-When you have a new dependency or privacy violation, what do you do?
-
-See: [RESOLVING_VIOLATIONS.md](RESOLVING_VIOLATIONS.md)
-
-## Recording existing violations
-
-For existing codebases, packages are likely to have existing boundary violations.
-
-If so, you will want to stop the bleeding and prevent more violations from occuring. The existing violations in the codebase can be recorded in a [todo list](#understanding-the-package-todo-file) by executing:
-
-    bin/packwerk update-todo
-
-![](static/packwerk_update.gif)
-
-`bin/packwerk update-todo` should only be run to record existing violations and to remove violations that have been worked off. Running `bin/packwerk update-todo` to resolve a violation should be the very last resort.
-
-See: [TROUBLESHOOT.md - Troubleshooting violations](TROUBLESHOOT.md#Troubleshooting_violations)
-
-### Understanding the package todo file
-
-The package TODO list is called `package_todo.yml` and can be found in the package folder. The list outlines the constant violations of the package, where the violation is located, and the file defining the violation.
-
-The package TODO list should not be added to, but worked off over time.
-
-```yaml
-components/merchant:
-  "::Checkouts::Core::CheckoutId":
-    violations:
-    - dependency
-    files:
-    - components/merchant/app/public/merchant/generate_order.rb
-```
-
-Above is an example of a constant violation entry in `package_todo.yml`.
-
-* `components/merchant` - package where the constant violation is found
-* `::Checkouts::Core::CheckoutId` - violated constant in question
-* `dependency` - type of violation, either dependency or privacy
-* `components/merchant/app/public/merchant/generate_order.rb` - path to the file containing the violated constant
-
-Violations exist within the package that makes a violating reference. This means privacy violations of your package can be found listed in `package_todo.yml` files in the packages with the reference to a private constant.
-
-# Loading Extensions
-
-You can optionally specify ruby files that you'd like to be loaded with `packwerk` by specifying a `require` directive in `packwerk.yml`:
-```yml
-require:
-  - ./path/to/file.rb
-  - my_gem
-```
-
-`packwerk` will directly call `require` with these paths.
-You can prefix local files with a dot to define them relative to `packwerk.yml`, or you can use absolute paths.
-You can also reference the name of a gem.
-
-## Examples
-
-### Custom Offense Formatter
-
-While `packwerk` ships with its own offense formatter, you may specify a custom one in your configuration file via the `offenses_formatter:` key.  Your custom formatter will be used when `bin/packwerk check` is run.
-
-Firstly, you'll need to create an `OffensesFormatter` class that includes `Packwerk::OffensesFormatter`. You can use [`Packwerk::Formatters::OffensesFormatter`](lib/packwerk/formatters/offenses_formatter.rb) as a point of reference for this. Then, in the `require` directive described above, you'll want to tell `packwerk` about it:
-```ruby
-# ./path/to/file.rb
-class MyOffensesFormatter
-  include Packwerk::OffensesFormatter
-  # implement the `OffensesFormatter` interface
-
-  def identifier
-    'my_offenses_formatter'
-  end
-end
-```
-
-Then in `packwerk.yml`, you can set the `formatter` to the identifier for your class:
-```yml
-offenses_formatter: my_offenses_formatter
-```
-
-You can also pass in a formatter on the command line:
-```
-bin/packwerk check --offenses-formatter=my_offenses_formatter
-```
-
-### Custom Checkers
-
-Packwerk ships with a way to analyze dependencies and also supports custom checkers, such as the privacy checker listed below.
-
-Custom checkers will allow references to constants to be analyzed in new ways, and for those invalid references to show up as violations in `package_todo.yml`.
-
-To create a custom checker, you'll first need to create a checker class that includes `Packwerk::Checker`. You can use [`Packwerk::ReferenceChecking::Checkers::DependencyChecker`](lib/packwerk/reference_checking/checkers/dependency_checker.rb) as a point of reference for this. Here is an example:
-
-```ruby
-# ./path/to/file.rb
-class MyChecker
-  include Packwerk::Checker
-  # implement the `Checker` interface
-
-  sig { override.returns(String) }
-  def violation_type
-    'my_custom_violation_type'
-  end
-
-  sig { override.params(listed_offense: ReferenceOffense).returns(T::Boolean) }
-  def strict_mode_violation?(listed_offense)
-    # This will allow "strict mode" to be supported in your checker
-    referencing_package = listed_offense.reference.package
-    referencing_package.config["enforce_custom"] == "strict"
-  end
-
-  sig { override.params(reference: Reference).returns(T::Boolean) }
-  def invalid_reference?(reference)
-    # your logic here
-  end
-
-  sig { override.params(reference: Reference).returns(String) }
-  def message(reference)
-    # your message here
-  end
-end
-```
-
-Then, in the `require` directive described above, you'll want to tell `packwerk` about it:
-
-```yml
-require:
-  - ./path/to/file.rb
-```
-
-#### Privacy Checker
-
-[`packwerk-extensions`](https://github.com/rubyatscale/packwerk-extensions) (originally extracted from `packwerk`) can be used to help define and enforce public API boundaries of a package. See the README.md for more details. To use this, add it to your `Gemfile` and then require it via `packwerk.yml`:
-```yml
-require:
-  - packwerk-extensions
-```
-
-### Custom Validators
-
-Similar to checkers, you can define your own validator to be executed when `bin/packwerk validate` is invoked. This can be used to support your custom checker (by specifying permitted keys) or to provide any other validations you want to impose on packages.
-
-To create a custom validator, you'll first need to create a validator class that includes `Packwerk::Validator`. You can use [`Packwerk::Validators::DependencyValidator`](lib/packwerk/validators/dependency_validator.rb) as a point of reference for this. Here is an example:
-
-```ruby
-# ./path/to/file.rb
-class MyValidator
-  include Packwerk::Validator
-  # implement the `Validator` interface
-
-  sig { override.returns(T::Array[String]) }
-  def permitted_keys
-    ['enforce_my_custom_checker']
-  end
-
-  sig { override.params(package_set: PackageSet, configuration: Configuration).returns(ApplicationValidator::Result) }
-  def call(package_set, configuration)
-    # your logic here
-  end
-end
-```
-
-Then, in the `require` directive described above, you'll want to tell `packwerk` about it:
-
-```yml
-require:
-  - ./path/to/file.rb
-```

data/bin/console

@@ -1,15 +0,0 @@
-#!/usr/bin/env ruby
-# frozen_string_literal: true
-
-require "bundler/setup"
-require "packwerk"
-
-# You can add fixtures and/or initialization code here to make experimenting
-# with your gem easier. You can also use a different console, if you like.
-
-# (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
-# Pry.start
-
-require "irb"
-IRB.start(__FILE__)

data/bin/m

@@ -1,29 +0,0 @@
-#!/usr/bin/env ruby
-# frozen_string_literal: true
-
-#
-# This file was generated by Bundler.
-#
-# The application 'm' is installed as part of a gem, and
-# this file is here to facilitate running it.
-#
-
-require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
-
-bundle_binstub = File.expand_path("../bundle", __FILE__)
-
-if File.file?(bundle_binstub)
-  if /This file was generated by Bundler/.match?(File.read(bundle_binstub, 300))
-    load(bundle_binstub)
-  else
-    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
-Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
-  end
-end
-
-require "rubygems"
-require "bundler/setup"
-
-load Gem.bin_path("m", "m")

data/bin/rake

@@ -1,29 +0,0 @@
-#!/usr/bin/env ruby
-# frozen_string_literal: true
-
-#
-# This file was generated by Bundler.
-#
-# The application 'rake' is installed as part of a gem, and
-# this file is here to facilitate running it.
-#
-
-require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
-
-bundle_binstub = File.expand_path("../bundle", __FILE__)
-
-if File.file?(bundle_binstub)
-  if /This file was generated by Bundler/.match?(File.read(bundle_binstub, 300))
-    load(bundle_binstub)
-  else
-    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
-Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
-  end
-end
-
-require "rubygems"
-require "bundler/setup"
-
-load Gem.bin_path("rake", "rake")

data/bin/rubocop

@@ -1,29 +0,0 @@
-#!/usr/bin/env ruby
-# frozen_string_literal: true
-
-#
-# This file was generated by Bundler.
-#
-# The application 'rubocop' is installed as part of a gem, and
-# this file is here to facilitate running it.
-#
-
-require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
-
-bundle_binstub = File.expand_path("../bundle", __FILE__)
-
-if File.file?(bundle_binstub)
-  if /This file was generated by Bundler/.match?(File.read(bundle_binstub, 300))
-    load(bundle_binstub)
-  else
-    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
-Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
-  end
-end
-
-require "rubygems"
-require "bundler/setup"
-
-load Gem.bin_path("rubocop", "rubocop")

data/bin/setup

@@ -1,8 +0,0 @@
-#!/usr/bin/env bash
-set -euo pipefail
-IFS=$'\n\t'
-set -vx
-
-bundle install
-
-# Do any other automated setup that you need to do here

data/bin/srb

@@ -1,29 +0,0 @@
-#!/usr/bin/env ruby
-# frozen_string_literal: true
-
-#
-# This file was generated by Bundler.
-#
-# The application 'srb' is installed as part of a gem, and
-# this file is here to facilitate running it.
-#
-
-require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
-
-bundle_binstub = File.expand_path("../bundle", __FILE__)
-
-if File.file?(bundle_binstub)
-  if /This file was generated by Bundler/.match?(File.read(bundle_binstub, 300))
-    load(bundle_binstub)
-  else
-    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
-Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
-  end
-end
-
-require "rubygems"
-require "bundler/setup"
-
-load Gem.bin_path("sorbet", "srb")

data/bin/tapioca

@@ -1,29 +0,0 @@
-#!/usr/bin/env ruby
-# frozen_string_literal: true
-
-#
-# This file was generated by Bundler.
-#
-# The application 'tapioca' is installed as part of a gem, and
-# this file is here to facilitate running it.
-#
-
-require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
-
-bundle_binstub = File.expand_path("../bundle", __FILE__)
-
-if File.file?(bundle_binstub)
-  if /This file was generated by Bundler/.match?(File.read(bundle_binstub, 300))
-    load(bundle_binstub)
-  else
-    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
-Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
-  end
-end
-
-require "rubygems"
-require "bundler/setup"
-
-load Gem.bin_path("tapioca", "tapioca")

data/dev.yml

@@ -1,32 +0,0 @@
-name: packwerk
-
-type: ruby
-
-up:
-  - ruby: 3.2.1
-  - bundler
-
-commands:
-  test:
-    run: |
-      if [[ "$*" =~ ":"[0-9]+ ]];
-      then
-        # run test by its line number
-        bin/m "$@"
-      elif [[ "$#" -eq 1 && -f "$1" ]];
-      then
-        # run all tests in given file(s)
-        bin/rake test TEST="$@"
-      else
-        # run all tests
-        bin/rake test
-      fi
-  style: "bin/rubocop -D --auto-correct"
-  typecheck:
-    desc: "run Sorbet typechecking"
-    run: "bin/srb tc"
-    aliases: ['tc']
-    subcommands:
-      update:
-        desc: "update RBIs for gems"
-        run: "bin/tapioca sync -c 'dev typecheck update'"

data/gemfiles/Gemfile-rails-6-0

@@ -1,22 +0,0 @@
-# frozen_string_literal: true
-
-source("https://rubygems.org")
-
-gemspec path: ".."
-
-# Specify the same dependency sources as the application Gemfile
-
-gem("spring")
-gem("rails", "~> 6.0.0")
-gem("constant_resolver", require: false)
-gem("sorbet-runtime", require: false)
-gem("rubocop-performance", require: false)
-gem("rubocop-sorbet", require: false)
-gem("mocha", require: false)
-gem("rubocop-shopify", require: false)
-gem("tapioca", require: false)
-
-group :development do
-  gem("byebug", require: false)
-  gem("minitest-focus", require: false)
-end

data/gemfiles/Gemfile-rails-6-1

@@ -1,22 +0,0 @@
-# frozen_string_literal: true
-
-source("https://rubygems.org")
-
-gemspec path: ".."
-
-# Specify the same dependency sources as the application Gemfile
-
-gem("spring")
-gem("rails", "~> 6.1")
-gem("constant_resolver", require: false)
-gem("sorbet-runtime", require: false)
-gem("rubocop-performance", require: false)
-gem("rubocop-sorbet", require: false)
-gem("mocha", require: false)
-gem("rubocop-shopify", require: false)
-gem("tapioca", require: false)
-
-group :development do
-  gem("byebug", require: false)
-  gem("minitest-focus", require: false)
-end

data/lib/packwerk/cli/result.rb

@@ -1,11 +0,0 @@
-# typed: strict
-# frozen_string_literal: true
-
-module Packwerk
-  class Cli
-    class Result < T::Struct
-      const :message, String
-      const :status, T::Boolean
-    end
-  end
-end