packwerk 2.2.0 → 2.2.2

data/README.md

@@ -66,7 +66,7 @@ Various third parties have built tooling on top of packwerk. Here's a selection
 - https://github.com/bellroy/graphwerk draws a graph of your package dependencies
 - https://github.com/Gusto/packwerk-vscode integrates packwerk into Visual Studio Code so you can see violations right in your editor
 - https://github.com/Gusto/stimpack sets up Rails autoloading, as well as `rspec` and `FactoryBot` integration, for packages arranged in a flat list. Stimpack is quite convenient, but for autoloading we recommend to use `Rails::Engine`s instead.
-- https://github.com/BigRails/danger-packwerk integrates packwerk with [danger.systems](https://danger.systems) to provide packwerk feedback as Github inline PR comments
+- https://github.com/rubyatscale/danger-packwerk integrates packwerk with [danger.systems](https://danger.systems) to provide packwerk feedback as Github inline PR comments
 
 ## Development
 

data/RESOLVING_VIOLATIONS.md

@@ -0,0 +1,81 @@
+# Resolving Violations
+
+Violations can be [recorded as a deprecation](#recording-violations) or (better!) [eliminated](#eliminating-violations).
+
+## Recording Violations
+💡 New privacy and dependency violations are never hard-blocked. There are many very valid reasons to run `bin/packwerk update-deprecations`, adding new violations to `deprecated_references.yml` files. Even if you feel your reason might not be "valid," if your judgement says adding the violation and shipping your change will produce positive impact, trust your gut.
+
+### Emergency Fixes
+❔ Is it a revert or is there a lot of urgency because you are fixing a production bug impacting customers?
+
+➡️ Simply run `bin/packwerk update-deprecations`, and address the violation when the customer issue is resolved.
+
+### Improving System Design
+❔ Are you improving system boundaries by renaming or moving a file, class, constant,` or module?
+
+➡️ Simply run `bin/packwerk update-deprecations`. We've improved how our system is organized, so the new violations are natural.
+
+### Making Things Explicit
+❔ Are you making something that was implicit (hidden to Packwerk) explicit, such as adding a Sorbet signature, using a class instead of a method call, or something similar?
+
+➡️ Simply run `bin/packwerk update-deprecations`. Making something implicit explicit and capturing that as a new violation is a strict improvement.
+
+### Temporary State
+❔ Is the violation temporary because you will soon delete the code or is it part of a refactor to improve system boundaries and reduce violations overall?
+
+➡️ Simply run `bin/packwerk update-deprecations`. Sometimes things get "worse" before they get better.
+
+### Delivering Features
+❔ Are you in a rush to get a feature out and product, your manager, or an internal sense of urgency has made you feel like you can't resolve system design issues?
+
+➡️ Stay strong. Eliminate the violation. It is important to build a sustainable business that optimizes for the long-term. Look for advocates such as from mentors or within your team who can help you justify improving system design.
+
+## Eliminating Violations
+💡 Dependency and privacy violations are Packwerk's signal that what we've stated about the desired system design (what
+packages exist and what lives in them, the dependencies in a package.yml, and the public interface in the package's public folder) doesn't match the reality of our system.
+If what we've stated about our system design doesn't feel right, then the violations won't make sense either! Make sure to think through system design before addressing a violation.
+
+### Moving Things Around
+❔ Does the code you're writing (or changing) live in the right package? Does the code you're referencing live in the right package?
+
+If not, find a better place for it to live.
+
+Otherwise, follow the guide for eliminating [Privacy Violations](#privacy-violations) or [Dependency Violations](#dependency-violations).
+
+### Privacy Violations
+💡  Packwerk thinks something is a privacy violation if you're referencing a constant, class, or module defined in the private implementation (i.e. not the public folder) of another package. We care about these because we want to make sure we only use parts of a package that have been exposed as public API.
+
+An explicit and implementation-hiding public API is a cornerstone of well-modularized code.
+
+#### Use Existing Public Interface
+❔ Does the package you're using expose public API in its public folder that supports your use case?
+
+➡️ Use that public API instead!
+
+#### Change The Public Interface
+❔ Can we work with the package's owner to create and use a public API? Or should the thing we're using already be public?
+
+➡️  Work together on a new public API and use that instead! If the thing we're using should be public, move it to the public folder to make it public!
+
+⛈️ If working with the package's owner to improve the API is not possible, run `bin/packwerk update-deprecations`. Add some context to your PR about why it's not possible.
+
+### Dependency Violations
+💡  Packwerk thinks something is a dependency violation if you're referencing a constant, class, module defined ANYWHERE but your package doesn't list it as an explicit dependency in its `package.yml`. We care about these because it allows us to be systematically intentional about what our code needs to run and helps us untangle and remove dependency cycles from our system.
+
+Thoughtful dependency management is another cornerstone of well-modularized code.
+
+#### Adding Explicit Dependencies
+❔ Do we actually want to depend on the other package? Work with your team to help answer this question!
+
+➡️  Add the other package to your package's `package.yml` `dependencies` key.
+
+⁉️ Did you get a cyclic dependency when CI ran `bin/packwerk validate`?
+
+➡️  Work with your team to think through what link in the cycle we don't want. Remove that link and rerun `bin/packwerk validate`.
+
+#### Changing The System Design
+❔ Can we spend some time to think through changes to the system design that don't require the dependency?
+
+➡️  Work with the owners of the relevant packages, as well as your team, to think through a design that doesn't include the unwanted dependency.
+
+⛈️ If this is not possible within the scope of your changes (think hard about this one!), run `bin/packwerk update-deprecations`. Add some context to your PR about why it's not possible, and any additional context you may have, such as a possible solution.

data/Rakefile

@@ -7,7 +7,7 @@ Rake::TestTask.new(:test) do |t|
   t.libs << "test"
   t.libs << "lib"
   t.test_files = FileList["test/**/*_test.rb"]
-  t.warning = true
+  t.warning = false
 end
 
 task(default: :test)

data/USAGE.md

@@ -17,6 +17,8 @@
     * [Using public folders](#using-public-folders)
   * [Enforcing dependency boundary](#enforcing-dependency-boundary)
 * [Checking for violations](#checking-for-violations)
+* [Resolving new violations](#resolving-new-violations)
+  * [Understanding how to respond to new violations](#understanding-how-to-respond-to-new-violations)
 * [Recording existing violations](#recording-existing-violations)
   * [Understanding the list of deprecated references](#understanding-the-list-of-deprecated-references)
 
@@ -54,7 +56,7 @@ Here is a list of files generated:
 
 | File                        | Location     | Description |
 |-----------------------------|--------------|------------|
-| Packwerk configuration      | packwerk.yml | See [Setting up the configuration file](#Setting-up-the-configuration-file) |
+| Packwerk configuration      | packwerk.yml | See [Setting up the configuration file](#configuring-packwerk) |
 | Root package                | package.yml  | A package for the root folder |
 
 After that, you may begin creating packages for your application. See [Defining packages](#Defining-packages)
@@ -115,7 +117,7 @@ We recommend setting up the package system validation for your Rails application
 
 Use the following command to validate the application:
 
-    packwerk validate
+    bin/packwerk validate
 
 ![](static/packwerk_validate.gif)
 
@@ -204,17 +206,17 @@ It will be a dependency violation when `components/shop_identity` tries to refer
 
 After enforcing the boundary checks for a package, you may execute:
 
-    packwerk check
+    bin/packwerk check
 
 Packwerk will check the entire codebase for any new or stale violations.
 
 You can also specify folders for a shorter run time. When checking against folders all subfolders will be analyzed, irrespective of nested package boundaries.
 
-    packwerk check components/your_package
+    bin/packwerk check components/your_package
 
 You can also specify packages for a shorter run time. When checking against packages any packages nested underneath the specified packages will not be checked. This can be helpful to test packages like the root package, which can have many nested packages.
 
-    packwerk check --packages=components/your_package,components/your_other_package
+    bin/packwerk check --packages=components/your_package,components/your_other_package
 
 ![](static/packwerk_check.gif)
 
@@ -222,6 +224,13 @@ In order to keep the package system valid at each version of the application, we
 
 See: [TROUBLESHOOT.md - Sample violations](TROUBLESHOOT.md#Sample-violations)
 
+## Resolving new violations
+### Understanding how to respond to new violations
+
+When you have a new dependency or privacy violation, what do you do?
+
+See: [RESOLVING_VIOLATIONS.md](RESOLVING_VIOLATIONS.md)
+
 ## Recording existing violations
 
 For existing codebases, packages are likely to have existing boundary violations.

data/bin/m

@@ -15,7 +15,7 @@ ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
 bundle_binstub = File.expand_path("../bundle", __FILE__)
 
 if File.file?(bundle_binstub)
-  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+  if /This file was generated by Bundler/.match?(File.read(bundle_binstub, 300))
     load(bundle_binstub)
   else
     abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.

data/bin/rake

@@ -15,7 +15,7 @@ ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
 bundle_binstub = File.expand_path("../bundle", __FILE__)
 
 if File.file?(bundle_binstub)
-  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+  if /This file was generated by Bundler/.match?(File.read(bundle_binstub, 300))
     load(bundle_binstub)
   else
     abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.

data/bin/rubocop

@@ -15,7 +15,7 @@ ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
 bundle_binstub = File.expand_path("../bundle", __FILE__)
 
 if File.file?(bundle_binstub)
-  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+  if /This file was generated by Bundler/.match?(File.read(bundle_binstub, 300))
     load(bundle_binstub)
   else
     abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.

data/bin/srb

@@ -15,7 +15,7 @@ ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
 bundle_binstub = File.expand_path("../bundle", __FILE__)
 
 if File.file?(bundle_binstub)
-  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+  if /This file was generated by Bundler/.match?(File.read(bundle_binstub, 300))
     load(bundle_binstub)
   else
     abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.

data/bin/tapioca

@@ -15,7 +15,7 @@ ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
 bundle_binstub = File.expand_path("../bundle", __FILE__)
 
 if File.file?(bundle_binstub)
-  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+  if /This file was generated by Bundler/.match?(File.read(bundle_binstub, 300))
     load(bundle_binstub)
   else
     abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.

data/gemfiles/Gemfile-rails-6-0

@@ -7,7 +7,7 @@ gemspec path: ".."
 # Specify the same dependency sources as the application Gemfile
 
 gem("spring")
-gem("rails", '~> 6.0.0')
+gem("rails", "~> 6.0.0")
 gem("constant_resolver", require: false)
 gem("sorbet-runtime", require: false)
 gem("rubocop-performance", require: false)

data/gemfiles/Gemfile-rails-6-1

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+source("https://rubygems.org")
+
+gemspec path: ".."
+
+# Specify the same dependency sources as the application Gemfile
+
+gem("spring")
+gem("rails", "~> 6.1.0")
+gem("constant_resolver", require: false)
+gem("sorbet-runtime", require: false)
+gem("rubocop-performance", require: false)
+gem("rubocop-sorbet", require: false)
+gem("mocha", require: false)
+gem("rubocop-shopify", require: false)
+gem("tapioca", require: false)
+
+group :development do
+  gem("byebug", require: false)
+  gem("minitest-focus", require: false)
+end

data/lib/packwerk/application_load_paths.rb

@@ -21,7 +21,7 @@ module Packwerk
       sig { returns(T::Hash[String, Module]) }
       def extract_application_autoload_paths
         Rails.autoloaders.inject({}) do |h, loader|
-          h.merge(loader.root_dirs)
+          h.merge(loader.dirs(namespaces: true))
         end
       end
 

data/lib/packwerk/application_validator.rb

@@ -66,6 +66,7 @@ module Packwerk
 
       privacy_settings.each do |config_file_path, setting|
         next unless setting.is_a?(Array)
+
         constants = setting
 
         results += assert_constants_can_be_loaded(constants, config_file_path)
@@ -92,7 +93,7 @@ module Packwerk
         hash = YAML.load_file(f)
         next unless hash
 
-        known_keys = %w(enforce_privacy enforce_dependencies public_path dependencies metadata)
+        known_keys = ["enforce_privacy", "enforce_dependencies", "public_path", "dependencies", "metadata"]
         unknown_keys = hash.keys - known_keys
 
         unless unknown_keys.empty?
@@ -309,7 +310,7 @@ module Packwerk
           Result.new(
             ok: false,
             error_value: "'#{constant}', listed in the 'enforce_privacy' option in #{config_file_path}, is invalid.\n"\
-            "Private constants need to be prefixed with the top-level namespace operator `::`."
+              "Private constants need to be prefixed with the top-level namespace operator `::`."
           )
         else
           constant.try(&:constantize) && Result.new(ok: true)
@@ -324,9 +325,9 @@ module Packwerk
       Result.new(
         ok: false,
         error_value: "'#{name}', listed in #{config_file_path}, could not be resolved.\n"\
-        "This is probably because it is an autovivified namespace - a namespace module that doesn't have a\n"\
-        "file explicitly defining it. Packwerk currently doesn't support declaring autovivified namespaces as\n"\
-        "private. Add a #{explicit_filepath} file to explicitly define the constant."
+          "This is probably because it is an autovivified namespace - a namespace module that doesn't have a\n"\
+          "file explicitly defining it. Packwerk currently doesn't support declaring autovivified namespaces as\n"\
+          "private. Add a #{explicit_filepath} file to explicitly define the constant."
       )
     end
 
@@ -341,7 +342,7 @@ module Packwerk
         Result.new(
           ok: false,
           error_value: "'#{name}' is declared as private in the '#{declared_package}' package but appears to be "\
-          "defined\nin the '#{constant_package}' package. Packwerk resolved it to #{location}."
+            "defined\nin the '#{constant_package}' package. Packwerk resolved it to #{location}."
         )
       end
     end

data/lib/packwerk/association_inspector.rb

@@ -10,12 +10,12 @@ module Packwerk
     CustomAssociations = T.type_alias { T.any(T::Array[Symbol], T::Set[Symbol]) }
 
     RAILS_ASSOCIATIONS = T.let(
-      %i(
-        belongs_to
-        has_many
-        has_one
-        has_and_belongs_to_many
-      ).to_set,
+      [
+        :belongs_to,
+        :has_many,
+        :has_one,
+        :has_and_belongs_to_many,
+      ].to_set,
       CustomAssociations
     )
 
@@ -31,15 +31,16 @@ module Packwerk
         .returns(T.nilable(String))
     end
     def constant_name_from_node(node, ancestors:)
-      return unless Node.method_call?(node)
+      return unless NodeHelpers.method_call?(node)
       return unless association?(node)
 
-      arguments = Node.method_arguments(node)
+      arguments = NodeHelpers.method_arguments(node)
       return unless (association_name = association_name(arguments))
 
       if (class_name_node = custom_class_name(arguments))
-        return unless Node.string?(class_name_node)
-        Node.literal_value(class_name_node)
+        return unless NodeHelpers.string?(class_name_node)
+
+        NodeHelpers.literal_value(class_name_node)
       else
         @inflector.classify(association_name.to_s)
       end
@@ -49,23 +50,24 @@ module Packwerk
 
     sig { params(node: AST::Node).returns(T::Boolean) }
     def association?(node)
-      method_name = Node.method_name(node)
+      method_name = NodeHelpers.method_name(node)
       @associations.include?(method_name)
     end
 
     sig { params(arguments: T::Array[AST::Node]).returns(T.nilable(AST::Node)) }
     def custom_class_name(arguments)
-      association_options = arguments.detect { |n| Node.hash?(n) }
+      association_options = arguments.detect { |n| NodeHelpers.hash?(n) }
       return unless association_options
 
-      Node.value_from_hash(association_options, :class_name)
+      NodeHelpers.value_from_hash(association_options, :class_name)
     end
 
     sig { params(arguments: T::Array[AST::Node]).returns(T.any(T.nilable(Symbol), T.nilable(String))) }
     def association_name(arguments)
-      return unless Node.symbol?(arguments[0])
+      association_name_node = T.must(arguments[0])
+      return unless NodeHelpers.symbol?(association_name_node)
 
-      Node.literal_value(arguments[0])
+      NodeHelpers.literal_value(association_name_node)
     end
   end
 end

data/lib/packwerk/cache.rb

@@ -1,5 +1,5 @@
-# frozen_string_literal: true
 # typed: strict
+# frozen_string_literal: true
 
 require "digest"
 
@@ -13,31 +13,35 @@ module Packwerk
       const :file_contents_digest, String
       const :unresolved_references, T::Array[UnresolvedReference]
 
-      sig { returns(String) }
-      def serialize
-        to_json
-      end
-
-      sig { params(serialized_cache_contents: String).returns(CacheContents) }
-      def self.deserialize(serialized_cache_contents)
-        cache_contents_json = JSON.parse(serialized_cache_contents)
-        unresolved_references = cache_contents_json["unresolved_references"].map do |json|
-          UnresolvedReference.new(
-            json["constant_name"],
-            json["namespace_path"],
-            json["relative_path"],
-            Node::Location.new(json["source_location"]["line"], json["source_location"]["column"],)
+      class << self
+        extend T::Sig
+
+        sig { params(serialized_cache_contents: String).returns(CacheContents) }
+        def deserialize(serialized_cache_contents)
+          cache_contents_json = JSON.parse(serialized_cache_contents)
+          unresolved_references = cache_contents_json["unresolved_references"].map do |json|
+            UnresolvedReference.new(
+              json["constant_name"],
+              json["namespace_path"],
+              json["relative_path"],
+              Node::Location.new(json["source_location"]["line"], json["source_location"]["column"],)
+            )
+          end
+
+          CacheContents.new(
+            file_contents_digest: cache_contents_json["file_contents_digest"],
+            unresolved_references: unresolved_references,
           )
         end
+      end
 
-        CacheContents.new(
-          file_contents_digest: cache_contents_json["file_contents_digest"],
-          unresolved_references: unresolved_references,
-        )
+      sig { returns(String) }
+      def serialize
+        to_json
       end
     end
 
-    CACHE_SHAPE = T.type_alias do
+    CacheShape = T.type_alias do
       T::Hash[
         String,
         CacheContents
@@ -47,7 +51,7 @@ module Packwerk
     sig { params(enable_cache: T::Boolean, cache_directory: Pathname, config_path: T.nilable(String)).void }
     def initialize(enable_cache:, cache_directory:, config_path:)
       @enable_cache = enable_cache
-      @cache = T.let({}, CACHE_SHAPE)
+      @cache = T.let({}, CacheShape)
       @files_by_digest = T.let({}, T::Hash[String, String])
       @config_path = config_path
       @cache_directory = cache_directory
@@ -71,7 +75,7 @@ module Packwerk
       ).returns(T::Array[UnresolvedReference])
     end
     def with_cache(file_path, &block)
-      return block.call unless @enable_cache
+      return yield unless @enable_cache
 
       cache_location = @cache_directory.join(digest_for_string(file_path))
 
@@ -89,7 +93,7 @@ module Packwerk
       else
         Debug.out("Cache miss for #{file_path}")
 
-        unresolved_references = block.call
+        unresolved_references = yield
 
         cache_contents = CacheContents.new(
           file_contents_digest: file_contents_digest,
@@ -116,6 +120,7 @@ module Packwerk
     sig { void }
     def bust_cache_if_packwerk_yml_has_changed!
       return nil if @config_path.nil?
+
       bust_cache_if_contents_have_changed(File.read(@config_path), :packwerk_yml)
     end
 
@@ -155,14 +160,16 @@ module Packwerk
   end
 
   class Debug
-    extend T::Sig
+    class << self
+      extend T::Sig
 
-    sig { params(out: String).void }
-    def self.out(out)
-      if ENV["DEBUG_PACKWERK_CACHE"]
-        puts(out)
+      sig { params(out: String).void }
+      def out(out)
+        if ENV["DEBUG_PACKWERK_CACHE"]
+          puts(out)
+        end
       end
-    end
+  end
   end
 
   private_constant :Debug

data/lib/packwerk/cli.rb

@@ -50,8 +50,6 @@ module Packwerk
       case subcommand
       when "init"
         init
-      when "generate_configs"
-        generate_configs
       when "check"
         output_result(parse_run(args).check)
       when "detect-stale-violations"
@@ -61,20 +59,11 @@ module Packwerk
       when "validate"
         validate(args)
       when nil, "help"
-        @err_out.puts(<<~USAGE)
-          Usage: #{$PROGRAM_NAME} <subcommand>
-
-          Subcommands:
-            init - set up packwerk
-            check - run all checks
-            update - update deprecated references (deprecated, use update-deprecations instead)
-            update-deprecations - update deprecated references
-            validate - verify integrity of packwerk and package configuration
-            help  - display help information about packwerk
-        USAGE
-        true
+        usage
       else
-        @err_out.puts("'#{subcommand}' is not a packwerk command. See `packwerk help`.")
+        @err_out.puts(
+          "'#{subcommand}' is not a packwerk command. See `packwerk help`."
+        )
         false
       end
     end
@@ -117,6 +106,21 @@ module Packwerk
       success
     end
 
+    sig { returns(T::Boolean) }
+    def usage
+      @err_out.puts(<<~USAGE)
+        Usage: #{$PROGRAM_NAME} <subcommand>
+
+        Subcommands:
+          init - set up packwerk
+          check - run all checks
+          update-deprecations - update deprecated_references.yml files
+          validate - verify integrity of packwerk and package configuration
+          help  - display help information about packwerk
+      USAGE
+      true
+    end
+
     sig { params(result: Result).returns(T::Boolean) }
     def output_result(result)
       @out.puts
@@ -128,17 +132,17 @@ module Packwerk
       params(
         relative_file_paths: T::Array[String],
         ignore_nested_packages: T::Boolean
-      ).returns(FilesForProcessing::AbsoluteFileSet)
+      ).returns(FilesForProcessing::RelativeFileSet)
     end
     def fetch_files_to_process(relative_file_paths, ignore_nested_packages)
-      absolute_file_set = FilesForProcessing.fetch(
+      relative_file_set = FilesForProcessing.fetch(
         relative_file_paths: relative_file_paths,
         ignore_nested_packages: ignore_nested_packages,
         configuration: @configuration
       )
       abort("No files found or given. "\
-        "Specify files or check the include and exclude glob in the config file.") if absolute_file_set.empty?
-      absolute_file_set
+        "Specify files or check the include and exclude glob in the config file.") if relative_file_set.empty?
+      relative_file_set
     end
 
     sig { params(_paths: T::Array[String]).returns(T::Boolean) }
@@ -190,7 +194,7 @@ module Packwerk
       end
 
       ParseRun.new(
-        absolute_file_set: fetch_files_to_process(relative_file_paths, ignore_nested_packages),
+        relative_file_set: fetch_files_to_process(relative_file_paths, ignore_nested_packages),
         configuration: @configuration,
         progress_formatter: @progress_formatter,
         offenses_formatter: @offenses_formatter

data/lib/packwerk/const_node_inspector.rb

@@ -13,7 +13,8 @@ module Packwerk
         .returns(T.nilable(String))
     end
     def constant_name_from_node(node, ancestors:)
-      return nil unless Node.constant?(node)
+      return nil unless NodeHelpers.constant?(node)
+
       parent = ancestors.first
 
       # Only process the root `const` node for namespaced constant references. For example, in the
@@ -24,8 +25,8 @@ module Packwerk
         fully_qualify_constant(ancestors)
       else
         begin
-          Node.constant_name(node)
-        rescue Node::TypeError
+          NodeHelpers.constant_name(node)
+        rescue NodeHelpers::TypeError
           nil
         end
       end
@@ -35,20 +36,20 @@ module Packwerk
 
     sig { params(parent: T.nilable(AST::Node)).returns(T::Boolean) }
     def root_constant?(parent)
-      !(parent && Node.constant?(parent))
+      !(parent && NodeHelpers.constant?(parent))
     end
 
     sig { params(node: AST::Node, parent: AST::Node).returns(T.nilable(T::Boolean)) }
     def constant_in_module_or_class_definition?(node, parent:)
-      parent_name = Node.module_name_from_definition(parent)
-      parent_name && parent_name == Node.constant_name(node)
+      parent_name = NodeHelpers.module_name_from_definition(parent)
+      parent_name && parent_name == NodeHelpers.constant_name(node)
     end
 
     sig { params(ancestors: T::Array[AST::Node]).returns(String) }
     def fully_qualify_constant(ancestors)
       # We're defining a class with this name, in which case the constant is implicitly fully qualified by its
       # enclosing namespace
-      "::" + Node.parent_module_name(ancestors: ancestors)
+      "::" + NodeHelpers.parent_module_name(ancestors: ancestors)
     end
   end
 end

data/lib/packwerk/constant_name_inspector.rb

@@ -12,9 +12,9 @@ module Packwerk
     interface!
 
     sig do
-      params(node: ::AST::Node, ancestors: T::Array[::AST::Node])
+      abstract
+        .params(node: ::AST::Node, ancestors: T::Array[::AST::Node])
         .returns(T.nilable(String))
-        .abstract
     end
     def constant_name_from_node(node, ancestors:); end
   end