packwerk 2.1.0 → 2.1.1

data/lib/packwerk/run_context.rb

@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 require "constant_resolver"
@@ -8,21 +8,17 @@ module Packwerk
   class RunContext
     extend T::Sig
 
-    attr_reader(
-      :root_path,
-      :load_paths,
-      :package_paths,
-      :inflector,
-      :custom_associations,
-      :checker_classes,
-    )
-
-    DEFAULT_CHECKERS = [
-      ::Packwerk::ReferenceChecking::Checkers::DependencyChecker,
-      ::Packwerk::ReferenceChecking::Checkers::PrivacyChecker,
-    ]
+    DEFAULT_CHECKERS = T.let([
+      ::Packwerk::ReferenceChecking::Checkers::DependencyChecker.new,
+      ::Packwerk::ReferenceChecking::Checkers::PrivacyChecker.new,
+    ], T::Array[ReferenceChecking::Checkers::Checker])
 
     class << self
+      extend T::Sig
+
+      sig do
+        params(configuration: Configuration).returns(RunContext)
+      end
       def from_configuration(configuration)
         inflector = ActiveSupport::Inflector
 
@@ -39,36 +35,56 @@ module Packwerk
       end
     end
 
+    sig do
+      params(
+        root_path: String,
+        load_paths: T::Array[String],
+        inflector: T.class_of(ActiveSupport::Inflector),
+        cache_directory: Pathname,
+        config_path: T.nilable(String),
+        package_paths: T.nilable(T.any(T::Array[String], String)),
+        custom_associations: AssociationInspector::CustomAssociations,
+        checkers: T::Array[ReferenceChecking::Checkers::Checker],
+        cache_enabled: T::Boolean,
+      ).void
+    end
     def initialize(
       root_path:,
       load_paths:,
+      inflector:,
+      cache_directory:,
+      config_path: nil,
       package_paths: nil,
-      inflector: nil,
       custom_associations: [],
-      checker_classes: DEFAULT_CHECKERS,
-      cache_enabled: false,
-      cache_directory: nil,
-      config_path: nil
+      checkers: DEFAULT_CHECKERS,
+      cache_enabled: false
     )
       @root_path = root_path
       @load_paths = load_paths
       @package_paths = package_paths
       @inflector = inflector
       @custom_associations = custom_associations
-      @checker_classes = checker_classes
+      @checkers = checkers
       @cache_enabled = cache_enabled
       @cache_directory = cache_directory
       @config_path = config_path
+
+      @file_processor = T.let(nil, T.nilable(FileProcessor))
+      @context_provider = T.let(nil, T.nilable(ConstantDiscovery))
+      # We need to initialize this before we fork the process, see https://github.com/Shopify/packwerk/issues/182
+      @cache = T.let(
+        Cache.new(enable_cache: @cache_enabled, cache_directory: @cache_directory, config_path: @config_path), Cache
+      )
     end
 
-    sig { params(file: String).returns(T::Array[Packwerk::Offense]) }
-    def process_file(file:)
-      unresolved_references_and_offenses = file_processor.call(file)
+    sig { params(absolute_file: String).returns(T::Array[Packwerk::Offense]) }
+    def process_file(absolute_file:)
+      unresolved_references_and_offenses = file_processor.call(absolute_file)
       references_and_offenses = ReferenceExtractor.get_fully_qualified_references_and_offenses_from(
         unresolved_references_and_offenses,
         context_provider
       )
-      reference_checker = ReferenceChecking::ReferenceChecker.new(checkers)
+      reference_checker = ReferenceChecking::ReferenceChecker.new(@checkers)
       references_and_offenses.flat_map { |reference| reference_checker.call(reference) }
     end
 
@@ -76,14 +92,14 @@ module Packwerk
 
     sig { returns(FileProcessor) }
     def file_processor
-      @file_processor ||= FileProcessor.new(node_processor_factory: node_processor_factory, cache: cache)
+      @file_processor ||= FileProcessor.new(node_processor_factory: node_processor_factory, cache: @cache)
     end
 
     sig { returns(NodeProcessorFactory) }
     def node_processor_factory
       NodeProcessorFactory.new(
         context_provider: context_provider,
-        root_path: root_path,
+        root_path: @root_path,
         constant_name_inspectors: constant_name_inspectors
       )
     end
@@ -99,32 +115,22 @@ module Packwerk
     sig { returns(ConstantResolver) }
     def resolver
       ConstantResolver.new(
-        root_path: root_path,
-        load_paths: load_paths,
-        inflector: inflector,
+        root_path: @root_path,
+        load_paths: @load_paths,
+        inflector: @inflector,
       )
     end
 
-    sig { returns(Cache) }
-    def cache
-      @cache ||= Cache.new(enable_cache: @cache_enabled, cache_directory: @cache_directory, config_path: @config_path)
-    end
-
     sig { returns(PackageSet) }
     def package_set
-      ::Packwerk::PackageSet.load_all_from(root_path, package_pathspec: package_paths)
-    end
-
-    sig { returns(T::Array[ReferenceChecking::Checkers::Checker]) }
-    def checkers
-      checker_classes.map(&:new)
+      ::Packwerk::PackageSet.load_all_from(@root_path, package_pathspec: @package_paths)
     end
 
     sig { returns(T::Array[ConstantNameInspector]) }
     def constant_name_inspectors
       [
         ::Packwerk::ConstNodeInspector.new,
-        ::Packwerk::AssociationInspector.new(inflector: inflector, custom_associations: custom_associations),
+        ::Packwerk::AssociationInspector.new(inflector: @inflector, custom_associations: @custom_associations),
       ]
     end
   end

data/lib/packwerk/spring_command.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# typed: false
+# typed: true
 
 require "spring/commands"
 

data/lib/packwerk/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module Packwerk
-  VERSION = "2.1.0"
+  VERSION = "2.1.1"
 end

data/sorbet/config

@@ -1,2 +1,3 @@
 --dir
 .
+--enable-experimental-requires-ancestor

data/sorbet/rbi/gems/tapioca@0.4.19.rbi

@@ -562,7 +562,7 @@ module Tapioca::GenericTypeRegistry
     def name_of(constant); end
     sig { params(object: BasicObject).returns(Integer) }
     def object_id_of(object); end
-    sig { params(constant: T.untyped, type_variable_type: T.enum([:type_member, :type_template]), type_variable: T::Types::TypeVariable, fixed: T.untyped, lower: T.untyped, upper: T.untyped).void }
+    sig { params(constant: T.untyped, type_variable_type: T.deprecated_enum([:type_member, :type_template]), type_variable: T::Types::TypeVariable, fixed: T.untyped, lower: T.untyped, upper: T.untyped).void }
     def register_type_variable(constant, type_variable_type, type_variable, fixed, lower, upper); end
     sig { params(type_variable_type: Symbol, variance: Symbol, fixed: T.untyped, lower: T.untyped, upper: T.untyped).returns(String) }
     def serialize_type_variable(type_variable_type, variance, fixed, lower, upper); end

data/sorbet/tapioca/require.rb

@@ -3,7 +3,7 @@
 # This is an autogenerated file for explicit gem requires.
 # Please instead update this file by running `tapioca require`.
 
-# typed: false
+# typed: strict
 
 require "ast"
 require "ast/node"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: packwerk
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Shopify Inc.
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-02-16 00:00:00.000000000 Z
+date: 2022-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -269,6 +269,7 @@ files:
 - lib/packwerk/parsers.rb
 - lib/packwerk/parsers/erb.rb
 - lib/packwerk/parsers/factory.rb
+- lib/packwerk/parsers/parser_interface.rb
 - lib/packwerk/parsers/ruby.rb
 - lib/packwerk/reference.rb
 - lib/packwerk/reference_checking/checkers/checker.rb