packwerk 1.1.2 → 1.1.3

data/lib/packwerk.rb

@@ -4,6 +4,7 @@
 require "sorbet-runtime"
 require "active_support"
 require "constant_resolver"
+require "fileutils"
 
 require "packwerk/offense"
 

data/lib/packwerk/application_validator.rb

@@ -101,26 +101,26 @@ module Packwerk
 
         if hash.key?("enforce_privacy")
           unless [TrueClass, FalseClass, Array].include?(hash["enforce_privacy"].class)
-            errors << "Invalid 'enforce_privacy' option in #{f.inspect}: #{hash['enforce_privacy'].inspect}"
+            errors << "Invalid 'enforce_privacy' option in #{f.inspect}: #{hash["enforce_privacy"].inspect}"
           end
         end
 
         if hash.key?("enforce_dependencies")
           unless [TrueClass, FalseClass].include?(hash["enforce_dependencies"].class)
-            errors << "Invalid 'enforce_dependencies' option in #{f.inspect}: #{hash['enforce_dependencies'].inspect}"
+            errors << "Invalid 'enforce_dependencies' option in #{f.inspect}: #{hash["enforce_dependencies"].inspect}"
           end
         end
 
         if hash.key?("public_path")
           unless hash["public_path"].is_a?(String)
-            errors << "'public_path' option must be a string in #{f.inspect}: #{hash['public_path'].inspect}"
+            errors << "'public_path' option must be a string in #{f.inspect}: #{hash["public_path"].inspect}"
           end
         end
 
         next unless hash.key?("dependencies")
         next if hash["dependencies"].is_a?(Array)
 
-        errors << "Invalid 'dependencies' option in #{f.inspect}: #{hash['dependencies'].inspect}"
+        errors << "Invalid 'dependencies' option in #{f.inspect}: #{hash["dependencies"].inspect}"
       end
 
       if errors.empty?
@@ -194,7 +194,7 @@ module Packwerk
       cycle_strings = dependency_graph.cycles.map do |cycle|
         cycle_strings = cycle.map(&:to_s)
         cycle_strings << cycle.first.to_s
-        "\t- #{cycle_strings.join(' → ')}"
+        "\t- #{cycle_strings.join(" → ")}"
       end
 
       if dependency_graph.acyclic?

data/lib/packwerk/node_processor.rb

@@ -25,7 +25,8 @@ module Packwerk
       @checkers = checkers
     end
 
-    def call(node, ancestors:)
+    sig { params(node: Parser::AST::Node, ancestors: T::Array[Parser::AST::Node]).returns(T.nilable(Offense)) }
+    def call(node, ancestors)
       if Node.method_call?(node) || Node.constant?(node)
         reference = @reference_extractor.reference_from_node(node, ancestors: ancestors, file_path: @filename)
         check_reference(reference, node) if reference

data/lib/packwerk/node_visitor.rb

@@ -10,7 +10,7 @@ module Packwerk
     end
 
     def visit(node, ancestors:, result:)
-      offense = @node_processor.call(node, ancestors: ancestors)
+      offense = @node_processor.call(node, ancestors)
       result << offense if offense
 
       child_ancestors = [node] + ancestors

data/lib/packwerk/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module Packwerk
-  VERSION = "1.1.2"
+  VERSION = "1.1.3"
 end

data/library.yml

@@ -3,4 +3,4 @@ name: Packwerk
 stewards:
 - "@Shopify/kernel-architecture-patterns"
 slack_channels:
-- architecture-patterns
+- code-foundations

data/service.yml

@@ -1,6 +1,6 @@
 # https://services.shopify.io/services/packwerk/production
 org_line: Kernel
-owners: Shopify/kernel-architecture-patterns
+owners: Shopify/core-stewardship
 classification: library
 slack_channels:
-  - architecture-patterns
+  - core-stewardship

data/shipit.rubygems.yml

@@ -1 +1,5 @@
-# default configs
+dependencies:
+  override: []
+deploy:
+  override:
+  - release-gem packwerk.gemspec rake release

data/sorbet/rbi/gems/{actioncable@6.1.0.alpha-d80c18a391e33552ae2d943e68af56946f883f65.rbi → actioncable@7.0.0.alpha-d612542336d9a61381311c95a27d801bb4094779.rbi}

@@ -1,6 +1,6 @@
 # DO NOT EDIT MANUALLY
 # This is an autogenerated file for types exported from the `actioncable` gem.
-# Please instead update this file by running `dev typecheck update`.
+# Please instead update this file by running `bin/tapioca sync`.
 
 # typed: true
 
@@ -49,12 +49,12 @@ class ActionCable::Channel::Base
   def _unsubscribe_callbacks; end
   def connection; end
   def identifier; end
-  def logger(*args, &block); end
+  def logger(*_arg0, &_arg1); end
   def params; end
   def perform_action(data); end
-  def periodic_timers=(_); end
+  def periodic_timers=(_arg0); end
   def rescue_handlers; end
-  def rescue_handlers=(_); end
+  def rescue_handlers=(_arg0); end
   def rescue_handlers?; end
   def subscribe_to_channel; end
   def unsubscribe_from_channel; end
@@ -107,8 +107,8 @@ module ActionCable::Channel::Broadcasting
 
   mixes_in_class_methods(::ActionCable::Channel::Broadcasting::ClassMethods)
 
-  def broadcast_to(*args, &block); end
-  def broadcasting_for(*args, &block); end
+  def broadcast_to(*_arg0, &_arg1); end
+  def broadcasting_for(*_arg0, &_arg1); end
 end
 
 module ActionCable::Channel::Broadcasting::ClassMethods
@@ -139,7 +139,7 @@ module ActionCable::Channel::Naming
 
   mixes_in_class_methods(::ActionCable::Channel::Naming::ClassMethods)
 
-  def channel_name(*args, &block); end
+  def channel_name(*_arg0, &_arg1); end
 end
 
 module ActionCable::Channel::Naming::ClassMethods
@@ -167,13 +167,13 @@ end
 module ActionCable::Channel::Streams
   extend(::ActiveSupport::Concern)
 
-  def pubsub(*args, &block); end
+  def pubsub(*_arg0, &_arg1); end
   def stop_all_streams; end
   def stop_stream_for(model); end
   def stop_stream_from(broadcasting); end
   def stream_for(model, callback = T.unsafe(nil), coder: T.unsafe(nil), &block); end
   def stream_from(broadcasting, callback = T.unsafe(nil), coder: T.unsafe(nil), &block); end
-  def stream_or_reject_for(record); end
+  def stream_or_reject_for(model); end
 
   private
 
@@ -194,7 +194,7 @@ class ActionCable::Channel::TestCase < ::ActiveSupport::TestCase
   extend(::ActionCable::Channel::TestCase::Behavior::ClassMethods)
 
   def _channel_class; end
-  def _channel_class=(_); end
+  def _channel_class=(_arg0); end
   def _channel_class?; end
   def connection; end
   def subscription; end
@@ -264,9 +264,9 @@ class ActionCable::Connection::Base
   def close(reason: T.unsafe(nil), reconnect: T.unsafe(nil)); end
   def dispatch_websocket_message(websocket_message); end
   def env; end
-  def event_loop(*args, &block); end
+  def event_loop(*_arg0, &_arg1); end
   def identifiers; end
-  def identifiers=(_); end
+  def identifiers=(_arg0); end
   def identifiers?; end
   def logger; end
   def on_close(reason, code); end
@@ -275,10 +275,10 @@ class ActionCable::Connection::Base
   def on_open; end
   def process; end
   def protocol; end
-  def pubsub(*args, &block); end
+  def pubsub(*_arg0, &_arg1); end
   def receive(websocket_message); end
   def rescue_handlers; end
-  def rescue_handlers=(_); end
+  def rescue_handlers=(_arg0); end
   def rescue_handlers?; end
   def send_async(method, *arguments); end
   def server; end
@@ -438,7 +438,7 @@ class ActionCable::Connection::Subscriptions
   def add(data); end
   def execute_command(data); end
   def identifiers; end
-  def logger(*args, &block); end
+  def logger(*_arg0, &_arg1); end
   def perform_action(data); end
   def remove(data); end
   def remove_subscription(subscription); end
@@ -477,7 +477,7 @@ class ActionCable::Connection::TestCase < ::ActiveSupport::TestCase
   extend(::ActionCable::Connection::TestCase::Behavior::ClassMethods)
 
   def _connection_class; end
-  def _connection_class=(_); end
+  def _connection_class=(_arg0); end
   def _connection_class?; end
   def connection; end
 
@@ -556,7 +556,7 @@ class ActionCable::RemoteConnections::RemoteConnection
 
   def disconnect; end
   def identifiers; end
-  def identifiers=(_); end
+  def identifiers=(_arg0); end
   def identifiers?; end
 
   protected
@@ -593,7 +593,7 @@ class ActionCable::Server::Base
   def connection_identifiers; end
   def disconnect(identifiers); end
   def event_loop; end
-  def logger(*args, &block); end
+  def logger(*_arg0, &_arg1); end
   def mutex; end
   def pubsub; end
   def remote_connections; end
@@ -625,26 +625,26 @@ class ActionCable::Server::Configuration
   def initialize; end
 
   def allow_same_origin_as_host; end
-  def allow_same_origin_as_host=(_); end
+  def allow_same_origin_as_host=(_arg0); end
   def allowed_request_origins; end
-  def allowed_request_origins=(_); end
+  def allowed_request_origins=(_arg0); end
   def cable; end
-  def cable=(_); end
+  def cable=(_arg0); end
   def connection_class; end
-  def connection_class=(_); end
+  def connection_class=(_arg0); end
   def disable_request_forgery_protection; end
-  def disable_request_forgery_protection=(_); end
+  def disable_request_forgery_protection=(_arg0); end
   def log_tags; end
-  def log_tags=(_); end
+  def log_tags=(_arg0); end
   def logger; end
-  def logger=(_); end
+  def logger=(_arg0); end
   def mount_path; end
-  def mount_path=(_); end
+  def mount_path=(_arg0); end
   def pubsub_adapter; end
   def url; end
-  def url=(_); end
+  def url=(_arg0); end
   def worker_pool_size; end
-  def worker_pool_size=(_); end
+  def worker_pool_size=(_arg0); end
 end
 
 module ActionCable::Server::Connections
@@ -659,15 +659,29 @@ ActionCable::Server::Connections::BEAT_INTERVAL = T.let(T.unsafe(nil), Integer)
 
 class ActionCable::Server::Worker
   include(::ActiveSupport::Callbacks)
+  include(::ActionCable::Server::Worker::ActiveRecordConnectionManagement)
   extend(::ActiveSupport::Callbacks::ClassMethods)
   extend(::ActiveSupport::DescendantsTracker)
 
+  def initialize(max_size: T.unsafe(nil)); end
+
   def __callbacks; end
   def __callbacks?; end
   def _run_work_callbacks(&block); end
   def _work_callbacks; end
+  def async_exec(receiver, *args, connection:, &block); end
+  def async_invoke(receiver, method, *args, connection: T.unsafe(nil), &block); end
   def connection; end
   def connection=(obj); end
+  def executor; end
+  def halt; end
+  def invoke(receiver, method, *args, connection:, &block); end
+  def stopping?; end
+  def work(connection); end
+
+  private
+
+  def logger; end
 
   class << self
     def __callbacks; end
@@ -680,6 +694,12 @@ class ActionCable::Server::Worker
   end
 end
 
+module ActionCable::Server::Worker::ActiveRecordConnectionManagement
+  extend(::ActiveSupport::Concern)
+
+  def with_database_connections; end
+end
+
 module ActionCable::SubscriptionAdapter
   extend(::ActiveSupport::Autoload)
 end
@@ -738,8 +758,8 @@ module ActionCable::TestHelper
   def assert_broadcasts(stream, number, &block); end
   def assert_no_broadcasts(stream, &block); end
   def before_setup; end
-  def broadcasts(*args, &block); end
-  def clear_messages(*args, &block); end
+  def broadcasts(*_arg0, &_arg1); end
+  def clear_messages(*_arg0, &_arg1); end
   def pubsub_adapter; end
 
   private
@@ -766,7 +786,7 @@ module ActionCable::Channel::ChannelStub
   def start_periodic_timers; end
   def stop_all_streams; end
   def stop_periodic_timers; end
-  def stream_from(broadcasting, *_); end
+  def stream_from(broadcasting, *_arg1); end
   def streams; end
 end
 
@@ -806,9 +826,9 @@ end
 
 class ActionCable::Connection::TestRequest < ::ActionDispatch::TestRequest
   def cookie_jar; end
-  def cookie_jar=(_); end
+  def cookie_jar=(_arg0); end
   def session; end
-  def session=(_); end
+  def session=(_arg0); end
 end
 
 class ActionCable::SubscriptionAdapter::Async < ::ActionCable::SubscriptionAdapter::Inline
@@ -821,12 +841,12 @@ end
 class ActionCable::SubscriptionAdapter::Async::AsyncSubscriberMap < ::ActionCable::SubscriptionAdapter::SubscriberMap
   def initialize(event_loop); end
 
-  def add_subscriber(*_); end
-  def invoke_callback(*_); end
+  def add_subscriber(*_arg0); end
+  def invoke_callback(*_arg0); end
 end
 
 class ActionCable::SubscriptionAdapter::Inline < ::ActionCable::SubscriptionAdapter::Base
-  def initialize(*_); end
+  def initialize(*_arg0); end
 
   def broadcast(channel, payload); end
   def shutdown; end

data/sorbet/rbi/gems/{actionmailbox@6.1.0.alpha-d80c18a391e33552ae2d943e68af56946f883f65.rbi → actionmailbox@7.0.0.alpha-d612542336d9a61381311c95a27d801bb4094779.rbi}

@@ -1,6 +1,6 @@
 # DO NOT EDIT MANUALLY
 # This is an autogenerated file for types exported from the `actionmailbox` gem.
-# Please instead update this file by running `dev typecheck update`.
+# Please instead update this file by running `bin/tapioca sync`.
 
 # typed: true
 
@@ -55,16 +55,16 @@ class ActionMailbox::Base
   def _process_callbacks; end
   def _run_process_callbacks(&block); end
   def bounce_with(message); end
-  def bounced!(*args, &block); end
-  def delivered!(*args, &block); end
+  def bounced!(*_arg0, &_arg1); end
+  def delivered!(*_arg0, &_arg1); end
   def finished_processing?; end
   def inbound_email; end
-  def logger(*args, &block); end
-  def mail(*args, &block); end
+  def logger(*_arg0, &_arg1); end
+  def mail(*_arg0, &_arg1); end
   def perform_processing; end
   def process; end
   def rescue_handlers; end
-  def rescue_handlers=(_); end
+  def rescue_handlers=(_arg0); end
   def rescue_handlers?; end
   def router; end
   def router=(val); end
@@ -100,28 +100,16 @@ class ActionMailbox::BaseController < ::ActionController::Base
 
   class << self
     def __callbacks; end
-    def _helpers; end
     def middleware_stack; end
   end
 end
 
-module ActionMailbox::BaseController::HelperMethods
-  include(::ActionController::Base::HelperMethods)
-end
-
 class ActionMailbox::Engine < ::Rails::Engine
 end
 
-class ActionMailbox::InboundEmail < ::ActiveRecord::Base
-  include(::ActionMailbox::InboundEmail::Routable)
-  include(::ActionMailbox::InboundEmail::MessageId)
-  include(::ActionMailbox::InboundEmail::Incineratable)
-  extend(::ActionMailbox::InboundEmail::MessageId::ClassMethods)
-
+class ActionMailbox::InboundEmail < ::ActionMailbox::Record
   class << self
-    def __callbacks; end
     def _validators; end
-    def attribute_type_decorations; end
     def defined_enums; end
   end
 end
@@ -155,6 +143,7 @@ module ActionMailbox::InboundEmail::MessageId::ClassMethods
 
   private
 
+  def create_and_upload_raw_email!(source); end
   def extract_message_id(source); end
   def generate_missing_message_id(message_checksum); end
 end
@@ -176,6 +165,13 @@ class ActionMailbox::IncinerationJob < ::ActiveJob::Base
   end
 end
 
+class ActionMailbox::Record < ::ActiveRecord::Base
+  class << self
+    def _validators; end
+    def defined_enums; end
+  end
+end
+
 class ActionMailbox::Router
   def initialize; end
 
@@ -389,7 +385,7 @@ class Mail::Message
   def deliver; end
   def deliver!; end
   def delivery_handler; end
-  def delivery_handler=(_); end
+  def delivery_handler=(_arg0); end
   def delivery_method(method = T.unsafe(nil), settings = T.unsafe(nil)); end
   def delivery_status_part; end
   def delivery_status_report?; end
@@ -445,9 +441,9 @@ class Mail::Message
   def part(params = T.unsafe(nil)); end
   def parts; end
   def perform_deliveries; end
-  def perform_deliveries=(_); end
+  def perform_deliveries=(_arg0); end
   def raise_delivery_errors; end
-  def raise_delivery_errors=(_); end
+  def raise_delivery_errors=(_arg0); end
   def raw_envelope; end
   def raw_source; end
   def read; end
@@ -545,25 +541,26 @@ Mail::RubyVer = Mail::Ruby19
 
 module Rails
   extend(::ActiveSupport::Autoload)
+  extend(::ActiveSupport::Benchmarkable)
 
   class << self
     def app_class; end
-    def app_class=(_); end
+    def app_class=(_arg0); end
     def application; end
-    def application=(_); end
+    def application=(_arg0); end
     def autoloaders; end
     def backtrace_cleaner; end
     def cache; end
-    def cache=(_); end
+    def cache=(_arg0); end
     def configuration; end
     def env; end
     def env=(environment); end
     def gem_version; end
     def groups(*groups); end
-    def initialize!(*args, &block); end
-    def initialized?(*args, &block); end
+    def initialize!(*_arg0, &_arg1); end
+    def initialized?(*_arg0, &_arg1); end
     def logger; end
-    def logger=(_); end
+    def logger=(_arg0); end
     def public_path; end
     def root; end
     def version; end