packwerk-extensions 0.0.2 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b7fea06d86abb03ba6ef34da052ca7cffcfbb0a05e0c8d6dfd2f48e5bd45fbb1
-  data.tar.gz: e66f49a41bd969e2ebc0801f42647823d19e3d2a158e53d1cb8854a7b84fa42c
+  metadata.gz: 03a304b3c407316bea35a2939967a2cdcbdd30a2459652b96992acd40e49be5a
+  data.tar.gz: 5703efe5318e73495845b5d6f5d7f8bf042e0066cf9b2122697fff6dd9cbfc34
 SHA512:
-  metadata.gz: 960ef0ab02a22b82663d44b6b28ca530e4998b683dafd35c1bf6d6fd8d778aca8d062f9ca96d6149c000a39686f02c7c859d04992df489f06ad5c1044f4e8754
-  data.tar.gz: ba25114ea98091d77ee510f03ca553713a5b532a4b4cd287dffff77accb7ad83882532abf4a147a96d7e402ba364a7fed4193691374ced53bf637e45d47cb11b
+  metadata.gz: 5a680df43f37a36afc61a43ef2bc4e91fd5f8d3763aded52dc51cd3acb712d799079447ed5d0d6a9ac366b4d71edd51c13cc284962e320e1c69206533c7f56ed
+  data.tar.gz: 6bcc586c29c90097340cd1bc3322a7e16f9b2b6b2ba8176284da216175333a97b98d80f6572ace6209cb3a333974dd81bd6bbed7928162a839b5f2c9a4a44220

data/lib/packwerk/privacy/checker.rb

@@ -27,12 +27,7 @@ module Packwerk
         return false if privacy_package.public_path?(reference.constant.location)
 
         privacy_option = privacy_package.enforce_privacy
-        return false if enforcement_disabled?(privacy_option)
-
-        return false unless privacy_option == true || privacy_option == 'strict' ||
-                            explicitly_private_constant?(reference.constant, explicitly_private_constants: T.unsafe(privacy_option))
-
-        true
+        !enforcement_disabled?(privacy_option)
       end
 
       sig do
@@ -65,18 +60,6 @@ module Packwerk
 
       private
 
-      sig do
-        params(
-          constant: ConstantContext,
-          explicitly_private_constants: T::Array[String]
-        ).returns(T::Boolean)
-      end
-      def explicitly_private_constant?(constant, explicitly_private_constants:)
-        explicitly_private_constants.include?(constant.name) ||
-          # nested constants
-          explicitly_private_constants.any? { |epc| constant.name.start_with?("#{epc}::") }
-      end
-
       sig do
         params(privacy_option: T.nilable(T.any(T::Boolean, String, T::Array[String])))
           .returns(T::Boolean)

data/lib/packwerk/privacy/validator.rb

@@ -13,30 +13,10 @@ module Packwerk
       def call(package_set, configuration)
         privacy_settings = package_manifests_settings_for(configuration, 'enforce_privacy')
 
-        resolver = ConstantResolver.new(
-          root_path: configuration.root_path,
-          load_paths: configuration.load_paths
-        )
-
         results = T.let([], T::Array[Result])
 
         privacy_settings.each do |config_file_path, setting|
           results << check_enforce_privacy_setting(config_file_path, setting)
-          next unless setting.is_a?(Array)
-
-          constants = setting
-
-          results += assert_constants_can_be_loaded(constants, config_file_path)
-
-          constant_locations = constants.map { |c| [c, resolver.resolve(c)&.location] }
-
-          constant_locations.each do |name, location|
-            results << if location
-                         check_private_constant_location(configuration, package_set, name, location, config_file_path)
-                       else
-                         private_constant_unresolvable(name, config_file_path)
-                       end
-          end
         end
 
         public_path_settings = package_manifests_settings_for(configuration, 'public_path')
@@ -72,7 +52,7 @@ module Packwerk
         params(config_file_path: String, setting: T.untyped).returns(Result)
       end
       def check_enforce_privacy_setting(config_file_path, setting)
-        if [TrueClass, FalseClass, Array, NilClass].include?(setting.class)
+        if [TrueClass, FalseClass, Array, NilClass].include?(setting.class) || setting == 'strict'
           Result.new(ok: true)
         else
           Result.new(
@@ -81,55 +61,6 @@ module Packwerk
           )
         end
       end
-
-      sig do
-        params(configuration: Configuration, package_set: PackageSet, name: T.untyped, location: T.untyped,
-               config_file_path: T.untyped).returns(Result)
-      end
-      def check_private_constant_location(configuration, package_set, name, location, config_file_path)
-        declared_package = package_set.package_from_path(relative_path(configuration, config_file_path))
-        constant_package = package_set.package_from_path(location)
-
-        if constant_package == declared_package
-          Result.new(ok: true)
-        else
-          Result.new(
-            ok: false,
-            error_value: "'#{name}' is declared as private in the '#{declared_package}' package but appears to be " \
-                         "defined\nin the '#{constant_package}' package. Packwerk resolved it to #{location}."
-          )
-        end
-      end
-
-      sig { params(constants: T.untyped, config_file_path: String).returns(T::Array[Result]) }
-      def assert_constants_can_be_loaded(constants, config_file_path)
-        constants.map do |constant|
-          if constant.start_with?('::')
-            constant.try(&:constantize) && Result.new(ok: true)
-          else
-            error_value = "'#{constant}', listed in the 'enforce_privacy' option " \
-                          "in #{config_file_path}, is invalid.\nPrivate constants need to be " \
-                          'prefixed with the top-level namespace operator `::`.'
-            Result.new(
-              ok: false,
-              error_value: error_value
-            )
-          end
-        end
-      end
-
-      sig { params(name: T.untyped, config_file_path: T.untyped).returns(Result) }
-      def private_constant_unresolvable(name, config_file_path)
-        explicit_filepath = "#{(name.start_with?('::') ? name[2..] : name).underscore}.rb"
-
-        Result.new(
-          ok: false,
-          error_value: "'#{name}', listed in #{config_file_path}, could not be resolved.\n" \
-                       "This is probably because it is an autovivified namespace - a namespace module that doesn't have a\n" \
-                       "file explicitly defining it. Packwerk currently doesn't support declaring autovivified namespaces as\n" \
-                       "private. Add a #{explicit_filepath} file to explicitly define the constant."
-        )
-      end
     end
   end
 end

data/lib/packwerk/visibility/checker.rb

@@ -59,18 +59,6 @@ module Packwerk
 
       private
 
-      sig do
-        params(
-          constant: ConstantContext,
-          explicitly_private_constants: T::Array[String]
-        ).returns(T::Boolean)
-      end
-      def explicitly_private_constant?(constant, explicitly_private_constants:)
-        explicitly_private_constants.include?(constant.name) ||
-          # nested constants
-          explicitly_private_constants.any? { |epc| constant.name.start_with?("#{epc}::") }
-      end
-
       sig do
         params(visibility_option: T.nilable(T.any(T::Boolean, String)))
           .returns(T::Boolean)

data/lib/packwerk/visibility/validator.rb

@@ -19,7 +19,7 @@ module Packwerk
         package_manifests_settings_for(configuration, 'enforce_visibility').each do |config, setting|
           next if setting.nil?
 
-          next if [TrueClass, FalseClass, 'strict'].include?(setting.class)
+          next if [TrueClass, FalseClass].include?(setting.class) || setting == 'strict'
 
           results << Result.new(
             ok: false,

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: packwerk-extensions
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.4
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-12-16 00:00:00.000000000 Z
+date: 2022-12-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: packwerk