packwerk-extensions 0.0.1 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dcb5ef4db4ff6cf134b8707feb0cb4009c8e38db338c407bcbf1fa88da19f79e
-  data.tar.gz: 59e1d1382dba41b33924eb82e679a830ccd642446a52748afabcd2d86b7f64b2
+  metadata.gz: a1317a98d7569bfe1b33cc9a816e768ddbe0dd8a6ab33f3e746f15870a533704
+  data.tar.gz: ee91aae5d17e4ac4408440da88fe92982a8c114e11d9d7026087f13afaff5ebf
 SHA512:
-  metadata.gz: 3873288311271201955075edbf6fe17af585cf62efd1b5d925908e1f7791a45cf1b19e6c4bce29ab5d2bc624ed3eaacece6bf0a153f98051261408a8c2ec1d58
-  data.tar.gz: 4651d546fa1aff7e1c4521c5311711d7598d9f2defb621132172d1a3058a3d7b15bddfde40e67f8e658490df1616ff90ad14e2fc45e18d0383a7f67f3331c4a2
+  metadata.gz: ba36bca58d779e3c10960b4193bb14abd7d2d57c3866d0097094cffd508391bf72264466ca1095a7e16aac410b954c4ce53cc677b824b528866a9d8bf6822c85
+  data.tar.gz: 7d7b3a5f57229dc7578ea31e98b04ea73036fe39087235181185792fb2f2b7213e8659c9c3d3b70e6a2d38f0ca7ba6e2dd6fc7af3c15d22e75a9220ea072dc19

data/lib/packwerk/privacy/checker.rb

@@ -67,7 +67,7 @@ module Packwerk
 
       sig do
         params(
-          constant: ConstantDiscovery::ConstantContext,
+          constant: ConstantContext,
           explicitly_private_constants: T::Array[String]
         ).returns(T::Boolean)
       end

data/lib/packwerk/privacy/validator.rb

@@ -7,7 +7,9 @@ module Packwerk
       extend T::Sig
       include Packwerk::Validator
 
-      sig { override.params(package_set: PackageSet, configuration: Configuration).returns(ApplicationValidator::Result) }
+      Result = Packwerk::Validator::Result
+
+      sig { override.params(package_set: PackageSet, configuration: Configuration).returns(Result) }
       def call(package_set, configuration)
         privacy_settings = package_manifests_settings_for(configuration, 'enforce_privacy')
 
@@ -16,7 +18,7 @@ module Packwerk
           load_paths: configuration.load_paths
         )
 
-        results = T.let([], T::Array[ApplicationValidator::Result])
+        results = T.let([], T::Array[Result])
 
         privacy_settings.each do |config_file_path, setting|
           results << check_enforce_privacy_setting(config_file_path, setting)
@@ -53,13 +55,13 @@ module Packwerk
       private
 
       sig do
-        params(config_file_path: String, setting: T.untyped).returns(ApplicationValidator::Result)
+        params(config_file_path: String, setting: T.untyped).returns(Result)
       end
       def check_public_path(config_file_path, setting)
         if setting.is_a?(String) || setting.nil?
-          ApplicationValidator::Result.new(ok: true)
+          Result.new(ok: true)
         else
-          ApplicationValidator::Result.new(
+          Result.new(
             ok: false,
             error_value: "'public_path' option must be a string in #{config_file_path.inspect}: #{setting.inspect}"
           )
@@ -67,13 +69,13 @@ module Packwerk
       end
 
       sig do
-        params(config_file_path: String, setting: T.untyped).returns(ApplicationValidator::Result)
+        params(config_file_path: String, setting: T.untyped).returns(Result)
       end
       def check_enforce_privacy_setting(config_file_path, setting)
-        if [TrueClass, FalseClass, Array, NilClass].include?(setting.class)
-          ApplicationValidator::Result.new(ok: true)
+        if [TrueClass, FalseClass, Array, NilClass].include?(setting.class) || setting == 'strict'
+          Result.new(ok: true)
         else
-          ApplicationValidator::Result.new(
+          Result.new(
             ok: false,
             error_value: "Invalid 'enforce_privacy' option in #{config_file_path.inspect}: #{setting.inspect}"
           )
@@ -82,16 +84,16 @@ module Packwerk
 
       sig do
         params(configuration: Configuration, package_set: PackageSet, name: T.untyped, location: T.untyped,
-               config_file_path: T.untyped).returns(ApplicationValidator::Result)
+               config_file_path: T.untyped).returns(Result)
       end
       def check_private_constant_location(configuration, package_set, name, location, config_file_path)
         declared_package = package_set.package_from_path(relative_path(configuration, config_file_path))
         constant_package = package_set.package_from_path(location)
 
         if constant_package == declared_package
-          ApplicationValidator::Result.new(ok: true)
+          Result.new(ok: true)
         else
-          ApplicationValidator::Result.new(
+          Result.new(
             ok: false,
             error_value: "'#{name}' is declared as private in the '#{declared_package}' package but appears to be " \
                          "defined\nin the '#{constant_package}' package. Packwerk resolved it to #{location}."
@@ -99,16 +101,16 @@ module Packwerk
         end
       end
 
-      sig { params(constants: T.untyped, config_file_path: String).returns(T::Array[ApplicationValidator::Result]) }
+      sig { params(constants: T.untyped, config_file_path: String).returns(T::Array[Result]) }
       def assert_constants_can_be_loaded(constants, config_file_path)
         constants.map do |constant|
           if constant.start_with?('::')
-            constant.try(&:constantize) && ApplicationValidator::Result.new(ok: true)
+            constant.try(&:constantize) && Result.new(ok: true)
           else
             error_value = "'#{constant}', listed in the 'enforce_privacy' option " \
                           "in #{config_file_path}, is invalid.\nPrivate constants need to be " \
                           'prefixed with the top-level namespace operator `::`.'
-            ApplicationValidator::Result.new(
+            Result.new(
               ok: false,
               error_value: error_value
             )
@@ -116,11 +118,11 @@ module Packwerk
         end
       end
 
-      sig { params(name: T.untyped, config_file_path: T.untyped).returns(ApplicationValidator::Result) }
+      sig { params(name: T.untyped, config_file_path: T.untyped).returns(Result) }
       def private_constant_unresolvable(name, config_file_path)
         explicit_filepath = "#{(name.start_with?('::') ? name[2..] : name).underscore}.rb"
 
-        ApplicationValidator::Result.new(
+        Result.new(
           ok: false,
           error_value: "'#{name}', listed in #{config_file_path}, could not be resolved.\n" \
                        "This is probably because it is an autovivified namespace - a namespace module that doesn't have a\n" \

data/lib/packwerk/visibility/checker.rb

@@ -61,7 +61,7 @@ module Packwerk
 
       sig do
         params(
-          constant: ConstantDiscovery::ConstantContext,
+          constant: ConstantContext,
           explicitly_private_constants: T::Array[String]
         ).returns(T::Boolean)
       end

data/lib/packwerk/visibility/validator.rb

@@ -7,19 +7,21 @@ module Packwerk
       extend T::Sig
       include Packwerk::Validator
 
-      sig { override.params(package_set: PackageSet, configuration: Configuration).returns(ApplicationValidator::Result) }
+      Result = Packwerk::Validator::Result
+
+      sig { override.params(package_set: PackageSet, configuration: Configuration).returns(Result) }
       def call(package_set, configuration)
         visible_settings = package_manifests_settings_for(configuration, 'visible_to')
-        results = T.let([], T::Array[ApplicationValidator::Result])
+        results = T.let([], T::Array[Result])
 
         all_package_names = package_set.map(&:name).to_set
 
         package_manifests_settings_for(configuration, 'enforce_visibility').each do |config, setting|
           next if setting.nil?
 
-          next if [TrueClass, FalseClass, 'strict'].include?(setting.class)
+          next if [TrueClass, FalseClass].include?(setting.class) || setting == 'strict'
 
-          results << ApplicationValidator::Result.new(
+          results << Result.new(
             ok: false,
             error_value: "\tInvalid 'enforce_visibility' option: #{setting.inspect} in #{config.inspect}"
           )
@@ -32,13 +34,13 @@ module Packwerk
             packages_not_found = setting.to_set - all_package_names
 
             if packages_not_found.any?
-              results << ApplicationValidator::Result.new(
+              results << Result.new(
                 ok: false,
                 error_value: "'visible_to' option must only contain valid packages in #{config_file_path.inspect}. Invalid packages: #{packages_not_found.to_a.inspect}"
               )
             end
           else
-            results << ApplicationValidator::Result.new(
+            results << Result.new(
               ok: false,
               error_value: "'visible_to' option must be an array in #{config_file_path.inspect}."
             )

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: packwerk-extensions
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.3
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-12-13 00:00:00.000000000 Z
+date: 2022-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: packwerk