packs 0.0.43 → 0.0.45

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bc08064feda47e2bf0a7946b47c62f747f4024ea66fedbd0358cced98703ff7d
-  data.tar.gz: 3b720e41762061c7d3a150579e97623d2c8202d220d7227bf38b478f994f29e0
+  metadata.gz: ad12cf46cbfafc5f4b3b2d785f2ec2f3f67ed34cb8322bba6929a7ae584d06e1
+  data.tar.gz: 8712c08b31b3457b403d3814764496f3c4d46e53867f88760cadd10083e38a63
 SHA512:
-  metadata.gz: e798e2a7ab7dc26e2ca3a6e46eea32843e3e6197b40d47ecb1c552d7d0b8df3bc5dcceb99aa3266a33b9aef6a2332ee649875254dd9f3cbdc5c4886138bfdcee
-  data.tar.gz: 662a21d82b0b69b6102ccdeb5411324d0ea60e50a729255b42524571a5e7a568ae81ca33b1f2eb39d48a5d51ab3f9755eac063f371c0d9a602736c8d24c80a00
+  metadata.gz: bad96e8500d53692f4930cb08ae0ed1be99b8b0524283027d424a05094d23039b5ed9bd646d94db4e67de158ca5af480288c05e799af0a82e6c46cc2c4190fc0
+  data.tar.gz: ed7ebf9ed287b16336187500dc1ebfb833ce569039f7ad9775e9cf84fee53be47f6326fd8b7a4f3abc61d922080dc9ae2ab8e3049583bf8165871b7a4e763ffb

data/lib/packs/configuration.rb

@@ -13,6 +13,9 @@ module Packs
     sig { returns(UserEventLogger) }
     attr_accessor :user_event_logger
 
+    sig { returns(T::Boolean) }
+    attr_accessor :use_pks
+
     OnPackageTodoLintFailure = T.type_alias do
       T.proc.params(output: String).void
     end
@@ -25,6 +28,7 @@ module Packs
       @enforce_dependencies = T.let(default_enforce_dependencies, T::Boolean)
       @user_event_logger = T.let(DefaultUserEventLogger.new, UserEventLogger)
       @on_package_todo_lint_failure = T.let(->(output) {}, OnPackageTodoLintFailure)
+      @use_pks = T.let(false, T::Boolean)
     end
 
     sig { returns(T::Boolean) }

data/lib/packs/private/file_move_operation.rb

@@ -53,15 +53,20 @@ module Packs
 
       sig { returns(FileMoveOperation) }
       def spec_file_move_operation
+        path_parts = filepath_without_pack_name.split('/')
+        folder = T.must(path_parts[0])
+        file_extension = T.must(filepath_without_pack_name.split('.').last)
+
         # This could probably be implemented by some "strategy pattern" where different extension types are handled by different helpers
         # Such a thing could also include, for example, when moving a controller, moving its ERB view too.
-        if origin_pathname.extname == '.rake'
-          new_origin_pathname = origin_pathname.sub('/lib/', '/spec/lib/').sub(%r{^lib/}, 'spec/lib/').sub('.rake', '_spec.rb')
-          new_destination_pathname = destination_pathname.sub('/lib/', '/spec/lib/').sub(%r{^lib/}, 'spec/lib/').sub('.rake', '_spec.rb')
+        if folder == 'app'
+          new_origin_pathname = spec_pathname_for_app(origin_pathname, file_extension)
+          new_destination_pathname = spec_pathname_for_app(destination_pathname, file_extension)
         else
-          new_origin_pathname = origin_pathname.sub('/app/', '/spec/').sub(%r{^app/}, 'spec/').sub('.rb', '_spec.rb')
-          new_destination_pathname = destination_pathname.sub('/app/', '/spec/').sub(%r{^app/}, 'spec/').sub('.rb', '_spec.rb')
+          new_origin_pathname = spec_pathname_for_non_app(origin_pathname, file_extension, folder)
+          new_destination_pathname = spec_pathname_for_non_app(destination_pathname, file_extension, folder)
         end
+
         FileMoveOperation.new(
           origin_pathname: new_origin_pathname,
           destination_pathname: new_destination_pathname,
@@ -69,8 +74,38 @@ module Packs
         )
       end
 
+      sig { params(filepath: Pathname, pack: T.nilable(Packs::Pack)).returns(String) }
+      def self.get_filepath_without_pack_name(filepath, pack)
+        if pack
+          filepath.to_s.gsub("#{pack.name}/", '')
+        else
+          filepath.to_s
+        end
+      end
+
       private
 
+      sig { returns(String) }
+      def filepath_without_pack_name
+        self.class.get_filepath_without_pack_name(origin_pathname, origin_pack)
+      end
+
+      sig { params(pathname: Pathname, file_extension: String).returns(Pathname) }
+      def spec_pathname_for_app(pathname, file_extension)
+        pathname
+          .sub('/app/', '/spec/')
+          .sub(%r{^app/}, 'spec/')
+          .sub(".#{file_extension}", '_spec.rb')
+      end
+
+      sig { params(pathname: Pathname, file_extension: String, folder: String).returns(Pathname) }
+      def spec_pathname_for_non_app(pathname, file_extension, folder)
+        pathname
+          .sub("/#{folder}/", "/spec/#{folder}/")
+          .sub(%r{^#{folder}/}, "spec/#{folder}/")
+          .sub(".#{file_extension}", '_spec.rb')
+      end
+
       sig { params(path: Pathname).returns(FileMoveOperation) }
       def relative_to(path)
         FileMoveOperation.new(

data/lib/packs.rb

@@ -32,17 +32,29 @@ module Packs
 
   sig { returns(T::Boolean) }
   def self.update
-    Private.system_with('bin/packwerk update-todo')
+    if Packs.config.use_pks
+      Private.system_with('bin/pks update')
+    else
+      Private.system_with('bin/packwerk update-todo')
+    end
   end
 
   sig { returns(T::Boolean) }
   def self.validate
-    Private.system_with('bin/packwerk validate')
+    if Packs.config.use_pks
+      Private.system_with('bin/pks validate')
+    else
+      Private.system_with('bin/packwerk validate')
+    end
   end
 
   sig { params(files: T::Array[String]).returns(T::Boolean) }
   def self.check(files)
-    Private.system_with("bin/packwerk check #{files.join(' ')}")
+    if Packs.config.use_pks
+      Private.system_with("bin/pks check #{files.join(' ')}")
+    else
+      Private.system_with("bin/packwerk check #{files.join(' ')}")
+    end
   end
 
   sig do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: packs
 version: !ruby/object:Gem::Version
-  version: 0.0.43
+  version: 0.0.45
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-05-28 00:00:00.000000000 Z
+date: 2024-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bigdecimal
@@ -344,7 +344,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.9
+rubygems_version: 3.5.16
 signing_key:
 specification_version: 4
 summary: Provides CLI tools for working with ruby packs.