packs 0.0.36 → 0.0.38

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c0a49abad749c63c73c0bbb9cfa0ac4d75962af3c0f5b22cfb8173906f18310e
-  data.tar.gz: e9757c94ee7866e9ee7daaeec189166aa7a07b47baa18f93eff239552a5e94ab
+  metadata.gz: 876b307fd78af1128f0404e37f792d5b249b77ccba825fcd8afc3729ac77c242
+  data.tar.gz: 39b947778eda7ce4aadd58830bb8abf320c3b1cf3f09327b503a24b93ea43add
 SHA512:
-  metadata.gz: a74621a2a3346a352256086cb534c1ef6038beac481af3559409682ce2198c4d90e16b4d276ebe271fc93d6a9d7a2260642bf0aa2b76de22cd8bd4d9f11054a1
-  data.tar.gz: 93dc9e6df47b7150fd1c2ef1ddd312931b154934d83ae8060307ef17a6a146858b98b33f6961863a3c23348b0aa398f0c188098e6bdf5dc5c6c70547b97fc843
+  metadata.gz: 7aecd7614772de0eb3166954887d9012161697f355cd852a12d652f745c5bd424ac52839204762067fbb27d48ea8ffd56551f1c4eb6597fa50099cfd43f22070
+  data.tar.gz: dbc2223fe7612e204f59548136bfc8b8f77355f321cfee17d25766a94ba7fb473be9fe47f2db9d95138a746dba1a7ce687c60befba05f481cfa4b2603f2bc547

data/README.md

@@ -111,7 +111,10 @@ Make sure there are no spaces between the comma-separated list of paths of direc
 `bin/packs rename`
 
 ## Set packs/child_pack as a child of packs/parent_pack
-`bin/packs move_to_parent packs/child_pack packs/parent_pack `
+`bin/packs move_to_parent packs/child_pack packs/parent_pack`
+
+## Move packs/foo to the some/directory folder, where some/directory does not contain a package.yml file
+`bin/packs move_to_folder packs/foo some/directory`
 
 
 ## Releasing

data/lib/packs/cli.rb

@@ -7,12 +7,16 @@ module Packs
     extend T::Sig
 
     desc 'create packs/your_pack', 'Create pack with name packs/your_pack'
+    option :enforce_dependencies, type: :boolean, default: nil, aliases: :d, banner: 'Enforce dependencies'
     option :enforce_privacy, type: :boolean, default: true, aliases: :p, banner: 'Enforce privacy'
+    option :enforce_architecture, type: :boolean, default: true, aliases: :a, banner: 'Enforce architecture'
     sig { params(pack_name: String).void }
     def create(pack_name)
       Packs.create_pack!(
         pack_name: pack_name,
-        enforce_privacy: options[:enforce_privacy]
+        enforce_dependencies: options[:enforce_dependencies],
+        enforce_privacy: options[:enforce_privacy],
+        enforce_architecture: options[:enforce_architecture]
       )
       exit_successfully
     end
@@ -150,7 +154,7 @@ module Packs
       exit_successfully
     end
 
-    desc 'move_to_parent packs/child_pack packs/parent_pack ', 'Set packs/child_pack as a child of packs/parent_pack'
+    desc 'move_to_parent packs/child_pack packs/parent_pack', 'Set packs/child_pack as a child of packs/parent_pack'
     sig { params(child_pack_name: String, parent_pack_name: String).void }
     def move_to_parent(child_pack_name, parent_pack_name)
       Packs.move_to_parent!(
@@ -160,6 +164,16 @@ module Packs
       exit_successfully
     end
 
+    desc 'move_to_folder packs/foo some/directory', 'Move packs/foo to the some/directory folder, where some/directory does not contain a package.yml file'
+    sig { params(pack_name: String, destination: String).void }
+    def move_to_folder(pack_name, destination)
+      Packs.move_to_folder!(
+        pack_name: pack_name,
+        destination: destination
+      )
+      exit_successfully
+    end
+
     private
 
     # This is used by thor to know that these private methods are not intended to be CLI commands

data/lib/packs/private.rb

@@ -47,12 +47,13 @@ module Packs
     sig do
       params(
         pack_name: String,
-        enforce_privacy: T::Boolean,
         enforce_dependencies: T.nilable(T::Boolean),
+        enforce_privacy: T::Boolean,
+        enforce_architecture: T::Boolean,
         team: T.nilable(CodeTeams::Team)
       ).void
     end
-    def self.create_pack!(pack_name:, enforce_privacy:, enforce_dependencies:, team:)
+    def self.create_pack!(pack_name:, enforce_dependencies:, enforce_privacy:, enforce_architecture:, team:)
       Logging.section('👋 Hi!') do
         intro = Packs.config.user_event_logger.before_create_pack(pack_name)
         Logging.print_bold_green(intro)
@@ -60,7 +61,13 @@ module Packs
 
       pack_name = Private.clean_pack_name(pack_name)
 
-      package = create_pack_if_not_exists!(pack_name: pack_name, enforce_privacy: enforce_privacy, enforce_dependencies: enforce_dependencies, team: team)
+      package = create_pack_if_not_exists!(
+        pack_name: pack_name,
+        enforce_dependencies: enforce_dependencies,
+        enforce_privacy: enforce_privacy,
+        enforce_architecture: enforce_architecture,
+        team: team
+      )
       add_public_directory(package) if package.enforce_privacy
       add_readme_todo(package)
 
@@ -140,6 +147,85 @@ module Packs
       end
     end
 
+    sig do
+      params(
+        pack_name: String,
+        destination: String,
+        per_file_processors: T::Array[PerFileProcessorInterface]
+      ).void
+    end
+    def self.move_to_folder!(pack_name:, destination:, per_file_processors: [Packs::RubocopPostProcessor.new, Packs::CodeOwnershipPostProcessor.new])
+      pack_name = Private.clean_pack_name(pack_name)
+      package = ParsePackwerk.all.find { |p| p.name == pack_name }
+      if package.nil?
+        raise StandardError, "Can not find package with name #{pack_name}. Make sure the argument is of the form `packs/my_pack/`"
+      end
+
+      # First we create a new pack that has the exact same properties of the old one!
+      package_last_name = package.directory.basename
+      new_package_name = File.join(destination, package_last_name)
+
+      new_package = ParsePackwerk::Package.new(
+        name: new_package_name,
+        enforce_dependencies: package.enforce_dependencies,
+        enforce_privacy: package.enforce_privacy,
+        enforce_architecture: package.enforce_architecture,
+        dependencies: package.dependencies,
+        violations: package.violations,
+        metadata: package.metadata,
+        config: package.config
+      )
+      ParsePackwerk.write_package_yml!(new_package)
+      ParsePackwerk.bust_cache!
+
+      # Move everything from the old pack to the new one
+      move_to_pack!(
+        pack_name: new_package_name,
+        paths_relative_to_root: [package.directory.to_s],
+        per_file_processors: per_file_processors
+      )
+
+      # Then delete the old package.yml and package_todo.yml files
+      package.yml.delete
+      package_todo_file = ParsePackwerk::PackageTodo.for(package).pathname
+      package_todo_file.delete if package_todo_file.exist?
+
+      ParsePackwerk.bust_cache!
+
+      ParsePackwerk.all.each do |other_package|
+        new_dependencies = other_package.dependencies.map { |d| d == pack_name ? new_package_name : d }
+
+        new_config = other_package.config.dup
+        if new_config['ignored_dependencies']
+          new_config['ignored_dependencies'] = new_config['ignored_dependencies'].map do |d|
+            d == pack_name ? new_package_name : d
+          end
+        end
+
+        new_other_package = ParsePackwerk::Package.new(
+          name: other_package.name,
+          enforce_dependencies: other_package.enforce_dependencies,
+          enforce_privacy: other_package.enforce_privacy,
+          enforce_architecture: other_package.enforce_architecture,
+          dependencies: new_dependencies.uniq.sort,
+          violations: other_package.violations,
+          metadata: other_package.metadata,
+          config: new_config
+        )
+
+        ParsePackwerk.write_package_yml!(new_other_package)
+      end
+
+      sorbet_config = Pathname.new('sorbet/config')
+      if sorbet_config.exist?
+        Packs.replace_in_file(
+          file: sorbet_config.to_s,
+          find: package.directory.join('spec'),
+          replace_with: new_package.directory.join('spec')
+        )
+      end
+    end
+
     sig do
       params(
         pack_name: String,
@@ -161,7 +247,12 @@ module Packs
       parent_name = Private.clean_pack_name(parent_name)
       parent_package = ParsePackwerk.all.find { |p| p.name == parent_name }
       if parent_package.nil?
-        parent_package = create_pack_if_not_exists!(pack_name: parent_name, enforce_privacy: true, enforce_dependencies: true)
+        parent_package = create_pack_if_not_exists!(
+          pack_name: parent_name,
+          enforce_dependencies: true,
+          enforce_privacy: true,
+          enforce_architecture: true
+        )
       end
 
       # First we create a new pack that has the exact same properties of the old one!
@@ -172,6 +263,7 @@ module Packs
         name: new_package_name,
         enforce_privacy: package.enforce_privacy,
         enforce_dependencies: package.enforce_dependencies,
+        enforce_architecture: package.enforce_architecture,
         dependencies: package.dependencies,
         violations: package.violations,
         metadata: package.metadata,
@@ -212,8 +304,9 @@ module Packs
 
         new_other_package = ParsePackwerk::Package.new(
           name: other_package.name,
-          enforce_privacy: other_package.enforce_privacy,
           enforce_dependencies: other_package.enforce_dependencies,
+          enforce_privacy: other_package.enforce_privacy,
+          enforce_architecture: other_package.enforce_architecture,
           dependencies: new_dependencies.uniq.sort,
           violations: other_package.violations,
           metadata: other_package.metadata,
@@ -305,6 +398,7 @@ module Packs
         name: pack_name,
         dependencies: (package.dependencies + [dependency_name]).uniq.sort,
         enforce_privacy: package.enforce_privacy,
+        enforce_architecture: package.enforce_architecture,
         enforce_dependencies: package.enforce_dependencies,
         violations: package.violations,
         metadata: package.metadata,
@@ -370,12 +464,13 @@ module Packs
     sig do
       params(
         pack_name: String,
-        enforce_privacy: T::Boolean,
         enforce_dependencies: T.nilable(T::Boolean),
+        enforce_privacy: T::Boolean,
+        enforce_architecture: T::Boolean,
         team: T.nilable(CodeTeams::Team)
       ).returns(ParsePackwerk::Package)
     end
-    def self.create_pack_if_not_exists!(pack_name:, enforce_privacy:, enforce_dependencies:, team: nil)
+    def self.create_pack_if_not_exists!(pack_name:, enforce_dependencies:, enforce_privacy:, enforce_architecture:, team: nil)
       allowed_locations = Packs::Specification.config.pack_paths
       if allowed_locations.none? { |location| File.fnmatch(location, pack_name) }
         raise StandardError, "Packs only supports packages in the the following directories: #{allowed_locations}. Please make sure to pass in the name of the pack including the full directory path, e.g. `packs/my_pack`."
@@ -398,6 +493,7 @@ module Packs
         package = ParsePackwerk::Package.new(
           enforce_dependencies: should_enforce_dependencies || false,
           enforce_privacy: enforce_privacy,
+          enforce_architecture: enforce_architecture,
           dependencies: [],
           violations: [],
           metadata: {},

data/lib/packs/user_event_logger.rb

@@ -105,6 +105,24 @@ module Packs
       MSG
     end
 
+    sig { params(pack_name: String).returns(String) }
+    def before_move_to_folder(pack_name)
+      <<~MSG
+        You are moving one pack to a new directory. Check out #{documentation_link} for more info!
+      MSG
+    end
+
+    sig { params(pack_name: String).returns(String) }
+    def after_move_to_folder(pack_name)
+      <<~MSG
+        Your next steps might be:
+
+        1) Delete the old pack when things look good: `git rm -r #{pack_name}`
+
+        2) Run `bin/packwerk update-todo` to update the violations. Make sure to run `spring stop` first.
+      MSG
+    end
+
     sig { params(pack_name: String).returns(String) }
     def on_create_public_directory_todo(pack_name)
       <<~MSG

data/lib/packs.rb

@@ -49,6 +49,7 @@ module Packs
     params(
       pack_name: String,
       enforce_privacy: T::Boolean,
+      enforce_architecture: T::Boolean,
       enforce_dependencies: T.nilable(T::Boolean),
       team: T.nilable(CodeTeams::Team)
     ).void
@@ -56,6 +57,7 @@ module Packs
   def self.create_pack!(
     pack_name:,
     enforce_privacy: true,
+    enforce_architecture: true,
     enforce_dependencies: nil,
     team: nil
   )
@@ -63,6 +65,7 @@ module Packs
       pack_name: pack_name,
       enforce_privacy: enforce_privacy,
       enforce_dependencies: enforce_dependencies,
+      enforce_architecture: enforce_architecture,
       team: team
     )
   end
@@ -178,6 +181,36 @@ module Packs
     end
   end
 
+  sig do
+    params(
+      pack_name: String,
+      destination: String,
+      per_file_processors: T::Array[PerFileProcessorInterface]
+    ).void
+  end
+  def self.move_to_folder!(
+    pack_name:,
+    destination:,
+    per_file_processors: [Packs::RubocopPostProcessor.new, Packs::CodeOwnershipPostProcessor.new]
+  )
+    Logging.section('👋 Hi!') do
+      intro = Packs.config.user_event_logger.before_move_to_folder(pack_name)
+      Logging.print_bold_green(intro)
+    end
+
+    Private.move_to_folder!(
+      pack_name: pack_name,
+      destination: destination,
+      per_file_processors: per_file_processors
+    )
+
+    Logging.section('Next steps') do
+      next_steps = Packs.config.user_event_logger.after_move_to_folder(pack_name)
+
+      Logging.print_bold_green(next_steps)
+    end
+  end
+
   sig do
     params(
       type: String,

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: packs
 version: !ruby/object:Gem::Version
-  version: 0.0.36
+  version: 0.0.38
 platform: ruby
 authors:
 - Gusto Engineers
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-11-28 00:00:00.000000000 Z
+date: 2023-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_ownership
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.22.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.22.0
 - !ruby/object:Gem::Dependency
   name: rainbow
   requirement: !ruby/object:Gem::Requirement
@@ -314,7 +314,7 @@ metadata:
   source_code_uri: https://github.com/rubyatscale/packs
   changelog_uri: https://github.com/rubyatscale/packs/releases
   allowed_push_host: https://rubygems.org
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -329,8 +329,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.4.10
+signing_key:
 specification_version: 4
 summary: Provides CLI tools for working with ruby packs.
 test_files: []