packs 0.0.36 → 0.0.37

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c0a49abad749c63c73c0bbb9cfa0ac4d75962af3c0f5b22cfb8173906f18310e
-  data.tar.gz: e9757c94ee7866e9ee7daaeec189166aa7a07b47baa18f93eff239552a5e94ab
+  metadata.gz: 61faca4f667524b1ad3ac80486441315601f3ceda6ff04c413a1412b943e7df4
+  data.tar.gz: 347f3a70a95fb188497f7056f88925a5c9ecc409fc0b9561d35ce8fbe13ca191
 SHA512:
-  metadata.gz: a74621a2a3346a352256086cb534c1ef6038beac481af3559409682ce2198c4d90e16b4d276ebe271fc93d6a9d7a2260642bf0aa2b76de22cd8bd4d9f11054a1
-  data.tar.gz: 93dc9e6df47b7150fd1c2ef1ddd312931b154934d83ae8060307ef17a6a146858b98b33f6961863a3c23348b0aa398f0c188098e6bdf5dc5c6c70547b97fc843
+  metadata.gz: 11de5f83297dce2506a151ceb9f6e18d2a7bdfdfb0086f3ac05b2136f2530b638817d5eea079342265102e2e652c6264f6b31df9fd58e9a1bc61a15f0d47eae9
+  data.tar.gz: ab4bd4f5e89f880ada5f0d9bf7d4a25119a8e3b9ca1158be241cb3b9530b6470ddf6cf817d3c2930afd53b2c0ddd17821d0ee9b42a61547d0578402f581ce87e

data/README.md

@@ -111,7 +111,10 @@ Make sure there are no spaces between the comma-separated list of paths of direc
 `bin/packs rename`
 
 ## Set packs/child_pack as a child of packs/parent_pack
-`bin/packs move_to_parent packs/child_pack packs/parent_pack `
+`bin/packs move_to_parent packs/child_pack packs/parent_pack`
+
+## Move packs/foo to the some/directory folder, where some/directory does not contain a package.yml file
+`bin/packs move_to_folder packs/foo some/directory`
 
 
 ## Releasing

data/lib/packs/cli.rb

@@ -150,7 +150,7 @@ module Packs
       exit_successfully
     end
 
-    desc 'move_to_parent packs/child_pack packs/parent_pack ', 'Set packs/child_pack as a child of packs/parent_pack'
+    desc 'move_to_parent packs/child_pack packs/parent_pack', 'Set packs/child_pack as a child of packs/parent_pack'
     sig { params(child_pack_name: String, parent_pack_name: String).void }
     def move_to_parent(child_pack_name, parent_pack_name)
       Packs.move_to_parent!(
@@ -160,6 +160,16 @@ module Packs
       exit_successfully
     end
 
+    desc 'move_to_folder packs/foo some/directory', 'Move packs/foo to the some/directory folder, where some/directory does not contain a package.yml file'
+    sig { params(pack_name: String, destination: String).void }
+    def move_to_folder(pack_name, destination)
+      Packs.move_to_folder!(
+        pack_name: pack_name,
+        destination: destination
+      )
+      exit_successfully
+    end
+
     private
 
     # This is used by thor to know that these private methods are not intended to be CLI commands

data/lib/packs/private.rb

@@ -140,6 +140,83 @@ module Packs
       end
     end
 
+    sig do
+      params(
+        pack_name: String,
+        destination: String,
+        per_file_processors: T::Array[PerFileProcessorInterface]
+      ).void
+    end
+    def self.move_to_folder!(pack_name:, destination:, per_file_processors: [Packs::RubocopPostProcessor.new, Packs::CodeOwnershipPostProcessor.new])
+      pack_name = Private.clean_pack_name(pack_name)
+      package = ParsePackwerk.all.find { |p| p.name == pack_name }
+      if package.nil?
+        raise StandardError, "Can not find package with name #{pack_name}. Make sure the argument is of the form `packs/my_pack/`"
+      end
+
+      # First we create a new pack that has the exact same properties of the old one!
+      package_last_name = package.directory.basename
+      new_package_name = File.join(destination, package_last_name)
+
+      new_package = ParsePackwerk::Package.new(
+        name: new_package_name,
+        enforce_privacy: package.enforce_privacy,
+        enforce_dependencies: package.enforce_dependencies,
+        dependencies: package.dependencies,
+        violations: package.violations,
+        metadata: package.metadata,
+        config: package.config
+      )
+      ParsePackwerk.write_package_yml!(new_package)
+      ParsePackwerk.bust_cache!
+
+      # Move everything from the old pack to the new one
+      move_to_pack!(
+        pack_name: new_package_name,
+        paths_relative_to_root: [package.directory.to_s],
+        per_file_processors: per_file_processors
+      )
+
+      # Then delete the old package.yml and package_todo.yml files
+      package.yml.delete
+      package_todo_file = ParsePackwerk::PackageTodo.for(package).pathname
+      package_todo_file.delete if package_todo_file.exist?
+
+      ParsePackwerk.bust_cache!
+
+      ParsePackwerk.all.each do |other_package|
+        new_dependencies = other_package.dependencies.map { |d| d == pack_name ? new_package_name : d }
+
+        new_config = other_package.config.dup
+        if new_config['ignored_dependencies']
+          new_config['ignored_dependencies'] = new_config['ignored_dependencies'].map do |d|
+            d == pack_name ? new_package_name : d
+          end
+        end
+
+        new_other_package = ParsePackwerk::Package.new(
+          name: other_package.name,
+          enforce_privacy: other_package.enforce_privacy,
+          enforce_dependencies: other_package.enforce_dependencies,
+          dependencies: new_dependencies.uniq.sort,
+          violations: other_package.violations,
+          metadata: other_package.metadata,
+          config: new_config
+        )
+
+        ParsePackwerk.write_package_yml!(new_other_package)
+      end
+
+      sorbet_config = Pathname.new('sorbet/config')
+      if sorbet_config.exist?
+        Packs.replace_in_file(
+          file: sorbet_config.to_s,
+          find: package.directory.join('spec'),
+          replace_with: new_package.directory.join('spec')
+        )
+      end
+    end
+
     sig do
       params(
         pack_name: String,

data/lib/packs/user_event_logger.rb

@@ -105,6 +105,24 @@ module Packs
       MSG
     end
 
+    sig { params(pack_name: String).returns(String) }
+    def before_move_to_folder(pack_name)
+      <<~MSG
+        You are moving one pack to a new directory. Check out #{documentation_link} for more info!
+      MSG
+    end
+
+    sig { params(pack_name: String).returns(String) }
+    def after_move_to_folder(pack_name)
+      <<~MSG
+        Your next steps might be:
+
+        1) Delete the old pack when things look good: `git rm -r #{pack_name}`
+
+        2) Run `bin/packwerk update-todo` to update the violations. Make sure to run `spring stop` first.
+      MSG
+    end
+
     sig { params(pack_name: String).returns(String) }
     def on_create_public_directory_todo(pack_name)
       <<~MSG

data/lib/packs.rb

@@ -178,6 +178,36 @@ module Packs
     end
   end
 
+  sig do
+    params(
+      pack_name: String,
+      destination: String,
+      per_file_processors: T::Array[PerFileProcessorInterface]
+    ).void
+  end
+  def self.move_to_folder!(
+    pack_name:,
+    destination:,
+    per_file_processors: [Packs::RubocopPostProcessor.new, Packs::CodeOwnershipPostProcessor.new]
+  )
+    Logging.section('👋 Hi!') do
+      intro = Packs.config.user_event_logger.before_move_to_folder(pack_name)
+      Logging.print_bold_green(intro)
+    end
+
+    Private.move_to_folder!(
+      pack_name: pack_name,
+      destination: destination,
+      per_file_processors: per_file_processors
+    )
+
+    Logging.section('Next steps') do
+      next_steps = Packs.config.user_event_logger.after_move_to_folder(pack_name)
+
+      Logging.print_bold_green(next_steps)
+    end
+  end
+
   sig do
     params(
       type: String,

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: packs
 version: !ruby/object:Gem::Version
-  version: 0.0.36
+  version: 0.0.37
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-11-28 00:00:00.000000000 Z
+date: 2023-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_ownership