packetgen 3.1.3 → 3.1.4

data/lib/packetgen/header/ospfv3/hello.rb

@@ -1,10 +1,10 @@
+# frozen_string_literal: true
+
 # This file is part of PacketGen
 # See https://github.com/sdaubert/packetgen for more informations
 # Copyright (C) 2016 Sylvain Daubert <sylvain.daubert@laposte.net>
 # This program is published under MIT license.
 
-# frozen_string_literal: true
-
 module PacketGen
   module Header
     class OSPFv3

data/lib/packetgen/header/ospfv3/ipv6_prefix.rb

@@ -1,10 +1,10 @@
+# frozen_string_literal: true
+
 # This file is part of PacketGen
 # See https://github.com/sdaubert/packetgen for more informations
 # Copyright (C) 2016 Sylvain Daubert <sylvain.daubert@laposte.net>
 # This program is published under MIT license.
 
-# frozen_string_literal: true
-
 module PacketGen
   module Header
     class OSPFv3

data/lib/packetgen/header/ospfv3/ls_ack.rb

@@ -1,10 +1,10 @@
+# frozen_string_literal: true
+
 # This file is part of PacketGen
 # See https://github.com/sdaubert/packetgen for more informations
 # Copyright (C) 2016 Sylvain Daubert <sylvain.daubert@laposte.net>
 # This program is published under MIT license.
 
-# frozen_string_literal: true
-
 module PacketGen
   module Header
     class OSPFv3

data/lib/packetgen/header/ospfv3/ls_request.rb

@@ -1,10 +1,10 @@
+# frozen_string_literal: true
+
 # This file is part of PacketGen
 # See https://github.com/sdaubert/packetgen for more informations
 # Copyright (C) 2016 Sylvain Daubert <sylvain.daubert@laposte.net>
 # This program is published under MIT license.
 
-# frozen_string_literal: true
-
 module PacketGen
   module Header
     class OSPFv3

data/lib/packetgen/header/ospfv3/ls_update.rb

@@ -1,10 +1,10 @@
+# frozen_string_literal: true
+
 # This file is part of PacketGen
 # See https://github.com/sdaubert/packetgen for more informations
 # Copyright (C) 2016 Sylvain Daubert <sylvain.daubert@laposte.net>
 # This program is published under MIT license.
 
-# frozen_string_literal: true
-
 module PacketGen
   module Header
     class OSPFv3

data/lib/packetgen/header/ospfv3/lsa.rb

@@ -1,10 +1,10 @@
+# frozen_string_literal: true
+
 # This file is part of PacketGen
 # See https://github.com/sdaubert/packetgen for more informations
 # Copyright (C) 2016 Sylvain Daubert <sylvain.daubert@laposte.net>
 # This program is published under MIT license.
 
-# frozen_string_literal: true
-
 module PacketGen
   module Header
     class OSPFv3
@@ -197,9 +197,7 @@ module PacketGen
         private
 
         def record_from_hash(hsh)
-          unless hsh.key? :type
-            raise ArgumentError, 'hash should have :type key'
-          end
+          raise ArgumentError, 'hash should have :type key' unless hsh.key? :type
 
           klass = if @only_headers
                     LSAHeader

data/lib/packetgen/header/ospfv3/lsa_header.rb

@@ -1,10 +1,10 @@
+# frozen_string_literal: true
+
 # This file is part of PacketGen
 # See https://github.com/sdaubert/packetgen for more informations
 # Copyright (C) 2016 Sylvain Daubert <sylvain.daubert@laposte.net>
 # This program is published under MIT license.
 
-# frozen_string_literal: true
-
 module PacketGen
   module Header
     class OSPFv3
@@ -31,13 +31,13 @@ module PacketGen
       class LSAHeader < Types::Fields
         # LSA known types
         TYPES = {
-          'Router'            => 0x2001,
-          'Network'           => 0x2002,
+          'Router' => 0x2001,
+          'Network' => 0x2002,
           'Inter-Area-Prefix' => 0x2003,
           'Inter-Area-Router' => 0x2004,
-          'AS-External'       => 0x4005,
-          'NSSA'              => 0x2007,
-          'Link'              => 0x0008,
+          'AS-External' => 0x4005,
+          'NSSA' => 0x2007,
+          'Link' => 0x0008,
           'Intra-Area-Prefix' => 0x2009
         }.freeze
 

data/lib/packetgen/header/snmp.rb

@@ -1,11 +1,11 @@
 # coding: utf-8
+# frozen_string_literal: true
+
 # This file is part of PacketGen
 # See https://github.com/sdaubert/packetgen for more informations
 # Copyright (C) 2016 Sylvain Daubert <sylvain.daubert@laposte.net>
 # This program is published under MIT license.
 
-# frozen_string_literal: true
-
 module PacketGen
   module Header
     # Dissect error
@@ -22,6 +22,8 @@ module PacketGen
       # Configuration sinks listen to this port
       UDP_PORT2 = 162
 
+      # rubocop:disable Naming/ConstantName
+
       PDU_GET      = 0
       PDU_NEXT     = 1
       PDU_RESPONSE = 2
@@ -31,27 +33,28 @@ module PacketGen
       PDU_INFORM   = 6
       PDU_TRAPv2   = 7
       PDU_REPORT   = 8
+      # rubocop:enable Naming/ConstantName
 
       ERRORS = {
-        'no_error'              => 0,
-        'too_big'               => 1,
-        'no_such_name'          => 2,
-        'bad_value'             => 3,
-        'read_only'             => 4,
-        'generic_error'         => 5,
-        'no_access'             => 6,
-        'wrong_type'            => 7,
-        'wrong_length'          => 8,
-        'wrong_encoding'        => 9,
-        'wrong_value'           => 10,
-        'no_creation'           => 11,
-        'inconsistent_value'    => 12,
+        'no_error' => 0,
+        'too_big' => 1,
+        'no_such_name' => 2,
+        'bad_value' => 3,
+        'read_only' => 4,
+        'generic_error' => 5,
+        'no_access' => 6,
+        'wrong_type' => 7,
+        'wrong_length' => 8,
+        'wrong_encoding' => 9,
+        'wrong_value' => 10,
+        'no_creation' => 11,
+        'inconsistent_value' => 12,
         'ressource_unavailable' => 13,
-        'commit_failed'         => 14,
-        'undo_failed'           => 15,
-        'authorization_error'   => 16,
-        'not_writable'          => 17,
-        'inconsistent_name'     => 18
+        'commit_failed' => 14,
+        'undo_failed' => 15,
+        'authorization_error' => 16,
+        'not_writable' => 17,
+        'inconsistent_name' => 18
       }.freeze
 
       # Class to handle SNMP VarBind
@@ -162,13 +165,13 @@ module PacketGen
                  implicit: SNMP::PDU_TRAPv1, constructed: true,
                  content: [objectid(:enterprise),
                            octet_string(:agent_addr),
-                           integer(:generic_trap, enum: { 'cold_start'        => 0,
-                                                          'warm_start'        => 1,
-                                                          'link_down'         => 2,
-                                                          'link_up'           => 3,
-                                                          'auth_failure'      => 4,
+                           integer(:generic_trap, enum: { 'cold_start' => 0,
+                                                          'warm_start' => 1,
+                                                          'link_down' => 2,
+                                                          'link_up' => 3,
+                                                          'auth_failure' => 4,
                                                           'egp_neighbor_loss' => 5,
-                                                          'specific'          => 6 }),
+                                                          'specific' => 6 }),
                            integer(:specific_trap),
                            integer(:timestamp),
                            model(:varbindlist, VariableBindings)]
@@ -291,8 +294,8 @@ module PacketGen
           str << data.chosen_value.inspect(1)
           begin
             str << Inspect.inspect_body(self[:message].to_der, 'ASN.1 DER')
-          rescue StandardError => ex
-            raise unless ex.message =~ /TAG.*not handled/
+          rescue StandardError => e
+            raise unless e.message =~ /TAG.*not handled/
           end
           str
         end

data/lib/packetgen/header/tcp.rb

@@ -1,10 +1,10 @@
+# frozen_string_literal: true
+
 # This file is part of PacketGen
 # See https://github.com/sdaubert/packetgen for more informations
 # Copyright (C) 2016 Sylvain Daubert <sylvain.daubert@laposte.net>
 # This program is published under MIT license.
 
-# frozen_string_literal: true
-
 module PacketGen
   module Header
     # TCP header ({https://tools.ietf.org/html/rfc793 RFC 793})
@@ -235,7 +235,7 @@ module PacketGen
           doff = Inspect.int_dec_hex(data_offset, 1)
           str << shift << Inspect::FMT_ATTR % ['', 'data_offset', doff]
           str << shift << Inspect::FMT_ATTR % ['', 'reserved', reserved]
-          flags = ''.dup
+          flags = +''
           %w[ns cwr ece urg ack psh rst syn fin].each do |fl|
             flags << (send("flag_#{fl}?") ? fl[0].upcase : '.')
           end

data/lib/packetgen/header/tcp/option.rb

@@ -1,10 +1,10 @@
+# frozen_string_literal: true
+
 # This file is part of PacketGen
 # See https://github.com/sdaubert/packetgen for more informations
 # Copyright (C) 2016 Sylvain Daubert <sylvain.daubert@laposte.net>
 # This program is published under MIT license.
 
-# frozen_string_literal: true
-
 module PacketGen
   module Header
     class TCP
@@ -113,9 +113,7 @@ module PacketGen
         # @return [String]
         def to_human
           str = self.class == Option ? +"unk-#{kind}" : self.class.to_s.sub(/.*::/, '')
-          if (length > 2) && !self[:value].to_s.empty?
-            str << ":#{self[:value].to_s.inspect}"
-          end
+          str << ":#{self[:value].to_s.inspect}" if (length > 2) && !self[:value].to_s.empty?
           str
         end
 

data/lib/packetgen/header/tcp/options.rb

@@ -1,10 +1,10 @@
+# frozen_string_literal: true
+
 # This file is part of PacketGen
 # See https://github.com/sdaubert/packetgen for more informations
 # Copyright (C) 2016 Sylvain Daubert <sylvain.daubert@laposte.net>
 # This program is published under MIT license.
 
-# frozen_string_literal: true
-
 require_relative 'option'
 
 module PacketGen

data/lib/packetgen/header/tftp.rb

@@ -1,10 +1,10 @@
+# frozen_string_literal: true
+
 # This file is part of PacketGen
 # See https://github.com/sdaubert/packetgen for more informations
 # Copyright (C) 2016 Sylvain Daubert <sylvain.daubert@laposte.net>
 # This program is published under MIT license.
 
-# frozen_string_literal: true
-
 module PacketGen
   module Header
     # A TFTP (Trivial File Transfer Protocol,
@@ -49,10 +49,10 @@ module PacketGen
     class TFTP < Base
       # Known opcodes
       OPCODES = {
-        'RRQ'   => 1,
-        'WRQ'   => 2,
-        'DATA'  => 3,
-        'ACK'   => 4,
+        'RRQ' => 1,
+        'WRQ' => 2,
+        'DATA' => 3,
+        'ACK' => 4,
         'Error' => 5
       }.freeze
 

data/lib/packetgen/header/udp.rb

@@ -1,10 +1,10 @@
+# frozen_string_literal: true
+
 # This file is part of PacketGen
 # See https://github.com/sdaubert/packetgen for more informations
 # Copyright (C) 2016 Sylvain Daubert <sylvain.daubert@laposte.net>
 # This program is published under MIT license.
 
-# frozen_string_literal: true
-
 module PacketGen
   module Header
     # UDP header ({https://tools.ietf.org/html/rfc768 RFC 768})
@@ -71,7 +71,7 @@ module PacketGen
       # option is set.
       def initialize(options={})
         super
-        self.length += self[:body].sz if self[:body].sz > 0
+        self.length += self[:body].sz if self[:body].sz.positive?
       end
 
       # Compute checksum and set +checksum+ field

data/lib/packetgen/headerable.rb

@@ -1,10 +1,10 @@
+# frozen_string_literal: true
+
 # This file is part of PacketGen
 # See https://github.com/sdaubert/packetgen for more informations
 # Copyright (C) 2016 Sylvain Daubert <sylvain.daubert@laposte.net>
 # This program is published under MIT license.
 
-# frozen_string_literal: true
-
 module PacketGen
   # This mixin module defines minimal API for a class to act as a header
   # in {Packet}.
@@ -85,9 +85,10 @@ module PacketGen
     # @return [self]
     # @raise [NotImplementedError]
     def read(str)
+      # Do not call super and rescue NoMethodError: too slow
+      raise NotImplementedError, "#{self.class} should implement #read" if method(:read).super_method.nil?
+
       super
-    rescue NoMethodError
-      raise NotImplementedError, "#{self.class} should implement #read"
     end
   end
 end

data/lib/packetgen/inject.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+# This file is part of PacketGen
+# See https://github.com/sdaubert/packetgen for more informations
+# Copyright (C) 2016 Sylvain Daubert <sylvain.daubert@laposte.net>
+# This program is published under MIT license.
+require_relative 'pcaprub_wrapper'
+
+module PacketGen
+  # Module to inject packets on wire
+  # @author Sylvain Daubert
+  # @api private
+  # @since 3.1.4
+  module Inject
+    # Inject given data onto wire
+    # @param [String] iface interface name
+    # @param [String,Packet,Header::Base] data to inject
+    # @return [void]
+    def self.inject(iface:, data:)
+      PCAPRUBWrapper.inject(iface: iface, data: data.to_s)
+    end
+  end
+end

data/lib/packetgen/inspect.rb

@@ -1,10 +1,10 @@
+# frozen_string_literal: true
+
 # This file is part of PacketGen
 # See https://github.com/sdaubert/packetgen for more informations
 # Copyright (C) 2016 Sylvain Daubert <sylvain.daubert@laposte.net>
 # This program is published under MIT license.
 
-# frozen_string_literal: true
-
 module PacketGen
   # {Inspect} module provides methods to help writing +inspect+
   # @api private
@@ -37,6 +37,25 @@ module PacketGen
       "%-16s (0x%0#{hexsize}x)" % [value.to_i, value.to_i]
     end
 
+    # @param [String] str
+    # @param [Integer] int
+    # @param [Integer] hexsize
+    # @return [String]
+    def self.enum_human_hex(str, int, hexsize)
+      "%-16s (0x%0#{hexsize}x)" % [str, int]
+    end
+
+    # Simple formatter to inspect an attribute
+    # @param [String] type attribute type
+    # @param [String] attr attribute name
+    # @param [String] value
+    # @param [Integer] level
+    # @return [String]
+    def self.format(type, attr, value, level=1)
+      str = Inspect.shift_level(level)
+      str << Inspect::FMT_ATTR % [type, attr, value]
+    end
+
     # Format an attribute for +#inspect+.
     # 3 cases are handled:
     # * attribute value is a {Types::Int}: show value as integer and in
@@ -48,10 +67,10 @@ module PacketGen
     # @param [Integer] level
     # @return [String]
     def self.inspect_attribute(attr, value, level=1)
-      str = shift_level(level)
+      type = value.class.to_s.sub(/.*::/, '')
       val = case value
             when Types::Enum
-              "%-16s (0x%0#{value.sz * 2}x)" % [value.to_human, value.to_i]
+              enum_human_hex(value.to_human, value.to_i, value.sz * 2)
             when Types::Int
               int_dec_hex(value, value.sz * 2)
             when Integer
@@ -65,7 +84,7 @@ module PacketGen
                 value.to_s.inspect
               end
             end
-      str << FMT_ATTR % [value.class.to_s.sub(/.*::/, ''), attr, val]
+      self.format(type, attr, val, level)
     end
 
     # Format a ASN.1 attribute for +#inspect+.

data/lib/packetgen/packet.rb

@@ -1,13 +1,11 @@
 # coding: utf-8
+# frozen_string_literal: true
+
 # This file is part of PacketGen
 # See https://github.com/sdaubert/packetgen for more informations
 # Copyright (C) 2016 Sylvain Daubert <sylvain.daubert@laposte.net>
 # This program is published under MIT license.
 
-# frozen_string_literal: true
-
-require 'pcaprub'
-
 module PacketGen
   # An object of type {Packet} handles a network packet. This packet may contain
   # multiple protocol headers, starting from MAC layer or from Network (OSI) layer.
@@ -89,26 +87,21 @@ module PacketGen
       capture.packets
     end
 
-    # Read packets from +filename+. Mays read Pcap and Pcap-NG formats.
+    # Read packets from +filename+. May read Pcap and Pcap-NG formats.
     #
-    # For more control, see {PcapNG::File} or +PCAPRUB::Pcap+.
+    # For more control (on Pcap-ng only), see {PcapNG::File}.
     # @param [String] filename PcapNG or Pcap file.
     # @return [Array<Packet>]
+    # @raise [ArgumentError] unknown file format
     # @author Sylvain Daubert
     # @author Kent Gruber - Pcap format
     # @since 2.0.0 Also read Pcap format.
     def self.read(filename)
-      PcapNG::File.new.read_packets filename
+      PcapNG::File.new.read_packets(filename)
     rescue StandardError => e
       raise ArgumentError, e unless File.extname(filename.downcase) == '.pcap'
 
-      packets = []
-      PCAPRUB::Pcap.open_offline(filename).each_packet do |packet|
-        next unless (packet = PacketGen.parse(packet.to_s))
-
-        packets << packet
-      end
-      packets
+      Pcap.read(filename)
     end
 
     # Write packets to +filename+
@@ -132,11 +125,13 @@ module PacketGen
     # @param [String] protocol
     # @param [Hash] options protocol specific options
     # @return [self]
-    # @raise [ArgumentError] unknown protocol
+    # @raise [BindingError] unknown protocol
     def add(protocol, options={})
       klass = check_protocol(protocol)
 
-      header = klass.new(options.merge!(packet: self))
+      # options[:packet]= self is speedier than options.merge(packet: self)
+      options[:packet] = self
+      header = klass.new(options)
       add_header header
       self
     end
@@ -146,12 +141,14 @@ module PacketGen
     # @param [String] protocol protocol to insert
     # @param [Hash] options protocol specific options
     # @return [self]
-    # @raise [ArgumentError] unknown protocol
+    # @raise [BindingError] unknown protocol
     def insert(prev, protocol, options={})
       klass = check_protocol(protocol)
 
       nxt = prev.body
-      header = klass.new(options.merge!(packet: self))
+      # options[:packet]= self is speedier than options.merge(packet: self)
+      options[:packet] = self
+      header = klass.new(options)
       add_header header, previous_header: prev
       idx = headers.index(prev) + 1
       headers[idx, 0] = header
@@ -217,7 +214,7 @@ module PacketGen
     # @return [Array] see return from {PcapNG::File#to_file}
     # @see File
     def to_f(filename)
-      PcapNG::File.new.array_to_file(filename: filename, array: [self])
+      PcapNG::File.new.array_to_file(file: filename, array: [self])
     end
     alias write to_f
 
@@ -251,10 +248,11 @@ module PacketGen
     #    from binding with first other's one. Use only when current header field
     #    has its value set accordingly.
     # @return [self] +self+ with new headers from +other+
+    # @raise [BindingError] do not known how to encapsulate
     # @since 1.1.0
     def encapsulate(other, parsing: false)
       other.headers.each_with_index do |h, i|
-        add_header h, parsing: (i > 0) || parsing
+        add_header h, parsing: i.positive? || parsing
       end
     end
 
@@ -262,36 +260,32 @@ module PacketGen
     # @param [Array<Header>] hdrs
     # @return [self] +self+ with some headers removed
     # @raise [FormatError] any headers not in +self+
-    # @raise [FormatError] removed headers result in an unknown binding
+    # @raise [BindingError] removed headers result in an unknown binding
     # @since 1.1.0
     def decapsulate(*hdrs)
       hdrs.each do |hdr|
-        idx = headers.index(hdr)
-        raise FormatError, 'header not in packet!' if idx.nil?
-
-        prev_hdr = idx > 0 ? headers[idx - 1] : nil
-        next_hdr = (idx + 1) < headers.size ? headers[idx + 1] : nil
-        headers.delete_at(idx)
+        prev_hdr = previous_header(hdr)
+        next_hdr = next_header(hdr)
+        headers.delete(hdr)
         add_header(next_hdr, previous_header: prev_hdr) if prev_hdr && next_hdr
       end
-    rescue ArgumentError => ex
-      raise FormatError, ex.message
+    rescue ArgumentError => e
+      raise FormatError, e.message
     end
 
     # Parse a binary string and populate Packet from it.
     # @param [String] binary_str
     # @param [String,nil] first_header First protocol header. +nil+ means discover it!
     # @return [Packet] self
-    # @raise [ArgumentError] +first_header+ is an unknown header
+    # @raise [ParseError] +first_header+ is an unknown header
+    # @raise [BindingError] unknwon binding between some headers
     def parse(binary_str, first_header: nil)
       headers.clear
 
       if first_header.nil?
         # No decoding forced for first header. Have to guess it!
         first_header = guess_first_header(binary_str)
-        if first_header.nil?
-          raise ParseError, 'cannot identify first header in string'
-        end
+        raise ParseError, 'cannot identify first header in string' if first_header.nil?
       end
 
       add first_header
@@ -374,6 +368,35 @@ module PacketGen
       headers.last
     end
 
+    # Give header index in packet
+    # @param [Headerable] hdr
+    # @return [Integer]
+    # @raise [FormatError] +hdr+ not in packet
+    def header_index(hdr)
+      idx = headers.index(hdr)
+      raise FormatError, 'header not in packet!' if idx.nil?
+
+      idx
+    end
+
+    # Give header previous +hdr+ in packet
+    # @param [Headerable] hdr
+    # @return [Headerable,nil] May return +nil+ if +hdr+ is the first header in packet
+    # @raise [FormatError] +hdr+ not in packet
+    def previous_header(hdr)
+      idx = header_index(hdr)
+      idx.positive? ? headers[idx - 1] : nil
+    end
+
+    # Give header next +hdr+ in packet
+    # @param [Headerable] hdr
+    # @return [Headerable,nil] May return +nil+ if +hdr+ is the last header in packet
+    # @raise [FormatError] +hdr+ not in packet
+    def next_header(hdr)
+      idx = header_index(hdr)
+      (idx + 1) < headers.size ? headers[idx + 1] : nil
+    end
+
     # @overload header(klass, layer=1)
     #  @param [Class] klass
     #  @param [Integer] layer
@@ -388,9 +411,8 @@ module PacketGen
       return header unless arg.is_a? Hash
 
       arg.each do |key, value|
-        unless header.respond_to? "#{key}="
-          raise ArgumentError, "unknown #{key} attribute for #{klass}"
-        end
+        raise ArgumentError, "unknown #{key} attribute for #{klass}" unless header.respond_to? "#{key}="
+
         header.send "#{key}=", value
       end
 
@@ -408,26 +430,15 @@ module PacketGen
     end
 
     # Add a header to packet
-    # @param [Header::Base] header
-    # @param [Header::Base] previous_header
+    # @param [Headerable] header
+    # @param [Headerable] previous_header
     # @param [Boolean] parsing
     # @return [void]
+    # @raise [BindingError]
     def add_header(header, previous_header: nil, parsing: false)
       prev_header = previous_header || last_header
-      if prev_header
-        bindings = prev_header.class.known_headers[header.class]
-        bindings = prev_header.class.known_headers[header.class.superclass] if bindings.nil?
-        if bindings.nil?
-          msg = "#{prev_header.class} knowns no layer association with #{header.protocol_name}. ".dup
-          msg << "Try #{prev_header.class}.bind_layer(#{header.class}, "
-          msg << "#{prev_header.method_name}_proto_field: "
-          msg << "value_for_#{header.method_name})"
-          raise ArgumentError, msg
-        end
+      add_to_previous_header(prev_header, header, parsing) if prev_header
 
-        bindings.set(prev_header) if !bindings.empty? && !parsing
-        prev_header[:body] = header
-      end
       header.packet = self
       headers << header unless previous_header
 
@@ -436,6 +447,20 @@ module PacketGen
       add_magic_header_method header
     end
 
+    # Bind +header+ to +prev_header+.
+    # @param [Headerable] prev_header
+    # @param [Headerable] header
+    # @param [Boolean] parsing
+    # @return [void]
+    # @raise [BindingError]
+    def add_to_previous_header(prev_header, header, parsing)
+      bindings = prev_header.class.known_headers[header.class] || prev_header.class.known_headers[header.class.superclass]
+      raise BindingError.new(prev_header, header) if bindings.nil?
+
+      bindings.set(prev_header) if !bindings.empty? && !parsing
+      prev_header[:body] = header
+    end
+
     # Add method to access +header+
     # @param [Header::Base] header
     # @return [void]