package_protections 3.0.0 → 3.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0c09fbdc359d1dc28d4168fc0041dc385ea8a5b78c77436c598d5f6fd3eb24d6
-  data.tar.gz: 7ab7d9d30955c98c8213434b80923a96602a2489e2b822b9e8f75f3ff25145e8
+  metadata.gz: aabad25e536a226f791248e858e8db7fc67410b2d623879326165630bfd0922d
+  data.tar.gz: 64b1d4b5ab05315e9c5ecefdd3105af7485a6f2ed0ba59b9ae456c306b824d72
 SHA512:
-  metadata.gz: 0027653c627faaacdc1e7dfe57342d10130b93cd833a5083091c54fbc48ba106366768671ce703cdf5c4576dcd53db10a39cc59f0262fc18b06153d00ddcc284
-  data.tar.gz: 1494769fd3a1120add3da651cba6b0c826cc990890669810eb1532404ef1e2820470628bc89a77794589b819ed557da9cb3127910deebe2780854d560760ad9d
+  metadata.gz: 58aea344a1b283458d878b224c02fd339e27ca541f2ee025a65970ca94fc717ad5b95137e577760cb512fabf4c5657ccb15f8bc57f78330960294a47c2ad1898
+  data.tar.gz: 2700f4963e5fe0c5b987aede413458a7181ee8e471b9689bf0dcd0659bd535e99ffee83487ae88c1acfbcc245e8f62da91c070a77bcbea060a4a59bc00b21e19

data/README.md

@@ -56,7 +56,7 @@ This protection only looks at files in `packs/your_pack/app` (it ignores spec fi
 This protection is implemented via Rubocop -- expect to see results for this when running `rubocop` however you normally do. To add to the TODO list, add to `.rubocop_todo.yml`
 Lastly – this protection can be configured by setting `globally_permitted_namespaces`, e.g.:
 ```ruby
-PackageProtections.configure do |config|
+RuboCop::Packs.configure do |config|
   config.globally_permitted_namespaces = ['SomeGlobalNamespace']
 end
 ```

data/lib/rubocop/cop/package_protections/namespaced_under_package_name.rb

@@ -10,36 +10,6 @@ module RuboCop
         extend T::Sig
         include ::PackageProtections::RubocopProtectionInterface
 
-        # We override `cop_configs` for this protection.
-        # The default behavior disables cops when a package has turned off a protection.
-        # However: namespace violations can occur even when one package has TURNED OFF their namespace protection
-        # but another package has it turned on. Therefore, all packages must always be opted in no matter what.
-        #
-        sig do
-          params(packages: T::Array[::PackageProtections::ProtectedPackage])
-          .returns(T::Array[::PackageProtections::RubocopProtectionInterface::CopConfig])
-        end
-        def cop_configs(packages)
-          include_packs = T.let([], T::Array[String])
-          packages.each do |p|
-            enabled_for_pack = !p.violation_behavior_for(NamespacedUnderPackageName::IDENTIFIER).fail_never?
-            if enabled_for_pack
-              include_packs << p.name
-            end
-          end
-
-          [
-            ::PackageProtections::RubocopProtectionInterface::CopConfig.new(
-              name: cop_name,
-              enabled: include_packs.any?,
-              metadata: {
-                'IncludePacks' => include_packs,
-                'GloballyPermittedNamespaces' => ::PackageProtections.config.globally_permitted_namespaces
-              }
-            )
-          ]
-        end
-
         sig { override.returns(T::Array[String]) }
         def included_globs_for_pack
           [
@@ -57,23 +27,19 @@ module RuboCop
 
         sig { override.params(behavior: ::PackageProtections::ViolationBehavior, package: ParsePackwerk::Package).returns(T.nilable(String)) }
         def unmet_preconditions_for_behavior(behavior, package)
-          if !behavior.enabled? && !package.metadata['global_namespaces'].nil?
-            "Invalid configuration for package `#{package.name}`. `#{identifier}` must be turned on to use `global_namespaces` configuration."
-          else
-            # We don't need to validate if the behavior is currentely fail_never
-            return if behavior.fail_never?
+          # We don't need to validate if the behavior is currentely fail_never
+          return if behavior.fail_never?
 
-            # The reason for this is precondition is the `MultipleNamespacesProtection` assumes this to work properly.
-            # To remove this precondition, we need to modify `MultipleNamespacesProtection` to be more generalized!
-            is_root_package = package.name == ParsePackwerk::ROOT_PACKAGE_NAME
-            in_allowed_directory = ::PackageProtections::EXPECTED_PACK_DIRECTORIES.any? do |expected_package_directory|
-              package.directory.to_s.start_with?(expected_package_directory)
-            end
-            if in_allowed_directory || is_root_package
-              nil
-            else
-              "Package #{package.name} must be located in one of #{::PackageProtections::EXPECTED_PACK_DIRECTORIES.join(', ')} (or be the root) to use this protection"
-            end
+          # The reason for this is precondition is the `MultipleNamespacesProtection` assumes this to work properly.
+          # To remove this precondition, we need to modify `MultipleNamespacesProtection` to be more generalized!
+          is_root_package = package.name == ParsePackwerk::ROOT_PACKAGE_NAME
+          in_allowed_directory = ::PackageProtections::EXPECTED_PACK_DIRECTORIES.any? do |expected_package_directory|
+            package.directory.to_s.start_with?(expected_package_directory)
+          end
+          if in_allowed_directory || is_root_package
+            nil
+          else
+            "Package #{package.name} must be located in one of #{::PackageProtections::EXPECTED_PACK_DIRECTORIES.join(', ')} (or be the root) to use this protection"
           end
         end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: package_protections
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.2.0
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-10-24 00:00:00.000000000 Z
+date: 2022-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport